---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119455/#review63110
---
I think this is nearly good to go. A few questions below.
On July 25, 2014, 8:13 a.m., David Edmundson wrote:
src/declarativeimports/plasmacomponents/qml/styles/ButtonStyle.qml, line 42
https://git.reviewboard.kde.org/r/119455/diff/3/?file=292514#file292514line42
I was thinking this can become just
property real minimumWidth:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119455/
---
(Updated July 25, 2014, 9:41 a.m.)
Review request for KDE Frameworks and
On July 25, 2014, 8:13 a.m., David Edmundson wrote:
src/declarativeimports/plasmacomponents/qml/styles/ButtonStyle.qml, line 42
https://git.reviewboard.kde.org/r/119455/diff/3/?file=292514#file292514line42
I was thinking this can become just
property real minimumWidth:
On July 25, 2014, 8:13 a.m., David Edmundson wrote:
src/declarativeimports/plasmacomponents/qml/styles/ButtonStyle.qml, line 42
https://git.reviewboard.kde.org/r/119455/diff/3/?file=292514#file292514line42
I was thinking this can become just
property real minimumWidth:
On July 25, 2014, 8:13 a.m., David Edmundson wrote:
src/declarativeimports/plasmacomponents/qml/styles/ButtonStyle.qml, line 42
https://git.reviewboard.kde.org/r/119455/diff/3/?file=292514#file292514line42
I was thinking this can become just
property real minimumWidth:
On July 25, 2014, 8:13 a.m., David Edmundson wrote:
src/declarativeimports/plasmacomponents/qml/styles/ButtonStyle.qml, line 42
https://git.reviewboard.kde.org/r/119455/diff/3/?file=292514#file292514line42
I was thinking this can become just
property real minimumWidth:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119455/#review63127
---
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119455/
---
(Updated July 25, 2014, 10:55 a.m.)
Review request for KDE Frameworks
On July 25, 2014, 10:44 a.m., David Edmundson wrote:
src/declarativeimports/plasmacomponents/qml/styles/ButtonStyle.qml, line 76
https://git.reviewboard.kde.org/r/119455/diff/4/?file=292603#file292603line76
This causes a behavioural change:
look at line 102 of the old
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119455/
---
(Updated July 25, 2014, 11:05 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119455/#review63163
---
One thing tough, i would put back in all the documentation
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119455/
---
Review request for KDE Frameworks and Plasma.
Repository:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119455/#review63086
---
Exciting!
Might this eventually support a ButtonStyle.qml
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119455/#review63087
---
Concerning the icon names: for the Desktops Effects KCM the
On July 24, 2014, 4:18 p.m., Andrew Lake wrote:
Exciting!
Might this eventually support a ButtonStyle.qml in the plasma theme that
overrides the svg-based ButtonStyle if it's present? That way we could take
the already developed Breeze ButtonStyle.qml and just ship it in the
On July 24, 2014, 4:20 p.m., Martin Gräßlin wrote:
Concerning the icon names: for the Desktops Effects KCM the names are
working without me doing anything. So there must be a solution hidden in
the widgets emulating style.
yes, the native style figures out that internally, creates an
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119455/
---
(Updated July 24, 2014, 4:31 p.m.)
Review request for KDE Frameworks and
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119455/#review63091
---
On July 24, 2014, 4:56 p.m., David Edmundson wrote:
src/declarativeimports/plasmacomponents/qml/styles/ButtonStyle.qml, line 41
https://git.reviewboard.kde.org/r/119455/diff/2/?file=292510#file292510line41
This isn't very declarative, is there a reason we can't do:
On July 24, 2014, 4:56 p.m., David Edmundson wrote:
src/declarativeimports/plasmacomponents/qml/styles/ButtonStyle.qml, line 83
https://git.reviewboard.kde.org/r/119455/diff/2/?file=292510#file292510line83
style.labelImplicitWidth doesn't exist?
gah, leftover
- Marco
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119455/
---
(Updated July 24, 2014, 6:17 p.m.)
Review request for KDE Frameworks and
22 matches
Mail list logo
