Re: Review Request 119711: Use CMAKE_INSTALL_FULL_LIBEXECDIR_KF5

2014-08-11 Thread Nicolas Lécureuil
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119711/ --- (Updated Aug. 11, 2014, 12:30 p.m.) Review request for KDE Frameworks

Re: Review Request 119711: Use CMAKE_INSTALL_FULL_LIBEXECDIR_KF5

2014-08-11 Thread Lukáš Tinkl
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119711/#review64260 --- I'm getting this error: chown: cannot access 

Re: Review Request 119711: Use CMAKE_INSTALL_FULL_LIBEXECDIR_KF5

2014-08-11 Thread Lukáš Tinkl
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119711/#review64266 --- +1 from me, I'd wait for dfaure for the final ship it tho :)

Re: Review Request 119711: Use CMAKE_INSTALL_FULL_LIBEXECDIR_KF5

2014-08-11 Thread Nicolas Lécureuil
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119711/ --- (Updated Aug. 11, 2014, 2:22 p.m.) Review request for KDE Frameworks and

Re: Review Request 119711: Use CMAKE_INSTALL_FULL_LIBEXECDIR_KF5

2014-08-11 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119711/#review64267 --- src/kdeinit/kinit.cpp

Re: Review Request 119711: Use CMAKE_INSTALL_FULL_LIBEXECDIR_KF5

2014-08-11 Thread Nicolas Lécureuil
On Aug. 11, 2014, 2:47 p.m., David Faure wrote: src/kdeinit/kinit.cpp, line 503 https://git.reviewboard.kde.org/r/119711/diff/2/?file=303743#file303743line503 This can't work, it's replacing a full path with a relative path. The goal of this code was s/libexec/lib/

Re: Review Request 119711: Use CMAKE_INSTALL_FULL_LIBEXECDIR_KF5

2014-08-11 Thread Nicolas Lécureuil
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119711/ --- (Updated Aug. 11, 2014, 2:54 p.m.) Review request for KDE Frameworks and

Re: Review Request 119711: Use CMAKE_INSTALL_FULL_LIBEXECDIR_KF5

2014-08-11 Thread Hrvoje Senjan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119711/#review64284 --- src/start_kdeinit/start_kdeinit.c

Re: Review Request 119711: Use CMAKE_INSTALL_FULL_LIBEXECDIR_KF5

2014-08-11 Thread Nicolas Lécureuil
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119711/ --- (Updated Aug. 11, 2014, 5:51 p.m.) Review request for KDE Frameworks and

Re: Review Request 119711: Use CMAKE_INSTALL_FULL_LIBEXECDIR_KF5

2014-08-11 Thread Lukáš Tinkl
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119711/#review64290 --- Ship it! Ship It! - Lukáš Tinkl On Srp. 11, 2014, 7:51

Re: Review Request 119711: Use CMAKE_INSTALL_FULL_LIBEXECDIR_KF5

2014-08-11 Thread Nicolas Lécureuil
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119711/ --- (Updated Aug. 11, 2014, 6:23 p.m.) Status -- This change has been