Re: Review Request 122206: [kio] Make tests optional

2017-04-22 Thread Andreas Sturmlechner
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122206/ --- (Updated April 22, 2017, 10:35 p.m.) Status -- This change has been

Re: Review Request 122206: [kio] Make tests optional

2015-03-18 Thread Aleix Pol Gonzalez
On March 17, 2015, 4:37 a.m., Albert Vaca Cintora wrote: I know this is merged already but this patch is being applied to every KDE package and I want to keep the discussion in a single place. We already have a toggle option in CMake that is BUILD_TESTING. If Gentoo wants to not

Re: Review Request 122206: [kio] Make tests optional

2015-03-18 Thread Ben Cooksley
On March 17, 2015, 3:37 a.m., Albert Vaca Cintora wrote: I know this is merged already but this patch is being applied to every KDE package and I want to keep the discussion in a single place. We already have a toggle option in CMake that is BUILD_TESTING. If Gentoo wants to not

Re: Review Request 122206: [kio] Make tests optional

2015-03-17 Thread Albert Vaca Cintora
On March 16, 2015, 8:37 p.m., Albert Vaca Cintora wrote: I know this is merged already but this patch is being applied to every KDE package and I want to keep the discussion in a single place. We already have a toggle option in CMake that is BUILD_TESTING. If Gentoo wants to not

Re: Review Request 122206: [kio] Make tests optional

2015-03-17 Thread Ben Cooksley
On March 17, 2015, 3:37 a.m., Albert Vaca Cintora wrote: I know this is merged already but this patch is being applied to every KDE package and I want to keep the discussion in a single place. We already have a toggle option in CMake that is BUILD_TESTING. If Gentoo wants to not

Re: Review Request 122206: [kio] Make tests optional

2015-03-17 Thread Albert Astals Cid
On mar. 17, 2015, 3:37 a.m., Albert Vaca Cintora wrote: I know this is merged already but this patch is being applied to every KDE package and I want to keep the discussion in a single place. We already have a toggle option in CMake that is BUILD_TESTING. If Gentoo wants to not

Re: Review Request 122206: [kio] Make tests optional

2015-03-17 Thread Michael Palimaka
On March 17, 2015, 3:37 a.m., Albert Vaca Cintora wrote: I know this is merged already but this patch is being applied to every KDE package and I want to keep the discussion in a single place. We already have a toggle option in CMake that is BUILD_TESTING. If Gentoo wants to not

Re: Review Request 122206: [kio] Make tests optional

2015-03-16 Thread Albert Vaca Cintora
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122206/#review77603 --- I know this is merged already but this patch is being applied

Re: Review Request 122206: [kio] Make tests optional

2015-02-07 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122206/#review75568 --- Ship it! Ship It! - David Faure On Feb. 7, 2015, 12:14

Re: Review Request 122206: [kio] Make tests optional

2015-02-06 Thread Andreas Sturmlechner
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122206/ --- (Updated Feb. 7, 2015, 12:14 a.m.) Review request for KDE Frameworks.

Re: Review Request 122206: [kio] Make tests optional

2015-02-03 Thread Andreas Sturmlechner
On Feb. 1, 2015, 2:33 p.m., David Faure wrote: Let me get this straight. This patch makes the option BUILD_TESTING work, i.e. skip testing if not set. The solution that was committed to kwin, *additionally* sets BUILD_TESTING to false if Qt5Test isn't available. This doesn't

Re: Review Request 122206: [kio] Make tests optional

2015-02-01 Thread Andreas Sturmlechner
On Jan. 23, 2015, 8:58 p.m., David Faure wrote: Not sure why this is suddenly triggering many philosophical discussions about what users should be doing (IMHO, give them choice, this is opensource). Similar changes have been done in most other frameworks long ago, this is most

Re: Review Request 122206: [kio] Make tests optional

2015-02-01 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122206/#review75140 --- Let me get this straight. This patch makes the option

Re: Review Request 122206: [kio] Make tests optional

2015-02-01 Thread Martin Gräßlin
On Jan. 23, 2015, 9:58 p.m., David Faure wrote: Not sure why this is suddenly triggering many philosophical discussions about what users should be doing (IMHO, give them choice, this is opensource). Similar changes have been done in most other frameworks long ago, this is most

Re: Review Request 122206: [kio] Make tests optional

2015-01-29 Thread Martin Gräßlin
On Jan. 23, 2015, 9:58 p.m., David Faure wrote: Not sure why this is suddenly triggering many philosophical discussions about what users should be doing (IMHO, give them choice, this is opensource). Similar changes have been done in most other frameworks long ago, this is most

Re: Review Request 122206: [kio] Make tests optional

2015-01-29 Thread Vishesh Handa
On Jan. 23, 2015, 8:58 p.m., David Faure wrote: Not sure why this is suddenly triggering many philosophical discussions about what users should be doing (IMHO, give them choice, this is opensource). Similar changes have been done in most other frameworks long ago, this is most

Re: Review Request 122206: [kio] Make tests optional

2015-01-28 Thread Vishesh Handa
On Jan. 23, 2015, 8:58 p.m., David Faure wrote: Not sure why this is suddenly triggering many philosophical discussions about what users should be doing (IMHO, give them choice, this is opensource). Similar changes have been done in most other frameworks long ago, this is most

Re: Review Request 122206: [kio] Make tests optional

2015-01-23 Thread Vishesh Handa
On Jan. 23, 2015, 1:43 p.m., Vishesh Handa wrote: I'm not against this, but I am curious as to why this is being done. I would think that packagers should be building the tests and running them on their platform and make sure everything passes. We have a strict policy that all

Re: Review Request 122206: [kio] Make tests optional

2015-01-23 Thread Matthew Dawson
On Jan. 23, 2015, 8:43 a.m., Vishesh Handa wrote: I'm not against this, but I am curious as to why this is being done. I would think that packagers should be building the tests and running them on their platform and make sure everything passes. We have a strict policy that all

Re: Review Request 122206: [kio] Make tests optional

2015-01-23 Thread Albert Astals Cid
On gen. 23, 2015, 1:43 p.m., Vishesh Handa wrote: I'm not against this, but I am curious as to why this is being done. I would think that packagers should be building the tests and running them on their platform and make sure everything passes. We have a strict policy that all

Re: Review Request 122206: [kio] Make tests optional

2015-01-23 Thread Andreas Sturmlechner
On Jan. 23, 2015, 1:43 p.m., Vishesh Handa wrote: I'm not against this, but I am curious as to why this is being done. I would think that packagers should be building the tests and running them on their platform and make sure everything passes. We have a strict policy that all

Re: Review Request 122206: [kio] Make tests optional

2015-01-23 Thread Vishesh Handa
On Jan. 23, 2015, 1:43 p.m., Vishesh Handa wrote: I'm not against this, but I am curious as to why this is being done. I would think that packagers should be building the tests and running them on their platform and make sure everything passes. We have a strict policy that all

Re: Review Request 122206: [kio] Make tests optional

2015-01-23 Thread Matthew Dawson
On Jan. 23, 2015, 8:43 a.m., Vishesh Handa wrote: I'm not against this, but I am curious as to why this is being done. I would think that packagers should be building the tests and running them on their platform and make sure everything passes. We have a strict policy that all

Re: Review Request 122206: [kio] Make tests optional

2015-01-23 Thread Matthew Dawson
On Jan. 23, 2015, 8:43 a.m., Vishesh Handa wrote: I'm not against this, but I am curious as to why this is being done. I would think that packagers should be building the tests and running them on their platform and make sure everything passes. We have a strict policy that all

Re: Review Request 122206: [kio] Make tests optional

2015-01-23 Thread Vishesh Handa
On Jan. 23, 2015, 1:43 p.m., Vishesh Handa wrote: I'm not against this, but I am curious as to why this is being done. I would think that packagers should be building the tests and running them on their platform and make sure everything passes. We have a strict policy that all

Re: Review Request 122206: [kio] Make tests optional

2015-01-23 Thread Matthew Dawson
On Jan. 23, 2015, 8:43 a.m., Vishesh Handa wrote: I'm not against this, but I am curious as to why this is being done. I would think that packagers should be building the tests and running them on their platform and make sure everything passes. We have a strict policy that all

Re: Review Request 122206: [kio] Make tests optional

2015-01-23 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122206/#review74633 --- Ship it! Not sure why this is suddenly triggering many

Re: Review Request 122206: [kio] Make tests optional

2015-01-23 Thread Martin Gräßlin
On Jan. 23, 2015, 2:43 p.m., Vishesh Handa wrote: I'm not against this, but I am curious as to why this is being done. I would think that packagers should be building the tests and running them on their platform and make sure everything passes. We have a strict policy that all

Re: Review Request 122206: [kio] Make tests optional

2015-01-23 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122206/#review74602 --- I'm not against this, but I am curious as to why this is

Review Request 122206: [kio] Make tests optional

2015-01-22 Thread Andreas Sturmlechner
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122206/ --- Review request for KDE Frameworks. Repository: kio Description ---

Re: Review Request 122206: [kio] Make tests optional

2015-01-22 Thread Andreas Sturmlechner
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122206/ --- (Updated Jan. 22, 2015, 7:48 p.m.) Review request for KDE Frameworks.