On March 22, 2015, 3:56 p.m., Albert Astals Cid wrote:
src/kglobalaccel.h, line 260
https://git.reviewboard.kde.org/r/122981/diff/2/?file=356138#file356138line260
typo in following
Gregor Mi wrote:
About why it is needed: see
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122981/#review78472
---
src/kglobalaccel.h (line 372)
On April 4, 2015, 9:14 vorm., Gregor Mi wrote:
src/kglobalaccel.h, line 372
https://git.reviewboard.kde.org/r/122981/diff/4/?file=359983#file359983line372
NOTE that this causes compile error in libKF5XmlGui
/home/gregor/dev/kf5/usr/lib64/libKF5XmlGui.so.5.8.0:
On March 22, 2015, 3:56 p.m., Albert Astals Cid wrote:
src/kglobalaccel.h, line 260
https://git.reviewboard.kde.org/r/122981/diff/2/?file=356138#file356138line260
typo in following
Gregor Mi wrote:
About why it is needed: see
On March 22, 2015, 3:56 p.m., Albert Astals Cid wrote:
src/kglobalaccel.h, line 260
https://git.reviewboard.kde.org/r/122981/diff/2/?file=356138#file356138line260
typo in following
Gregor Mi wrote:
About why it is needed: see
On mar. 22, 2015, 3:56 p.m., Albert Astals Cid wrote:
src/kglobalaccel.h, line 260
https://git.reviewboard.kde.org/r/122981/diff/2/?file=356138#file356138line260
typo in following
Gregor Mi wrote:
About why it is needed: see
On mar. 22, 2015, 3:56 p.m., Albert Astals Cid wrote:
src/kglobalaccel.h, line 260
https://git.reviewboard.kde.org/r/122981/diff/2/?file=356138#file356138line260
typo in following
Gregor Mi wrote:
About why it is needed: see
On März 22, 2015, 3:56 nachm., Albert Astals Cid wrote:
src/kglobalaccel.h, line 260
https://git.reviewboard.kde.org/r/122981/diff/2/?file=356138#file356138line260
typo in following
Gregor Mi wrote:
About why it is needed: see
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122981/#review78505
---
Honestly, i think the problem here is that the function just
On mar. 22, 2015, 3:56 p.m., Albert Astals Cid wrote:
src/kglobalaccel.h, line 260
https://git.reviewboard.kde.org/r/122981/diff/2/?file=356138#file356138line260
typo in following
Gregor Mi wrote:
About why it is needed: see
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122981/
---
(Updated April 3, 2015, 5:50 p.m.)
Review request for KDE Frameworks,
On March 22, 2015, 3:56 p.m., Albert Astals Cid wrote:
src/kglobalaccel.h, line 260
https://git.reviewboard.kde.org/r/122981/diff/2/?file=356138#file356138line260
typo in following
Gregor Mi wrote:
About why it is needed: see
On mar. 22, 2015, 3:56 p.m., Albert Astals Cid wrote:
src/kglobalaccel.h, line 260
https://git.reviewboard.kde.org/r/122981/diff/2/?file=356138#file356138line260
typo in following
Gregor Mi wrote:
About why it is needed: see
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122981/
---
(Updated April 2, 2015, 2:56 p.m.)
Review request for KDE Frameworks,
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122981/#review78410
---
I finally managed to make most the master unit tests pass:
On March 22, 2015, 3:56 p.m., Albert Astals Cid wrote:
src/kglobalaccel.h, line 260
https://git.reviewboard.kde.org/r/122981/diff/2/?file=356138#file356138line260
typo in following
Gregor Mi wrote:
About why it is needed: see
On March 22, 2015, 4:56 p.m., Albert Astals Cid wrote:
src/kglobalaccel.h, line 260
https://git.reviewboard.kde.org/r/122981/diff/2/?file=356138#file356138line260
typo in following
Gregor Mi wrote:
About why it is needed: see
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122981/#review77902
---
autotests/kglobalshortcuttest.cpp (lines 424 - 428)
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122981/#review77901
---
I doubt the test will work on the CI system as there we don't
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122981/#review77912
---
Can you clarify why this is needed? If it is something we
On March 22, 2015, 11:07 a.m., Martin Gräßlin wrote:
src/kglobalaccel.h, line 266
https://git.reviewboard.kde.org/r/122981/diff/2/?file=356138#file356138line266
can I get your time machine?
https://www.kde.org/announcements/kde-frameworks-5.8.0.php ;-)
yes, sure, please fetch it
On March 22, 2015, 3:56 p.m., Albert Astals Cid wrote:
src/kglobalaccel.h, line 260
https://git.reviewboard.kde.org/r/122981/diff/2/?file=356138#file356138line260
typo in following
Gregor Mi wrote:
About why it is needed: see
On March 22, 2015, 11:08 a.m., Martin Gräßlin wrote:
autotests/kglobalshortcuttest.cpp, lines 424-428
https://git.reviewboard.kde.org/r/122981/diff/2/?file=356137#file356137line424
please compare with the other test cases - there are verifications on
whether kglobalacceld is
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122981/
---
(Updated March 22, 2015, 4:05 p.m.)
Review request for KDE Frameworks,
On mar. 22, 2015, 3:56 p.m., Albert Astals Cid wrote:
src/kglobalaccel.h, line 260
https://git.reviewboard.kde.org/r/122981/diff/2/?file=356138#file356138line260
typo in following
Gregor Mi wrote:
About why it is needed: see
On March 22, 2015, 11:08 a.m., Martin Gräßlin wrote:
autotests/kglobalshortcuttest.cpp, lines 424-428
https://git.reviewboard.kde.org/r/122981/diff/2/?file=356137#file356137line424
please compare with the other test cases - there are verifications on
whether kglobalacceld is
On March 22, 2015, 3:56 p.m., Albert Astals Cid wrote:
src/kglobalaccel.h, line 260
https://git.reviewboard.kde.org/r/122981/diff/2/?file=356138#file356138line260
typo in following
About why it is needed: see
KGlobalShortcutTest::testLoadShortcutFromGlobalSettings: shortcut() does
On March 17, 2015, 7:10 a.m., Martin Gräßlin wrote:
src/kglobalaccel.h, line 269
https://git.reviewboard.kde.org/r/122981/diff/1/?file=355342#file355342line269
what are the some cases?
I removed the some cases. I was thinking about
kwin/effects/desktopgrid/desktopgrid_config.cpp
On March 17, 2015, 7:10 a.m., Martin Gräßlin wrote:
src/kglobalaccel.h, lines 256-260
https://git.reviewboard.kde.org/r/122981/diff/1/?file=355342#file355342line256
please add an
@since
and
@param
For the @since I looked at the value in the CMakeLists.txt -- 5.8.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122981/
---
Review request for KDE Frameworks, Martin Gräßlin and Thomas Lübking.
30 matches
Mail list logo