Re: Review Request 123223: Fix bug 344614: kservice splits filename wrong

2015-04-06 Thread Gregor Mi
On April 4, 2015, 9:34 a.m., David Faure wrote: Well spotted. I would however do what the commit says and just replace indexOf with lastIndexOf. QFileInfo::completeBaseName does much more work, see QFileSystemEntry::completeBaseName(). About the unittest: the solution is to

Re: Review Request 123223: Fix bug 344614: kservice splits filename wrong

2015-04-04 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123223/#review78473 --- Well spotted. I would however do what the commit says and

Re: Review Request 123223: Fix bug 344614: kservice splits filename wrong

2015-04-03 Thread Gregor Mi
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123223/ --- (Updated April 3, 2015, 5:35 p.m.) Review request for KDE Frameworks.