Re: Review Request 124331: New proxy: KExtraColumnsProxyModel, allows to add columns to an existing model.

2015-07-17 Thread David Faure
On July 15, 2015, 9:36 a.m., Milian Wolff wrote: src/kextracolumnsproxymodel.cpp, line 85 https://git.reviewboard.kde.org/r/124331/diff/3/?file=385295#file385295line85 ah, a pity. Btw, in KDevelop where I can use lambdas (can you here?), I stopped using private signals and

Re: Review Request 124331: New proxy: KExtraColumnsProxyModel, allows to add columns to an existing model.

2015-07-17 Thread Nicolás Alvarez
On Jul. 15, 2015, 6:36 a.m., Milian Wolff wrote: src/kextracolumnsproxymodel.cpp, line 85 https://git.reviewboard.kde.org/r/124331/diff/3/?file=385295#file385295line85 ah, a pity. Btw, in KDevelop where I can use lambdas (can you here?), I stopped using private signals and

Re: Review Request 124331: New proxy: KExtraColumnsProxyModel, allows to add columns to an existing model.

2015-07-15 Thread Milian Wolff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124331/#review82536 --- Ship it! Yu are right about QPMI, but it just shows again

Re: Review Request 124331: New proxy: KExtraColumnsProxyModel, allows to add columns to an existing model.

2015-07-15 Thread Mark Gaiser
On jul 15, 2015, 9:36 a.m., Milian Wolff wrote: src/kextracolumnsproxymodel.cpp, line 85 https://git.reviewboard.kde.org/r/124331/diff/3/?file=385295#file385295line85 ah, a pity. Btw, in KDevelop where I can use lambdas (can you here?), I stopped using private signals and instead

Re: Review Request 124331: New proxy: KExtraColumnsProxyModel, allows to add columns to an existing model.

2015-07-15 Thread David Faure
On July 14, 2015, 4:58 p.m., Milian Wolff wrote: src/kextracolumnsproxymodel.cpp, line 44 https://git.reviewboard.kde.org/r/124331/diff/3/?file=385295#file385295line44 these two really should be QVector. As far as I can see, you do not interact with the Qt API and thus need QList

Re: Review Request 124331: New proxy: KExtraColumnsProxyModel, allows to add columns to an existing model.

2015-07-15 Thread David Faure
On July 15, 2015, 5:54 a.m., Sune Vuorela wrote: src/kextracolumnsproxymodel.h, line 39 https://git.reviewboard.kde.org/r/124331/diff/3/?file=385294#file385294line39 Are there any of these not supported things we might want to support in the future? Can we implement e.g.

Re: Review Request 124331: New proxy: KExtraColumnsProxyModel, allows to add columns to an existing model.

2015-07-15 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124331/ --- (Updated July 15, 2015, 8:59 a.m.) Review request for KDE Frameworks,

Re: Review Request 124331: New proxy: KExtraColumnsProxyModel, allows to add columns to an existing model.

2015-07-14 Thread David Faure
On July 13, 2015, 7:42 p.m., Sune Vuorela wrote: src/kextracolumnsproxymodel.h, line 92 https://git.reviewboard.kde.org/r/124331/diff/2/?file=385017#file385017line92 where is the implementation of this? (and the unit tests ? :) Ouch, good catch, I forgot to finish this. Done now.

Re: Review Request 124331: New proxy: KExtraColumnsProxyModel, allows to add columns to an existing model.

2015-07-14 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124331/ --- (Updated July 14, 2015, 10:42 a.m.) Review request for KDE Frameworks,

Re: Review Request 124331: New proxy: KExtraColumnsProxyModel, allows to add columns to an existing model.

2015-07-14 Thread Milian Wolff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124331/#review82500 --- Ship it! src/kextracolumnsproxymodel.cpp (line 36)

Re: Review Request 124331: New proxy: KExtraColumnsProxyModel, allows to add columns to an existing model.

2015-07-14 Thread Sune Vuorela
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124331/#review82521 --- src/kextracolumnsproxymodel.h (line 39)

Re: Review Request 124331: New proxy: KExtraColumnsProxyModel, allows to add columns to an existing model.

2015-07-13 Thread Sune Vuorela
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124331/#review82472 --- I like the concept, and have a whole bunch of nitpickery and

Re: Review Request 124331: New proxy: KExtraColumnsProxyModel, allows to add columns to an existing model.

2015-07-13 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124331/ --- (Updated July 13, 2015, 8:31 a.m.) Review request for KDE Frameworks,

Review Request 124331: New proxy: KExtraColumnsProxyModel, allows to add columns to an existing model.

2015-07-12 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124331/ --- Review request for KDE Frameworks, Jesper Pedersen and Stephen Kelly.

Re: Review Request 124331: New proxy: KExtraColumnsProxyModel, allows to add columns to an existing model.

2015-07-12 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124331/#review82440 --- autotests/kextracolumnsproxymodeltest.cpp (line 1)