On July 15, 2015, 9:36 a.m., Milian Wolff wrote:
src/kextracolumnsproxymodel.cpp, line 85
https://git.reviewboard.kde.org/r/124331/diff/3/?file=385295#file385295line85
ah, a pity. Btw, in KDevelop where I can use lambdas (can you here?), I
stopped using private signals and
On Jul. 15, 2015, 6:36 a.m., Milian Wolff wrote:
src/kextracolumnsproxymodel.cpp, line 85
https://git.reviewboard.kde.org/r/124331/diff/3/?file=385295#file385295line85
ah, a pity. Btw, in KDevelop where I can use lambdas (can you here?), I
stopped using private signals and
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124331/#review82536
---
Ship it!
Yu are right about QPMI, but it just shows again
On jul 15, 2015, 9:36 a.m., Milian Wolff wrote:
src/kextracolumnsproxymodel.cpp, line 85
https://git.reviewboard.kde.org/r/124331/diff/3/?file=385295#file385295line85
ah, a pity. Btw, in KDevelop where I can use lambdas (can you here?), I
stopped using private signals and instead
On July 14, 2015, 4:58 p.m., Milian Wolff wrote:
src/kextracolumnsproxymodel.cpp, line 44
https://git.reviewboard.kde.org/r/124331/diff/3/?file=385295#file385295line44
these two really should be QVector. As far as I can see, you do not
interact with the Qt API and thus need QList
On July 15, 2015, 5:54 a.m., Sune Vuorela wrote:
src/kextracolumnsproxymodel.h, line 39
https://git.reviewboard.kde.org/r/124331/diff/3/?file=385294#file385294line39
Are there any of these not supported things we might want to support
in the future? Can we implement e.g.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124331/
---
(Updated July 15, 2015, 8:59 a.m.)
Review request for KDE Frameworks,
On July 13, 2015, 7:42 p.m., Sune Vuorela wrote:
src/kextracolumnsproxymodel.h, line 92
https://git.reviewboard.kde.org/r/124331/diff/2/?file=385017#file385017line92
where is the implementation of this? (and the unit tests ? :)
Ouch, good catch, I forgot to finish this. Done now.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124331/
---
(Updated July 14, 2015, 10:42 a.m.)
Review request for KDE Frameworks,
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124331/#review82500
---
Ship it!
src/kextracolumnsproxymodel.cpp (line 36)
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124331/#review82521
---
src/kextracolumnsproxymodel.h (line 39)
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124331/#review82472
---
I like the concept, and have a whole bunch of nitpickery and
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124331/
---
(Updated July 13, 2015, 8:31 a.m.)
Review request for KDE Frameworks,
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124331/
---
Review request for KDE Frameworks, Jesper Pedersen and Stephen Kelly.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124331/#review82440
---
autotests/kextracolumnsproxymodeltest.cpp (line 1)
15 matches
Mail list logo