Re: Review Request 125164: Fix misbehavior when canceling a job

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125164/#review87245 --- autotests/jobtest.cpp (line 298)

Re: Review Request 125164: Fix misbehavior when canceling a job

> On Oct. 19, 2015, 5:44 p.m., Albert Astals Cid wrote: > > Is this trying to fix something similar to > > https://git.reviewboard.kde.org/r/125613/diff/ ? No, completely unrelated. - David --- This is an automatically generated

Re: Review Request 125164: Fix misbehavior when canceling a job

> On Oct. 22, 2015, 9:39 a.m., David Faure wrote: > > autotests/jobtest.cpp, line 309 > > > > > > What is the purpose of changing the currently-being-uploaded data > > buffer? Ah, from the fix I can see the

Re: Review Request 125164: Fix misbehavior when canceling a job

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125164/ --- (Updated Oct. 23, 2015, 2:19 a.m.) Review request for KDE Frameworks.

Re: Review Request 125164: Fix misbehavior when canceling a job

> On Oct. 22, 2015, 9:39 a.m., David Faure wrote: > > src/core/transferjob.cpp, line 400 > > > > > > Why slotFinished? Wouldn't just return be enough? > > kill() is supposed to take care of emitting finished

Re: Review Request 125164: Fix misbehavior when canceling a job

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125164/#review87091 --- Is this trying to fix something similar to

Re: Review Request 125164: Fix misbehavior when canceling a job

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125164/#review87040 --- bump? - Aleix Pol Gonzalez On Sept. 11, 2015, 3:24 p.m.,

Review Request 125164: Fix misbehavior when canceling a job

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125164/ --- Review request for KDE Frameworks. Repository: kio Description ---