Re: Review Request 125279: KSycoca: change DB filename to include language and sha1 of the dirs it's built from.

2015-09-20 Thread Sune Vuorela
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125279/#review85682 --- What happens on file systems that doesn't support hardlinks ?

Re: Review Request 125279: KSycoca: change DB filename to include language and sha1 of the dirs it's built from.

2015-09-20 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125279/ --- (Updated Sept. 20, 2015, 10:27 a.m.) Review request for KDE Frameworks

Re: Review Request 125279: KSycoca: change DB filename to include language and sha1 of the dirs it's built from.

2015-09-20 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125279/ --- (Updated Sept. 20, 2015, 5:15 p.m.) Status -- This change has been

Re: Review Request 125279: KSycoca: change DB filename to include language and sha1 of the dirs it's built from.

2015-09-20 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125279/#review85693 --- Ship it! Ship It! - Albert Astals Cid On set. 20, 2015,

Re: Review Request 125279: KSycoca: change DB filename to include language and sha1 of the dirs it's built from.

2015-09-19 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125279/ --- (Updated Sept. 19, 2015, 7:34 p.m.) Review request for KDE Frameworks

Re: Review Request 125279: KSycoca: change DB filename to include language and sha1 of the dirs it's built from.

2015-09-19 Thread David Faure
> On Sept. 19, 2015, 3:47 p.m., David Faure wrote: > > Hmmm... and then old-kded crashed. You can't mmap a symlink? > > > > #10 0x7f6b0c76d6d4 in qt_assert(char const*, char const*, int) > > (assertion=0x7f6b0d69fbbf [...] "canRead", file=[...] > >

Re: Review Request 125279: KSycoca: change DB filename to include language and sha1 of the dirs it's built from.

2015-09-19 Thread David Faure
> On Sept. 18, 2015, 8:37 p.m., Albert Astals Cid wrote: > > Ship It! I just realized that there is a possible migration problem with this patch. If you upgrade kservice in a running plasma5 session, and then install some app, it will never show up in the K menu (or be launched when clicking

Re: Review Request 125279: KSycoca: change DB filename to include language and sha1 of the dirs it's built from.

2015-09-19 Thread Albert Astals Cid
> On set. 18, 2015, 8:37 p.m., Albert Astals Cid wrote: > > Ship It! > > David Faure wrote: > I just realized that there is a possible migration problem with this > patch. > If you upgrade kservice in a running plasma5 session, and then install > some app, it will never show up in the

Re: Review Request 125279: KSycoca: change DB filename to include language and sha1 of the dirs it's built from.

2015-09-19 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125279/ --- (Updated Sept. 19, 2015, 11:29 p.m.) Review request for KDE Frameworks

Re: Review Request 125279: KSycoca: change DB filename to include language and sha1 of the dirs it's built from.

2015-09-19 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125279/ --- (Updated Sept. 19, 2015, 3:43 p.m.) Review request for KDE Frameworks

Re: Review Request 125279: KSycoca: change DB filename to include language and sha1 of the dirs it's built from.

2015-09-19 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125279/#review85670 --- Hmmm... and then old-kded crashed. You can't mmap a symlink?

Re: Review Request 125279: KSycoca: change DB filename to include language and sha1 of the dirs it's built from.

2015-09-19 Thread Albert Astals Cid
> On set. 19, 2015, 3:47 p.m., David Faure wrote: > > Hmmm... and then old-kded crashed. You can't mmap a symlink? > > > > #10 0x7f6b0c76d6d4 in qt_assert(char const*, char const*, int) > > (assertion=0x7f6b0d69fbbf [...] "canRead", file=[...] > >

Re: Review Request 125279: KSycoca: change DB filename to include language and sha1 of the dirs it's built from.

2015-09-18 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125279/#review85643 --- Ship it! Ship It! - Albert Astals Cid On set. 16, 2015,

Re: Review Request 125279: KSycoca: change DB filename to include language and sha1 of the dirs it's built from.

2015-09-16 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125279/#review85532 --- +1 - Aleix Pol Gonzalez On Sept. 17, 2015, 1:30 a.m.,

Review Request 125279: KSycoca: change DB filename to include language and sha1 of the dirs it's built from.

2015-09-16 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125279/ --- Review request for KDE Frameworks and Albert Astals Cid. Repository: