Re: Review Request 127655: Fix KAboutData::applicationData() to init from current Q*Application metadata

> On May 4, 2016, 9:48 p.m., Albert Astals Cid wrote: > > src/lib/kaboutdata.cpp, line 46 > > > > > > 5.4 is now the minimum supported version of KDE Frameowkrs 5 Fixed with

Re: Review Request 127655: Fix KAboutData::applicationData() to init from current Q*Application metadata

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127655/#review95189 --- Fix it, then Ship it! src/lib/kaboutdata.cpp (line 46)

Re: Review Request 127655: Fix KAboutData::applicationData() to init from current Q*Application metadata

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127655/ --- (Updated May 4, 2016, 9:41 p.m.) Status -- This change has been

Re: Review Request 127655: Fix KAboutData::applicationData() to init from current Q*Application metadata

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127655/#review95186 --- Ship it! Ship It! - Michael Pyne On May 4, 2016, 2:47

Re: Review Request 127655: Fix KAboutData::applicationData() to init from current Q*Application metadata

> On May 4, 2016, 11:20 a.m., Friedrich W. H. Kossebau wrote: > > src/lib/kaboutdata.cpp, line 925 > > > > > > Forgot to note the static I am used to write here. But given your > > comment I am now unsure about

Re: Review Request 127655: Fix KAboutData::applicationData() to init from current Q*Application metadata

> On May 4, 2016, 3:40 a.m., Michael Pyne wrote: > > autotests/kaboutdatatest.cpp, line 317 > > > > > > Doesn't this call make the KAboutData::applicationData() call that > > happens later return *this*

Re: Review Request 127655: Fix KAboutData::applicationData() to init from current Q*Application metadata

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127655/ --- (Updated May 4, 2016, 2:47 p.m.) Review request for KDE Frameworks, Alex

Re: Review Request 127655: Fix KAboutData::applicationData() to init from current Q*Application metadata

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127655/#review95158 --- autotests/kaboutdatatest.cpp (line 317)

Re: Review Request 127655: Fix KAboutData::applicationData() to init from current Q*Application metadata

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127655/#review95147 --- Fix it, then Ship it! A couple of minor things but this

Re: Review Request 127655: Fix KAboutData::applicationData() to init from current Q*Application metadata

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127655/ --- (Updated May 3, 2016, 12:39 a.m.) Review request for KDE Frameworks,