Re: Review Request 127809: [Platform xcb] Get best icon size when he's not specified

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127809/ --- (Updated May 20, 2016, 6:54 p.m.) Status -- This change has been

Re: Review Request 127809: [Platform xcb] Get best icon size when he's not specified

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127809/#review95638 --- Ship it! Sorry for the hard review. - Martin Gräßlin

Re: Review Request 127809: [Platform xcb] Get best icon size when he's not specified

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127809/ --- (Updated Май 18, 2016, 11:06 преди обяд) Review request for KDE

Re: Review Request 127809: [Platform xcb] Get best icon size when he's not specified

> On May 17, 2016, 4:44 p.m., Martin Gräßlin wrote: > > src/platforms/xcb/kwindowsystem.cpp, lines 730-732 > > > > > > this change looks not really needed. Looking at the code I think there > > is no change at

Re: Review Request 127809: [Platform xcb] Get best icon size when he's not specified

> On Май 17, 2016, 5:44 след обяд, Martin Gräßlin wrote: > > src/platforms/xcb/kwindowsystem.cpp, lines 730-732 > > > > > > this change looks not really needed. Looking at the code I think there > > is no

Re: Review Request 127809: [Platform xcb] Get best icon size when he's not specified

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127809/#review95540 --- sorry for the late review. Thanks for updating the change

Re: Review Request 127809: [Platform xcb] Get best icon size when he's not specified

> On Май 9, 2016, 3:37 след обяд, Anthony Fieroni wrote: > > Ping. It is ok, now? Martin is there any problems with whis patch? - Anthony --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 127809: [Platform xcb] Get best icon size when he's not specified

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127809/#review95296 --- Ping. It is ok, now? - Anthony Fieroni On Май 6, 2016,

Re: Review Request 127809: [Platform xcb] Get best icon size when he's not specified

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127809/ --- (Updated Май 6, 2016, 12:08 след обяд) Review request for KDE

Re: Review Request 127809: [Platform xcb] Get best icon size when he's not specified

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127809/#review95227 --- src/platforms/xcb/kwindowsystem.cpp (lines 736 - 739)

Re: Review Request 127809: [Platform xcb] Get best icon size when he's not specified

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127809/ --- (Updated Май 6, 2016, 10:02 преди обяд) Review request for KDE

Re: Review Request 127809: [Platform xcb] Get best icon size when he's not specified

> On May 4, 2016, 10:18 a.m., Martin Gräßlin wrote: > > src/platforms/xcb/kwindowsystem.cpp, lines 711-717 > > > > > > This changes the behavior of the method. Now always NETWM is preferred, > > even if it

Re: Review Request 127809: [Platform xcb] Get best icon size when he's not specified

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127809/ --- (Updated Май 5, 2016, 7:50 след обяд) Review request for KDE Frameworks,

Re: Review Request 127809: [Platform xcb] Get best icon size when he's not specified

> On Май 4, 2016, 11:18 преди обяд, Martin Gräßlin wrote: > > src/platforms/xcb/kwindowsystem.cpp, lines 711-717 > > > > > > This changes the behavior of the method. Now always NETWM is preferred, > > even if

Re: Review Request 127809: [Platform xcb] Get best icon size when he's not specified

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127809/#review95152 --- src/platforms/xcb/kwindowsystem.cpp (lines 711 - 716)

Re: Review Request 127809: [Platform xcb] Get best icon size when he's not specified

> On May 2, 2016, 4:02 p.m., Martin Gräßlin wrote: > > What is the "best" size if it's not specified? Why is your change better > > than how it was? > > > > This change adjusts a very important part of the icon lookup functionality > > used by KWin and Plasma. I'm a little bit scared of

Re: Review Request 127809: [Platform xcb] Get best icon size when he's not specified

> On Май 2, 2016, 5:02 след обяд, Martin Gräßlin wrote: > > What is the "best" size if it's not specified? Why is your change better > > than how it was? > > > > This change adjusts a very important part of the icon lookup functionality > > used by KWin and Plasma. I'm a little bit scared of

Re: Review Request 127809: [Platform xcb] Get best icon size when he's not specified

> On Май 2, 2016, 5:02 след обяд, Martin Gräßlin wrote: > > What is the "best" size if it's not specified? Why is your change better > > than how it was? > > > > This change adjusts a very important part of the icon lookup functionality > > used by KWin and Plasma. I'm a little bit scared of

Re: Review Request 127809: [Platform xcb] Get best icon size when he's not specified

> On May 2, 2016, 4:02 p.m., Martin Gräßlin wrote: > > What is the "best" size if it's not specified? Why is your change better > > than how it was? > > > > This change adjusts a very important part of the icon lookup functionality > > used by KWin and Plasma. I'm a little bit scared of

Re: Review Request 127809: [Platform xcb] Get best icon size when he's not specified

> On May 2, 2016, 4:02 p.m., Martin Gräßlin wrote: > > What is the "best" size if it's not specified? Why is your change better > > than how it was? > > > > This change adjusts a very important part of the icon lookup functionality > > used by KWin and Plasma. I'm a little bit scared of

Re: Review Request 127809: [Platform xcb] Get best icon size when he's not specified

> On Май 2, 2016, 5:02 след обяд, Martin Gräßlin wrote: > > What is the "best" size if it's not specified? Why is your change better > > than how it was? > > > > This change adjusts a very important part of the icon lookup functionality > > used by KWin and Plasma. I'm a little bit scared of

Re: Review Request 127809: [Platform xcb] Get best icon size when he's not specified

> On Май 2, 2016, 5:02 след обяд, Martin Gräßlin wrote: > > src/platforms/xcb/kwindowsystem.cpp, lines 740-741 > > > > > > This makes the code way more difficult to read. I'm no longer able to > > grasp what's

Re: Review Request 127809: [Platform xcb] Get best icon size when he's not specified

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127809/ --- (Updated Май 2, 2016, 5:04 след обяд) Review request for KDE Frameworks,

Re: Review Request 127809: [Platform xcb] Get best icon size when he's not specified

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127809/#review95084 --- What is the "best" size if it's not specified? Why is your