Re: Review Request 128353: Unit tests of directory permissions in zip files

2016-07-04 Thread Sune Vuorela
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128353/ --- (Updated July 4, 2016, 6:27 p.m.) Status -- This change has been

Re: Review Request 128353: Unit tests of directory permissions in zip files

2016-07-04 Thread Sune Vuorela
> On July 3, 2016, 8:25 p.m., David Faure wrote: > > autotests/karchivetest.cpp, line 1118 > > > > > > Why QLatin1String("") and not just QString() ? Previous unit test does the same - Sune

Re: Review Request 128353: Unit tests of directory permissions in zip files

2016-07-03 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128353/#review97066 --- Fix it, then Ship it! autotests/karchivetest.cpp (line

Re: Review Request 128353: Unit tests of directory permissions in zip files

2016-07-03 Thread Sune Vuorela
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128353/ --- (Updated July 3, 2016, 1:09 p.m.) Review request for KDE Frameworks and

Review Request 128353: Unit tests of directory permissions in zip files

2016-07-03 Thread Sune Vuorela
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128353/ --- Review request for KDE Frameworks and David Faure. Repository: karchive