Re: Review Request 128790: Call utempter manually

2016-10-01 Thread Martin Tobias Holmedahl Sandsmark
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128790/ --- (Updated Oct. 1, 2016, 8:59 a.m.) Status -- This change has been mar

Re: Review Request 128790: Call utempter manually

2016-10-01 Thread Oswald Buddenhagen
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128790/#review99696 --- Ship it! Ship It! - Oswald Buddenhagen On Oct. 1, 2016,

Re: Review Request 128790: Call utempter manually

2016-10-01 Thread Martin Tobias Holmedahl Sandsmark
> On Sept. 23, 2016, 5:17 a.m., Oswald Buddenhagen wrote: > > cmake/FindUTEMPTER.cmake, line 53 > > > > > > i suppose it would make sense to keep it, but with the executable. > > Martin Tobias Holmedahl Sandsmark

Re: Review Request 128790: Call utempter manually

2016-10-01 Thread Martin Tobias Holmedahl Sandsmark
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128790/ --- (Updated Oct. 1, 2016, 10:37 a.m.) Review request for KDE Frameworks, Dav

Re: Review Request 128790: Call utempter manually

2016-09-25 Thread Oswald Buddenhagen
> On Sept. 23, 2016, 5:17 a.m., Oswald Buddenhagen wrote: > > cmake/FindUTEMPTER.cmake, line 53 > > > > > > i suppose it would make sense to keep it, but with the executable. > > Martin Tobias Holmedahl Sandsmark

Re: Review Request 128790: Call utempter manually

2016-09-25 Thread Martin Tobias Holmedahl Sandsmark
> On Sept. 23, 2016, 5:17 a.m., Oswald Buddenhagen wrote: > > a bit of delay due to vacation ... no problem, I was in shenzhen myself. > On Sept. 23, 2016, 5:17 a.m., Oswald Buddenhagen wrote: > > cmake/FindUTEMPTER.cmake, line 53 > >

Re: Review Request 128790: Call utempter manually

2016-09-22 Thread Oswald Buddenhagen
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128790/#review99479 --- a bit of delay due to vacation ... cmake/FindUTEMPTER.cmake

Re: Review Request 128790: Call utempter manually

2016-09-08 Thread Martin Tobias Holmedahl Sandsmark
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128790/ --- (Updated Sept. 9, 2016, 4:50 a.m.) Review request for KDE Frameworks, Dav

Re: Review Request 128790: Call utempter manually

2016-09-06 Thread Oswald Buddenhagen
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128790/#review98963 --- cmake/FindUTEMPTER.cmake (line 35)

Re: Review Request 128790: Call utempter manually

2016-09-04 Thread Thiago Macieira
> On Sept. 4, 2016, 2:13 p.m., Thiago Macieira wrote: > > What happens if one builds on a machine without utempter? Are we still linking to libutempter? - Thiago --- This is an automatically generated e-mail. To reply, visit: https://g

Re: Review Request 128790: Call utempter manually

2016-09-04 Thread Thiago Macieira
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128790/#review98873 --- src/kpty.cpp (line 85)

Re: Review Request 128790: Call utempter manually

2016-09-04 Thread Martin Tobias Holmedahl Sandsmark
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128790/ --- (Updated Sept. 4, 2016, 10:20 a.m.) Review request for KDE Frameworks, Da

Re: Review Request 128790: Call utempter manually

2016-08-28 Thread Martin Tobias Holmedahl Sandsmark
> On Aug. 28, 2016, 3:24 p.m., Oswald Buddenhagen wrote: > > src/kpty.cpp, line 165 > > > > > > hmpf, i'd really prefer this to be a configure/cmake thing rather than > > a runtime detection. less runtime code,

Re: Review Request 128790: Call utempter manually

2016-08-28 Thread Oswald Buddenhagen
> On Aug. 28, 2016, 3:24 p.m., Oswald Buddenhagen wrote: > > src/kpty.cpp, line 165 > > > > > > hmpf, i'd really prefer this to be a configure/cmake thing rather than > > a runtime detection. less runtime code,

Re: Review Request 128790: Call utempter manually

2016-08-28 Thread Martin Tobias Holmedahl Sandsmark
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128790/ --- (Updated Aug. 28, 2016, 5:36 p.m.) Review request for KDE Frameworks, Dav

Re: Review Request 128790: Call utempter manually

2016-08-28 Thread Martin Tobias Holmedahl Sandsmark
> On Aug. 28, 2016, 3:24 p.m., Oswald Buddenhagen wrote: > > src/kpty.cpp, line 165 > > > > > > hmpf, i'd really prefer this to be a configure/cmake thing rather than > > a runtime detection. less runtime code,

Re: Review Request 128790: Call utempter manually

2016-08-28 Thread Oswald Buddenhagen
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128790/#review98749 --- src/kpty.cpp (line 165)

Re: Review Request 128790: Call utempter manually

2016-08-28 Thread Martin Tobias Holmedahl Sandsmark
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128790/ --- (Updated Aug. 28, 2016, 2:58 p.m.) Review request for KDE Frameworks, Dav