Re: Review Request 129197: Fix tests on FreeBSD

2016-10-31 Thread Gleb Popov
> On Oct. 16, 2016, 4:12 p.m., Tobias Berner wrote: > > I'm kind of unsure if this is right. Yes, the tests run now, but isn't the > > issue rather in the way kpty works (or fails to work on FreeBSD)? > > Gleb Popov wrote: > From what i've understood, this boils down to >

Re: Review Request 129197: Fix tests on FreeBSD

2016-10-29 Thread Oswald Buddenhagen
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129197/#review100148 --- autotests/kptyprocesstest.cpp (line 123)

Re: Review Request 129197: Fix tests on FreeBSD

2016-10-29 Thread Oswald Buddenhagen
> On Oct. 16, 2016, 1:12 p.m., Tobias Berner wrote: > > I'm kind of unsure if this is right. Yes, the tests run now, but isn't the > > issue rather in the way kpty works (or fails to work on FreeBSD)? > > Gleb Popov wrote: > From what i've understood, this boils down to >

Re: Review Request 129197: Fix tests on FreeBSD

2016-10-16 Thread Gleb Popov
> On Oct. 16, 2016, 4:12 p.m., Tobias Berner wrote: > > I'm kind of unsure if this is right. Yes, the tests run now, but isn't the > > issue rather in the way kpty works (or fails to work on FreeBSD)? >From what i've understood, this boils down to >`KPtyDevicePrivate::_k_canRead()` method in

Re: Review Request 129197: Fix tests on FreeBSD

2016-10-16 Thread Tobias Berner
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129197/#review100039 --- I'm kind of unsure if this is right. Yes, the tests run

Review Request 129197: Fix tests on FreeBSD

2016-10-16 Thread Gleb Popov
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129197/ --- Review request for KDE Frameworks, Adriaan de Groot, Tobias Berner, Oswald