Re: Splitting out a KX11Extras frameworks from KWindowSystems

2013-09-19 Thread David Faure
On Monday 16 September 2013 15:07:37 Martin Graesslin wrote: Hi, KWindowSystems is a framework which looks to me like a KX11Extras framework. Most of the things inside this framework are X11 specific. Some API even has XLib/XCB specific data types as arguments or return values (e.g.

Re: Review Request 112758: Move KCompletion to tier2

2013-09-19 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112758/#review40320 --- Ship it! Did you check that it passes the definition of done

Re: Review Request 112795: Move KDocTools to tier2

2013-09-19 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112795/#review40321 --- Ship it! Did you check that it passes the definition of done

Re: Review Request 112785: Add ki18n_wrap_ui macro to ki18nMacros

2013-09-19 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112785/#review40322 --- https://git.reviewboard.kde.org/r/112795/diff/ might provide

Re: Review Request 112796: Move kcolorutilsdemo from kconfigwidgets/tests to kguiaddons/tests

2013-09-19 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112796/#review40323 --- tier1/kguiaddons/tests/CMakeLists.txt

Re: Review Request 112803: Start cleaning up KDNSSD

2013-09-19 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112803/#review40324 --- dnssd/CMakeLists.txt

Re: Review Request 112808: Port away from KDirWatch in KEmoticons (prior to splitting)

2013-09-19 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112808/#review40325 --- staging/kemoticons/src/core/kemoticons.cpp

Re: Build failed in Jenkins: kdelibs_frameworks_qt5 #1219

2013-09-19 Thread Aleix Pol
On Wed, Sep 18, 2013 at 5:03 PM, KDE CI System n...@kde.org wrote: See http://build.kde.org/job/kdelibs_frameworks_qt5/1219/changes Changes: [aleixpol] Reorganize KDocTools cmake code [aleixpol] Start adopting QCollator -- [...truncated 3600

Re: Fwd: Print Dialog - next steps

2013-09-19 Thread John Layt
On 18 September 2013 08:18, David Faure fa...@kde.org wrote: On Monday 09 September 2013 14:07:31 Martin Klapetek wrote: 5) In KF5 the KdePrintDialog stuff can either be removed entirely, or more conservatively modified to no longer insert the extra KDE Cups widgets and modifications so they

Re: Review Request 112681: Tests for KPluginTrader and friends

2013-09-19 Thread Sebastian Kügler
On Sept. 18, 2013, 10 p.m., David Faure wrote: staging/kservice/tests/pluginlocator/plugintest.cpp, line 170 http://git.reviewboard.kde.org/r/112681/diff/4/?file=190381#file190381line170 hehe I'll leave this in for now. It's the call which parses the stuff created by

Re: Review Request 112796: Move kcolorutilsdemo from kconfigwidgets/tests to kguiaddons/tests

2013-09-19 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112796/ --- (Updated Sept. 19, 2013, 11:30 a.m.) Status -- This change has been

Re: Review Request 112796: Move kcolorutilsdemo from kconfigwidgets/tests to kguiaddons/tests

2013-09-19 Thread Aurélien Gâteau
On Sept. 19, 2013, 9:43 a.m., David Faure wrote: tier1/kguiaddons/tests/CMakeLists.txt, line 28 http://git.reviewboard.kde.org/r/112796/diff/1/?file=190441#file190441line28 But now it's kguiaddons (a tier1) that doesn't build standalone (with tests enabled), because it needs

Re: Review Request 112681: Tests for KPluginTrader and friends

2013-09-19 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112681/ --- (Updated Sept. 19, 2013, 10:19 a.m.) Status -- This change has been

Re: Review Request 112681: Tests for KPluginTrader and friends

2013-09-19 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112681/#review40331 --- This review has been submitted with commit

Re: Review Request 112795: Move KDocTools to tier2

2013-09-19 Thread Aleix Pol Gonzalez
On Sept. 19, 2013, 7:40 a.m., David Faure wrote: tier2/kdoctools/CMakeLists.txt, line 44 http://git.reviewboard.kde.org/r/112795/diff/1/?file=190432#file190432line44 I'm curious, what does that do? It's where the *Config.cmake file will go. Each module define its own

Re: Review Request 112795: Move KDocTools to tier2

2013-09-19 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112795/#review40336 --- This review has been submitted with commit

Re: Review Request 112758: Move KCompletion to tier2

2013-09-19 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112758/ --- (Updated Sept. 19, 2013, 11:13 a.m.) Status -- This change has been

Re: Review Request 112803: Start cleaning up KDNSSD

2013-09-19 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112803/ --- (Updated Sept. 19, 2013, 11:24 a.m.) Review request for KDE Frameworks.

Review Request 112811: Make kguiaddons build standalone

2013-09-19 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112811/ --- Review request for KDE Frameworks and Martin Klapetek. Description

Re: Review Request 112803: Start cleaning up KDNSSD

2013-09-19 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112803/#review40340 --- Ship it! Looks good to me. dnssd/CMakeLists.txt

Review Request 112814: kjs - remove unused dependencies

2013-09-19 Thread Michael Palimaka
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112814/ --- Review request for KDE Frameworks. Description --- QtWidgets is not

Re: Review Request 112803: Start cleaning up KDNSSD

2013-09-19 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112803/#review40347 --- This review has been submitted with commit

Review Request 112823: Move KPixmapSequencer to KWidgetsAddons

2013-09-19 Thread Àlex Fiestas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112823/ --- Review request for KDE Frameworks and Aurélien Gâteau. Description

Re: Review Request 112823: Move KPixmapSequencer to KWidgetsAddons

2013-09-19 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112823/#review40352 --- Looks good overall, but I found a few minor issues.

Re: Review Request 112823: Move KPixmapSequencer to KWidgetsAddons

2013-09-19 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112823/#review40350 --- Maybe you should add a note in KDE5Porting.html? - Aleix Pol

Re: Review Request 112823: Move KPixmapSequencer to KWidgetsAddons

2013-09-19 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112823/#review40351 --- Maybe you should add a note in KDE5Porting.html? - Aleix Pol

Review Request 112825: Adopt modules directory structure

2013-09-19 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112825/ --- Review request for KDE Frameworks. Description --- Moves all code to

Re: Review Request 112823: Move KPixmapSequencer to KWidgetsAddons

2013-09-19 Thread Àlex Fiestas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112823/ --- (Updated Sept. 19, 2013, 3:25 p.m.) Review request for KDE Frameworks and

Re: Review Request 112823: Move KPixmapSequencer to KWidgetsAddons

2013-09-19 Thread Sebastian Kügler
On Sept. 19, 2013, 2:27 p.m., Aurélien Gâteau wrote: tier1/kwidgetsaddons/tests/CMakeLists.txt, line 6 http://git.reviewboard.kde.org/r/112823/diff/1/?file=190546#file190546line6 In KDE4 days programs marked as test had a KDESRCDIR define set which pointed to

Re: Review Request 112823: Move KPixmapSequencer to KWidgetsAddons

2013-09-19 Thread Àlex Fiestas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112823/ --- (Updated Sept. 19, 2013, 3:07 p.m.) Review request for KDE Frameworks and

Re: kde4_add_plugin on KF5

2013-09-19 Thread Aleix Pol
On Thu, Sep 19, 2013 at 6:15 PM, Sebastian Kügler se...@kde.org wrote: On Thursday, September 19, 2013 18:00:41 Aleix Pol wrote: Hi, We should decide what we do with the add_plugin macro. Should I install it as kf5_add_plugin from KCoreAddons? Do we want something different or better?

kde4_add_plugin on KF5

2013-09-19 Thread Aleix Pol
Hi, We should decide what we do with the add_plugin macro. Should I install it as kf5_add_plugin from KCoreAddons? Do we want something different or better? Aleix ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org

Re: Review Request 112828: Provide ecm_add_unit_test() and ecm_add_multiple_unit_tests()

2013-09-19 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112828/#review40360 --- It should be called autotests instead of unittests. It's the

Re: Review Request 112823: Move KPixmapSequencer to KWidgetsAddons

2013-09-19 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112823/#review40361 --- Ship it! Patch does not apply there (complains about

Re: kde4_add_plugin on KF5

2013-09-19 Thread Sebastian Kügler
On Thursday, September 19, 2013 18:26:54 Aleix Pol wrote: Well, I thought of something like that, but I checked and there are projects using the different arguments that kde4_add_plugin has. I don't see the point of oversimplifying there. I didn't mean oversimplifying, but: - to provide

Build failed in Jenkins: plasma-framework_master_qt5 #758

2013-09-19 Thread KDE CI System
See http://build.kde.org/job/plasma-framework_master_qt5/758/changes Changes: [notmart] new install targe [notmart] argsrc for config that can be passed as parameter -- [...truncated 27 lines...] strigidaemon - Branch master libstreamanalyzer -

kde-workspace master becomes Qt5-based

2013-09-19 Thread Sebastian Kügler
Hi all, We're planning to merge the frameworks-scratch branch of kde-workspace into master next Monday. That means if you're building your Plasma yourself from Git (and you're not yet ready for Plasma2 ;)), you should switch to the KDE/4.11 branch. The build will fail otherwise, so you will

Re: kde4_add_plugin on KF5

2013-09-19 Thread Alexander Neundorf
On Thursday 19 September 2013, Alex Merry wrote: On 19/09/13 17:00, Aleix Pol wrote: Hi, We should decide what we do with the add_plugin macro. Should I install it as kf5_add_plugin from KCoreAddons? Do we want something different or better? Would e-c-m be the right place for it?

Review Request 112830: Start splitting KParts

2013-09-19 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112830/ --- Review request for KDE Frameworks. Description --- Started

Build failed in Jenkins: plasma-framework_master_qt5 #759

2013-09-19 Thread KDE CI System
See http://build.kde.org/job/plasma-framework_master_qt5/759/changes Changes: [notmart] manage args also for pasted text without urls -- [...truncated 26 lines...] attica - Branch master libstreamanalyzer - Branch master kdelibs - Branch