Hello,
And what's the error message?
--
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE, in particular KDE Frameworks 5
After his patch
http://commits.kde.org/kdelibs/aac41bc93595a0f341886692fba48717a1a9e2a9,
the issue has been fixed by itself... I can no more
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113045/
---
Review request for KDE Frameworks.
Repository: kdelibs
Description
On Tuesday 01 October 2013 19:28:04 Aleix Pol wrote:
Hi,
Since ReviewBoard is not working for me, I decided to send this review as
an e-mail. I know it's less practical, but also I think it's important to
get it done and I'd rather go reasonably fast with it before we start
getting too much
On Wednesday 02 October 2013 10:14:12 Aurélien Gâteau wrote:
On Tuesday 01 October 2013 19:28:04 Aleix Pol wrote:
Hi,
Since ReviewBoard is not working for me, I decided to send this review as
an e-mail. I know it's less practical, but also I think it's important to
get it done and I'd
Aurélien Gâteau wrote:
On Tuesday 01 October 2013 19:28:04 Aleix Pol wrote:
Hi,
Since ReviewBoard is not working for me, I decided to send this review as
an e-mail. I know it's less practical, but also I think it's important to
get it done and I'd rather go reasonably fast with it before we
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113046/
---
Review request for KDE Frameworks.
Repository: kdelibs
Description
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112931/
---
(Updated Oct. 2, 2013, 10:33 a.m.)
Status
--
This change has been
Aurélien Gâteau wrote:
Move kconfigwidgets to tier3
When I suggested tiers, I proposed that tier2 frameworks could depend on
other tier2 frameworks.
http://thread.gmane.org/gmane.comp.kde.devel.core/67458/focus=67520
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112998/#review41099
---
the add_subdirectory(tests) is still commented in
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112998/
---
(Updated Oct. 2, 2013, 9:27 a.m.)
Review request for KDE Frameworks.
On Wednesday 02 October 2013 11:09:59 Stephen Kelly wrote:
Aurélien Gâteau wrote:
Move kconfigwidgets to tier3
When I suggested tiers, I proposed that tier2 frameworks could depend on
other tier2 frameworks.
http://thread.gmane.org/gmane.comp.kde.devel.core/67458/focus=67520
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112998/
---
(Updated Oct. 2, 2013, 9:36 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112998/#review41101
---
This review has been submitted with commit
Aurélien Gâteau wrote:
I don't have any strong opinion on this, but if we allow tier2 frameworks
to depend on other tier2 frameworks then is there a need for tier3 at all?
Your wiki pages seems to indicate there is no need for it.
That wiki page predates the Randa meeting, where some stuff
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113048/
---
Review request for KDE Frameworks.
Repository: kdelibs
Description
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113048/
---
(Updated Oct. 2, 2013, 10:29 a.m.)
Review request for KDE Frameworks.
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113045/#review41105
---
staging/kcmutils/CMakeLists.txt
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112828/#review41107
---
ping, Richardson can you comment over this review? we really
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113048/#review41108
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On Oct. 2, 2013,
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113046/#review41109
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On Oct. 2, 2013,
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113048/
---
(Updated Oct. 2, 2013, 11:48 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113048/#review41112
---
This review has been submitted with commit
On Oct. 2, 2013, 11:02 a.m., Aleix Pol Gonzalez wrote:
staging/kcmutils/CMakeLists.txt, line 23
http://git.reviewboard.kde.org/r/113045/diff/1/?file=193397#file193397line23
Why removing these?
As I understand it everything should compile with -DQT_NO_CAST_TO_ASCII, it was
David Edmundson wrote:
On Oct. 2, 2013, 11:02 a.m., Aleix Pol Gonzalez wrote:
staging/kcmutils/CMakeLists.txt, line 23
http://git.reviewboard.kde.org/r/113045/diff/1/?file=193397#file193397line23
Why removing these?
As I understand it everything should compile with
I haven't moved anything.
Also this review is 3 different commits, one for each of the sentences
in the description.
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
On Wed, Oct 2, 2013 at 10:25 AM, Stephen Kelly steve...@gmail.com wrote:
Aurélien Gâteau wrote:
On Tuesday 01 October 2013 19:28:04 Aleix Pol wrote:
Hi,
Since ReviewBoard is not working for me, I decided to send this review
as
an e-mail. I know it's less practical, but also I think
David Edmundson wrote:
I haven't moved anything.
Also this review is 3 different commits, one for each of the sentences
in the description.
Indeed, thanks!
Steve.
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
Aleix Pol wrote:
I pushed a couple of new commits that remove the usage of macro_bool_to_01
and the HAVE_QSSLSOCKET thing.
I assume you have no intention of merging that branch? The top commit looks
fine at least.
Please cherry-pick it to frameworks, and rebase and clean-up the rest of
On Wednesday 02 October 2013 12:06:57 Stephen Kelly wrote:
Aurélien Gâteau wrote:
I don't have any strong opinion on this, but if we allow tier2 frameworks
to depend on other tier2 frameworks then is there a need for tier3 at all?
Your wiki pages seems to indicate there is no need for it.
Aurélien Gâteau wrote:
On Wednesday 02 October 2013 12:06:57 Stephen Kelly wrote:
Aurélien Gâteau wrote:
I don't have any strong opinion on this, but if we allow tier2
frameworks to depend on other tier2 frameworks then is there a need for
tier3 at all? Your wiki pages seems to indicate
On Wednesday 02 October 2013 14:48:45 Stephen Kelly wrote:
Aurélien Gâteau wrote:
On Wednesday 02 October 2013 12:06:57 Stephen Kelly wrote:
Aurélien Gâteau wrote:
I don't have any strong opinion on this, but if we allow tier2
frameworks to depend on other tier2 frameworks then is there
On Wednesday, October 02, 2013 11:09:59 Stephen Kelly wrote:
Aurélien Gâteau wrote:
Move kconfigwidgets to tier3
When I suggested tiers, I proposed that tier2 frameworks could depend on
other tier2 frameworks.
http://thread.gmane.org/gmane.comp.kde.devel.core/67458/focus=67520
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113046/#review41114
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113046/
---
(Updated Oct. 2, 2013, 1:19 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113038/#review41115
---
Ship it!
kdesu/CMakeLists.txt
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113049/#review41117
---
Ship it!
Does this make attica independent of ECM? Does it
On Oct. 2, 2013, 2:20 p.m., Stephen Kelly wrote:
Does this make attica independent of ECM? Does it still need to find ECM?
Actually yes. So I'll remove the find_package(ECM...) too and push.
- Martin
---
This is an automatically
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113050/
---
Review request for KDE Frameworks.
Repository: kdelibs
Description
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113050/#review41120
---
I like the idea of being more specific about the return value,
On Oct. 2, 2013, 4:47 p.m., Aleix Pol Gonzalez wrote:
I like the idea of being more specific about the return value, but isn't
this going to break source compatibility?
No because it is OK to assign an enum to an int, so this code:
int result = KMessageBox::warningContinueCancel(...)
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113049/
---
(Updated Oct. 2, 2013, 3:29 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113049/#review41126
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113052/
---
(Updated Oct. 2, 2013, 3:54 p.m.)
Review request for KDE Frameworks and
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113052/#review41128
---
Ship it!
Ship It!
- Stephen Kelly
On Oct. 2, 2013, 3:54
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112942/
---
(Updated Oct. 2, 2013, 4:05 p.m.)
Review request for KDE Frameworks.
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113038/#review41130
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113038/
---
(Updated Oct. 2, 2013, 4:09 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113052/
---
(Updated Oct. 2, 2013, 5:07 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113052/#review41131
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112828/
---
(Updated Oct. 2, 2013, 7:14 p.m.)
Review request for Extra Cmake Modules
See http://build.kde.org/job/kdelibs_frameworks_qt5/1318/changes
Changes:
[aleixpol] Remove weird cmake indirections
--
[...truncated 614 lines...]
-- Looking for include files sys/types.h, netinet/in.h - found
-- Looking for res_init in resolv
-- Looking
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112901/
---
(Updated Oct. 2, 2013, 5:17 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112901/#review41133
---
This review has been submitted with commit
See http://build.kde.org/job/kdelibs_frameworks_qt5/1319/changes
Changes:
[aleixpol] Fix build
[aleixpol] Should have gone in
--
[...truncated 541 lines...]
-- Looking for include file arpa/nameser8_compat.h - not found
-- Looking for include files
See http://build.kde.org/job/kdelibs_frameworks_qt5/1320/changes
Changes:
[aleixpol] kioslaves also uses finders from cmake/modules
--
[...truncated 522 lines...]
CMake Warning at kio/CMakeLists.txt:40 (find_package):
By not providing FindACL.cmake in
As you may know, Qt is working to release 5.2. The dev branch has been
merged to the stable branch, which means the stable branch is now 5.2,
and dev is now 5.3.
build.kde.org is compiling Qt from source, but it's using the dev
branch. As far as I know, the plan is to release KF5 depending on Qt
On Wed, Oct 2, 2013 at 7:53 PM, Nicolás Alvarez
nicolas.alva...@gmail.comwrote:
As you may know, Qt is working to release 5.2. The dev branch has been
merged to the stable branch, which means the stable branch is now 5.2,
and dev is now 5.3.
build.kde.org is compiling Qt from source, but
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113039/#review41141
---
Ship it!
Woa amazing :)
+1
- Aleix Pol Gonzalez
On Oct. 1,
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113008/#review41142
---
Ship it!
Ship It!
- Valentin Rusu
On Oct. 2, 2013, 12:53
On Oct. 2, 2013, 6:51 p.m., Valentin Rusu wrote:
Ship It!
Thanks for doing this!
- Valentin
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113008/#review41142
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112923/
---
(Updated Oct. 2, 2013, 7:12 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112923/#review41145
---
This review has been submitted with commit
See http://build.kde.org/job/kdelibs_frameworks_qt5/1322/changes
Changes:
[kde] Make leftMargin rightMargin virtual methods in KCategoryDrawer
[kde] Set correct target for KEmoticons export
--
[...truncated 510 lines...]
-- Looking for openpty in util
--
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113067/
---
Review request for KDE Frameworks.
Repository: kdelibs
Description
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113067/#review41148
---
Ship it!
This is the simplest solution to get it back
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112985/
---
(Updated Oct. 2, 2013, 9:33 p.m.)
Review request for KDE Frameworks.
See http://build.kde.org/job/kdelibs_frameworks_qt5/1323/changes
Changes:
[aleixpol] Fix build
--
[...truncated 511 lines...]
-- KF5[InstallDirs]: Loaded settings from
See http://build.kde.org/job/kdelibs_frameworks_qt5/1324/changes
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[Background for the blissfully Windows-ignorant devs:
On Windows, executable files have a flag saying whether they are GUI
or console applications. Running a GUI application from a console will
give you the prompt back immediately; I think there's no way to
capture stdout. Running a console
69 matches
Mail list logo
