---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119079/#review62844
---
src/lib/plugin/kpluginloader.h
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119388/#review62848
---
templates/C++/kde-frameworks5-simple/src/main.cpp
On July 22, 2014, 7:42 a.m., Laurent Montel wrote:
templates/C++/kde-frameworks5-simple/src/main.cpp, line 43
https://git.reviewboard.kde.org/r/119388/diff/1/?file=291491#file291491line43
bool KAboutData::setupCommandLine(QCommandLineParser *parser)
{
if
On juil. 22, 2014, 7:42 matin, Laurent Montel wrote:
templates/C++/kde-frameworks5-simple/src/main.cpp, line 43
https://git.reviewboard.kde.org/r/119388/diff/1/?file=291491#file291491line43
bool KAboutData::setupCommandLine(QCommandLineParser *parser)
{
if
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119388/
---
(Updated July 22, 2014, 9:12 a.m.)
Review request for KDE Frameworks and
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119079/
---
(Updated Juli 22, 2014, 1:17 nachm.)
Review request for KDE Frameworks.
On Juli 22, 2014, 9:24 vorm., David Faure wrote:
src/lib/plugin/kpluginloader.h, line 316
https://git.reviewboard.kde.org/r/119079/diff/9/?file=291388#file291388line316
is there a unittest for that? (directory being a relative path)
Yes there is for KPluginLoader::findPlugins(),
See http://build.kde.org/job/kde-baseapps_frameworks_qt5/70/changes
Changes:
[scripty] SVN_SILENT made messages (.desktop file)
[scripty] SVN_SILENT made messages (after extraction)
[scripty] SVN_SILENT made messages (after extraction)
[christoph] Indicate used text encoding in generated HTML
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119406/
---
Review request for KDE Frameworks and Plasma.
Repository:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119406/#review62888
---
+1, this escentially means that it now will use the same code
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119409/
---
Review request for KDE Frameworks and Plasma.
Repository:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119409/
---
(Updated July 22, 2014, 3:40 p.m.)
Review request for KDE Frameworks and
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119410/
---
Review request for KDE Frameworks and David Faure.
Repository: kio
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119409/#review62891
---
src/scriptengines/qml/plasmoid/appletinterface.cpp
On July 22, 2014, 3:59 p.m., Aleix Pol Gonzalez wrote:
src/scriptengines/qml/plasmoid/appletinterface.cpp, line 555
https://git.reviewboard.kde.org/r/119409/diff/1/?file=291856#file291856line555
Why can't you just call the method? You're not delaying it
ah, no, because that thig is
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119409/
---
(Updated July 22, 2014, 4:10 p.m.)
Review request for KDE Frameworks and
On July 22, 2014, 3:59 p.m., Aleix Pol Gonzalez wrote:
Forgot to say, I think introducing a X-Plasma-Provides is ok.
I guess that it will contain the concepts it's fulfilling, right? such as:
X-Plasma-Provides=clock
On July 22, 2014, 3:59 p.m., Aleix Pol Gonzalez wrote:
On July 21, 2014, 4:24 p.m., Jonathan Riddell wrote:
Also is it really worth having icons? I guess it's fine, but maybe it could
be skipped.
icons are nice :)
- Jonathan
---
This is an automatically generated e-mail. To reply,
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119388/
---
(Updated July 22, 2014, 4:26 p.m.)
Review request for KDE Frameworks,
On July 22, 2014, 3:59 p.m., Aleix Pol Gonzalez wrote:
src/scriptengines/qml/plasmoid/appletinterface.cpp, line 555
https://git.reviewboard.kde.org/r/119409/diff/1/?file=291856#file291856line555
Why can't you just call the method? You're not delaying it
Marco Martin wrote:
On July 22, 2014, 3:59 p.m., Aleix Pol Gonzalez wrote:
src/scriptengines/qml/plasmoid/appletinterface.cpp, line 555
https://git.reviewboard.kde.org/r/119409/diff/1/?file=291856#file291856line555
Why can't you just call the method? You're not delaying it
Marco Martin wrote:
See http://build.kde.org/job/kconfig_master_qt5/118/changes
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
On July 22, 2014, 3:59 p.m., Aleix Pol Gonzalez wrote:
src/scriptengines/qml/plasmoid/appletinterface.cpp, line 555
https://git.reviewboard.kde.org/r/119409/diff/1/?file=291856#file291856line555
Why can't you just call the method? You're not delaying it
Marco Martin wrote:
On July 22, 2014, 3:59 p.m., Aleix Pol Gonzalez wrote:
src/scriptengines/qml/plasmoid/appletinterface.cpp, line 555
https://git.reviewboard.kde.org/r/119409/diff/1/?file=291856#file291856line555
Why can't you just call the method? You're not delaying it
Marco Martin wrote:
On July 22, 2014, 3:59 p.m., Aleix Pol Gonzalez wrote:
src/scriptengines/qml/plasmoid/appletinterface.cpp, line 555
https://git.reviewboard.kde.org/r/119409/diff/1/?file=291856#file291856line555
Why can't you just call the method? You're not delaying it
Marco Martin wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119410/#review62902
---
Have to run now but want to comment so i don't forget.
Have
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119406/#review62911
---
Two issues:
- Existing Dialog instances don't get the corner
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119417/
---
Review request for KDE Frameworks.
Repository: kconfig
Description
Hello,
Currently KDELibs4Support fails to install on Windows. It gives the
following error:
CMake Error at src/cmake_install.cmake:264 (file):
file RELATIVE_PATH must be passed a full path to the file:
searched_dir-NOTFOUND
Call Stack (most recent call first):
cmake_install.cmake:115
29 matches
Mail list logo
