Re: KIdleTime : to poll not or provide a settable resolution for the polling backends?

René J. V. Bertin wrote: > As to MacPoller: I'll see whether I subclass WidgetBasedPoller or whether it's > just as efficient to copy/paste the relevant code (if I'd be overriding too > many methods, which might be the case here). Seems I'll be doing copy/paste, because when I subclass following

Re: Review Request 126087: Move the i18n context from KDeclarative

> On Nov. 17, 2015, 10:58 a.m., Marco Martin wrote: > > Here's the reason I don't like it: > > In origin KDeclarative was intended to be a library that only depended from > > Qt stuff, to be at most tier 2 (and imports there were supposed to be > > qt-only as well) and frameworks applications

Re: Review Request 126087: Move the i18n context from KDeclarative

> On Nov. 17, 2015, 10:58 a.m., Marco Martin wrote: > > Here's the reason I don't like it: > > In origin KDeclarative was intended to be a library that only depended from > > Qt stuff, to be at most tier 2 (and imports there were supposed to be > > qt-only as well) and frameworks applications

Re: Review Request 126087: Move the i18n context from KDeclarative

> On Nov. 17, 2015, 9:58 a.m., Marco Martin wrote: > > Here's the reason I don't like it: > > In origin KDeclarative was intended to be a library that only depended from > > Qt stuff, to be at most tier 2 (and imports there were supposed to be > > qt-only as well) and frameworks applications

Re: Review Request 126087: Move the i18n context from KDeclarative

> On Nov. 16, 2015, 3:08 p.m., Milian Wolff wrote: > > src/klocalizedcontext.cpp, line 53 > > > > > > isNull or isEmpty? Don't we usually want to check against isEmpty and > > never against isNull? Isn't the

Re: Review Request 126087: Move the i18n context from KDeclarative

> On Nov. 17, 2015, 9:58 a.m., Marco Martin wrote: > > Here's the reason I don't like it: > > In origin KDeclarative was intended to be a library that only depended from > > Qt stuff, to be at most tier 2 (and imports there were supposed to be > > qt-only as well) and frameworks applications

Re: KIdleTime : to poll not or provide a settable resolution for the polling backends?

Martin Graesslin wrote: Sorry, long reply, too many arguments. > Don't poll. Never ever, don't poll. That's the opposite of what an application wants to do. As I said elsewhere, while I agree on the principle I don't think that should be dogma. It depends on the requirements of the

Re: Review Request 126087: Move the i18n context from KDeclarative

> On Nov. 17, 2015, 9:58 a.m., Marco Martin wrote: > > Here's the reason I don't like it: > > In origin KDeclarative was intended to be a library that only depended from > > Qt stuff, to be at most tier 2 (and imports there were supposed to be > > qt-only as well) and frameworks applications

Re: Review Request 126056: Use KDE_INSTALL_ICONDIR to install the icons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126056/ --- (Updated Nov. 17, 2015, 12:42 nachm.) Review request for KDE Frameworks

Re: Review Request 126057: Use KDE_INSTALL_ICONDIR to install the icons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126057/ --- (Updated Nov. 17, 2015, 12:45 nachm.) Review request for KDE Frameworks

Re: KIdleTime: early and/or failing/rejected timeout detection?

Martin Graesslin wrote: > I don't really understand. How can it signal too early? I was wrong about the MS Windows implementation, but from WidgetBasedPoller: Q_FOREACH(int timeOut, m_timeouts) { if ( ( timeOut - idle < 300 && timeOut >= idle ) || ( idle - timeOut < 300 && idle >

Re: KIdleTime: early and/or failing/rejected timeout detection?

On Tuesday, November 17, 2015 5:04:09 PM CET René J. V. Bertin wrote: > > I can say for Wayland as I wrote that recently: > I'm guessing Wayland will provide a mechanism that's inspired by what Xcb > provides? eh no. As I control both the server (hello KWin) and the client (hello KWayland) I

Re: KIdleTime: early and/or failing/rejected timeout detection?

On Tuesday, November 17, 2015 2:59:57 PM CET René J.V. Bertin wrote: > KIdleTime really seems to have captured my attention - it's after all very > closely related to "problems" I've had to solve more than a few times in a > previous life. > > Currently, the MS Windows and OS X backends have 2

KIdleTime: early and/or failing/rejected timeout detection?

KIdleTime really seems to have captured my attention - it's after all very closely related to "problems" I've had to solve more than a few times in a previous life. Currently, the MS Windows and OS X backends have 2 issues with detecting & signalling idle timeouts, aside from the fact they

Re: KIdleTime: early and/or failing/rejected timeout detection?

Martin Graesslin wrote: > NO POLLING! > > If you cannot do that on OSX, I really think it's better to not provide it. If > you think it's unfair that there is a backend for X11 which performs polling, > then I'm going to delete the XScreenSaver based one. I'm not adding code that polls, I'm

Re: Review Request 126087: Move the i18n context from KDeclarative

> On Nov. 17, 2015, 9:43 a.m., Chusslove Illich wrote: > > Could you also document the usage in docs/programmers-guide.md (section > > #link_cat)? I'm not much into QML, so it would help me understand the > > implications of the usage. > > > > It seems to me other three series of calls

Re: KIdleTime : to poll not or provide a settable resolution for the polling backends?

Another thing I should have realised: It is not currently feasible with Qt to detect "global" events that are not destined to "ourselves" (see http://stackoverflow.com/questions/19229777/how-to-detect-global-mouse-button-events and

Re: Review Request 126056: Use KDE_INSTALL_ICONDIR to install the icons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126056/#review88499 --- icons/CMakeLists.txt (line 9)

Re: Review Request 126057: Use KDE_INSTALL_ICONDIR to install the icons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126057/#review88500 --- Ship it! Ship It! - Alex Merry On Nov. 17, 2015, 12:45

Re: Review Request 126078: [OS X] modernising the KIdleTime plugin (WIP!)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126078/#review88505 --- src/plugins/osx/macpoller.h (line 24)

Re: Review Request 125705: Use LANG for month names in calendar applet

> On Oct. 28, 2015, 9:44 p.m., Martin Klapetek wrote: > > So...any word on this? > > Albert Astals Cid wrote: > Re-reading your comment, if i understand it correctly, you claim it is a > bug in Qt that it does obey LC_DATE for month names when according to you > LC_DATE is only for the

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,NoX11,gcc - Build # 152 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/152/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Tue, 17 Nov 2015 23:11:23 + Build duration: 13 sec CHANGE SET

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,NoX11,gcc - Build # 153 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/153/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Wed, 18 Nov 2015 00:04:41 + Build duration: 2 min 53 sec CHANGE

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,NoX11,gcc - Build # 153 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/153/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Wed, 18 Nov 2015 00:04:41 + Build duration: 2 min 53 sec CHANGE

Re: Review Request 126087: Move the i18n context from KDeclarative

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126087/#review88463 --- Here's the reason I don't like it: In origin KDeclarative was

Re: Review Request 126091: Remove printscreen.khotkeys from KHotkeys package

> On Nov. 17, 2015, 12:51 p.m., Martin Gräßlin wrote: > > should the file be added to ksnapshot? Already done, installs to both {CMAKE_INSTALL_PREFIX}/share/khotkeys and {CMAKE_INSTALL_PREFIX}/share/apps/khotkeys (for kde4 compatibility) - Boudhayan

Re: Review Request 126087: Move the i18n context from KDeclarative

> On Nov. 17, 2015, 10:58 a.m., Marco Martin wrote: > > Here's the reason I don't like it: > > In origin KDeclarative was intended to be a library that only depended from > > Qt stuff, to be at most tier 2 (and imports there were supposed to be > > qt-only as well) and frameworks applications

Re: Review Request 126087: Move the i18n context from KDeclarative

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126087/#review88459 --- Could you also document the usage in

Re: Review Request 126078: [OS X] modernising the KIdleTime plugin (WIP!)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126078/#review88509 --- src/plugins/osx/macpoller.cpp (lines 144 - 149)

Re: Review Request 126078: [OS X] modernising the KIdleTime plugin (WIP!)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126078/ --- (Updated Nov. 17, 2015, 10:12 p.m.) Review request for KDE Software on

Re: KIdleTime: early and/or failing/rejected timeout detection?

On Tuesday, November 17, 2015 6:33:17 PM CET René J. V. Bertin wrote: > Martin Graesslin wrote: > > NO POLLING! > > > > If you cannot do that on OSX, I really think it's better to not provide > > it. If you think it's unfair that there is a backend for X11 which > > performs polling, then I'm