Re: RCC for icons - update: Re: Icons installed by apps

2016-03-10 Thread Jaroslaw Staniek
Update: Full (light) breeze.rcc theme file can be squashed to 5MiB using SVG optimizer SVGO, in a similar way to what Aleix's script does ( https://quickgit.kde.org/?p=breeze-icons.git=commit=8a31ac8ac105) :) Good job, Aleix. On 8 March 2016 at 23:56, Jaroslaw Staniek wrote:

Re: RCC for icons - update: Re: Icons installed by apps

2016-03-10 Thread Aleix Pol
On Thu, Mar 10, 2016 at 9:33 AM, Jaroslaw Staniek wrote: > Update: > > Full (light) breeze.rcc theme file can be squashed to 5MiB using SVG > optimizer SVGO, in a similar way to what Aleix's script does > (https://quickgit.kde.org/?p=breeze-icons.git=commit=8a31ac8ac105) :) > >

Review Request 127326: [KNotification] KNofication remove leak and missing emit closed

2016-03-10 Thread Anthony Fieroni
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127326/ --- Review request for KDE Frameworks, Kai Uwe Broulik, David Edmundson, and

Re: Review Request 127326: [KNotification] KNofication remove leak and missing emit closed

2016-03-10 Thread Martin Klapetek
> On March 10, 2016, 2:56 p.m., Martin Klapetek wrote: > > Can you please explain clearly the problem this should solve and explain > > more clearly how this solves that problem? > > > > Also I see with your every review "I have not tested this", please do test > > your patches before posting

Re: Review Request 127326: [KNotification] KNofication remove leak and missing emit closed

2016-03-10 Thread Anthony Fieroni
> On Март 10, 2016, 3:56 след обяд, Martin Klapetek wrote: > > Can you please explain clearly the problem this should solve and explain > > more clearly how this solves that problem? > > > > Also I see with your every review "I have not tested this", please do test > > your patches before

Re: Review Request 127326: [KNotification] KNofication remove leak and missing emit closed

2016-03-10 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127326/#review93387 --- Can you please explain clearly the problem this should solve

Review Request 127334: Fix build with -DBUILD_TEST=TRUE

2016-03-10 Thread Heiko Becker
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127334/ --- Review request for KDE Frameworks, Dario Freddi and Martin Gräßlin.

Re: Review Request 126750: Make KIconDialog and its sub-dialog Qt::WindowModal, rather than Qt::NonModal

2016-03-10 Thread Martin Gräßlin
> On Jan. 15, 2016, 8:20 a.m., Martin Gräßlin wrote: > > > The KIconDialog itself works fine, but the "Browse..." sub dialog, which > > > is a grand child of the modal dialog, is opened in the background and > > > cannot be used > > > > this sounds like a Qt bug or a KFileDialog bug. The sub

Re: Review Request 126750: Make KIconDialog and its sub-dialog Qt::WindowModal, rather than Qt::NonModal

2016-03-10 Thread Christoph Feck
> On Jan. 15, 2016, 7:20 a.m., Martin Gräßlin wrote: > > > The KIconDialog itself works fine, but the "Browse..." sub dialog, which > > > is a grand child of the modal dialog, is opened in the background and > > > cannot be used > > > > this sounds like a Qt bug or a KFileDialog bug. The sub

Re: Review Request 127271: Disable session restore for kwalletd5

2016-03-10 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127271/#review93398 --- Please revert to the initial patch, I should have given it a

Re: Review Request 127334: Fix build with -DBUILD_TEST=TRUE

2016-03-10 Thread Kevin Funk
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127334/#review93396 --- Ship it! Ship It! - Kevin Funk On March 10, 2016, 7:04

Re: Review Request 127334: Fix build with -DBUILD_TEST=TRUE

2016-03-10 Thread Heiko Becker
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127334/ --- (Updated March 10, 2016, 7:46 p.m.) Status -- This change has been

Re: Review Request 127271: Disable session restore for kwalletd5

2016-03-10 Thread David Faure
> On March 5, 2016, 9:27 a.m., David Faure wrote: > > Looks good and more portable than the > > qunsetenv("SESSION_MANAGER"); > > which is used in many other places... > > > > Not sure both connects are necessary though? > > Xuetian Weng wrote: > This is not to disable the whole

Re: Review Request 127326: [KNotification] KNofication remove leak and missing emit closed

2016-03-10 Thread Anthony Fieroni
> On Март 10, 2016, 3:56 след обяд, Martin Klapetek wrote: > > Can you please explain clearly the problem this should solve and explain > > more clearly how this solves that problem? > > > > Also I see with your every review "I have not tested this", please do test > > your patches before

Re: Review Request 127251: [KUnitConversion] Fix downloading currency exchange rates

2016-03-10 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127251/#review93400 --- src/currency.cpp (line 661)

Re: Jenkins-kde-ci: kio master kf5-qt5 » Linux, gcc - Build # 259 - Still Unstable!

2016-03-10 Thread David Faure
On Tuesday 08 March 2016 19:42:18 Christoph Cullmann wrote: > Hi, > > perhaps I am confused, but this looks strange to me. > > The TestSuite.kiocore-threadtest fails randomly (it worked in the previous > build with the patch inside) > and the favicons tests worked with my first try of this