Re: Review Request 127699: Set the xscreensaver plugin as valid only if the dbus interface org.freedesktop.ScreenSaver is present

2016-04-25 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127699/#review94839 --- src/plugins/xscreensaver/xscreensaverbasedpoller.cpp (line

Re: Review Request 127699: Set the xscreensaver plugin as valid only if the dbus interface org.freedesktop.ScreenSaver is present

2016-04-25 Thread Martin Gräßlin
> On April 25, 2016, 1:55 p.m., Martin Gräßlin wrote: > > The change looks wrong to me. The functionality of that poller > > implementation is not bound to the availability of the dbus interface, but > > on the XScreenSaver X11 extension. The dbus interface is only used to emit > > a

Re: Review Request 127699: Set the xscreensaver plugin as valid only if the dbus interface org.freedesktop.ScreenSaver is present

2016-04-25 Thread Paulo Lieuthier
> On April 25, 2016, 8:55 a.m., Martin Gräßlin wrote: > > The change looks wrong to me. The functionality of that poller > > implementation is not bound to the availability of the dbus interface, but > > on the XScreenSaver X11 extension. The dbus interface is only used to emit > > a

Re: Review Request 127699: Set the xscreensaver plugin as valid only if the dbus interface org.freedesktop.ScreenSaver is present

2016-04-25 Thread Paulo Lieuthier
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127699/ --- (Updated April 25, 2016, 11:52 a.m.) Status -- This change has been

[Differential] [Accepted] D1489: Disable new_delete_type_mismatch temporarily

2016-04-25 Thread apol (Aleix Pol Gonzalez)
apol accepted this revision. apol added a reviewer: apol. apol added a comment. This revision is now accepted and ready to land. Let's get this in until we can get a fixed Qt... REPOSITORY rCONFBUILD build.kde.org jenkins build configuration BRANCH master REVISION DETAIL

Re: Review Request 126362: Allow timeout in reset_oom_protection while waiting for SIGUSR1

2016-04-25 Thread Michael Pyne
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126362/#review94847 --- Any news on this one? I can commit it if you like (I'm still

[Differential] [Accepted] D1465: KFileItem: remove separate storage of times, use UDSEntry instead.

2016-04-25 Thread aacid (Albert Astals Cid)
aacid accepted this revision. aacid added a reviewer: aacid. aacid added a comment. This revision is now accepted and ready to land. Looks good :) BRANCH master REVISION DETAIL https://phabricator.kde.org/D1465 EMAIL PREFERENCES

Re: Review Request 127747: Create a new script that generate the documentation for all projects following the syntax I proposed

2016-04-25 Thread Olivier Churlaud
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127747/ --- (Updated April 25, 2016, 10:49 p.m.) Review request for KDE Frameworks,

Re: Jenkins-kde-ci: kdbusaddons master kf5-qt5 » Linux, gcc - Build # 11 - Still Unstable!

2016-04-25 Thread Albert Astals Cid
El dilluns, 25 d’abril de 2016, a les 19:14:00 CEST, Ben Cooksley va escriure: > On Mon, Apr 25, 2016 at 5:59 PM, Martin Graesslin wrote: > > On Saturday, April 23, 2016 8:48:17 PM CEST Ben Cooksley wrote: > >> On Sat, Apr 23, 2016 at 8:35 PM, Martin Graesslin

Re: [KIO] cookie service and installing in a parallel prefix (/opt/local)

2016-04-25 Thread David Faure
On Friday 22 April 2016 23:51:51 René J.V. Bertin wrote: > On Friday April 22 2016 23:33:27 René J.V. Bertin wrote: > > > Looks like I'm going to have to add output to kio_http and see if the error > > message doesn't come from an error==ENOENT returned from a failed function > > call. Seems

Re: Jenkins-kde-ci: kdbusaddons master kf5-qt5 » Linux, gcc - Build # 11 - Still Unstable!

2016-04-25 Thread Martin Graesslin
On Saturday, April 23, 2016 8:48:17 PM CEST Ben Cooksley wrote: > On Sat, Apr 23, 2016 at 8:35 PM, Martin Graesslin wrote: > > On Saturday, April 23, 2016 1:09:00 PM CEST Ben Cooksley wrote: > >> On Sat, Apr 23, 2016 at 1:04 PM, Daniel Vrátil wrote: > >> >

Re: Jenkins-kde-ci: kdbusaddons master kf5-qt5 » Linux, gcc - Build # 11 - Still Unstable!

2016-04-25 Thread Ben Cooksley
On Mon, Apr 25, 2016 at 5:59 PM, Martin Graesslin wrote: > On Saturday, April 23, 2016 8:48:17 PM CEST Ben Cooksley wrote: >> On Sat, Apr 23, 2016 at 8:35 PM, Martin Graesslin > wrote: >> > On Saturday, April 23, 2016 1:09:00 PM CEST Ben Cooksley wrote: >>

Re: Jenkins-kde-ci: kdbusaddons master kf5-qt5 » Linux, gcc - Build # 11 - Still Unstable!

2016-04-25 Thread Albert Astals Cid
I object. a) I already told you, don't use something nobody else uses, use the separate reposb) Not going to happen, but why would it matter at all? More reasons for it: c) ASAN does not check for things in the library being broken or not since it only works on code compiled with ASAN, so the

Re: Jenkins-kde-ci: kdbusaddons master kf5-qt5 » Linux, gcc - Build # 11 - Still Unstable!

2016-04-25 Thread Ben Cooksley
On Mon, Apr 25, 2016 at 7:29 PM, Albert Astals Cid wrote: > I object. > > a) I already told you, don't use something nobody else uses, use the > separate repos Umm, since when? To my knowledge kdesrc-build uses qt5.git. The Qt developers might not, but I don't care one bit what

Re: Jenkins-kde-ci: kdbusaddons master kf5-qt5 » Linux, gcc - Build # 11 - Still Unstable!

2016-04-25 Thread Kevin Ottens
Hello, On Monday, 25 April 2016 07:29:51 CEST Albert Astals Cid wrote: > I object. > a) I already told you, don't use something nobody else uses, use the > separate repos I think you're making that up to some extend, it's used and tested, more than all the possible combinations of using the

Re: Jenkins-kde-ci: kdbusaddons master kf5-qt5 » Linux, gcc - Build # 11 - Still Unstable!

2016-04-25 Thread Martin Graesslin
On Monday, April 25, 2016 11:17:03 AM CEST Luigi Toscano wrote: > On Monday 25 of April 2016 19:14:00 Ben Cooksley wrote: > > On Mon, Apr 25, 2016 at 5:59 PM, Martin Graesslin > > wrote: > > > In summary: I don't want spend time to investigate false positives. If > > > an > >

Re: ECM metainfo path

2016-04-25 Thread Harald Sitter
On Fri, Apr 22, 2016 at 10:13 PM, Matthias Klumpp wrote: > 2016-04-22 12:45 GMT+02:00 Harald Sitter : >> Lost mailing list CC, I am assuming that was intentional? (: > > Oops, no - I didn't see the CC and didn't hit reply-all then... > Adding the list back

Re: Jenkins-kde-ci: kdbusaddons master kf5-qt5 » Linux, gcc - Build # 11 - Still Unstable!

2016-04-25 Thread Martin Graesslin
On Monday, April 25, 2016 7:29:51 AM CEST Albert Astals Cid wrote: > I object. > a) I already told you, don't use something nobody else uses, use the > separate reposb) Not going to happen, but why would it matter at all? > > More reasons for it: c) ASAN does not check for things in the library

Review Request 127743: mkpath instead of mkdir

2016-04-25 Thread Harald Sitter
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127743/ --- Review request for KDE Frameworks. Repository: kio Description ---

Jenkins-kde-ci: kdbusaddons master kf5-qt5 » Linux,gcc - Build # 13 - Still Unstable!

2016-04-25 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kdbusaddons%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/13/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 25 Apr 2016 10:34:46 + Build duration: 50 sec CHANGE SET Revision

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,NoX11,gcc - Build # 26 - Still Unstable!

2016-04-25 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/26/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Mon, 25 Apr 2016 10:24:08 + Build duration: 2 min 55 sec CHANGE

Jenkins-kde-ci: frameworkintegration master kf5-qt5 » Linux,gcc - Build # 40 - Still Unstable!

2016-04-25 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/frameworkintegration%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/40/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 25 Apr 2016 10:23:18 + Build duration: 7 min 17 sec CHANGE SET Revision

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,All,gcc - Build # 26 - Still Unstable!

2016-04-25 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/26/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Mon, 25 Apr 2016 10:24:08 + Build duration: 2 min 57 sec CHANGE SET

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 26 - Still Unstable!

2016-04-25 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/26/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Mon, 25 Apr 2016 10:24:08 + Build duration: 3 min 55 sec CHANGE SET Revision

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,NoX11,gcc - Build # 26 - Still Unstable!

2016-04-25 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/26/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Mon, 25 Apr 2016 10:24:08 + Build duration: 3 min 54 sec CHANGE SET

Re: Jenkins-kde-ci: kdbusaddons master kf5-qt5 » Linux, gcc - Build # 11 - Still Unstable!

2016-04-25 Thread Martin Graesslin
On Saturday, April 23, 2016 10:35:22 AM CEST Martin Graesslin wrote: > Could we disable that ASAN check please[1]? I have two of my projects > failing due to the DBus problem and one further failing due to a similar > problem in QQuickStyleItem [2]. It's nice that we find errors, but I rather >

Re: Review Request 127743: mkpath instead of mkdir

2016-04-25 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127743/#review94837 --- +1 - Aleix Pol Gonzalez On April 25, 2016, 11:02 a.m.,

[Differential] [Updated, 2 lines] D1489: Disable new_delete_type_mismatch temporarily

2016-04-25 Thread aacid (Albert Astals Cid)
aacid updated this revision to Diff 3511. aacid added a comment. fix syntax REPOSITORY rCONFBUILD build.kde.org jenkins build configuration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1489?vs=3510=3511 BRANCH master REVISION DETAIL https://phabricator.kde.org/D1489

[Differential] [Updated] D1489: Disable new_delete_type_mismatch temporarily

2016-04-25 Thread aacid (Albert Astals Cid)
aacid added reviewers: graesslin, bcooksley, scarlettclark. aacid added a subscriber: Frameworks. aacid added a project: build.kde.org. REPOSITORY rCONFBUILD build.kde.org jenkins build configuration REVISION DETAIL https://phabricator.kde.org/D1489 EMAIL PREFERENCES

[Differential] [Updated] D1489: Disable new_delete_type_mismatch temporarily

2016-04-25 Thread Martin Gräßlin
graesslin added a comment. +1 REPOSITORY rCONFBUILD build.kde.org jenkins build configuration REVISION DETAIL https://phabricator.kde.org/D1489 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: aacid, bcooksley, scarlettclark, graesslin Cc:

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 19 - Fixed!

2016-04-25 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/19/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 26 Apr 2016 02:29:07 + Build duration: 2 min 32 sec CHANGE SET No changes JUNIT RESULTS Name:

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 19 - Fixed!

2016-04-25 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/19/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 26 Apr 2016 02:29:07 + Build duration: 2 min 32 sec CHANGE SET No changes JUNIT RESULTS Name:

Re: Review Request 127632: Prioritize correct extension per theme

2016-04-25 Thread Anthony Fieroni
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127632/#review94851 --- +1 without patch strace kate |& grep ENOENT | wc -l 9369

Re: Review Request 127747: Create a new script that generate the documentation for all projects following the syntax I proposed

2016-04-25 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127747/#review94845 --- metainfo.yaml (line 13)

Re: KF5 Tags tag tags, not commits

2016-04-25 Thread Stephen Kelly
David Faure wrote: > On Sunday 24 April 2016 13:54:02 Stephen Kelly wrote: >> >> Why doesn't v5.21.0 tag the d2e7c78c94e6 commit directly instead? > > Don't know. > > I just call git tag, then git does its magic. > > cat $here/modules.git | while read repo branch; do > echo $repo > .

Re: Review Request 127699: Set the xscreensaver plugin as valid only if the dbus interface org.freedesktop.ScreenSaver is present

2016-04-25 Thread Paulo Lieuthier
> On April 25, 2016, 8:55 a.m., Martin Gräßlin wrote: > > The change looks wrong to me. The functionality of that poller > > implementation is not bound to the availability of the dbus interface, but > > on the XScreenSaver X11 extension. The dbus interface is only used to emit > > a

Re: Review Request 127699: Set the xscreensaver plugin as valid only if the dbus interface org.freedesktop.ScreenSaver is present

2016-04-25 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127699/#review94832 --- The change looks wrong to me. The functionality of that