Re: Review Request 127805: Backup Remote Files: Treat mounted files also as remote files

> On May 1, 2016, 11:30 p.m., Aleix Pol Gonzalez wrote: > > src/document/katedocument.cpp, line 180 > > > > > > Maybe it would make sense to see what's the performance impact of this > > call

Re: Review Request 127903: Update kf5options manpage docbook

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127903/ --- (Updated Mai 26, 2016, 3:01 nachm.) Review request for Documentation and

Re: Review Request 127122: [Kate] Back/Forward mouse buttons

> On March 28, 2016, 8:22 p.m., Sven Brauch wrote: > > Hmm. Do we really need code for that? Can't you simply assign those buttons > > to the forward / backward actions as shortcuts? Try setting them as > > alternate shortcuts by default. > > Anthony Fieroni wrote: > This code is needed.

Jenkins-kde-ci: ktexteditor master stable-kf5-qt5 » Linux,gcc - Build # 88 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/ktexteditor%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/88/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 26 May 2016 15:30:26 + Build duration: 6 min 10 sec CHANGE SET Revision

Jenkins-kde-ci: ktexteditor master stable-kf5-qt5 » Linux,gcc - Build # 89 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/ktexteditor%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/89/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 26 May 2016 15:40:37 + Build duration: 7 min 0 sec CHANGE SET Revision

Re: Review Request 127587: [Kate view] Correct override cursor

> On April 8, 2016, 7:29 a.m., Kåre Särs wrote: > > What is it that needs fixing? > > > > I don't have a problem in either case listed. > > Emmanuel Pescosta wrote: > > 3. Context menu is closed > > I can reproduce this problem > > Anthony Fieroni wrote: > Drag file from

Re: Review Request 127122: [Kate] Back/Forward mouse buttons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127122/ --- (Updated May 26, 2016, 4:16 p.m.) Status -- This change has been

Re: Review Request 128019: Remove F1 as standard shortcut for Help

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128019/#review95848 --- While I appreciate the source of this change (I've almost

Jenkins-kde-ci: ktexteditor master kf5-qt5 » Linux,gcc - Build # 99 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/ktexteditor%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/99/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 26 May 2016 15:54:17 + Build duration: 7 min 47 sec CHANGE SET Revision

Re: Review Request 127997: Extend KNS3::Entry public API

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127997/#review95866 --- Sorry I missed the initial review request somehow. This

Jenkins-kde-ci: ktexteditor master stable-kf5-qt5 » Linux,gcc - Build # 90 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/ktexteditor%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/90/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 26 May 2016 15:54:17 + Build duration: 5 min 25 sec CHANGE SET Revision

Jenkins-kde-ci: ktexteditor master kf5-qt5 » Linux,gcc - Build # 99 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/ktexteditor%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/99/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 26 May 2016 15:54:17 + Build duration: 7 min 47 sec CHANGE SET Revision

Re: Review Request 128019: Remove F1 as standard shortcut for Help

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128019/#review95809 --- What function would you like to invoke with F1? Close app?

Re: Review Request 128011: Allow using new style connect syntax with KStandardAction::create()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128011/#review95810 --- Ship it! Thanks, looks good to me now, please push. I'm

Re: Review Request 128011: Allow using new style connect syntax with KStandardAction::create()

> On May 26, 2016, 10:56 a.m., David Faure wrote: > > Thanks, looks good to me now, please push. > > > > I'm just wondering if the "KF6 TODO" is actually feasible... > wondering if the "KF6 TODO" is actually feasible Can't comment on that, it's Alex' code, after all. > Note that this

Re: Review Request 128011: Allow using new style connect syntax with KStandardAction::create()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128011/#review95805 --- src/kstandardaction.h (line 258)

Re: Review Request 128011: Allow using new style connect syntax with KStandardAction::create()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128011/ --- (Updated May 26, 2016, 10:25 a.m.) Review request for KDE Frameworks,

Re: Review Request 127927: Move kcm_ssl kcm docs to subdir docs/kcontrol

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127927/#review95808 --- @dfaure: please don't forget to review this RR 127927 and

Re: Review Request 127903: Update kf5options manpage docbook

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127903/#review95887 --- Please review - Burkhard Lück On Mai 26, 2016, 3:01

Re: Review Request 127906: Remove qt5options manpage docbook

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127906/#review95890 --- If we want to provide a qt5options manpage we need at least

Re: Review Request 128019: Remove F1 as standard shortcut for Help

> On May 26, 2016, 7:49 a.m., Heiko Tietze wrote: > > What function would you like to invoke with F1? Close app? > > Albert Astals Cid wrote: > None, give it back to the apps so they can do whatever it wants with it, > like let's say F2 or F9 It was a rhetorical question. Default keys

Re: Review Request 128019: Remove F1 as standard shortcut for Help

> On May 26, 2016, 3:37 p.m., Matthew Dawson wrote: > > While I appreciate the source of this change (I've almost never hit F1 > > intending to open the doucmentation myself), I don't think a RR is the > > right place to discuss changes to our default shortcuts. This takes a > > small survey

Re: Review Request 128019: Remove F1 as standard shortcut for Help

> On May 26, 2016, 7:49 a.m., Heiko Tietze wrote: > > What function would you like to invoke with F1? Close app? None, give it back to the apps so they can do whatever it wants with it, like let's say F2 or F9 - Albert --- This is an

Re: Review Request 128019: Remove F1 as standard shortcut for Help

> On May 26, 2016, 10:51 a.m., Elvis Angelaccio wrote: > > What if people start complaining? ("Why F1 is not working anymore?!?") > > > > I just tried and the shortcut can be disabled *globally* from system > > settings (or replaced with another shortcut). It's something that you need > > to

Re: Review Request 127870: plasma-framework: AppletInterface::downloadPath()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127870/ --- (Updated May 27, 2016, 1:11 a.m.) Status -- This change has been

Re: Review Request 128019: Remove F1 as standard shortcut for Help

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128019/ --- (Updated May 26, 2016, 10:04 p.m.) Status -- This change has been

Re: Review Request 128019: Remove F1 as standard shortcut for Help

> On May 26, 2016, 3:37 p.m., Matthew Dawson wrote: > > While I appreciate the source of this change (I've almost never hit F1 > > intending to open the doucmentation myself), I don't think a RR is the > > right place to discuss changes to our default shortcuts. This takes a > > small survey

Re: Review Request 128019: Remove F1 as standard shortcut for Help

> On May 25, 2016, 11:25 p.m., Luigi Toscano wrote: > > I disagree, but I fear I will be the only one. When you disagre you have to give a reason ;) Do you really need a "shortcut" to go to help? How often do you use it compared to let's say Ctrl+F, F3, Ctrl+X? - Albert

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,All,gcc - Build # 59 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/59/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Thu, 26 May 2016 23:11:34 + Build duration: 2 min 52 sec CHANGE SET

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,All,gcc - Build # 59 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/59/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Thu, 26 May 2016 23:11:34 + Build duration: 2 min 52 sec CHANGE SET

Re: Review Request 128019: Remove F1 as standard shortcut for Help

> On May 26, 2016, 3:37 p.m., Matthew Dawson wrote: > > While I appreciate the source of this change (I've almost never hit F1 > > intending to open the doucmentation myself), I don't think a RR is the > > right place to discuss changes to our default shortcuts. This takes a > > small survey

Re: Review Request 128019: Remove F1 as standard shortcut for Help

> On May 26, 2016, 11:37 a.m., Matthew Dawson wrote: > > While I appreciate the source of this change (I've almost never hit F1 > > intending to open the doucmentation myself), I don't think a RR is the > > right place to discuss changes to our default shortcuts. This takes a > > small

Re: Review Request 127843: Properly remove composed characters

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127843/#review95827 --- Ok, I think one more revision and we're good to go. Thanks

Re: Review Request 128019: Remove F1 as standard shortcut for Help

> On May 26, 2016, 12:12 a.m., Thomas Pfeiffer wrote: > > As Kai said: Activating the help cursor by pressing F1 (and actually > > putting useful help behind it!) would be a great thing to have from a > > user's perspective. > > Contextual help would be much more helpful than a plain old help

Re: Review Request 127870: plasma-framework: AppletInterface::downloadPath()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127870/#review95815 --- Ship it! ping :) - Sebastian Kügler On May 8, 2016,

Re: Review Request 127843: Properly remove composed characters

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127843/ --- (Updated Kvě. 26, 2016, 10:06 dop.) Review request for Kate, KDE

Review Request 128023: Deprecate authorizeKAction() in favor of authorizeAction()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128023/ --- Review request for KDE Frameworks and Matthew Dawson. Repository:

Re: Review Request 128023: Deprecate authorizeKAction() in favor of authorizeAction()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128023/#review95822 --- -1 While it was errorneously ported to this action all over

Re: Review Request 128023: Deprecate authorizeKAction() in favor of authorizeAction()

> On May 26, 2016, 11:58 a.m., Kai Uwe Broulik wrote: > > -1 > > > > While it was errorneously ported to this action all over the place when it > > should not have been, KXmlGui actions and other menu and toolbar actions > > should still use the action/ prefix. I'm not sure I follow, I'm not

Re: Review Request 128019: Remove F1 as standard shortcut for Help

> On Mai 26, 2016, 12:12 vorm., Thomas Pfeiffer wrote: > > As Kai said: Activating the help cursor by pressing F1 (and actually > > putting useful help behind it!) would be a great thing to have from a > > user's perspective. > > Contextual help would be much more helpful than a plain old help

Re: Review Request 128019: Remove F1 as standard shortcut for Help

> On May 26, 2016, 12:12 a.m., Thomas Pfeiffer wrote: > > As Kai said: Activating the help cursor by pressing F1 (and actually > > putting useful help behind it!) would be a great thing to have from a > > user's perspective. > > Contextual help would be much more helpful than a plain old help

Re: Review Request 128019: Remove F1 as standard shortcut for Help

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128019/#review95818 --- What if people start complaining? ("Why F1 is not working

Re: Review Request 127843: Properly remove composed characters

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127843/#review95832 --- Ship it! Thanks a lot. This now looks good for me (could

Re: Review Request 127843: Properly remove composed characters

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127843/ --- (Updated May 26, 2016, 6:13 p.m.) Status -- This change has been

Re: Review Request 127997: Extend KNS3::Entry public API

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127997/#review95833 --- bump? - Aleix Pol Gonzalez On May 24, 2016, 1:25 p.m.,

Re: Review Request 127843: Properly remove composed characters

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127843/ --- (Updated Kvě. 26, 2016, 1:07 odp.) Review request for Kate, KDE