Re: KF5 repositories in Phabricator/Diffusion

On Thursday, June 16, 2016 7:58:15 PM CEST Ben Cooksley wrote: [...] > Until recently it would have also been slightly difficult to setup > repositories as Phabricator's Conduit API lacked proper support for > setting up repositories (something which was recently added). Hey Ben, only to make

Review Request 128205: Fix crash when a method exposed to Kross returns QVariant with non-relocatable data

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128205/ --- Review request for KDE Frameworks and Friedrich W. H. Kossebau.

Re: Review Request 128150: [libkerfuffle] Ark application exits before job's finished

> On Юни 16, 2016, 11:54 преди обяд, David Faure wrote: > > kerfuffle/jobs.cpp, line 127 > > > > > > The bug is on this line, don't use a direct connection. Yeah, i think so at first time. But remove connection

Re: Review Request 128113: [kuiserverjobtracker] Fix crash when unregister job

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128113/#review96558 --- tests/kjobtrackerstest.cpp (line 173)

Re: KF5 repositories in Phabricator/Diffusion

On Wed, Jun 15, 2016 at 11:33 AM, Alexander Potashev wrote: > Hi, Hi all, > > Albert noticed today that my patches for KF5::Kross on Phabricator > don't refer to any repository. I would be happy to specify it, but I > can't because there are no KF5 repositories set up on

Re: Review Request 128113: [kuiserverjobtracker] Fix crash when unregister job

> On Юни 16, 2016, 11:49 преди обяд, David Faure wrote: > > Looking at https://git.reviewboard.kde.org/r/128150 (to basically read the > > libkerfuffle code), I see what the problem is. > > > > You're mixing KJob and QThread, which is only fine if none of the KJob API > > is called from the

Re: Review Request 126610: kwidgetitemdelegate: properly cleanup widgets on index removal

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126610/#review96491 --- The patch makes sense to me. It's watching for items being

Re: Review Request 128113: [kuiserverjobtracker] Fix crash when unregister job

> On Юни 16, 2016, 10:57 преди обяд, David Faure wrote: > > tests/kjobtrackerstest.cpp, line 173 > > > > > > Is this change supposed to trigger the bug? I added those two connects > > locally (without the rest

Re: KF5 repositories in Phabricator/Diffusion

On Thu, Jun 16, 2016 at 8:20 PM, Andreas Cord-Landwehr wrote: > On Thursday, June 16, 2016 7:58:15 PM CEST Ben Cooksley wrote: > [...] >> Until recently it would have also been slightly difficult to setup >> repositories as Phabricator's Conduit API lacked proper support for

Re: Review Request 128113: [kuiserverjobtracker] Fix crash when unregister job

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128113/#review96567 --- Looking at https://git.reviewboard.kde.org/r/128150 (to

Re: Review Request 128150: [libkerfuffle] Ark application exits before job's finished

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128150/#review96568 --- kerfuffle/jobs.cpp (line 127)

Re: Review Request 128113: [kuiserverjobtracker] Fix crash when unregister job

> On Юни 16, 2016, 10:57 преди обяд, David Faure wrote: > > tests/kjobtrackerstest.cpp, line 173 > > > > > > Is this change supposed to trigger the bug? I added those two connects > > locally (without the rest

Re: Review Request 128113: [kuiserverjobtracker] Fix crash when unregister job

> On June 16, 2016, 8:49 a.m., David Faure wrote: > > Looking at https://git.reviewboard.kde.org/r/128150 (to basically read the > > libkerfuffle code), I see what the problem is. > > > > You're mixing KJob and QThread, which is only fine if none of the KJob API > > is called from the

Re: Review Request 128113: [kuiserverjobtracker] Fix crash when unregister job

> On Юни 16, 2016, 10:57 преди обяд, David Faure wrote: > > tests/kjobtrackerstest.cpp, line 173 > > > > > > Is this change supposed to trigger the bug? I added those two connects > > locally (without the rest

Re: Review Request 128208: [kio] Change to non-deprecated versions of QStyleOption subclasses

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128208/#review96593 --- Ship it! Ship It! - David Faure On June 16, 2016, 1:12

Re: Review Request 128187: Add a program to convert symbolically linked files to qrc aliases

> On June 16, 2016, 1:14 p.m., David Faure wrote: > > CMakeLists.txt, line 49 > > > > > > (it's curious that there isn't a way to get the full path in one go, > > but I don't know generator expressions enough to

Re: Review Request 128113: [kuiserverjobtracker] Fix crash when unregister job

> On June 16, 2016, 7:57 a.m., David Faure wrote: > > tests/kjobtrackerstest.cpp, line 173 > > > > > > Is this change supposed to trigger the bug? I added those two connects > > locally (without the rest of the

Re: Review Request 128191: Let KCapacityBar be usable in Qt Designer

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128191/ --- (Updated June 16, 2016, 1:10 p.m.) Status -- This change has been

Re: Review Request 128113: [kuiserverjobtracker] Fix crash when unregister job

> On June 16, 2016, 7:57 a.m., David Faure wrote: > > tests/kjobtrackerstest.cpp, line 173 > > > > > > Is this change supposed to trigger the bug? I added those two connects > > locally (without the rest of the

Re: Review Request 128187: Add a program to convert symbolically linked files to qrc aliases

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128187/#review96586 --- Given that without this patch, the resource file on Windows

Review Request 128208: [kio] Change to non-deprecated versions of QStyleOption subclasses

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128208/ --- Review request for KDE Frameworks and David Faure. Repository: kio

Adding Android Platform Availability to Frameworks

Hi, after the recent preparations, finally I would like to get permission to add the line " - name: Android" to the platforms section in the metainfo.yaml files of the following frameworks: attica kapidox karchive kcodecs kconfig kcoreaddons kguiaddons ki18n kimageformats kitemmodels kitemviews

Re: Review Request 128207: Move implementation of class MetaFunction methods into a separate .cpp file

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128207/#review96612 --- Ship it! Ship It! - Albert Astals Cid On June 16,

Re: Review Request 128215: Do not use C-style casts into void*

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128215/#review96614 --- Ship it! Ship It! - Albert Astals Cid On June 16,

Review Request 128216: [QueryMatch] Add iconName

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128216/ --- Review request for KDE Frameworks and Plasma. Repository: krunner

[Differential] [Changed Subscribers] D1924: KXMLGui: Fix merge indices when removing xmlgui clients with actions in groups.

dfaure added a subscriber: kde-frameworks-devel. REVISION DETAIL https://phabricator.kde.org/D1924 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: dfaure, svuorela, dhaumann Cc: kde-frameworks-devel ___

Re: Review Request 128205: Fix crash when a method exposed to Kross returns QVariant with non-relocatable data

> On Июнь 17, 2016, 12:42 д.п., Albert Astals Cid wrote: > > How hard is to add a unit test to prove this is needed+so it doesn't break > > again in the future? I've added this Python test case: http://commits.kde.org/kross-interpreters/b5a9d7320d02b5cbaa4cbef25341851849cc9d7a It's possible

Review Request 128219: No longer allow installing to generic data folder because of security hole.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128219/ --- Review request for KDE Frameworks, David Faure and Richard Moore.

Jenkins-kde-ci: ktexteditor master stable-kf5-qt5 » Linux,gcc - Build # 134 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/ktexteditor%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/134/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 16 Jun 2016 23:24:11 + Build duration: 29 min CHANGE SET No changes JUNIT RESULTS

Re: Review Request 128213: Fix HTML documentation generation

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128213/#review96619 --- Regarding the alternative stylesheets, I don't think that's

Re: Review Request 128207: Move implementation of class MetaFunction methods into a separate .cpp file

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128207/ --- (Updated June 17, 2016, 12:27 a.m.) Status -- This change has been

Re: Review Request 128215: Do not use C-style casts into void*

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128215/ --- (Updated June 17, 2016, 12:27 a.m.) Status -- This change has been

Re: Review Request 128216: [QueryMatch] Add iconName

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128216/#review96615 --- Ship it! Ship It! - David Edmundson On June 16, 2016,

Re: Adding Android Platform Availability to Frameworks

On Thursday, June 16, 2016 4:12:14 PM CEST Aleix Pol wrote: > On Thu, Jun 16, 2016 at 3:47 PM, Andreas Cord-Landwehr > > wrote: > > Hi, after the recent preparations, finally I would like to get permission > > to add the line " - name: Android" to the platforms section in

Jenkins-kde-ci: kiconthemes master kf5-qt5 » Linux,gcc - Build # 58 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kiconthemes%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/58/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 16 Jun 2016 14:44:51 + Build duration: 2 min 1 sec CHANGE SET Revision

Jenkins-kde-ci: kiconthemes master stable-kf5-qt5 » Linux,gcc - Build # 57 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kiconthemes%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/57/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 16 Jun 2016 14:44:51 + Build duration: 2 min 2 sec CHANGE SET Revision

Jenkins-kde-ci: kiconthemes master kf5-qt5 » Linux,gcc - Build # 58 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kiconthemes%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/58/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 16 Jun 2016 14:44:51 + Build duration: 2 min 1 sec CHANGE SET Revision

Re: Adding Android Platform Availability to Frameworks

On Thu, Jun 16, 2016 at 3:47 PM, Andreas Cord-Landwehr wrote: > Hi, after the recent preparations, finally I would like to get permission to > add the line " - name: Android" to the platforms section in the metainfo.yaml > files of the following frameworks: > > attica >

Review Request 128210: Enable Threadweaver to build on Android

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128210/ --- Review request for KDE Frameworks. Repository: threadweaver

Re: Review Request 128113: [kuiserverjobtracker] Fix crash when unregister job

> On June 16, 2016, 7:57 a.m., David Faure wrote: > > tests/kjobtrackerstest.cpp, line 173 > > > > > > Is this change supposed to trigger the bug? I added those two connects > > locally (without the rest of the

Re: Review Request 128187: Add a program to convert symbolically linked files to qrc aliases

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128187/#review96587 --- CMakeLists.txt (line 27)

Jenkins-kde-ci: kiconthemes master kf5-qt5 » Linux,gcc - Build # 57 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kiconthemes%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/57/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 16 Jun 2016 08:23:08 + Build duration: 56 sec CHANGE SET Revision

Re: Review Request 128187: Add a program to convert symbolically linked files to qrc aliases

> On June 16, 2016, 1:14 p.m., David Faure wrote: > > main.cpp, line 29 > > > > > > Recursion? Is there a risk of infinite recursion here? Yes there is a risk of recursion if the symbolic links also are. Should

Review Request 128207: Move implementation of class MetaFunction methods into a separate .cpp file

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128207/ --- Review request for KDE Frameworks. Repository: kross Description

Re: Review Request 128187: Add a program to convert symbolically linked files to qrc aliases

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128187/#review96597 --- Ship it! Ship It! - David Faure On June 16, 2016, 3:26

Re: Review Request 128187: Add a program to convert symbolically linked files to qrc aliases

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128187/ --- (Updated June 16, 2016, 4:02 p.m.) Status -- This change has been

Re: Review Request 128187: Add a program to convert symbolically linked files to qrc aliases

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128187/ --- (Updated June 16, 2016, 3:26 p.m.) Review request for KDE Frameworks,

Re: Review Request 128207: Move implementation of class MetaFunction methods into a separate .cpp file

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128207/ --- (Updated Июнь 16, 2016, 6:54 п.п.) Review request for KDE Frameworks.

Re: Review Request 128191: Let KCapacityBar be usable in Qt Designer

> On June 16, 2016, 4:47 p.m., Kåre Särs wrote: > > I'm getting this error on Windows with MSVC 2015 after this commit. > > > > ...etsaddons\src\kcapacitybar.h(234): error C2668: > > 'KCapacityBar::KCapacityBar': ambiguous call to overloaded function > > ...etsaddons\src\kcapacitybar.h(80):

Re: Review Request 128191: Let KCapacityBar be usable in Qt Designer

> On June 16, 2016, 4:47 p.m., Kåre Särs wrote: > > I'm getting this error on Windows with MSVC 2015 after this commit. > > > > ...etsaddons\src\kcapacitybar.h(234): error C2668: > > 'KCapacityBar::KCapacityBar': ambiguous call to overloaded function > > ...etsaddons\src\kcapacitybar.h(80):

Review Request 128213: Fix HTML documentation generation

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128213/ --- Review request for KDE Frameworks and Luigi Toscano. Repository:

Re: Review Request 128191: Let KCapacityBar be usable in Qt Designer

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128191/#review96599 --- I'm getting this error on Windows with MSVC 2015 after this

Re: Review Request 128191: Let KCapacityBar be usable in Qt Designer

> On June 16, 2016, 4:47 p.m., Kåre Särs wrote: > > I'm getting this error on Windows with MSVC 2015 after this commit. > > > > ...etsaddons\src\kcapacitybar.h(234): error C2668: > > 'KCapacityBar::KCapacityBar': ambiguous call to overloaded function > > ...etsaddons\src\kcapacitybar.h(80):

Re: Review Request 128208: [kio] Change to non-deprecated versions of QStyleOption subclasses

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128208/ --- (Updated June 16, 2016, 8:11 p.m.) Status -- This change has been

Re: Review Request 128213: Fix HTML documentation generation

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128213/ --- (Updated June 16, 2016, 4:43 p.m.) Review request for KDE Frameworks and

Re: Review Request 128191: Let KCapacityBar be usable in Qt Designer

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128191/#review96603 --- src/kcapacitybar.h (line 80)

Re: Review Request 128191: Let KCapacityBar be usable in Qt Designer

> On June 16, 2016, 4:52 p.m., David Faure wrote: > > src/kcapacitybar.h, line 80 > > > > > > I didn't see the default value here. This makes new KCapacityBar() > > ambiguous indeed. > > > > The default

Re: Review Request 128192: Remove man pages for scripts that no longer exist

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128192/ --- (Updated June 16, 2016, 5:02 p.m.) Status -- This change has been

Re: Review Request 127004: WIP: OpenFileManagerWindowJob

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127004/ --- (Updated Juni 16, 2016, 7:35 nachm.) Review request for KDE Frameworks,

Review Request 128215: Do not use C-style casts into void*

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128215/ --- Review request for KDE Frameworks. Bugs: 325055

[Differential] [Accepted] D1902: KRun: add runApplication method.

svuorela accepted this revision. svuorela added a reviewer: svuorela. BRANCH master REVISION DETAIL https://phabricator.kde.org/D1902 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: dfaure, hein, broulik, davidedmundson, svuorela Cc: #plasma,

Re: Review Request 128193: Deploy the khtml kxmlgui file in a Qt resource file.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128193/ --- (Updated June 16, 2016, 6:08 a.m.) Review request for KDE Frameworks and

Re: Review Request 128193: Deploy the khtml kxmlgui file in a Qt resource file.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128193/ --- (Updated June 16, 2016, 6:10 a.m.) Status -- This change has been

Re: Review Request 128191: Let KCapacityBar be usable in Qt Designer

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128191/#review96553 --- Ship it! Ship It! - David Faure On June 15, 2016, 5:44

Jenkins-kde-ci: kpty master stable-kf5-qt5 » Linux,gcc - Build # 60 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kpty%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/60/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 16 Jun 2016 07:26:21 + Build duration: 54 sec CHANGE SET Revision 60a7f22e4895bdbc41ba7ddaf0700ed695c4476c

Jenkins-kde-ci: kpty master stable-kf5-qt5 » Linux,gcc - Build # 60 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kpty%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/60/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 16 Jun 2016 07:26:21 + Build duration: 54 sec CHANGE SET Revision 60a7f22e4895bdbc41ba7ddaf0700ed695c4476c

Re: Review Request 128196: Add Android to supported platforms

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128196/ --- (Updated June 16, 2016, 10:30 a.m.) Status -- This change has been