Re: Review Request 129302: Fix include dir in pri file

2016-11-01 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129302/ --- (Updated Nov. 1, 2016, 11:39 a.m.) Status -- This change has been

Re: Review Request 129302: Fix include dir in pri file

2016-11-01 Thread Jan Grulich
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129302/#review100459 --- Ship it! Not only generictypes.h includes NM headers,

Re: Review Request 129298: RFC: supporting dependencies on KPackage

2016-11-01 Thread Dan Leinir Turthra Jensen
> On Oct. 31, 2016, 5:19 p.m., Marco Martin wrote: > > autotests/data/testpackagesdep/metadata.json, line 14 > > > > > > if kns ends up using ids, maybe the server should be specified as well, > > as the id

Review Request 129303: Fix include dir in pri file

2016-11-01 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129303/ --- Review request for KDE Frameworks and Jan Grulich. Repository:

Review Request 129302: Fix include dir in pri file

2016-11-01 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129302/ --- Review request for KDE Frameworks and Jan Grulich. Repository:

Re: Review Request 129302: Fix include dir in pri file

2016-11-01 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129302/ --- (Updated Nov. 1, 2016, 8:24 a.m.) Review request for KDE Frameworks and

Re: Review Request 129303: Fix include dir in pri file

2016-11-01 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129303/ --- (Updated Nov. 1, 2016, 8:38 a.m.) Status -- This change has been

Re: Review Request 129303: Fix include dir in pri file

2016-11-01 Thread Jan Grulich
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129303/#review100460 --- Ship it! Ship It! - Jan Grulich On Lis. 1, 2016, 8:21

Jenkins-kde-ci: oxygen Plasma-5.8 stable-kf5-qt5 » Linux,gcc - Build # 10 - Failure!

2016-11-01 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/oxygen%20Plasma-5.8%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/10/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 01 Nov 2016 11:37:42 + Build duration: 1 min 24 sec CHANGE SET Revision

Re: Review Request 129299: Warn on startup about ambiguous shortcuts (with an exception for Shift+Delete)

2016-11-01 Thread Elvis Angelaccio
> On Oct. 31, 2016, 6:50 p.m., Elvis Angelaccio wrote: > > src/kxmlguiwindow.cpp, line 327 > > > > > > I think it would be better if this were not blocking (i.e. creating the > > QMessageBox manually and

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,NoX11,gcc - Build # 235 - Still Unstable!

2016-11-01 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/235/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Tue, 01 Nov 2016 10:06:05 + Build duration: 5 min 28 sec CHANGE

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 235 - Unstable!

2016-11-01 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/235/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Tue, 01 Nov 2016 10:06:05 + Build duration: 5 min 25 sec CHANGE SET Revision

Re: Review Request 129122: Try to use ulog-helper if utempter does not exist

2016-11-01 Thread Tobias Berner
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129122/ --- (Updated Nov. 1, 2016, 9:42 a.m.) Status -- This change has been

Re: Review Request 129298: RFC: supporting dependencies on KPackage

2016-11-01 Thread Marco Martin
> On Oct. 31, 2016, 5:19 p.m., Marco Martin wrote: > > autotests/data/testpackagesdep/metadata.json, line 14 > > > > > > if kns ends up using ids, maybe the server should be specified as well, > > as the id

Re: Review Request 129298: RFC: supporting dependencies on KPackage

2016-11-01 Thread Dan Leinir Turthra Jensen
> On Oct. 31, 2016, 5:19 p.m., Marco Martin wrote: > > autotests/data/testpackagesdep/metadata.json, line 14 > > > > > > if kns ends up using ids, maybe the server should be specified as well, > > as the id

Jenkins-kde-ci: oxygen Plasma-5.8 stable-kf5-qt5 » Linux,gcc - Build # 11 - Still Failing!

2016-11-01 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/oxygen%20Plasma-5.8%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/11/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 01 Nov 2016 17:28:27 + Build duration: 45 sec CHANGE SET No changes

Re: Review Request 129299: Warn on startup about ambiguous shortcuts (with an exception for Shift+Delete)

2016-11-01 Thread Aleix Pol Gonzalez
> On Nov. 1, 2016, 2:35 a.m., Aleix Pol Gonzalez wrote: > > How about putting it in QDebug? > > Message boxes could make us all miserable. > > Albert Astals Cid wrote: > Making us miserable is the point, that way you'll fix it, a qdebug is > something noone will even see. (Note this should

Re: Review Request 129299: Warn on startup about ambiguous shortcuts (with an exception for Shift+Delete)

2016-11-01 Thread Albert Astals Cid
> On Nov. 1, 2016, 1:35 a.m., Aleix Pol Gonzalez wrote: > > How about putting it in QDebug? > > Message boxes could make us all miserable. > > Albert Astals Cid wrote: > Making us miserable is the point, that way you'll fix it, a qdebug is > something noone will even see. (Note this should

Re: Review Request 129170: Add KArchive::errorString() method to provide more details on KArchive errors

2016-11-01 Thread Romário Rios
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129170/ --- (Updated Nov. 1, 2016, 8:10 p.m.) Review request for KDE Frameworks.

Re: Review Request 129170: Add KArchive::errorString() method to provide more details on KArchive errors

2016-11-01 Thread Romário Rios
> On Oct. 30, 2016, 10:59 p.m., David Faure wrote: > > src/k7zip.cpp, line 2499 > > > > > > Translators (and users) won't know what CTime is, but oh well, not many > > people know anyway ;) I'm not sure what

Re: Review Request 129170: Add KArchive::errorString() method to provide more details on KArchive errors

2016-11-01 Thread David Faure
> On Oct. 30, 2016, 10:59 p.m., David Faure wrote: > > src/k7zip.cpp, line 2499 > > > > > > Translators (and users) won't know what CTime is, but oh well, not many > > people know anyway ;) > > Romário Rios

Jenkins-kde-ci: knotifyconfig master kf5-qt5 » Linux,gcc - Build # 248 - Fixed!

2016-11-01 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/knotifyconfig%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/248/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 01 Nov 2016 17:54:02 + Build duration: 1 min 35 sec CHANGE SET No changes JUNIT RESULTS

Jenkins-kde-ci: knotifyconfig master kf5-qt5 » Linux,gcc - Build # 248 - Fixed!

2016-11-01 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/knotifyconfig%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/248/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 01 Nov 2016 17:54:02 + Build duration: 1 min 35 sec CHANGE SET No changes JUNIT RESULTS