Re: Review Request 129396: Allow to read X-KDE-RunOnDiscreteGpu property from desktop file + take this option into account when starting service using KToolInvocation

> On Lis. 14, 2016, 10:32 odp., David Faure wrote: > > src/kdeinit/ktoolinvocation.cpp, line 107 > > > > > > Err that's a weird D-Bus name, isn't it? Should this become a > > freedesktop standard? > > Did

Re: Review Request 129405: KCollapsibleGroupBox: don't hide widgets, override focus policy instead

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129405/#review100850 --- Picture, or it didn't happen :-) (before/after would be

Re: Review Request 129405: KCollapsibleGroupBox: don't hide widgets, override focus policy instead

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129405/ --- (Updated Nov. 15, 2016, 9:53 a.m.) Review request for KDE Frameworks,

python binding's __init__.py

Alohas I am currently trying to package kitemmodels' python bindings. The module generator installs -./usr/lib/python2.7/dist-packages/PyKF5/__init__.py -./usr/lib/python2.7/dist-packages/PyKF5/KItemModels.so This will cause a fairly shitty problem on packaging level, when a second framework

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 270 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/270/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 15 Nov 2016 15:08:43 + Build duration: 5 min 12 sec CHANGE SET Revision 5618af6c7267877672246a6600f69af974d84bf7

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 270 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/270/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 15 Nov 2016 15:08:43 + Build duration: 5 min 12 sec CHANGE SET Revision 5618af6c7267877672246a6600f69af974d84bf7

Jenkins-kde-ci: kwindowsystem master kf5-qt5 » Linux,All,gcc - Build # 88 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kwindowsystem%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/88/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Tue, 15 Nov 2016 16:31:20 + Build duration: 1 min 47 sec CHANGE SET Revision

Jenkins-kde-ci: kwindowsystem master kf5-qt5 » Linux,All,gcc - Build # 88 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kwindowsystem%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/88/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Tue, 15 Nov 2016 16:31:20 + Build duration: 1 min 47 sec CHANGE SET Revision

Re: Review Request 129394: [filenamesearch] Fix huge ram usage in kded module

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129394/#review100862 --- This fix makes sense to me (well, I suggested it) ;) As to

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 142 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/142/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 15 Nov 2016 14:09:58 + Build duration: 4 min 33 sec CHANGE SET Revision

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 142 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/142/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 15 Nov 2016 14:09:58 + Build duration: 4 min 33 sec CHANGE SET Revision

Jenkins-kde-ci: kpty master kf5-qt5 » Linux,gcc - Build # 131 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kpty%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/131/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 15 Nov 2016 14:32:17 + Build duration: 1 min 37 sec CHANGE SET No changes JUNIT RESULTS Name: (root)

Jenkins-kde-ci: kpty master kf5-qt5 » Linux,gcc - Build # 131 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kpty%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/131/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 15 Nov 2016 14:32:17 + Build duration: 1 min 37 sec CHANGE SET No changes JUNIT RESULTS Name: (root)

Jenkins-kde-ci: kxmlgui master kf5-qt5 » Linux,gcc - Build # 100 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kxmlgui%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/100/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 15 Nov 2016 14:25:35 + Build duration: 58 sec CHANGE SET Revision 12510986bf58b074bc23394ee4bec0f0c4187fcc by

Jenkins-kde-ci: kxmlgui master kf5-qt5 » Linux,gcc - Build # 101 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kxmlgui%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/101/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 15 Nov 2016 15:08:43 + Build duration: 1 min 36 sec CHANGE SET No changes JUNIT RESULTS Name:

Re: Review Request 129397: Set environment variables from KLaunchRequest when starting new process

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129397/#review100861 --- src/klauncher/klauncher.cpp (line 558)

Jenkins-kde-ci: khtml master stable-kf5-qt5 » Linux,gcc - Build # 117 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/khtml%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/117/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 15 Nov 2016 14:32:27 + Build duration: 18 min CHANGE SET Revision

Re: Review Request 129405: KCollapsibleGroupBox: don't hide widgets, override focus policy instead

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129405/ --- (Updated Nov. 15, 2016, 4:27 p.m.) Status -- This change has been

Jenkins-kde-ci: kpty master kf5-qt5 » Linux,gcc - Build # 130 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kpty%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/130/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 15 Nov 2016 14:09:58 + Build duration: 1 min 31 sec CHANGE SET Revision

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 273 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/273/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 15 Nov 2016 14:18:21 + Build duration: 5 min 43 sec CHANGE SET Revision

Jenkins-kde-ci: kglobalaccel master stable-kf5-qt5 » Linux,gcc - Build # 137 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kglobalaccel%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/137/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 15 Nov 2016 14:23:21 + Build duration: 2 min 35 sec CHANGE SET No changes JUNIT RESULTS

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 273 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/273/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 15 Nov 2016 14:18:21 + Build duration: 5 min 43 sec CHANGE SET Revision

Jenkins-kde-ci: kcompletion master kf5-qt5 » Linux,gcc - Build # 103 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kcompletion%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/103/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 15 Nov 2016 14:26:31 + Build duration: 3 min 54 sec CHANGE SET No changes JUNIT RESULTS Name:

Jenkins-kde-ci: kcompletion master kf5-qt5 » Linux,gcc - Build # 103 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kcompletion%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/103/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 15 Nov 2016 14:26:31 + Build duration: 3 min 54 sec CHANGE SET No changes JUNIT RESULTS Name:

Jenkins-kde-ci: kxmlgui master kf5-qt5 » Linux,gcc - Build # 101 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kxmlgui%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/101/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 15 Nov 2016 15:08:43 + Build duration: 1 min 36 sec CHANGE SET No changes JUNIT RESULTS Name:

Re: python binding's __init__.py

Harald Sitter wrote: > Alohas > > I am currently trying to package kitemmodels' python bindings. The > module generator installs > > -./usr/lib/python2.7/dist-packages/PyKF5/__init__.py > -./usr/lib/python2.7/dist-packages/PyKF5/KItemModels.so > > This will cause a fairly shitty problem on

Jenkins-kde-ci: kglobalaccel master stable-kf5-qt5 » Linux,gcc - Build # 137 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kglobalaccel%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/137/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 15 Nov 2016 14:23:21 + Build duration: 2 min 35 sec CHANGE SET No changes JUNIT RESULTS

Jenkins-kde-ci: kwindowsystem master kf5-qt5 » Linux,All,gcc - Build # 87 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kwindowsystem%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/87/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Tue, 15 Nov 2016 14:12:32 + Build duration: 7 min 44 sec CHANGE SET Revision

Jenkins-kde-ci: kauth master stable-kf5-qt5 » Linux,gcc - Build # 135 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kauth%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/135/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 15 Nov 2016 14:23:21 + Build duration: 2 min 31 sec CHANGE SET No changes JUNIT RESULTS Name:

Jenkins-kde-ci: khtml master kf5-qt5 » Linux,gcc - Build # 117 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/khtml%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/117/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 15 Nov 2016 14:21:06 + Build duration: 16 min CHANGE SET Revision dcc1355cc5c0656b61ecc591b8dd6ebdd0cfb098 by

Jenkins-kde-ci: khtml master stable-kf5-qt5 » Linux,gcc - Build # 118 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/khtml%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/118/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 15 Nov 2016 15:33:51 + Build duration: 6 min 30 sec CHANGE SET No changes JUNIT RESULTS Name:

Jenkins-kde-ci: khtml master stable-kf5-qt5 » Linux,gcc - Build # 118 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/khtml%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/118/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 15 Nov 2016 15:33:51 + Build duration: 6 min 30 sec CHANGE SET No changes JUNIT RESULTS Name:

Jenkins-kde-ci: khtml master kf5-qt5 » Linux,gcc - Build # 118 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/khtml%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/118/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 15 Nov 2016 15:16:13 + Build duration: 21 min CHANGE SET No changes JUNIT RESULTS Name: (root)

Jenkins-kde-ci: khtml master kf5-qt5 » Linux,gcc - Build # 118 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/khtml%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/118/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 15 Nov 2016 15:16:13 + Build duration: 21 min CHANGE SET No changes JUNIT RESULTS Name: (root)

Re: Review Request 129397: Set environment variables from KLaunchRequest when starting new process

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129397/ --- (Updated Lis. 16, 2016, 7:32 dop.) Review request for KDE Frameworks,

Re: Review Request 129405: KCollapsibleGroupBox: don't hide widgets, override focus policy instead

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129405/#review100856 --- Ship it! Looks good from the usability POV, hidden items

Re: Review Request 129405: KCollapsibleGroupBox: don't hide widgets, override focus policy instead

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129405/ --- (Updated Nov. 15, 2016, 11:06 a.m.) Review request for KDE Frameworks,

Re: Review Request 129396: Allow to read X-KDE-RunOnDiscreteGpu property from desktop file + take this option into account when starting service using KToolInvocation

> On Lis. 14, 2016, 10:32 odp., David Faure wrote: > > src/kdeinit/ktoolinvocation.cpp, line 107 > > > > > > Err that's a weird D-Bus name, isn't it? Should this become a > > freedesktop standard? > > Did

Jenkins-kde-ci: kglobalaccel master stable-kf5-qt5 » Linux,gcc - Build # 136 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kglobalaccel%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/136/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 15 Nov 2016 14:00:59 + Build duration: 1 min 24 sec CHANGE SET Revision

Jenkins-kde-ci: kcompletion master kf5-qt5 » Linux,gcc - Build # 102 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kcompletion%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/102/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 15 Nov 2016 14:03:48 + Build duration: 1 min 18 sec CHANGE SET Revision

Jenkins-kde-ci: kauth master stable-kf5-qt5 » Linux,gcc - Build # 134 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kauth%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/134/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 15 Nov 2016 14:00:59 + Build duration: 56 sec CHANGE SET Revision

Re: Review Request 129405: KCollapsibleGroupBox: don't hide widgets, override focus policy instead

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129405/#review100839 --- Fix it, then Ship it! src/kcollapsiblegroupbox.cpp

Re: Review Request 129400: Avoid potential access of .last() on empty list

> On Nov. 14, 2016, 1:40 p.m., Aleix Pol Gonzalez wrote: > > src/kpackagetool/kpackagetool.cpp, line 502 > > > > > > Then just change to `QStandardPath::locate`? Sounds sensible to me. Though I don't really

Re: Review Request 129400: Avoid potential access of .last() on empty list

> On Nov. 14, 2016, 1:40 p.m., Aleix Pol Gonzalez wrote: > > src/kpackagetool/kpackagetool.cpp, line 502 > > > > > > Then just change to `QStandardPath::locate`? > > David Edmundson wrote: > Sounds sensible

Re: Review Request 129400: Avoid potential access of .last() on empty list

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129400/#review100858 --- Fix it, then Ship it! other than that, ship it

Jenkins-kde-ci: kwindowsystem master kf5-qt5 » Linux,All,gcc - Build # 86 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kwindowsystem%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/86/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Tue, 15 Nov 2016 13:42:43 + Build duration: 2 min 4 sec CHANGE SET No changes

Re: Review Request 129341: [kwallet] boost::shared_ptr -> std::shared_ptr

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129341/ --- (Updated Nov. 15, 2016, 8:54 p.m.) Review request for KDE Frameworks.