ngraham updated this revision to Diff 21064.
ngraham added a comment.
Rebase against master
REPOSITORY
R320 KIO Extras
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8352?vs=21059=21064
BRANCH
arcpatch-D8352
REVISION DETAIL
https://phabricator.kde.org/D8352
AFFECTED FILES
madcatx updated this revision to Diff 21049.
madcatx added a comment.
- Check against a range of affected versions
- Small stylistic changes
REPOSITORY
R320 KIO Extras
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8387?vs=21044=21049
REVISION DETAIL
elvisangelaccio added a comment.
The alternative is to wrap the change with
#if KIO_VERSION >= QT_VERSION_CHECK(5, 27, 0)
without bumping the minumum version in cmake.
REPOSITORY
R320 KIO Extras
REVISION DETAIL
https://phabricator.kde.org/D8352
To: ngraham, #frameworks,
ngraham updated this revision to Diff 21059.
ngraham added a comment.
If we don't have KDE Frameworks 5.40 yet, emulate the behavior of the
KIO::PreviewJob::defaultPlugins() API that we would otherwise want to use
REPOSITORY
R320 KIO Extras
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit R320:8b6c4e393bb0: Use KIO::PreviewJob::defaultPlugins()
(authored by ngraham).
REPOSITORY
R320 KIO Extras
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8352?vs=21064=21066
REVISION DETAIL
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.
Looks great to me. Can you mark the inline comments as Done?
REPOSITORY
R320 KIO Extras
REVISION DETAIL
https://phabricator.kde.org/D8387
To: madcatx, ngraham, davidedmundson,
madcatx marked 10 inline comments as done.
REPOSITORY
R320 KIO Extras
REVISION DETAIL
https://phabricator.kde.org/D8387
To: madcatx, ngraham, davidedmundson, elvisangelaccio, #frameworks
Cc: rdieter, graesslin, z3ntu
ngraham added a comment.
Do you have commit access? If not, I'll be happy to commit this once some
more of the folks who have made comments have also signed off on a final
version.
REPOSITORY
R320 KIO Extras
REVISION DETAIL
https://phabricator.kde.org/D8387
To: madcatx, ngraham,
elvisangelaccio added inline comments.
INLINE COMMENTS
> apol wrote in kjobtrackerinterface.h:73
> Then it should be protected?
Probably yes, should we add a TODO comment for KF6?
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
https://phabricator.kde.org/D8336
To: elvisangelaccio, kossebau,
ngraham added a comment.
Hmm, I hadn't thought about that. 5.40 isn't released yet, so if I change
`set(KF5_MIN_VERSION "5.3.0")` in the CMake file, it seems that this would fail
to build until 5.40 is released.
Should I back this out and re-commit after KF5.40 drops?
Or here's an
madcatx added a comment.
In https://phabricator.kde.org/D8387#157778, @ngraham wrote:
> Do you have commit access? If not, I'll be happy to commit this once some
more of the folks who have made comments have also signed off on a final
version.
No I don't. elvisangelaccio already
elvisangelaccio accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R320 KIO Extras
BRANCH
arcpatch-D8352
REVISION DETAIL
https://phabricator.kde.org/D8352
To: ngraham, #frameworks, broulik, elvisangelaccio, markg
madcatx updated this revision to Diff 21040.
madcatx edited the summary of this revision.
madcatx added a comment.
Detect versions of libsmbclient libraries that are considered broken and
apply the workaround only for those.
CHANGES SINCE LAST UPDATE
madcatx updated this revision to Diff 21044.
madcatx added a comment.
Tabs/spaces issue
REPOSITORY
R320 KIO Extras
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8387?vs=21040=21044
REVISION DETAIL
https://phabricator.kde.org/D8387
AFFECTED FILES
smb/kio_smb.cpp
elvisangelaccio added inline comments.
INLINE COMMENTS
> kio_smb.cpp:67
> SMBSlave::SMBSlave(const QByteArray& pool, const QByteArray& app)
> -: SlaveBase( "smb", pool, app ), m_openFd(-1)
> +: SlaveBase( "smb", pool, app ), m_openFd(-1),
> +
madcatx added inline comments.
INLINE COMMENTS
> elvisangelaccio wrote in kio_smb.cpp:67
> While at it, I'd move `m_openFd` on its own line
It kind of violates my "change only as much as is needed" but the whole kio-smb
source could probably use thorough reformatting anyway. Will do.
>
madcatx added a comment.
In https://phabricator.kde.org/D8387#157502, @ngraham wrote:
> So am I correct that this patch does the following:
>
> - If you go to a real password-protected samba server, without this patch
you are totally screwed; with it, you are correctly offered a
elvisangelaccio added inline comments.
INLINE COMMENTS
> madcatx wrote in kio_smb_browse.cpp:521
> Well, this method actually applies the workaround. The
> `m_enableEEXISTWorkaround` is set to true when the an affected libsmbclient
> library is detected.
Don't we set
elvisangelaccio added inline comments.
INLINE COMMENTS
> madcatx wrote in kio_smb_browse.cpp:521
> Yes. The idea is this: When the slave loads, it checks what libsmbclient lib
> is available and sets the `m_enableEEXISTWorkaround` if a broken version is
> detected. Then iff the return code
graesslin created this revision.
graesslin added reviewers: Frameworks, KWin, Plasma on Wayland.
Restricted Application added a subscriber: plasma-devel.
Restricted Application added projects: Plasma on Wayland, Frameworks.
REVISION SUMMARY
This protocol allows to indicate that a wl_surface
graesslin added inline comments.
INLINE COMMENTS
> kio_smb.cpp:50-60
> +static const QVector brokenVersions{ "4.7.0" };
> +
> +const QString currentVerString = QString::fromLatin1(smbc_version());
> +qCDebug(KIO_SMB) << "Using libsmbclient library version" <<
> currentVerString;
> +
elvisangelaccio reopened this revision.
elvisangelaccio added a comment.
This revision is now accepted and ready to land.
We cannot use new API without bumping the minimum KF5 version (currently 5.3,
we need 5.40...)
REPOSITORY
R320 KIO Extras
REVISION DETAIL
elvisangelaccio requested changes to this revision.
This revision now requires changes to proceed.
REPOSITORY
R320 KIO Extras
REVISION DETAIL
https://phabricator.kde.org/D8352
To: ngraham, #frameworks, broulik, elvisangelaccio, markg
graesslin added a comment.
Could you check which libsmbclient version is used and order the change?
REPOSITORY
R320 KIO Extras
REVISION DETAIL
https://phabricator.kde.org/D8387
To: madcatx, ngraham, davidedmundson, elvisangelaccio, #frameworks
Cc: graesslin, z3ntu
madcatx added inline comments.
INLINE COMMENTS
> elvisangelaccio wrote in kio_smb_browse.cpp:521
> Don't we set `m_enableEEXISTWorkaround` in the constructor?
Yes. The idea is this: When the slave loads, it checks what libsmbclient lib is
available and sets the `m_enableEEXISTWorkaround` if a
mkoller created this revision.
mkoller added a reviewer: mlaurent.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
This fixes URL detection for cases where one url with enclosing brackets
follows one without,
which
ngraham added a comment.
Will do.
Any remaining objections from anyone else?
REPOSITORY
R320 KIO Extras
REVISION DETAIL
https://phabricator.kde.org/D8387
To: madcatx, ngraham, davidedmundson, elvisangelaccio, #frameworks
Cc: rdieter, graesslin, z3ntu
Martchus created this revision.
Martchus added a reviewer: Plasma.
Martchus added a project: Plasma.
Restricted Application added subscribers: Frameworks, plasma-devel.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
Required for 'Allow setting "domain-suffix-match" in
Martchus edited the test plan for this revision.
REPOSITORY
R282 NetworkManagerQt
REVISION DETAIL
https://phabricator.kde.org/D8402
To: Martchus, #plasma
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, mart
Martchus added a dependency: D8405: Allow to set "domain-suffix-match" in Wi-Fi
settings.
REPOSITORY
R282 NetworkManagerQt
REVISION DETAIL
https://phabricator.kde.org/D8402
To: Martchus, #plasma
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg,
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20FreeBSDQt5.7/50/
Project:
Frameworks kdelibs4support kf5-qt5 FreeBSDQt5.7
Date of build:
Sun, 22 Oct 2017 02:38:48 +
Build duration:
6 min 58 sec and counting
31 matches
Mail list logo
