D9182: return nullptr -> return {} for QFlags

kossebau added a comment. Code change looks good to me. Think I missed that in my clean-up commits to @kfunk 's initial commit as I only compiled the library parts of KDE Frameworks, not the plugin modules. No maintainer of this module though, so just a +1 for now. Commit message

D9169: port to Package::fileUrl

This revision was automatically updated to reflect the committed changes. Closed by commit R242:84104aa463b1: port to Package::fileUrl (authored by mart). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9169?vs=23430=23464 REVISION DETAIL

D9124: make packageurlinterceptor as noop as possible

This revision was automatically updated to reflect the committed changes. Closed by commit R242:d0cbef14cbdd: make packageurlinterceptor as noop as possible (authored by mart). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

KDE CI: Frameworks kpackage kf5-qt5 SUSEQt5.7 - Build # 4 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20SUSEQt5.7/4/ Project: Frameworks kpackage kf5-qt5 SUSEQt5.7 Date of build: Mon, 04 Dec 2017 17:51:36 + Build duration: 5 min 30 sec and counting JUnit Tests

D9186: Remove unused contexts and itemDatas

dhaumann created this revision. dhaumann added a reviewer: vkrause. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Some contexts are commented out since they are used in commented out rules. Besides that, contexts

D9188: Highlighting Indexer: Check for empty context names and regexps

dhaumann created this revision. dhaumann added a reviewer: vkrause. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Warn about empty contexts of the form context="". Warn about empty RegExps String="". And fix the

D9124: make packageurlinterceptor as noop as possible

davidedmundson reopened this revision. davidedmundson added a comment. Was pushed in a branch, not master. Reopening on phab REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D9124 To: mart, #plasma Cc: davidedmundson, ngraham, apol, plasma-devel,

KDE CI: Frameworks kpackage kf5-qt5 SUSEQt5.10 - Build # 4 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20SUSEQt5.10/4/ Project: Frameworks kpackage kf5-qt5 SUSEQt5.10 Date of build: Mon, 04 Dec 2017 17:51:36 + Build duration: 1 min 21 sec and counting JUnit Tests

KDE CI: Frameworks kpackage kf5-qt5 FreeBSDQt5.7 - Build # 41 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20FreeBSDQt5.7/41/ Project: Frameworks kpackage kf5-qt5 FreeBSDQt5.7 Date of build: Mon, 04 Dec 2017 17:51:36 + Build duration: 51 sec and counting JUnit Tests

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 18 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/18/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 Date of build: Mon, 04 Dec 2017 17:36:11 + Build duration: 14 min and counting JUnit

D8728: Install mimetype definitions for kcfg/kcfgc/ui.rc/knotify & qrc files

kossebau added a subscriber: ltoscano. kossebau added a comment. In https://phabricator.kde.org/D8728#174635, @dfaure wrote: > I agree that those are really KF5 specific and developer-oriented, so rather unlikely to be e.g. sent by email to other people. Okay, so for now not

D9186: Remove unused contexts and itemDatas

vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R216 Syntax Highlighting BRANCH RemoveUnusedContextsAndItemDatas (branched from master) REVISION DETAIL https://phabricator.kde.org/D9186 To: dhaumann, vkrause Cc: #frameworks

D9182: return nullptr -> return {} for QFlags

mkoller created this revision. mkoller added reviewers: kfunk, kossebau. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Change the irritating nullptr return value to {} for the QImageIOPlugin::Capabilities QFlags

D9118: ki18n cmake macros: Mark UIC-generated .h files to skip AUTOMOC by default

This revision was automatically updated to reflect the committed changes. Closed by commit R249:6e3b70843566: cmake: Mark UIC-generated .h files to skip AUTOMOC by default. (authored by mpyne). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D9118?vs=23312=23478#toc REPOSITORY R249

D9190: TransferJob: workaround for when the readChannelFinished has already been emitted

aacid created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY This fixes a regression by the removal of the busy loop call from https://phabricator.kde.org/R241:bcdbe62660a9ca91b0d15f3a9a06a758ec8fdcda

D9189: Do not crash when completion object gets destroyed underneath us

mwolff added a subscriber: dfaure. mwolff added a comment. This makes KMail's Open With feature work again, but I wonder - is anyone capable of running valgrind? Or figure out where the deletion comes from? @dfaure? REPOSITORY R284 KCompletion REVISION DETAIL

D9189: Do not crash when completion object gets destroyed underneath us

mwolff created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY For some reason the 'Open With' dialog opened by KMail triggers the following crash for me: #0 0x68ea4220 in ?? () #1

D9189: Do not crash when completion object gets destroyed underneath us

mwolff edited the summary of this revision. REPOSITORY R284 KCompletion REVISION DETAIL https://phabricator.kde.org/D9189 To: mwolff Cc: dfaure, #frameworks

D9190: TransferJob: workaround for when the readChannelFinished has already been emitted

aacid added reviewers: dfaure, apol, albertvaka. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9190 To: aacid, dfaure, apol, albertvaka Cc: #frameworks

KDE CI: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.7 - Build # 74 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.7/74/ Project: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.7 Date of build: Tue, 05 Dec 2017 02:09:06 + Build duration: 6 min 26 sec and counting JUnit

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 - Build # 14 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.10/14/ Project: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 Date of build: Tue, 05 Dec 2017 02:09:06 + Build duration: 6 min 50 sec and counting JUnit Tests

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.7 - Build # 12 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.7/12/ Project: Frameworks kcoreaddons kf5-qt5 SUSEQt5.7 Date of build: Tue, 05 Dec 2017 02:09:06 + Build duration: 4 min 32 sec and counting JUnit Tests

D9166: Remove double lookups

This revision was automatically updated to reflect the committed changes. Closed by commit R301:e87e2dd27dd9: Remove double lookups (authored by mlaurent). REPOSITORY R301 KEmoticons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9166?vs=23419=23448 REVISION DETAIL

D9119: Initialize scale factor to the last scale factor set on any instance

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D9119 To: hein, #plasma, davidedmundson, broulik, mart Cc: graesslin, plasma-devel, #frameworks, ZrenBot, progwolff,

D9119: Initialize scale factor to the last scale factor set on any instance

This revision was automatically updated to reflect the committed changes. Closed by commit R242:f75816a33a32: Initialize scale factor to the last scale factor set on any instance (authored by hein). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

Re: Failing KTextEditor unit tests

On Tue, Dec 5, 2017 at 5:32 AM, Dominik Haumann wrote: > Hi frameworks-devs, Hi Dominik, > > since some time we have several unit tests that fail in the > KTextEditor framework: > https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20SUSEQt5.10/11/testReport/ > > It

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.7 - Build # 22 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.7/22/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.7 Date of build: Mon, 04 Dec 2017 17:36:11 + Build duration: 7 min 24 sec and counting

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.7 - Build # 164 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.7/164/ Project: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.7 Date of build: Mon, 04 Dec 2017 17:36:11 + Build duration: 8 min 47 sec and counting

D9118: ki18n cmake macros: Mark UIC-generated .h files to skip AUTOMOC by default

kfunk accepted this revision. kfunk added a comment. This revision is now accepted and ready to land. This shouldn't create any troubles with earlier CMake versions. Also note that we set the same properties unconditionally in newer Qt5 CMake macros:

D9015: Refactoring the hidding/showing animation use within KFilePlacesView

franckarrecot updated this revision to Diff 23411. franckarrecot added a comment. rebase to master REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9015?vs=23072=23411 REVISION DETAIL https://phabricator.kde.org/D9015 AFFECTED FILES

D8367: Hidding place groups implementation in KFilePlacesModel

franckarrecot updated this revision to Diff 23409. franckarrecot added a comment. rebase to master REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8367?vs=23024=23409 REVISION DETAIL https://phabricator.kde.org/D8367 AFFECTED FILES

D8450: User can now hide an entire places group from KFilePlacesView

franckarrecot updated this revision to Diff 23410. franckarrecot added a comment. rebase to master REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8450?vs=23025=23410 REVISION DETAIL https://phabricator.kde.org/D8450 AFFECTED FILES

D9162: KI18n: fix a number of double lookups

dfaure closed this revision. REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D9162 To: dfaure, ilic Cc: #frameworks

D9126: [RTL] - align properly the selected text for RTL

broulik added a comment. I don't understand. Isn't this the default and doesn't it automatically mirror it (`effectiveHorizontalAlignment`)? (I'd be fine with this one liner going in but I'm wondering why it would be needed in the first place) REPOSITORY R242 Plasma Framework (Library)

D9156: Fix a memory leak in KuitStaticData

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R249 KI18n BRANCH master REVISION DETAIL https://phabricator.kde.org/D9156 To: jtamate, #frameworks, dfaure

D9162: KI18n: fix a number of double lookups

ilic accepted this revision. This revision is now accepted and ready to land. REPOSITORY R249 KI18n BRANCH master REVISION DETAIL https://phabricator.kde.org/D9162 To: dfaure, ilic Cc: #frameworks

D8689: Fix the result of KDesktopFile::sortOrder()

volkov added a comment. Well, at first I was planning to use this method in my project, but since it's not used in KDE and besides the SortOrder key is deprecated, I guess that KDesktopFile::sortOrder() should be marked as deprecated. The question is whether to fix it first?

D9162: KI18n: fix a number of double lookups

dfaure created this revision. dfaure added a reviewer: ilic. Restricted Application added a project: Frameworks. REVISION SUMMARY contains()+value() is slower than just value() TEST PLAN Unittests still pass REPOSITORY R249 KI18n BRANCH master REVISION DETAIL

D9157: Add API documentation about Search Paths

vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R216 Syntax Highlighting BRANCH SearchPathsDocs (branched from master) REVISION DETAIL https://phabricator.kde.org/D9157 To: dhaumann, vkrause, cullmann Cc: #frameworks

Re: kcrash, fork, and stdout/stderr

On lundi 4 décembre 2017 05:43:14 CET Thiago Macieira wrote: > > Yes, no kdeinit involved. Here's the setup: > > > > $ bin/kcrashtest testAutoRestartDirectly > > > > starts test_crasher (with QProcess, using waitForFinished()) > > > > which crashes :) > > KCrash

D3987: Use nullptr in all Frameworks (just diff in KIO shown here)

kfunk added a comment. In https://phabricator.kde.org/D3987#174960, @mkoller wrote: > I just found out that this change introduced wrong replacements. It did not, the changes are correct, though they're probably not what everyone expects. Please read through the comments in

D9141: Setup QQmlEngine only once in QmlObject

broulik added inline comments. INLINE COMMENTS > mart wrote in qmlobject.h:72 > what about a different ctor which does that, but without exposing that enum? What signature should I use for the constructor? REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D9141 To:

D9126: [RTL] - align properly the selected text for RTL

mvourlakos added a comment. without that line there is the following problem: if in the combobox list there are also LTR items then when these items are selected they are aligned to the left and when the RTL items are selected they are aligned to the right. By adding that line the

D9157: Add API documentation about Search Paths

This revision was automatically updated to reflect the committed changes. Closed by commit R216:c59eedfa9087: Add API documentation about Search Paths (authored by dhaumann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9157?vs=23401=23415

KDE CI: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7 - Build # 108 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20FreeBSDQt5.7/108/ Project: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7 Date of build: Mon, 04 Dec 2017 11:42:39 + Build duration: 34 min and counting JUnit Tests

D9166: Remove double lookups

mlaurent added a reviewer: dfaure. REPOSITORY R301 KEmoticons REVISION DETAIL https://phabricator.kde.org/D9166 To: mlaurent, dfaure Cc: #frameworks

KDE CI: Frameworks ktexteditor kf5-qt5 SUSEQt5.7 - Build # 9 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20SUSEQt5.7/9/ Project: Frameworks ktexteditor kf5-qt5 SUSEQt5.7 Date of build: Mon, 04 Dec 2017 11:42:39 + Build duration: 24 min and counting JUnit Tests

KDE CI: Frameworks ktexteditor kf5-qt5 SUSEQt5.7 - Build # 11 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20SUSEQt5.7/11/ Project: Frameworks ktexteditor kf5-qt5 SUSEQt5.7 Date of build: Mon, 04 Dec 2017 12:40:49 + Build duration: 9 min 15 sec and counting JUnit Tests

KDE CI: Frameworks ktexteditor kf5-qt5 SUSEQt5.7 - Build # 12 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20SUSEQt5.7/12/ Project: Frameworks ktexteditor kf5-qt5 SUSEQt5.7 Date of build: Mon, 04 Dec 2017 13:15:45 + Build duration: 7 min 14 sec and counting JUnit Tests

D9165: Lazy-instanciate and lazy-load KNotification plugins.

hein added a subscriber: Frameworks. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D9165 To: hein, #plasma, #frameworks, davidedmundson Cc: #frameworks, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9156: Fix a memory leak in KuitStaticData

This revision was automatically updated to reflect the committed changes. Closed by commit R249:170317278f6b: Fix a memory leak in KuitStaticData (authored by jtamate). REPOSITORY R249 KI18n CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9156?vs=23400=23418 REVISION DETAIL

KDE CI: Frameworks ktexteditor kf5-qt5 SUSEQt5.10 - Build # 8 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20SUSEQt5.10/8/ Project: Frameworks ktexteditor kf5-qt5 SUSEQt5.10 Date of build: Mon, 04 Dec 2017 11:42:39 + Build duration: 32 min and counting JUnit Tests

D9166: Remove double lookups

mlaurent created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REPOSITORY R301 KEmoticons BRANCH remove_double_loop REVISION DETAIL https://phabricator.kde.org/D9166 AFFECTED FILES src/core/kemoticons.cpp To:

KDE CI: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7 - Build # 109 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20FreeBSDQt5.7/109/ Project: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7 Date of build: Mon, 04 Dec 2017 12:40:49 + Build duration: 21 min and counting JUnit Tests

KDE CI: Frameworks ktexteditor kf5-qt5 SUSEQt5.10 - Build # 10 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20SUSEQt5.10/10/ Project: Frameworks ktexteditor kf5-qt5 SUSEQt5.10 Date of build: Mon, 04 Dec 2017 12:48:44 + Build duration: 35 min and counting JUnit Tests

D9123: reuse KPackage instance between PluginLoader and Applet

davidedmundson added inline comments. INLINE COMMENTS > applet.cpp:98 > : QObject(0), > - d(new AppletPrivate(KPluginMetaData(), args.count() > 1 ? > args[1].toInt() : 0, this)) > + d(new AppletPrivate(KPluginMetaData(), args.count() > 2 ? > args[2].toInt() : 0, this)) > {

D9165: Lazy-instanciate and lazy-load KNotification plugins.

hein created this revision. hein added reviewers: Plasma, Frameworks, davidedmundson. Restricted Application added projects: Plasma, Frameworks. REVISION SUMMARY KNotificationManager always instanciates all of its built-in plugins as well as any externally supplied icons as soon as the first

KDE CI: Frameworks ktexteditor kf5-qt5 SUSEQt5.7 - Build # 10 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20SUSEQt5.7/10/ Project: Frameworks ktexteditor kf5-qt5 SUSEQt5.7 Date of build: Mon, 04 Dec 2017 12:06:40 + Build duration: 21 min and counting JUnit Tests

D9164: Fix typo in namespace

dhaumann created this revision. dhaumann added a reviewer: vkrause. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY There is an obvious typo in the namespace. I do not know, though, where this string is used. So

D9166: Remove double lookups

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. I expect this map to be very small, and creating a null KEmoticonsTheme allocates a d pointer, so I'm not 100% sure this is faster. But OK, I'm allergic to double lookups and people

KDE CI: Frameworks ktexteditor kf5-qt5 SUSEQt5.10 - Build # 9 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20SUSEQt5.10/9/ Project: Frameworks ktexteditor kf5-qt5 SUSEQt5.10 Date of build: Mon, 04 Dec 2017 12:15:31 + Build duration: 33 min and counting JUnit Tests

D9167: Improve string handling

apol created this revision. apol added a reviewer: Frameworks. Restricted Application added a project: Frameworks. REVISION SUMMARY Instead of using implicit casts, use the ones we need as suggested for KF5. TEST PLAN Builds, tests pass REPOSITORY R302 KIconThemes BRANCH master

D9165: Lazy-instanciate and lazy-load KNotification plugins.

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. One minor comment, then good to go. INLINE COMMENTS > knotificationmanager.cpp:136 > +addPlugin(plugin); > +} else if (action == QStringLiteral("Taskbar")) { >

D9165: Lazy-instanciate and lazy-load KNotification plugins.

hein updated this revision to Diff 23426. hein added a comment. Add and utilize a X-KDE-KNotification-OptionName field in KNotificationPlugin to try and avoid more instanciations. REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9165?vs=23417=23426

D9165: Lazy-instanciate and lazy-load KNotification plugins.

davidedmundson accepted this revision. davidedmundson added inline comments. INLINE COMMENTS > knotificationmanager.cpp:160 > +[, ](const KPluginMetaData ) { > +if (pluginFound) { > +return false; please add a comment explaining this. REPOSITORY

D9164: Fix typo in namespace

vkrause accepted this revision. vkrause added a comment. This revision is now accepted and ready to land. This must match what we use for our debug category name for kdebugsettings to work, so this shouldn't have any negative side-effects. REPOSITORY R216 Syntax Highlighting BRANCH

KDE CI: Frameworks ktexteditor kf5-qt5 SUSEQt5.10 - Build # 11 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20SUSEQt5.10/11/ Project: Frameworks ktexteditor kf5-qt5 SUSEQt5.10 Date of build: Mon, 04 Dec 2017 13:23:47 + Build duration: 16 min and counting JUnit Tests

D9168: Migrate some QRegExps to QRegularExpression

dhaumann created this revision. dhaumann added reviewers: cullmann, kfunk, mwolff. Restricted Application added projects: Kate, Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Please make a careful review. Many of these code changes are most likely not

D9155: Add used property to service file defintion

This revision was automatically updated to reflect the committed changes. Closed by commit R297:9f2bd7afb9cc: Add used property to service file defintion (authored by davidedmundson). REPOSITORY R297 KDED CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9155?vs=23398=23425 REVISION

D9165: Lazy-instanciate and lazy-load KNotification plugins.

This revision was automatically updated to reflect the committed changes. Closed by commit R289:1e048a10f861: Lazy-instanciate and lazy-load KNotification plugins. (authored by hein). REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9165?vs=23426=23427

D9169: port to Package::fileUrl

mart created this revision. mart added a reviewer: Plasma. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY makes things work when packages are in resources Depends from:

D9165: Lazy-instanciate and lazy-load KNotification plugins.

hein added a comment. Comment added: https://commits.kde.org/knotifications/9472dc7b9c63d10e5b707d1e3e3c3a24111fbe9d INLINE COMMENTS > davidedmundson wrote in knotificationmanager.cpp:136 > QLatin1String * 5 - 6 :P > davidedmundson wrote in knotificationmanager.cpp:156 > No reason we

D9175: Migrate some more QRegExps to QRegularExpression

dhaumann created this revision. dhaumann added reviewers: cullmann, kfunk, mwolff. Restricted Application added projects: Kate, Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Please make a careful review. Many of these code changes are most likely not

D9169: port to Package::fileUrl

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. I like your test plan :D REPOSITORY R242 Plasma Framework (Library) BRANCH phab/packegeFileUrl REVISION DETAIL https://phabricator.kde.org/D9169 To: mart, #plasma,

KDE CI: Frameworks ktexteditor kf5-qt5 SUSEQt5.7 - Build # 13 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20SUSEQt5.7/13/ Project: Frameworks ktexteditor kf5-qt5 SUSEQt5.7 Date of build: Mon, 04 Dec 2017 16:28:35 + Build duration: 7 min 14 sec and counting JUnit Tests

KDE CI: Frameworks ktexteditor kf5-qt5 SUSEQt5.10 - Build # 12 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20SUSEQt5.10/12/ Project: Frameworks ktexteditor kf5-qt5 SUSEQt5.10 Date of build: Mon, 04 Dec 2017 16:28:35 + Build duration: 16 min and counting JUnit Tests

D9164: Fix typo in namespace

This revision was automatically updated to reflect the committed changes. Closed by commit R216:792c9cb03888: Fix typo in namespace (authored by dhaumann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9164?vs=23416=23443 REVISION DETAIL

D9126: [RTL] - align properly the selected text for RTL

mvourlakos added a comment. In https://phabricator.kde.org/D9126#175594, @broulik wrote: > (I'd be fine with this one liner going in but I'm wondering why it would be needed in the first place) are we ok for landing this? REPOSITORY R242 Plasma Framework (Library) BRANCH

Failing KTextEditor unit tests

Hi frameworks-devs, since some time we have several unit tests that fail in the KTextEditor framework: https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20SUSEQt5.10/11/testReport/ It sesms all these issues are related to changes in the font, could that be? It even seems that asking

D9167: Improve string handling

dhaumann added a comment. Looks already pretty just. I just stumbled over two issues which maybe should be clarified - see comments. INLINE COMMENTS > kiconeffect.cpp:163 > + > +if (state == Colorize || effectGroupState == ToMonochrome) { > +cached += QLatin1Char(':') +

Re: kcrash, fork, and stdout/stderr

On Monday, 4 December 2017 00:26:55 PST David Faure wrote: > > Or do you fork a child at that point? fork from inside a signal handler is > > an incredibly bad idea, don't do it. > > Well, I guess that's why it's the fallback from the main strategy which is > "ask kdeinit to restart that