vonreth added reviewers: Frameworks, Craft, leinir.
REPOSITORY
R246 Sonnet
REVISION DETAIL
https://phabricator.kde.org/D9421
To: vonreth, #frameworks, #craft, leinir
Cc: #frameworks
mlaurent requested changes to this revision.
This revision now requires changes to proceed.
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
https://phabricator.kde.org/D9420
To: velurimithun, mlaurent
Cc: #frameworks
mlaurent added a comment.
Could you paste you compile error here please.
INLINE COMMENTS
> CMakeLists.txt:1
> -remove_definitions(-DQT_NO_CAST_FROM_ASCII)
> +#remove_definitions(-DQT_NO_CAST_FROM_ASCII)
>
Better to remove it.
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
habacker edited the summary of this revision.
REPOSITORY
R239 KDELibs4Support
REVISION DETAIL
https://phabricator.kde.org/D9386
To: habacker, dfaure, ltoscano, bcooksley
Cc: #frameworks
anthonyfieroni updated this revision to Diff 24144.
REPOSITORY
R304 KNewStuff
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9318?vs=23934=24144
REVISION DETAIL
https://phabricator.kde.org/D9318
AFFECTED FILES
src/core/cache.cpp
To: anthonyfieroni, leinir, #frameworks
Cc:
anthonyfieroni added a comment.
In https://phabricator.kde.org/D9318#181202, @dfaure wrote:
> Well, if this QSet can be huge, then these conversions from QList and to
QList are going to take a lot of CPU.
> Are you sure it wouldn't be much faster to do a linear search at append
time,
vonreth created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
The Craft version of aspell is relocatable and this hack is not
REPOSITORY
R246 Sonnet
BRANCH
master
REVISION DETAIL
velurimithun added a comment.
/home/veluri/ruqola_dep/kcoreaddons/autotests/kaboutdataapplicationdatatest.cpp:72:
error: request for member ‘setOrganizationDomain’ in ‘aboutData2’, which is of
non-class type ‘KAboutData(QLatin1String, QLatin1String, QLatin1String)’
mlaurent added a comment.
KAboutData aboutData2(QString::fromLatin1(AppName2),
QString::fromLatin1(ProgramName2), QString::fromLatin1(Version2));
use QString::fromLatin1 is will work
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
https://phabricator.kde.org/D9420
To: velurimithun,
mlaurent added a comment.
Arguiment from method use QString and not QLatin1String()
QString::fromLatin1 returns a QString
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
https://phabricator.kde.org/D9420
To: velurimithun, mlaurent
Cc: #frameworks
habacker created this revision.
habacker added reviewers: dfaure, bcooksley.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
This commit uses a similar approach as https://phabricator.kde.org/D9383
BUG:382459
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/19/
Project:
Frameworks kio kf5-qt5 FreeBSDQt5.9
Date of build:
Wed, 20 Dec 2017 10:08:19 +
Build duration:
7 min 46 sec and counting
JUnit Tests
Name:
habacker created this revision.
habacker added reviewers: dfaure, bcooksley.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
This commit uses a similar approach as https://phabricator.kde.org/D9383
BUG:382460
broulik added a comment.
Is it possible to move that logic into the `.in` file instead of changing the
cmake file? Just asking, I don't know cmake well.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D9423
To: habacker, dfaure, bcooksley
Cc: broulik, #frameworks
This revision was automatically updated to reflect the committed changes.
Closed by commit R246:bdc6562faf73: Dont cause circular linking on
Windows (authored by leinir).
REPOSITORY
R246 Sonnet
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9018?vs=23028=24150
REVISION DETAIL
broulik abandoned this revision.
REPOSITORY
R309 KService
REVISION DETAIL
https://phabricator.kde.org/D7642
To: broulik, kde-frameworks-devel, dfaure
Cc: dfaure, #frameworks
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.7/40/
Project:
Frameworks kio kf5-qt5 SUSEQt5.7
Date of build:
Wed, 20 Dec 2017 10:08:19 +
Build duration:
9 min 1 sec and counting
JUnit Tests
Name: (root)
dfaure added inline comments.
INLINE COMMENTS
> dfaure wrote in pathhelpers_p.h:31
> It seems to me that path2 cannot start with '/', by contract. It's supposed
> to be relative.
> So I'd say we could even be foolish^H^H^H^Hbrave and make that
>
> Q_ASSERT(!path2.startsWith('/'));
The
Hi,
Is it still possible to query a KWallet for the existence of specific
credentials without having to unlock it first?
The reason I'm asking (not entirely on-topic here, apologies) is that Google
Chrome has been putting up wallet unlock dialogs for a long time now,
apparently as soon as it
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:8a32c8c4aeb9: [Uri Filter Search Provider] readName() of
KDesktopFile (authored by broulik).
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9405?vs=24097=24149
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/39/
Project:
Frameworks kio kf5-qt5 SUSEQt5.10
Date of build:
Wed, 20 Dec 2017 10:08:19 +
Build duration:
14 min and counting
JUnit Tests
Name: (root)
habacker created this revision.
habacker added reviewers: dfaure, bcooksley.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
This commit uses a similar approach as https://phabricator.kde.org/D9383
BUG:388062
velurimithun created this revision.
velurimithun added a reviewer: mlaurent.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
TEST PLAN
Use QStringLiteral or QLatin1String for normal strings
REPOSITORY
R244 KCoreAddons
BRANCH
velurimithun added a comment.
Errors in Kaboutdataappplicationdatatest file
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
https://phabricator.kde.org/D9420
To: velurimithun, mlaurent
Cc: #frameworks
habacker created this revision.
habacker added a reviewer: dfaure.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
This file is a duplicate of the same file one directory level above
and is not used by the build
habacker created this revision.
habacker added reviewers: dfaure, bcooksley.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
This commit uses a similar approach as https://phabricator.kde.org/D9383
BUG:388063
habacker created this revision.
habacker added reviewers: dfaure, bcooksley.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
This commit uses a similar approach as https://phabricator.kde.org/D9383
BUG:388060
habacker created this revision.
habacker added reviewers: dfaure, bcooksley.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
This commit uses a similar approach as https://phabricator.kde.org/D9383
BUG:388059
mart added a comment.
here the change works perfectly..
right now, we have building on android broken for everybody, since months,
this is not acceptable :/
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D8173
To: apol, #frameworks, #build_system,
habacker updated this revision to Diff 24158.
habacker added a comment.
- removed unrelated AFTER parameter
REPOSITORY
R239 KDELibs4Support
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9404?vs=24090=24158
BRANCH
arcpatch-D9404
REVISION DETAIL
This revision was automatically updated to reflect the committed changes.
Closed by commit R289:b5e43439386e: Handle positions of LMB clicks on legacy
systray icons (authored by volkov).
REPOSITORY
R289 KNotifications
CHANGES SINCE LAST UPDATE
kfunk added a comment.
Could you please squash the commits and just keep this review for all the
changes in KIO? Doesn't make sense to have different Phab Diffs for that (makes
it harder to review, harder to revert in case, etc.).
REPOSITORY
R241 KIO
REVISION DETAIL
kfunk requested changes to this revision.
kfunk added a comment.
This revision now requires changes to proceed.
And I agree. There shouldn't be a need to use two different input files.
That's the whole point of `configure_file(...)` the interpolation of values
happens *inside* the input
habacker added a comment.
In https://phabricator.kde.org/D9386#181297, @dfaure wrote:
> That's trivial, isn't it? Rename networking.cpp to networking_unix.cpp, and
move to networking.cpp the methods that are platform-independent.
Any idea how to share the line
habacker added a comment.
In https://phabricator.kde.org/D9423#181442, @kfunk wrote:
> And I agree. There shouldn't be a need to use two different input files.
That's the whole point of `configure_file(...)`: the interpolation of values
happens *inside* the input files.
This
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.9/10/
Project:
Frameworks kirigami kf5-qt5 FreeBSDQt5.9
Date of build:
Wed, 20 Dec 2017 12:05:09 +
Build duration:
1 min 31 sec and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.9/11/
Project:
Frameworks kirigami kf5-qt5 FreeBSDQt5.9
Date of build:
Wed, 20 Dec 2017 12:08:09 +
Build duration:
1 min 18 sec and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20SUSEQt5.10/19/
Project:
Frameworks kirigami kf5-qt5 SUSEQt5.10
Date of build:
Wed, 20 Dec 2017 12:05:09 +
Build duration:
7 min 29 sec and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20SUSEQt5.7/21/
Project:
Frameworks kirigami kf5-qt5 SUSEQt5.7
Date of build:
Wed, 20 Dec 2017 12:05:09 +
Build duration:
7 min 38 sec and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20SUSEQt5.7/22/
Project:
Frameworks kirigami kf5-qt5 SUSEQt5.7
Date of build:
Wed, 20 Dec 2017 12:12:49 +
Build duration:
1 min 16 sec and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.9/12/
Project:
Frameworks kirigami kf5-qt5 FreeBSDQt5.9
Date of build:
Wed, 20 Dec 2017 12:12:49 +
Build duration:
1 min 17 sec and counting
JUnit Tests
apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.
How cool is it to remove workarounds? :)
REPOSITORY
R246 Sonnet
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D9421
To: vonreth, #frameworks, #craft, leinir, apol
Cc: apol,
leinir accepted this revision.
leinir added a comment.
Ha, yes, i concur with Aleix there, workaround-be-gone! ;) (i have a
suspicion the reason i thought this worked before is because i was testing on
my local machine... which also explains nicely why the packages from BF don't
have
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20SUSEQt5.10/20/
Project:
Frameworks kirigami kf5-qt5 SUSEQt5.10
Date of build:
Wed, 20 Dec 2017 12:12:39 +
Build duration:
7 min 3 sec and counting
JUnit Tests
habacker added a comment.
In https://phabricator.kde.org/D5175#181288, @bcooksley wrote:
> I still question how these installs conflict - as all the scenarios where
they could conflict should already be taken into account:
>
> 1. Linux distros, FreeBSD, etc have no co-installability
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20SUSEQt5.10/21/
Project:
Frameworks kirigami kf5-qt5 SUSEQt5.10
Date of build:
Wed, 20 Dec 2017 12:19:43 +
Build duration:
7 min 7 sec and counting
JUnit Tests
apol accepted this revision.
apol added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> CMakeLists.txt:66
>
> -configure_file(org.kde.kglobalaccel.service.in
> - ${CMAKE_CURRENT_BINARY_DIR}/org.kde.kglobalaccel.service)
> +if(WIN32)
> +
apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.
Sorry I just saw it and went ahead.
REPOSITORY
R268 KGlobalAccel
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D9429
To: habacker, dfaure, apol
Cc: apol, #frameworks
apol requested changes to this revision.
apol added a comment.
This revision now requires changes to proceed.
Wait, why is this needed all of a sudden? Aren't these services used in the
rest of win32 applications we have available in https://binary-factory.kde.org/?
REPOSITORY
R268
This revision was automatically updated to reflect the committed changes.
Closed by commit R246:d10d613b33ab: Remove anchient and broken workaround
(authored by vonreth).
REPOSITORY
R246 Sonnet
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9421?vs=24145=24164
REVISION DETAIL
velurimithun marked an inline comment as done.
velurimithun added inline comments.
INLINE COMMENTS
> mlaurent wrote in kaboutdatatest.cpp:184
> QStringLiteral doen't work here ?
Yeah working, I'll change it
> mlaurent wrote in kprocesstest.cpp:93
> QStringLiteral
These strings are going as
mlaurent added inline comments.
INLINE COMMENTS
> velurimithun wrote in kprocesstest.cpp:93
> These strings are going as arguments for QStringList() method that why I used
> QString::FromLatin1()
?
QStringLiteral works fine with QStringList
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
mlaurent added a comment.
IT's a WIP as I use file(APPEND...) because I want to generate several
categories in one file.
But it doesn't work as I don't have idea how to reset file when cmake is
started...
Do you have an idea ?
I will implement autotest and co if we have a
velurimithun updated this revision to Diff 24197.
velurimithun added a comment.
Changes are made using QStringLiteral
REPOSITORY
R244 KCoreAddons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9420?vs=24175=24197
REVISION DETAIL
https://phabricator.kde.org/D9420
AFFECTED
velurimithun updated this revision to Diff 24198.
velurimithun added a comment.
Update the code using QStringLiteral
REPOSITORY
R244 KCoreAddons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9420?vs=24197=24198
REVISION DETAIL
https://phabricator.kde.org/D9420
AFFECTED FILES
petermajchrak added a comment.
I can revert it back to the combobox based layout. Don't we have some UX
people that could take a look at this?
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8536
To: petermajchrak, elvisangelaccio, #vdg, colomar
Cc: colomar,
mlaurent created this revision.
Restricted Application added projects: Frameworks, Build System.
Restricted Application added subscribers: Build System, Frameworks.
TEST PLAN
Generate kmail categories file
REPOSITORY
R240 Extra CMake Modules
BRANCH
autogenerate_categories_file
REVISION
velurimithun added a comment.
I'm getting errors in processtest!!
/home/veluri/Qt/5.9.3/gcc_64/include/QtCore/qstringbuilder.h:357: error: no
matching function for call to ‘QConcatenable::appendTo(const char
[16], QChar*&)’
QConcatenable::appendTo(p.a, out);
mlaurent added inline comments.
INLINE COMMENTS
> desktoptojsontest.cpp:84
> QByteArray input =
> -// include an insignificant group
> -"[Some Group]\n"
> -"Foo=Bar\n"
> -"\n"
> -"[Desktop Entry]\n"
> -// only data
velurimithun updated this revision to Diff 24199.
REPOSITORY
R244 KCoreAddons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9420?vs=24198=24199
REVISION DETAIL
https://phabricator.kde.org/D9420
AFFECTED FILES
autotests/CMakeLists.txt
autotests/desktoptojsontest.cpp
mlaurent added a comment.
Missing all patch... please see
"https://community.kde.org/Infrastructure/Phabricator;
"Step 2: Updating your diff.
After you upload the code the reviewer will take a look and give you some
comments. If you get a thumbs up, you can skip this step. But
habacker marked an inline comment as done.
REPOSITORY
R268 KGlobalAccel
REVISION DETAIL
https://phabricator.kde.org/D9424
To: habacker, dfaure, bcooksley, apol
Cc: apol, #frameworks
apol added a subscriber: Windows.
REPOSITORY
R268 KGlobalAccel
REVISION DETAIL
https://phabricator.kde.org/D9424
To: habacker, dfaure, bcooksley, apol
Cc: #windows, apol, #frameworks
apol added subscribers: vonreth, kfunk.
apol added a comment.
@kfunk, @vonreth Will craft applications also benefit from this? Or is it
solved in a different way there?
REPOSITORY
R268 KGlobalAccel
REVISION DETAIL
https://phabricator.kde.org/D9424
To: habacker, dfaure, bcooksley, apol
habacker updated this revision to Diff 24168.
habacker added a comment.
- added note
REPOSITORY
R268 KGlobalAccel
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9424?vs=24148=24168
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D9424
AFFECTED FILES
velurimithun retitled this revision from "Compile commenting
remove_defintion(QT_NO_CAST_FROM_ASCII defination)" to "Compile commenting
remove_defintion(QT_NO_CAST_FROM_ASCII )".
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
https://phabricator.kde.org/D9420
To: velurimithun, mlaurent
Cc:
habacker added a comment.
I stumbled over one issue case and did a quick search which locations are
also affected by this issue type.
REPOSITORY
R268 KGlobalAccel
REVISION DETAIL
https://phabricator.kde.org/D9424
To: habacker, dfaure, bcooksley, apol
Cc: apol, #frameworks
This revision was automatically updated to reflect the committed changes.
Closed by commit R244:0d417760a53f: Match license keys by spdx (authored by
davidedmundson).
REPOSITORY
R244 KCoreAddons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9437?vs=24176=24177
REVISION DETAIL
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.7/21/
Project:
Frameworks kcoreaddons kf5-qt5 SUSEQt5.7
Date of build:
Wed, 20 Dec 2017 17:22:25 +
Build duration:
6 min 19 sec and counting
JUnit Tests
apol added a comment.
In https://phabricator.kde.org/D9423#181574, @kfunk wrote:
> In https://phabricator.kde.org/D9423#181460, @habacker wrote:
>
> > In https://phabricator.kde.org/D9423#181442, @kfunk wrote:
> >
> > > And I agree. There shouldn't be a need to use two different
apol accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R244 KCoreAddons
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D9437
To: davidedmundson, apol
Cc: #frameworks
dfaure accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R239 KDELibs4Support
BRANCH
arcpatch-D9404
REVISION DETAIL
https://phabricator.kde.org/D9404
To: habacker, dfaure, ltoscano, bcooksley
Cc: #frameworks
kfunk added a comment.
In https://phabricator.kde.org/D9423#181460, @habacker wrote:
> In https://phabricator.kde.org/D9423#181442, @kfunk wrote:
>
> > And I agree. There shouldn't be a need to use two different input files.
That's the whole point of `configure_file(...)`: the
kfunk added a comment.
@dfaure Opinions?
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D9423
To: habacker, dfaure, bcooksley, kfunk
Cc: kfunk, broulik, #frameworks
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.9/10/
Project:
Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.9
Date of build:
Wed, 20 Dec 2017 17:22:25 +
Build duration:
2 min 23 sec and counting
JUnit
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.10/23/
Project:
Frameworks kcoreaddons kf5-qt5 SUSEQt5.10
Date of build:
Wed, 20 Dec 2017 17:22:25 +
Build duration:
3 min 9 sec and counting
JUnit Tests
mlaurent requested changes to this revision.
mlaurent added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> kaboutdatatest.cpp:48
>
> -static const char AppName[] ="app";
> -static const char ProgramName[] ="ProgramName";
> -static const
kfunk added a comment.
Please let's discuss on https://phabricator.kde.org/D9423 exclusively. This
is basically fixing the same issue in a different repository.
REPOSITORY
R268 KGlobalAccel
REVISION DETAIL
https://phabricator.kde.org/D9424
To: habacker, dfaure, bcooksley, apol
Cc:
colomar added a comment.
With that many available algorithms, the combobox solution makes more sense
to me as well.
For checking a provided checksum, users don't have to use the combobox,
anyway. They just paste in the checksum and get a result automatically.
REPOSITORY
R241 KIO
habacker added a comment.
Thanks.
BTW: If you had done
cd
git pull --rebase
arc patch --nobranch D9429
git push
the related commit would be added to this review by default to indicate that
is has been pushed.
REPOSITORY
R268 KGlobalAccel
BRANCH
master
anthonyfieroni created this revision.
anthonyfieroni added a reviewer: dfaure.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
TEST PLAN
apol updated this revision to Diff 24185.
apol added a comment.
Went to albert's place and figured it out
REPOSITORY
R240 Extra CMake Modules
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8173?vs=22498=24185
BRANCH
arcpatch-D8173_2
REVISION DETAIL
aacid accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R240 Extra CMake Modules
BRANCH
arcpatch-D8173_2
REVISION DETAIL
https://phabricator.kde.org/D8173
To: apol, #frameworks, #build_system, aacid
Cc: mart
petermajchrak added a comment.
@anthonyfieroni, @elvisangelaccio, @colomar any progress? just want to get a
status... this diff seems to be taking quite a long time to get reviewed after
making changes...
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8536
To:
habacker added a commit: R268:881aadcec98a: Remove unused, duplicated file.
REPOSITORY
R268 KGlobalAccel
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D9429
To: habacker, dfaure, apol
Cc: apol, #frameworks
habacker added a comment.
In https://phabricator.kde.org/D9423#181574, @kfunk wrote:
> In https://phabricator.kde.org/D9423#181460, @habacker wrote:
>
> > In https://phabricator.kde.org/D9423#181442, @kfunk wrote:
> >
> > > And I agree. There shouldn't be a need to use two
mwolff updated this revision to Diff 24188.
mwolff added a comment.
- expand test to non-editable combo box
- fix wrong signal connection (regression introduced when ported to
QOverload<>::of)
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit R240:c91c3650968d: Use readelf to find project dependencies
(authored by apol).
REPOSITORY
R240 Extra CMake Modules
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8173?vs=24185=24192
REVISION
apol added a comment.
Yes, I didn't notice, sorry.
REPOSITORY
R268 KGlobalAccel
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D9429
To: habacker, dfaure, apol
Cc: apol, #frameworks
velurimithun updated this revision to Diff 24175.
velurimithun added a comment.
- use QLating1String
REPOSITORY
R244 KCoreAddons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9420?vs=24143=24175
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D9420
AFFECTED
davidedmundson created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
KAboutLicense supports exporting a license as an spdx ID.
(https://spdx.org/licenses/)
However the KAboutLicense::fromKeyword
91 matches
Mail list logo
