D9928: Fix one source of log spam referenced in Bug 388389 (Empty filename passed to function)

dhaumann added a comment. @davidedmundson If the associated bug is fixed, it should be closed. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D9928 To: rkron, #frameworks, davidedmundson Cc: dhaumann, ngraham, alexeymin, aacid, #frameworks

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 24 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/24/ Project: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 Date of build: Sat, 20 Jan 2018 22:26:47 + Build duration: 3 min 50 sec and counting

D9928: Fix one source of log spam referenced in Bug 388389 (Empty filename passed to function)

This revision was automatically updated to reflect the committed changes. Closed by commit R242:5eece6769f21: Fix one source of log spam referenced in Bug 388389 (Empty filename passed to… (authored by rkron, committed by davidedmundson). REPOSITORY R242 Plasma Framework (Library) CHANGES

D9928: Fix one source of log spam referenced in Bug 388389 (Empty filename passed to function)

rkron added a comment. I'm new to phabricator and do not have commit access. Does someone need to commit this? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D9928 To: rkron, #frameworks, davidedmundson Cc: ngraham, alexeymin, aacid, #frameworks

D9973: ktooltipwidget: Fix tooltip positioning

elvisangelaccio added inline comments. INLINE COMMENTS > michaelh wrote in ktooltipwidget.cpp:155 > > Are you saying that you don't want to correct it at the second place, just > > because tests did not reveal a bug? > > Yes, but it is rather like this: Due to my lack of my experience I don't

D9989: tools: Make all output messages translatable

michaelh marked 2 inline comments as done. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D9989 To: michaelh, smithjd, #frameworks, vhanda, lueck Cc: ngraham

D9973: ktooltipwidget: Fix tooltip positioning

michaelh added a comment. > Can you please describe exactly how many bugs are there and how to reproduce them? I can't exactly. There at least to phenomenona 1. 2 stages of metadata loading most likely affecting tooltip sizing F5665675: tooltip.mkv

D9973: ktooltipwidget: Fix tooltip positioning

elvisangelaccio added a comment. @michaelh Can you please describe exactly how many bugs are there and how to reproduce them? Also, ideally each bug should be reproduced by a test case in `ktooltipwidgettest.cpp`, but I understand that's a lot to ask (so feel free to ignore it).

Re: KHolidays as Framework (redux)

Am 20.01.2018 17:22 schrieb "Volker Krause" : Thanks, should be fixed now. Certainly better, although code examples and the like still would make a significant difference ;) Cheers Dominik On Saturday, 20 January 2018 15:17:53 CET Dominik Haumann wrote: > Hi, > > CC: only

Re: KHolidays as Framework (redux)

Thanks, should be fixed now. On Saturday, 20 January 2018 15:17:53 CET Dominik Haumann wrote: > Hi, > > CC: only kdepim, kde-frameworks-devel > > I have some general comments about the API documentation. Looking at > https://api.kde.org/stable/kdepimlibs-apidocs/kholidays/html/classes.html >

Re: A new tier1 for icontheme.rcc handling

+1 for the name kiconsupport as Ben suggested. Em 19 de jan de 2018 21:49, "Ben Cooksley" escreveu: On Thu, Jan 18, 2018 at 8:45 PM, Hannah von Reth wrote: > Hi everyone. Hi Hannah, > > Only some few of you will be aware of KIconThemes ability to load

D9989: tools: Make all output messages translatable

lueck added a comment. In https://phabricator.kde.org/D9989#193705, @michaelh wrote: > added i18n context OK from i18n pov, thanks REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D9989 To: michaelh, smithjd, #frameworks, vhanda, lueck Cc: ngraham

Re: KHolidays as Framework (redux)

Hi, CC: only kdepim, kde-frameworks-devel I have some general comments about the API documentation. Looking at https://api.kde.org/stable/kdepimlibs-apidocs/kholidays/html/classes.html the list mostly (only?) contains classes that are internal. Looking at

D9989: tools: Make all output messages translatable

michaelh updated this revision to Diff 25687. michaelh added a comment. added i18n context REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9989?vs=25676=25687 BRANCH translate-all (branched from master) REVISION DETAIL https://phabricator.kde.org/D9989

D9990: Fix compilation of just the UI-less host tools

This revision was automatically updated to reflect the committed changes. Closed by commit R246:eddccea61f31: Fix compilation of just the UI-less host tools (authored by vkrause). REPOSITORY R246 Sonnet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9990?vs=25680=25686 REVISION

D9595: Don't export kded5 as a CMake target

This revision was automatically updated to reflect the committed changes. Closed by commit R297:55e9a348870f: Dont export kded5 as a CMake target (authored by vkrause). REPOSITORY R297 KDED CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9595?vs=24556=25685 REVISION DETAIL

D9990: Fix compilation of just the UI-less host tools

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R246 Sonnet BRANCH master REVISION DETAIL https://phabricator.kde.org/D9990 To: vkrause, #frameworks, apol

D9595: Don't export kded5 as a CMake target

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R297 KDED BRANCH master REVISION DETAIL https://phabricator.kde.org/D9595 To: vkrause, #frameworks, apol

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 94 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/94/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Sat, 20 Jan 2018 11:09:27 + Build duration: 47 min and counting JUnit Tests Name: (root)

D9989: tools: Make all output messages translatable

lueck added inline comments. INLINE COMMENTS > michaelh wrote in monitorcommand.cpp:66 > Context needed? yes, please add context about the meaning of %1 REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D9989 To: michaelh, smithjd, #frameworks, vhanda, lueck Cc: ngraham

D9585: Fix finding libintl when "cross"-compiling native Yocto packages

This revision was automatically updated to reflect the committed changes. Closed by commit R249:5c98cc08767b: Fix finding libintl when cross-compiling native Yocto packages (authored by vkrause). REPOSITORY R249 KI18n CHANGES SINCE LAST UPDATE

D9595: Don't export kded5 as a CMake target

vkrause added a comment. ping REPOSITORY R297 KDED REVISION DETAIL https://phabricator.kde.org/D9595 To: vkrause, #frameworks

D9990: Fix compilation of just the UI-less host tools

vkrause created this revision. vkrause added a reviewer: Frameworks. Restricted Application added a project: Frameworks. vkrause requested review of this revision. REVISION SUMMARY ECM usually takes care of disabling tests, but it nevertheless requires all targets the tests depend on to

Possible regression in kio with data loss

Hi, Last weekend I did the following: * build kio using kdesrc-build * copy the resulting bin/kf5/file.so to /usr/lib64/qt5/plugins/kf5/kio * ldconfig * restart the session Just to be sure that all processes are using the new kio. I copied files to an ntfs filesystem and the files

D9585: Fix finding libintl when "cross"-compiling native Yocto packages

ilic accepted this revision. This revision is now accepted and ready to land. REPOSITORY R249 KI18n BRANCH master REVISION DETAIL https://phabricator.kde.org/D9585 To: vkrause, #frameworks, ilic

D9585: Fix finding libintl when "cross"-compiling native Yocto packages

vkrause added a comment. ping REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D9585 To: vkrause, #frameworks

Re: KHolidays as Framework (redux)

On Sunday, 14 January 2018 12:55:30 CET David Faure wrote: > On dimanche 14 janvier 2018 10:20:38 CET Volker Krause wrote: > > On Tuesday, 6 September 2016 12:03:15 CET Volker Krause wrote: > > > On Friday 01 January 2016 18:24:17 David Faure wrote: > > > > On Thursday 24 December 2015 12:28:13

D9420: Compile commenting remove_defintion(QT_NO_CAST_FROM_ASCII )

velurimithun added a comment. Sry for the late patch :)) I was busy with setting up Ruqola... I have one doubt that why this(kdirwatch_unittest.cpp ) file is in autotests?? It should be in unit tests right? Thank You for your patience. REPOSITORY R244 KCoreAddons REVISION

D9420: Compile commenting remove_defintion(QT_NO_CAST_FROM_ASCII )

velurimithun updated this revision to Diff 25677. velurimithun added a comment. - use QLating1String - compile commenting remove_definition(DQT_NO_CAST_FROM_ASCII - Make necessary changes according to comments in https://phabricator.kde.org/D9420 - Use QString::fromUtf8(..) to decode an

D9989: tools: Make all output messages translatable

michaelh added inline comments. INLINE COMMENTS > monitorcommand.cpp:66 > m_currentFile = filePath; > -m_out << "Indexing: " << filePath; > +m_out << i18n("Indexing: %1", filePath); > } Context needed? REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D9989

D9989: tools: Make all output messages translatable

michaelh created this revision. michaelh added reviewers: smithjd, Frameworks, vhanda. michaelh added a project: Frameworks. michaelh requested review of this revision. REPOSITORY R293 Baloo BRANCH translate-all (branched from master) REVISION DETAIL https://phabricator.kde.org/D9989

D9989: tools: Make all output messages translatable

michaelh added a reviewer: lueck. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D9989 To: michaelh, smithjd, #frameworks, vhanda, lueck Cc: ngraham

KDE CI: Frameworks baloo kf5-qt5 SUSEQt5.7 - Build # 24 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.7/24/ Project: Frameworks baloo kf5-qt5 SUSEQt5.7 Date of build: Sat, 20 Jan 2018 09:08:28 + Build duration: 3 min 55 sec and counting JUnit Tests Name:

D9959: baloosearch: Send summary to stderr

This revision was automatically updated to reflect the committed changes. Closed by commit R293:3e1a9b843dfd: baloosearch: Send summary to stderr (authored by michaelh). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9959?vs=25586=25673 REVISION DETAIL

D9420: Compile commenting remove_defintion(QT_NO_CAST_FROM_ASCII )

mlaurent added a comment. Ping bis ?:) REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D9420 To: velurimithun, mlaurent Cc: dfaure, #frameworks

D9987: Lessen log spam by not checking for existence of file with empty name

rkflx updated this revision to Diff 25672. rkflx added a comment. Spelling. REPOSITORY R303 KInit CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9987?vs=25671=25672 BRANCH master REVISION DETAIL https://phabricator.kde.org/D9987 AFFECTED FILES src/kdeinit/kinit.cpp To:

D9987: Lessen log spam by not checking for existence of file with empty name

rkflx updated this revision to Diff 25671. rkflx added a comment. Add comment. Thanks for the tip, Dominik :) REPOSITORY R303 KInit CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9987?vs=25670=25671 BRANCH master REVISION DETAIL https://phabricator.kde.org/D9987 AFFECTED

D9959: baloosearch: Send summary to stderr

lbeltrame accepted this revision. lbeltrame added a comment. This revision is now accepted and ready to land. LGTM. REPOSITORY R293 Baloo BRANCH search-summary REVISION DETAIL https://phabricator.kde.org/D9959 To: michaelh, #frameworks, vhanda, smithjd, broulik, lbeltrame

D9958: balooctl status: Produce parseable output

lbeltrame accepted this revision. lbeltrame added a comment. This revision is now accepted and ready to land. Changes are trivial enough IMO. Perhaps wait one or two days to see if anyone objects, then you can land this. REPOSITORY R293 Baloo BRANCH formatting REVISION DETAIL

D9987: Lessen log spam by not checking for existence of file with empty name

dhaumann added a comment. +1, but someone else must approve. You could even add this as comment: // check for empty string to avoid warning message in QFileExists. REPOSITORY R303 KInit REVISION DETAIL https://phabricator.kde.org/D9987 To: rkflx, #frameworks Cc: dhaumann