D10293: remove view-media-playlist from preferences icons

astippich created this revision. astippich added reviewers: Breeze, VDG, andreaska. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. astippich requested review of this revision. REVISION SUMMARY the view-media-playlist icon in the

D10293: remove view-media-playlist from preferences icons

astippich added a comment. I don't know if it is acceptable to just remove the icon. I also don't know if this is used anywhere. Stumbled upon while looking into icons for the Elisa music player where this icon then creates strange results. I think another workaround would be to create a

D10292: change 32px icons for playlist shuffle and repeat

astippich updated this revision to Diff 26512. astippich added a comment. update to 1px of line width, was 1.5 due to the scaling REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10292?vs=26497=26512 BRANCH playlist_shuffle_repeat REVISION DETAIL

D10292: change 32px icons for playlist shuffle and repeat

astippich created this revision. astippich added reviewers: Breeze, VDG, andreaska. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. astippich requested review of this revision. REVISION SUMMARY the 32px icons for media-playlist-shuffle

Re: Review Request 129398: Restore KTextEditor Document Dbus bindings

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129398/#review103861 --- If this patch is not merged yet, maybe consider moving it

D10300: [server] Don't crash when a subsurface gets commited whose parent surface got destroyed

graesslin created this revision. graesslin added reviewers: Frameworks, KWin, Plasma. Restricted Application added projects: Plasma on Wayland, Frameworks. Restricted Application added a subscriber: plasma-devel. graesslin requested review of this revision. Restricted Application edited projects,

D10279: add 24px media-album-cover icon

astippich updated this revision to Diff 26484. astippich added a comment. - do the same thing for dark icons REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10279?vs=26461=26484 BRANCH master REVISION DETAIL https://phabricator.kde.org/D10279

D10203: documenturldb: Temporarily remove Q_ASSERT, ignore empty filenames instead

michaelh added a comment. @mgallien: Here is way to come close to reproducing this without corrupting you db: $balooctl stop - Take 2 pendrives A and B - Plug them in in this order: A > B Assuming they are mounted inside `/run/media/mgallien/` $ stat -c "%D %n"

D10279: add 24px media-album-cover icon

astippich updated this revision to Diff 26495. astippich added a comment. use a proper feature branch, which I forgot to use before REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10279?vs=26484=26495 BRANCH media-album-cover REVISION DETAIL

D10292: change 32px icons for playlist shuffle and repeat

astippich added a comment. Before: F5691700: Screenshot_20180204_134019.png F5691702: Screenshot_20180204_134042.png After, which is also how the 24px and lower icons look like: F5691706:

D10292: change 32px icons for playlist shuffle and repeat

astippich edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D10292 To: astippich, #breeze, #vdg, andreaska Cc: #frameworks, michaelh, ngraham

D10300: [server] Don't crash when a subsurface gets commited whose parent surface got destroyed

davidedmundson accepted this revision. This revision is now accepted and ready to land. Restricted Application edited projects, added Plasma on Wayland; removed Plasma. REPOSITORY R127 KWayland BRANCH subsurface-parent-destroyed REVISION DETAIL https://phabricator.kde.org/D10300 To:

D10203: documenturldb: Temporarily remove Q_ASSERT, ignore empty filenames instead

mgallien added a comment. In https://phabricator.kde.org/D10203#200490, @michaelh wrote: > @mgallien: Here is way to come close to reproducing this without corrupting you db: > > $balooctl stop > > > - Take 2 pendrives A and B > - Plug them in in this order: A > B Assuming

D10286: Fix C# var regex

This revision was automatically updated to reflect the committed changes. Closed by commit R216:b874bbe19165: Fix C# var regex (authored by dhaumann). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D10286?vs=26471=26520#toc REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE

D10309: device: define StateChangeReason and MeteredStatus as Q_ENUMs

aleksanderm created this revision. aleksanderm added reviewers: Frameworks, jgrulich. Restricted Application added a project: Frameworks. aleksanderm requested review of this revision. REVISION SUMMARY So that e.g. users of the library can easily print them as strings. REPOSITORY R282

D9672: Don't emit error signal before we tried all list commands.

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH fix-ftp-list REVISION DETAIL https://phabricator.kde.org/D9672 To: wcpan, dfaure Cc: ngraham, cfeck, #frameworks, michaelh

D10286: Fix C# var regex

dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. This is a good patch - for next time, please increase the version number :-) REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D10286 To: wesdawg,

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.7 - Build # 112 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.7/112/ Project: Frameworks kio kf5-qt5 SUSEQt5.7 Date of build: Sun, 04 Feb 2018 17:08:36 + Build duration: 10 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 93 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/93/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Sun, 04 Feb 2018 17:08:36 + Build duration: 9 min 21 sec and counting JUnit Tests Name:

D10312: FileUndoManager: don't delete non-existing local files

elvisangelaccio edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10312 To: elvisangelaccio, dfaure Cc: #frameworks, michaelh, ngraham

Re: Possible regression in kio with data loss

El dissabte, 20 de gener de 2018, a les 11:56:34 CET, Jaime va escriure: > Hi, Is it me or noone reacted to a "data loss regression" email? That's pretty sad. > > Last weekend I did the following: > * build kio using kdesrc-build > * copy the resulting bin/kf5/file.so to

D10312: FileUndoManager: don't delete non-existing local files

elvisangelaccio created this revision. elvisangelaccio added a reviewer: dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. elvisangelaccio requested review of this revision. REVISION SUMMARY After a CopyJob the FileUndoManager

Re: Current security issues with KAuth support in KIO

So we're having KF5 5.43 next week, has this been figured out? I find this thread ended too open ended for my taste. Cheers, Albert El dissabte, 13 de gener de 2018, a les 23:55:16 CET, Luca Beltrame va escriure: > (please keep Fabian in CC, he's not subscribed and found out most of the >

D10314: Use F11 as the shortcut to toggle the aside preview

ngraham created this revision. ngraham added a reviewer: Frameworks. Restricted Application added a project: Frameworks. ngraham requested review of this revision. REVISION SUMMARY FEATURE: 389880 FIXED-IN: 5.44 TEST PLAN Shortcut works and toggles the aside preview. However, in doing

D10314: Use F11 as the shortcut to toggle the aside preview

ngraham edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10314 To: ngraham, #frameworks Cc: michaelh, ngraham

D10305: Framework patch: Moving the mouse over a different application icon immediately changes the window list

cfeck set the repository for this revision to R242 Plasma Framework (Library). Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D10305 To:

D10305: Fix "Moving the mouse over a different application icon immediately changes the window list"

cfeck requested changes to this revision. cfeck added a comment. This revision now requires changes to proceed. Please use the summary to describe what the patch does, not why you added it. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D10305 To:

D10305: Fix "Moving the mouse over a different application icon immediately changes the window list"

cfeck retitled this revision from "Framework patch: Moving the mouse over a different application icon immediately changes the window list" to "Fix "Moving the mouse over a different application icon immediately changes the window list"". cfeck edited the summary of this revision. REPOSITORY

Re: Possible regression in kio with data loss

2018-02-04 23:42 GMT+01:00 Albert Astals Cid : > El dissabte, 20 de gener de 2018, a les 11:56:34 CET, Jaime va escriure: > > Hi, > > Is it me or noone reacted to a "data loss regression" email? > > That's pretty sad. > > > > > Last weekend I did the following: > > * build kio

D10257: KUrlMimeData: fix handling of PreferLocalUrls

This revision was automatically updated to reflect the committed changes. Closed by commit R244:a7384f1817e5: KUrlMimeData: fix handling of PreferLocalUrls (authored by dfaure). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D10257?vs=26397=26555#toc REPOSITORY R244 KCoreAddons

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.7 - Build # 37 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.7/37/ Project: Frameworks kcoreaddons kf5-qt5 SUSEQt5.7 Date of build: Mon, 05 Feb 2018 07:40:34 + Build duration: 4 min 29 sec and counting JUnit Tests

KDE CI: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.9 - Build # 26 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.9/26/ Project: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.9 Date of build: Mon, 05 Feb 2018 07:40:34 + Build duration: 4 min 17 sec and counting JUnit

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 - Build # 42 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.10/42/ Project: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 Date of build: Mon, 05 Feb 2018 07:40:33 + Build duration: 8 min 55 sec and counting JUnit Tests

D7175: Redesign CMake syntax

turbov added a comment. @cullmann , @dhaumann if there is no intereset, I'll close this review and will distribute my CMake syntax in other ways... REVISION DETAIL https://phabricator.kde.org/D7175 To: turbov, dhaumann, #kate, #framework_syntax_highlighting, vkrause Cc: cullmann,

D10309: device: define StateChangeReason and MeteredStatus as Q_ENUMs

jgrulich accepted this revision. This revision is now accepted and ready to land. REPOSITORY R282 NetworkManagerQt BRANCH fixes REVISION DETAIL https://phabricator.kde.org/D10309 To: aleksanderm, #frameworks, jgrulich Cc: michaelh, ngraham