KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 122 - Still Unstable!

2018-02-08 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/122/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Thu, 08 Feb 2018 16:29:53 + Build duration: 18 min and counting JUnit Tests Name: (root)

D10390: Add vokoscreen to KMoreTools and add it to the "screenrecorder" grouping

2018-02-08 Thread gregormi
gregormi retitled this revision from "Minor fix: rename info file to _README.md" to "Add vokoscreen to KMoreTools and add it to the "screenrecorder" grouping". gregormi edited the test plan for this revision. gregormi added a reviewer: ngraham. REPOSITORY R304 KNewStuff REVISION DETAIL

D10390: Add vokoscreen to KMoreTools and add it to the "screenrecorder" grouping

2018-02-08 Thread Nathaniel Graham
ngraham accepted this revision. REPOSITORY R304 KNewStuff BRANCH master REVISION DETAIL https://phabricator.kde.org/D10390 To: gregormi, ngraham, apol Cc: #frameworks, michaelh, ngraham

D10390: Add vokoscreen to KMoreTools and add it to the "screenrecorder" grouping

2018-02-08 Thread Aleix Pol Gonzalez
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R304 KNewStuff BRANCH master REVISION DETAIL https://phabricator.kde.org/D10390 To: gregormi, ngraham, apol Cc: #frameworks, michaelh, ngraham

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 103 - Still Unstable!

2018-02-08 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/103/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Thu, 08 Feb 2018 16:37:36 + Build duration: 7 min 7 sec and counting JUnit Tests Name:

D10390: Minor fix: rename info file to _README.md

2018-02-08 Thread gregormi
gregormi created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. gregormi requested review of this revision. REVISION SUMMARY Add vokoscreen to KMoreTools and add it to the "screenrecorder" grouping TEST PLAN Run $ cd

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.7 - Build # 121 - Still Unstable!

2018-02-08 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.7/121/ Project: Frameworks kio kf5-qt5 SUSEQt5.7 Date of build: Thu, 08 Feb 2018 16:29:53 + Build duration: 25 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 123 - Still Unstable!

2018-02-08 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/123/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Thu, 08 Feb 2018 16:48:28 + Build duration: 6 min 20 sec and counting JUnit Tests Name:

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.7 - Build # 122 - Still Unstable!

2018-02-08 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.7/122/ Project: Frameworks kio kf5-qt5 SUSEQt5.7 Date of build: Thu, 08 Feb 2018 16:55:47 + Build duration: 7 min 7 sec and counting JUnit Tests Name: (root)

D10390: Add vokoscreen to KMoreTools and add it to the "screenrecorder" grouping

2018-02-08 Thread gregormi
This revision was automatically updated to reflect the committed changes. Closed by commit R304:bf82fe7c222f: Add vokoscreen to KMoreTools and add it to the screenrecorder grouping (authored by gregormi). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D10390?vs=26772=26774#toc REPOSITORY

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 102 - Still Unstable!

2018-02-08 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/102/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Thu, 08 Feb 2018 16:29:53 + Build duration: 7 min 22 sec and counting JUnit Tests Name:

D10358: Repair copying file to VFAT without warnings.

2018-02-08 Thread David Faure
dfaure closed this revision. REVISION DETAIL https://phabricator.kde.org/D10358 To: dfaure, chinmoyr, markg, jtamate Cc: #frameworks, michaelh, ngraham

D10376: kio_file: skip error handling for initial perms during file copy

2018-02-08 Thread David Faure
dfaure closed this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10376 To: dfaure, chinmoyr, markg, jtamate Cc: #frameworks, michaelh, ngraham

D10124: Faster simplejob start

2018-02-08 Thread David Faure
dfaure accepted this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10124 To: jtamate, #frameworks, mwolff, dfaure Cc: mwolff, broulik, ngraham, anthonyfieroni, michaelh

D10124: Faster simplejob start

2018-02-08 Thread Jaime Torres Amate
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R241:42fed2e70a21: Faster simplejob start (authored by jtamate). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 127 - Still Unstable!

2018-02-08 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/127/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Thu, 08 Feb 2018 21:25:29 + Build duration: 10 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 125 - Still Unstable!

2018-02-08 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/125/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Thu, 08 Feb 2018 20:51:57 + Build duration: 14 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.7 - Build # 124 - Still Unstable!

2018-02-08 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.7/124/ Project: Frameworks kio kf5-qt5 SUSEQt5.7 Date of build: Thu, 08 Feb 2018 20:55:38 + Build duration: 10 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 104 - Still Unstable!

2018-02-08 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/104/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Thu, 08 Feb 2018 20:36:54 + Build duration: 6 min 6 sec and counting JUnit Tests Name:

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 105 - Still Unstable!

2018-02-08 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/105/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Thu, 08 Feb 2018 20:43:09 + Build duration: 5 min 53 sec and counting JUnit Tests Name:

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.7 - Build # 123 - Still Unstable!

2018-02-08 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.7/123/ Project: Frameworks kio kf5-qt5 SUSEQt5.7 Date of build: Thu, 08 Feb 2018 20:36:54 + Build duration: 18 min and counting JUnit Tests Name: (root)

D10124: Faster simplejob start

2018-02-08 Thread Jaime Torres Amate
jtamate updated this revision to Diff 26787. jtamate added a comment. Removed the private slots. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10124?vs=26239=26787 BRANCH master REVISION DETAIL https://phabricator.kde.org/D10124 AFFECTED FILES

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 107 - Still Unstable!

2018-02-08 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/107/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Thu, 08 Feb 2018 21:20:14 + Build duration: 5 min 48 sec and counting JUnit Tests Name:

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 126 - Still Unstable!

2018-02-08 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/126/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Thu, 08 Feb 2018 21:06:37 + Build duration: 18 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 106 - Still Unstable!

2018-02-08 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/106/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Thu, 08 Feb 2018 20:52:54 + Build duration: 6 min 38 sec and counting JUnit Tests Name:

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.7 - Build # 125 - Still Unstable!

2018-02-08 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.7/125/ Project: Frameworks kio kf5-qt5 SUSEQt5.7 Date of build: Thu, 08 Feb 2018 21:20:14 + Build duration: 18 min and counting JUnit Tests Name: (root)

D10358: Repair copying file to VFAT without warnings.

2018-02-08 Thread Jaime Torres Amate
jtamate accepted this revision. jtamate added a comment. This revision is now accepted and ready to land. Even moving to a ntfs filesystem without the rights to change owner doesn't end in an empty file. Very good job. BRANCH silence_vfat_warnings REVISION DETAIL

D10363: [KIO] Add support for XDG_TEMPLATES_DIR in KNewFileMenu

2018-02-08 Thread Marijo Mustac
mmustac added a comment. @dfaure Thank you for your answer :-) As I am still at the beginnings I am really grateful for such constructive and valuable feedback like yours it helps me to become better and improve my code. Regarding your points: First of all I agree that a nice name

D10381: [ToolTipArea] Add "aboutToShow" signal

2018-02-08 Thread Kai Uwe Broulik
broulik created this revision. broulik added a reviewer: Plasma. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. broulik requested review of this revision. REVISION SUMMARY This is emitted just before the tooltip is

D10363: [KIO] Add support for XDG_TEMPLATES_DIR in KNewFileMenu

2018-02-08 Thread Marijo Mustac
mmustac updated this revision to Diff 26753. mmustac added a comment. Addressed the mentioned issues. F5698366: Screenshot_20180208_103832.png REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10363?vs=26702=26753

D10363: [KIO] Add support for XDG_TEMPLATES_DIR in KNewFileMenu

2018-02-08 Thread Marijo Mustac
mmustac marked 6 inline comments as done. mmustac added inline comments. INLINE COMMENTS > dfaure wrote in knewfilemenu.cpp:904 > the 2nd arg isn't necessary, just do line.mid(19) It is because we need to get rid of the " before and at the end of the path. REPOSITORY R241 KIO REVISION

D9446: WIP: Allow to autogenerate and install categories file

2018-02-08 Thread Laurent Montel
mlaurent abandoned this revision. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D9446 To: mlaurent, kfunk, lbeltrame, cgiboudeaux, dfaure, fvogt Cc: #frameworks, #build_system, michaelh, ngraham

D10390: Add vokoscreen to KMoreTools and add it to the "screenrecorder" grouping

2018-02-08 Thread gregormi
gregormi added a comment. Screenshot of test program: F5698743: grafik.png . One can see the new item. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D10390 To: gregormi, ngraham Cc: #frameworks, michaelh, ngraham

D10390: Add vokoscreen to KMoreTools and add it to the "screenrecorder" grouping

2018-02-08 Thread Nathaniel Graham
ngraham added a reviewer: apol. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D10390 To: gregormi, ngraham, apol Cc: #frameworks, michaelh, ngraham

D10378: Deprecate KFileItemList and introduce KFileItemListV2

2018-02-08 Thread Mark Gaiser
markg added a comment. Based on the comment you made in https://phabricator.kde.org/D10380 it's logical that this commit won't make it as it currently is implemented. The using line is probably also not the best option if you want to keep the convenience functions, inheriting would be

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 121 - Still Unstable!

2018-02-08 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/121/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Thu, 08 Feb 2018 12:08:17 + Build duration: 12 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 101 - Still Unstable!

2018-02-08 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/101/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Thu, 08 Feb 2018 12:08:17 + Build duration: 28 min and counting JUnit Tests Name:

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.7 - Build # 120 - Still Unstable!

2018-02-08 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.7/120/ Project: Frameworks kio kf5-qt5 SUSEQt5.7 Date of build: Thu, 08 Feb 2018 12:08:17 + Build duration: 45 min and counting JUnit Tests Name: (root)

D10341: Allow move semantics to be generated for KFileItem. The existing copy constructor, destructor and copy assignment operator are now also generated by the compiler.

2018-02-08 Thread Mark Gaiser
This revision was automatically updated to reflect the committed changes. Closed by commit R241:80ccfabb06ff: Allow move semantics to be generated for KFileItem. The existing copy… (authored by markg). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE