Call For Participation: Akademy Config Workshop

Dear KDE community, a friendly call for participation for the Config Workshop [0] at the Akademy in Room 125 on Tuesday 14th August from 10:30-12:30, then lunch together, and then from 14:00-15:00. If you want to participate, with or without a short talk (3 to 10 minutes about some

D14401: Don't instantiate a QStringRef into a QString only to search in a QStringList

aacid accepted this revision. aacid added a comment. This revision is now accepted and ready to land. Does this really make a difference? Also... fix qt to get QStringList::containst(QStringRef)? REPOSITORY R235 Attica BRANCH master REVISION DETAIL

D13805: Present error dialog when user tries to create directory named "." or ".."

ngraham added a comment. @elvisangelaccio? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D13805 To: tmarshall, #dolphin, #frameworks, ngraham, dfaure, elvisangelaccio Cc: cfeck, elvisangelaccio, dfaure, tmarshall, bruns, ngraham, kde-frameworks-devel, michaelh,

D14345: Give the PlasmaComponents3 TextField the ability to have a Clear button

safaalfulaij added a comment. Great! Now I know why the port to PC3 didn't start :D Now to the patch. First, by this we will allow the user to get text under the icon, which will be impossible to read. Second is what I'm here for :) The clear button placement and icon should not follow

D14360: Remove custom icon selection for trash

shubham updated this revision to Diff 38524. shubham added a comment. Creating m_iconButton only for entries other than TRASH REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14360?vs=38468=38524 REVISION DETAIL https://phabricator.kde.org/D14360 AFFECTED

D14360: Remove custom icon selection for trash

pino requested changes to this revision. pino added a comment. This revision now requires changes to proceed. It is a good start, but not enough: - `m_iconButton` must be set to null in the constructor (ideally at the beginning, in the initializer list), otherwise it will be

D14274: Modelines: add byte-order-mark & small fixes

nibags updated this revision to Diff 38477. nibags added a comment. - Delete update references REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14274?vs=38201=38477 BRANCH fix-modelines REVISION DETAIL https://phabricator.kde.org/D14274

D14302: Don't block forever in ensureKdeinitRunning

jtamate added a comment. Qt 5.11.0 and frameworks 5.46.0 over xcb. I'm sorry, I'll have to wait until the next lock, I didn't find the lock file neither the blocked kdeinit5. Is the complete name of the lock file be logged with qCDebug() ?. Just after killing dolphin yesterday afternoon

D14270: CoffeeScript: fix templates in embedded JavaScript code & add escapes

nibags updated this revision to Diff 38476. nibags added a comment. - Increase file version (to 6). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14270?vs=38194=38476 BRANCH jsemb-coffeescript REVISION DETAIL

D12945: kcoredirlister lstItems benchmark

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12945 To: jtamate, dfaure, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13743: Migrate build system to use find_package in autotests/ki18n_install

apol added a comment. Looks good to me, I don't really see why it's better though... Actually calling find_package on KF5I18n will define twice the targets such as KF5::I18n, I'm not sure this will even work alright. REPOSITORY R249 KI18n REVISION DETAIL

D14395: [KSambaShare] Check file that's changed before reloading

broulik created this revision. broulik added reviewers: Frameworks, dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY We use the `KDirWatch` singleton so we

D14397: Port audio notification to libcanberra

broulik created this revision. broulik added reviewers: Frameworks, dfaure, davidedmundson, sitter, drosca, kfunk, rjvbb. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION

D6513: Add support for Attica tags support

mlaurent requested changes to this revision. mlaurent added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > entryinternal.cpp:495 > if (reader.name() != QLatin1String("stuff")) { > -qWarning() << "Parsing Entry from invalid XML"; > +

D6513: Add support for Attica tags support

leinir updated this revision to Diff 38489. leinir marked 4 inline comments as done. leinir added a comment. Address ahiemstra's comments REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6513?vs=37047=38489 REVISION DETAIL

D14395: [KSambaShare] Check file that's changed before reloading

lbeltrame added a comment. +1 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14395 To: broulik, #frameworks, dfaure Cc: lbeltrame, kde-frameworks-devel, michaelh, ngraham, bruns

D14397: Port audio notification to libcanberra

sitter added a comment. Canberra's primary advantage over phonon is that it can directly use pulseaudio/alsa, bypassing the entire sound system middleware madness and leveraging PA's builtin caching mechanism. i.e. if a sound notification is played a bunch of times it will be cached

D14360: Remove custom icon selection for trash

shubham added a reviewer: dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14360 To: shubham, ngraham, broulik, #dolphin, #frameworks, dfaure Cc: pino, kde-frameworks-devel, michaelh, ngraham, bruns

D6513: Add support for Attica tags support

leinir marked 7 inline comments as done. leinir added inline comments. INLINE COMMENTS > ahiemstra wrote in atticaprovider.cpp:283 > Wouldn't it be simpler to first check if the content should be considered at > all, and then check if one of the downloads is valid? So something like: > >

D14397: Port audio notification to libcanberra

rjvbb added a comment. > We probably lose the ability to play sound on Windows and Mac? Does libcanberra (still) require pulseaudio or can it work with different backends? It not, a move to using it exclusively for sound would get a big fat -1 from me. Pulseaudio is problematic on

D14397: Port audio notification to libcanberra

broulik added a comment. > Does libcanberra (still) require pulseaudio or can it work with different backends? According to its website "It comes with several backends (ALSA, PulseAudio, OSS, GStreamer, null)" REPOSITORY R289 KNotifications REVISION DETAIL

D14397: Port audio notification to libcanberra

rjvbb added a comment. > - gstreamer is technically x-platform, whether one actually wants to attempt building and using it on these platforms is another question I suppose Gstreamer builds and functions on Mac, but AFAIK comes with a whole bunch of dependencies to install and run.

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.9 - Build # 68 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.9/68/ Project: Frameworks purpose kf5-qt5 SUSEQt5.9 Date of build: Thu, 26 Jul 2018 11:05:39 + Build duration: 6 min 30 sec and counting JUnit Tests Name:

D13819: dummy commit to test pre-review CI

Harbormaster failed remote builds in B1215: Diff 38500! REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D13819 To: bshah Cc: jenkins-ci, kde-frameworks-devel, michaelh, ngraham, bruns

D14397: Port audio notification to libcanberra

rjvbb added a comment. That's a nicety, not necessarily a requirement, at least not for playing notification sounds. Just how often do you get sound alerts at such high rates that caching becomes unavoidable, before you get mad and resolve the issue or yank the plug? I think that proper

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.9 - Build # 67 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.9/67/ Project: Frameworks purpose kf5-qt5 SUSEQt5.9 Date of build: Wed, 25 Jul 2018 03:34:35 + Build duration: 1 day 7 hr and counting JUnit Tests Name:

D14341: if an applet is invalid, it has immediately UiReadyConstraint

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. you have typos in the comment and commit message REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D14341 To:

D14397: Port audio notification to libcanberra

rjvbb added a comment. Anyway, if using QtMultiMedia cannot be considered please make it a build option to use just QApplication::beep() for sound notifications so that packagers can decide whether or not they want to introduce dependencies on libcanberra and everything it needs. On Mac at

D14341: if an applet is invalid, it has immediately UiReadyConstraint

This revision was automatically updated to reflect the committed changes. Closed by commit R242:56f0df412713: if an applet is invalid, it has immediately UiReadyConstraint (authored by mart). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D14341?vs=38352=38497#toc REPOSITORY R242

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 189 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/189/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 Date of build: Thu, 26 Jul 2018 11:10:57 + Build duration: 6 min 8 sec and counting

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.10 - Build # 39 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.10/39/ Project: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.10 Date of build: Thu, 26 Jul 2018 11:10:57 + Build duration: 5 min 34 sec and counting

D14397: Port audio notification to libcanberra

rjvbb added a comment. > According to its website "It comes with several backends (ALSA, PulseAudio, OSS, GStreamer, null)" Which are all either Linux-specific or *nix-desktop oriented with ties to X11 and probably even GTk. Justifying a change with loss of weight while at the

D14401: Don't instantiate a QStringRef into a QString only to search in a QStringList

apol created this revision. apol added reviewers: leinir, whiting. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY It's just not overloaded by QStringList, so we keep a

D13819: dummy commit to test pre-review CI

bshah updated this revision to Diff 38500. bshah added a comment. - change REPOSITORY R243 KArchive CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13819?vs=37574=38500 BRANCH bshah REVISION DETAIL https://phabricator.kde.org/D13819 AFFECTED FILES CMakeLists.txt To:

D14400: Fix Mixed to Upper mode latching in Aztec code generation

vkrause created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY This breaks generating valid UIC 918.3 train tickets. REPOSITORY R280 Prison BRANCH

D14341: if an applet is invalid, it has immediately UiReadyConstraint

mart edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D14341 To: mart, #plasma, davidedmundson Cc: davidedmundson, kde-frameworks-devel, michaelh, ngraham, bruns

D14397: Port audio notification to libcanberra

sitter added a comment. In D14397#298420 , @rjvbb wrote: > I didn't think of this before, but do you actually need a 3rd party library for playing alert sounds? In D14397#298350 , @sitter

D14397: Port audio notification to libcanberra

sitter added a comment. In D14397#298420 , @rjvbb wrote: > > According to its website "It comes with several backends (ALSA, PulseAudio, OSS, GStreamer, null)" > > Which are all either Linux-specific or *nix-desktop oriented with ties to

D14395: [KSambaShare] Check file that's changed before reloading

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Well spotted. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14395 To: broulik, #frameworks, dfaure Cc: lbeltrame, kde-frameworks-devel, michaelh, ngraham, bruns

D6513: Add support for Attica tags support

leinir updated this revision to Diff 38506. leinir marked an inline comment as done. leinir added a comment. Address mlaurent's comments REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6513?vs=38489=38506 REVISION DETAIL

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 333 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/333/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Thu, 26 Jul 2018 13:08:37 + Build duration: 6 min 7 sec and counting JUnit Tests Name:

D14237: Make Konqi look good in HiDPI

ngraham added a comment. Whatever the size/memory penalty is, I'm not sure we can get around paying it since the vector approach was a no-go. I tried my best to reduce the size of the image as much as possible, at least. REPOSITORY R263 KXmlGui REVISION DETAIL

D14395: [KSambaShare] Check file that's changed before reloading

This revision was automatically updated to reflect the committed changes. Closed by commit R241:a9b4eded78e8: [KSambaShare] Check file thats changed before reloading (authored by broulik). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14395?vs=38479=38508

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.10 - Build # 90 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.10/90/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.10 Date of build: Thu, 26 Jul 2018 13:08:37 + Build duration: 7 min 1 sec and counting JUnit Tests Name:

D14237: Make Konqi look good in HiDPI

broulik added a comment. > If the increased image memory is payed only when the dialog is shown i don't see it as a problem tbh. Well, it's compiled into `.qrc` and potentially shipped for bundled applications? The RAM will be shared, I guess? I don't really know how this qt resource

D6513: Add support for Attica tags support

leinir marked 3 inline comments as done. leinir added inline comments. INLINE COMMENTS > mlaurent wrote in entryinternal.cpp:495 > qCWarning(KNEWSTUFF_CORE) ? I was just adding in a bit of verbosity to the output... but yes, makes sense to fix that while i'm there anyway :) REPOSITORY R304

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 180 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/180/ Project: Frameworks kio kf5-qt5 SUSEQt5.9 Date of build: Thu, 26 Jul 2018 13:08:37 + Build duration: 24 min and counting JUnit Tests Name: (root)

D14397: Port audio notification to libcanberra

ngraham added a comment. Impressive work, Kai! However I rather like the idea of improving QTMultiMedia's sound handling features rather than working around the lack of them by using a different library. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D14397

D14395: [KSambaShare] Check file that's changed before reloading

broulik added a comment. Unlikely REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14395 To: broulik, #frameworks, dfaure Cc: ngraham, lbeltrame, kde-frameworks-devel, michaelh, bruns

D14397: Support libcanberra for audio notification

broulik updated this revision to Diff 38512. broulik retitled this revision from "Port audio notification to libcanberra" to "Support libcanberra for audio notification". broulik edited the test plan for this revision. broulik added a comment. - Keep Phonon as fallback when libcanberra isn't

D14395: [KSambaShare] Check file that's changed before reloading

ngraham added a comment. Could this have fixed https://bugs.kde.org/show_bug.cgi?id=394764? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14395 To: broulik, #frameworks, dfaure Cc: ngraham, lbeltrame, kde-frameworks-devel, michaelh, bruns

D14397: Support libcanberra for audio notification

rjvbb added a comment. > However I rather like the idea of improving QTMultiMedia's sound handling features rather than working around the lack of them by using a different library. Thanks Nathan for rewording my argument better than I managed. > Is there a CMake way to say "one of