D14530: Fix crash when save a QImage to the eps format file

zccrs added a comment. In D14530#301690 , @dfaure wrote: > I don't see much point in this patch, Qt already tells you that a QCoreApplication is missing (as you can see in the bug report). You have to create a QCoreApplication in any Qt

D14661: Force reevaluation of Predicates if interfaces are removed

bruns added a comment. This is an alternative to D13869 REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D14661 To: bruns, #frameworks, broulik, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14661: Force reevaluation of Predicates if interfaces are removed

bruns edited the test plan for this revision. bruns added reviewers: Frameworks, broulik, ngraham. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D14661 To: bruns, #frameworks, broulik, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14663: Give the "invalid directory name" dialog a cancel button

ngraham edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14663 To: ngraham, #vdg, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14640: Use appropriate icon for a cancel button that will ask for a new name

ngraham added a comment. In D14640#304429 , @abetts wrote: > In D14640#304428 , @ngraham wrote: > > > In D14640#304405 , @abetts wrote: > > > > > In

D14663: Give the "invalid directory name" dialog a cancel button

ngraham edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14663 To: ngraham, #vdg, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.10 - Build # 109 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.10/109/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.10 Date of build: Mon, 06 Aug 2018 22:49:49 + Build duration: 12 min and counting JUnit Tests Name:

D14663: Give the "invalid directory name" dialog a cancel button

ngraham created this revision. ngraham added reviewers: VDG, Frameworks. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY Adds a cancel button to the "Invalid

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 199 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/199/ Project: Frameworks kio kf5-qt5 SUSEQt5.9 Date of build: Mon, 06 Aug 2018 22:39:38 + Build duration: 20 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks kio kf5-qt5 WindowsMSVCQt5.10 - Build # 200 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20WindowsMSVCQt5.10/200/ Project: Frameworks kio kf5-qt5 WindowsMSVCQt5.10 Date of build: Mon, 06 Aug 2018 22:39:38 + Build duration: 10 min and counting

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.10 - Build # 108 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.10/108/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.10 Date of build: Mon, 06 Aug 2018 22:30:48 + Build duration: 18 min and counting JUnit Tests Name:

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 354 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/354/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Mon, 06 Aug 2018 22:41:46 + Build duration: 6 min 17 sec and counting JUnit Tests Name:

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 353 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/353/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Mon, 06 Aug 2018 22:30:48 + Build duration: 10 min and counting CONSOLE OUTPUT [...truncated

D14572: Check the build directory for po/ as well

This revision was automatically updated to reflect the committed changes. Closed by commit R249:64796250e69d: Check the build directory for po/ as well (authored by apol). REPOSITORY R249 KI18n CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14572?vs=39196=39233 REVISION DETAIL

KDE CI: Frameworks kio kf5-qt5 WindowsMSVCQt5.10 - Build # 199 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20WindowsMSVCQt5.10/199/ Project: Frameworks kio kf5-qt5 WindowsMSVCQt5.10 Date of build: Mon, 06 Aug 2018 22:30:48 + Build duration: 6 min 5 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 198 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/198/ Project: Frameworks kio kf5-qt5 SUSEQt5.9 Date of build: Mon, 06 Aug 2018 22:30:48 + Build duration: 2 min 28 sec and counting CONSOLE OUTPUT

D14640: Use appropriate icon for a cancel button that will ask for a new name

ngraham closed this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14640 To: ngraham, #frameworks, #vdg, abetts Cc: abetts, broulik, dfaure, kde-frameworks-devel, michaelh, ngraham, bruns

D14632: keyword rule: Spport for keywords inclusion from another language/file

jpoelen added a comment. I just thought of `Definition::keywordLists()` which does not list the keywords used by this new syntax. - Should we add the lists used as and when parsing? - Move the functionality on the tag ``? (``, ` name##language `) - Other? REPOSITORY R216

D14610: Use KLineEdit for folder name if folder has write access, else use QLabel

dfaure added a comment. In D14610#304619 , @rkflx wrote: > In D14610#303987 , @dfaure wrote: > > > Hmm, well, for IconApplet's use case > > > I'd say it would be nice to be consistent

D14662: KPropertiesDialog: switch to label in setFileNameReadOnly(true)

dfaure created this revision. dfaure added reviewers: rkflx, shubham, ngraham. Restricted Application added a project: Frameworks. Restricted Application edited subscribers, added: kde-frameworks-devel; removed: Frameworks. dfaure requested review of this revision. REVISION SUMMARY for

D14632: keyword rule: Spport for keywords inclusion from another language/file

jpoelen edited the summary of this revision. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D14632 To: jpoelen, #framework_syntax_highlighting, cullmann, dhaumann Cc: kwrite-devel, vkrause, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns,

D14643: Bump the minimum logging category to Warning

ltoscano abandoned this revision. ltoscano added a comment. Thanks for confirming. I will work on setting the default to Info for Frameworks components when it's not the case already, and tuning the debug messages. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14643

D14643: Bump the minimum logging category to Warning

dfaure added a comment. In D14643#304608 , @ltoscano wrote: > I was under the impression that we were generally moving towards less chatty components by default, which included having Warning as minimum default level. > Unfortunately I don't

D14572: Check the build directory for po/ as well

dfaure accepted this revision. REPOSITORY R249 KI18n BRANCH arcpatch-D14572 REVISION DETAIL https://phabricator.kde.org/D14572 To: apol, #frameworks, ltoscano, dfaure Cc: dfaure, kde-frameworks-devel, michaelh, ngraham, bruns

D14606: KCrash: DrKonqi cancelled = able to start...

rjvbb added a comment. OK, if no one else cares :) I told you how to reproduce the problem: do whatever it takes to make `cat /proc/sys/kernel/core_pattern` return a pipe command. Without that KCrash appears to think that you won't get a coredump (wrong...) and will exit when DrKonqi

D14606: KCrash: DrKonqi cancelled = able to start...

dfaure added a comment. I never said I don't care, I said: tell me how to reproduce this problem. REPOSITORY R285 KCrash REVISION DETAIL https://phabricator.kde.org/D14606 To: rjvbb, #frameworks, sitter Cc: dfaure, kde-frameworks-devel, michaelh, ngraham, bruns

D14661: Force reevaluation of Predicates if interfaces are removed

bruns created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY If an application wants to show only specicific devices based on predicate matching, and

D14610: Use KLineEdit for folder name if folder has write access, else use QLabel

rkflx added a comment. In D14610#303987 , @dfaure wrote: > Hmm, well, for IconApplet's use case I'd say it would be nice to be consistent everywhere. > I could do it myself, faster than doing 10 reviews :-) No doubt about that,

D14643: Bump the minimum logging category to Warning

ltoscano added a comment. I was under the impression that we were generally moving towards less chatty components by default, which included having Warning as minimum default level. Unfortunately I don't remember anymore how I've got this idea, but I remember some patches setting the

KDE CI: Frameworks kirigami kf5-qt5 AndroidQt5.11 - Build # 63 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20AndroidQt5.11/63/ Project: Frameworks kirigami kf5-qt5 AndroidQt5.11 Date of build: Mon, 06 Aug 2018 16:29:17 + Build duration: 3 min 52 sec and counting

KDE CI: Frameworks kirigami kf5-qt5 SUSEQt5.10 - Build # 246 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20SUSEQt5.10/246/ Project: Frameworks kirigami kf5-qt5 SUSEQt5.10 Date of build: Mon, 06 Aug 2018 16:29:17 + Build duration: 4 min 35 sec and counting JUnit Tests

KDE CI: Frameworks kirigami kf5-qt5 WindowsMSVCQt5.10 - Build # 161 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20WindowsMSVCQt5.10/161/ Project: Frameworks kirigami kf5-qt5 WindowsMSVCQt5.10 Date of build: Mon, 06 Aug 2018 16:29:17 + Build duration: 3 min 13 sec and counting

KDE CI: Frameworks kirigami kf5-qt5 SUSEQt5.9 - Build # 162 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20SUSEQt5.9/162/ Project: Frameworks kirigami kf5-qt5 SUSEQt5.9 Date of build: Mon, 06 Aug 2018 16:29:17 + Build duration: 2 min 11 sec and counting JUnit Tests

KDE CI: Frameworks kirigami kf5-qt5 SUSEQt5.9 - Build # 161 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20SUSEQt5.9/161/ Project: Frameworks kirigami kf5-qt5 SUSEQt5.9 Date of build: Mon, 06 Aug 2018 16:15:56 + Build duration: 1 min 26 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks kirigami kf5-qt5 WindowsMSVCQt5.10 - Build # 160 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20WindowsMSVCQt5.10/160/ Project: Frameworks kirigami kf5-qt5 WindowsMSVCQt5.10 Date of build: Mon, 06 Aug 2018 16:14:36 + Build duration: 1 min 30 sec and counting

KDE CI: Frameworks kirigami kf5-qt5 AndroidQt5.11 - Build # 62 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20AndroidQt5.11/62/ Project: Frameworks kirigami kf5-qt5 AndroidQt5.11 Date of build: Mon, 06 Aug 2018 16:15:29 + Build duration: 39 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks kirigami kf5-qt5 SUSEQt5.9 - Build # 160 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20SUSEQt5.9/160/ Project: Frameworks kirigami kf5-qt5 SUSEQt5.9 Date of build: Mon, 06 Aug 2018 16:12:46 + Build duration: 3 min 8 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks kirigami kf5-qt5 SUSEQt5.10 - Build # 245 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20SUSEQt5.10/245/ Project: Frameworks kirigami kf5-qt5 SUSEQt5.10 Date of build: Mon, 06 Aug 2018 16:14:36 + Build duration: 53 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks kirigami kf5-qt5 AndroidQt5.11 - Build # 61 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20AndroidQt5.11/61/ Project: Frameworks kirigami kf5-qt5 AndroidQt5.11 Date of build: Mon, 06 Aug 2018 16:12:47 + Build duration: 2 min 41 sec and counting CONSOLE

KDE CI: Frameworks kirigami kf5-qt5 WindowsMSVCQt5.10 - Build # 159 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20WindowsMSVCQt5.10/159/ Project: Frameworks kirigami kf5-qt5 WindowsMSVCQt5.10 Date of build: Mon, 06 Aug 2018 16:12:46 + Build duration: 1 min 40 sec and counting

KDE CI: Frameworks kirigami kf5-qt5 SUSEQt5.10 - Build # 244 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20SUSEQt5.10/244/ Project: Frameworks kirigami kf5-qt5 SUSEQt5.10 Date of build: Mon, 06 Aug 2018 16:12:46 + Build duration: 58 sec and counting CONSOLE OUTPUT

D14640: Use appropriate icon for a cancel button that will ask for a new name

abetts added a comment. In D14640#304428 , @ngraham wrote: > In D14640#304405 , @abetts wrote: > > > In D14640#304400 , @ngraham wrote: > > > > > Hmm,

D14640: Use appropriate icon for a cancel button that will ask for a new name

abetts accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH rename-icons (branched from master) REVISION DETAIL https://phabricator.kde.org/D14640 To: ngraham, #frameworks, #vdg, abetts Cc: abetts, broulik, dfaure, kde-frameworks-devel,

D14640: Use appropriate icon for a cancel button that will ask for a new name

ngraham added a comment. In D14640#304405 , @abetts wrote: > In D14640#304400 , @ngraham wrote: > > > Hmm, I'm not sure a cancel button makes sense here because that would end the process of

D14569: Make it possible for ECM to detect po files at configure time

This revision was automatically updated to reflect the committed changes. Closed by commit R240:02881711cfce: Make it possible for ECM to detect po files at configure time (authored by apol). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE

D14572: Check the build directory for po/ as well

ltoscano accepted this revision. ltoscano added a comment. It was basically already approved, and it already made sense. The only requested change (a comment) was applied. REPOSITORY R249 KI18n BRANCH arcpatch-D14572 REVISION DETAIL https://phabricator.kde.org/D14572 To: apol,

D14569: Make it possible for ECM to detect po files at configure time

apol updated this revision to Diff 39197. apol added a comment. Correct version REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14569?vs=38983=39197 BRANCH master REVISION DETAIL https://phabricator.kde.org/D14569 AFFECTED FILES

D14572: Check the build directory for po/ as well

apol updated this revision to Diff 39196. apol added a comment. Added David's recommended comment REPOSITORY R249 KI18n CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14572?vs=38988=39196 BRANCH arcpatch-D14572 REVISION DETAIL https://phabricator.kde.org/D14572 AFFECTED

D14640: Use appropriate icon for a cancel button that will ask for a new name

abetts added a comment. In D14640#304400 , @ngraham wrote: > Hmm, I'm not sure a cancel button makes sense here because that would end the process of creating the folder. If you chose an invalid name, presumably you still want to create the

D14640: Use appropriate icon for a cancel button that will ask for a new name

ngraham added a comment. Hmm, I'm not sure a cancel button makes sense here because that would end the process of creating the folder. If you chose an invalid name, presumably you still want to create the folder. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14640

D14606: KCrash: DrKonqi cancelled = able to start...

rjvbb added a comment. I'd still like that message not to appear if I just dismissed DrKonqi myself. But if no one else care about it I'll just patch the code for myself ... REPOSITORY R285 KCrash REVISION DETAIL https://phabricator.kde.org/D14606 To: rjvbb, #frameworks, sitter Cc:

D14640: Use appropriate icon for a cancel button that will ask for a new name

abetts added a comment. Could the message have 2 buttons? A cancel and an "Enter a different name". That way, if the user inadvertently entered that reserved name can cancel the action still. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14640 To: ngraham,

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 197 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/197/ Project: Frameworks kio kf5-qt5 SUSEQt5.9 Date of build: Mon, 06 Aug 2018 13:58:31 + Build duration: 6 min 15 sec and counting JUnit Tests Name:

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 196 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/196/ Project: Frameworks kio kf5-qt5 SUSEQt5.9 Date of build: Mon, 06 Aug 2018 13:38:06 + Build duration: 20 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.10 - Build # 107 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.10/107/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.10 Date of build: Mon, 06 Aug 2018 13:46:58 + Build duration: 8 min 5 sec and counting JUnit Tests

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 352 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/352/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Mon, 06 Aug 2018 13:48:25 + Build duration: 6 min 56 sec and counting JUnit Tests Name:

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 351 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/351/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Mon, 06 Aug 2018 13:38:06 + Build duration: 10 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.10 - Build # 106 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.10/106/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.10 Date of build: Mon, 06 Aug 2018 13:38:06 + Build duration: 8 min 49 sec and counting JUnit Tests

D14648: Make read-only filenames selectable

This revision was automatically updated to reflect the committed changes. Closed by commit R241:748a65599dd9: Make read-only filenames selectable (authored by ngraham). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14648?vs=39189=39193 REVISION DETAIL

D14650: Use title case for some button labels

This revision was automatically updated to reflect the committed changes. Closed by commit R241:5bdb364b0a02: Use title case for some button labels (authored by ngraham). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14650?vs=39191=39192 REVISION DETAIL

D14648: Make read-only filenames selectable

shubham accepted this revision. shubham added a comment. This revision is now accepted and ready to land. Oh, forgot to do that in R241:e2c56f6ddc517bc4915ab3c84971d17054225c76 . REPOSITORY R241 KIO BRANCH

D14650: Use title case for some button labels

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. Thanks REPOSITORY R241 KIO BRANCH title-case (branched from master) REVISION DETAIL https://phabricator.kde.org/D14650 To: ngraham, broulik, #frameworks Cc: kde-frameworks-devel,

D14640: Use appropriate icon for a cancel button that will ask for a new name

ngraham added inline comments. INLINE COMMENTS > broulik wrote in knewfilemenu.cpp:416 > Also this needs title capitalization [1] > > [1] https://community.kde.org/KDE_Visual_Design_Group/HIG/Capitalization Addressed separately in D14650 . REPOSITORY R241

D14650: Use title case for some button labels

ngraham created this revision. ngraham added reviewers: broulik, Frameworks. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY Use title case for button labels, per

D14640: Use appropriate icon for a cancel button that will ask for a new name

broulik added inline comments. INLINE COMMENTS > knewfilemenu.cpp:416 > KGuiItem cancelGuiItem(KStandardGuiItem::cancel()); > cancelGuiItem.setText(i18nc("@action:button", "Enter a different name")); > +cancelGuiItem.setIcon(QIcon::fromTheme(QStringLiteral("edit-rename"))); Also

D14610: Use KLineEdit for folder name if folder has write access, else use QLabel

ngraham added a comment. Late to the party here, but the read-only label needs to be selectable too. I submitted a patch for that: D14648 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14610 To: shubham, rkflx, dfaure, ngraham Cc:

D14648: Make read-only filenames selectable

ngraham created this revision. ngraham added reviewers: shubham, Frameworks. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY This patch makes read-only filenames (and

D14610: Use KLineEdit for folder name if folder has write access, else use QLabel

ngraham added a task: T9297: Polish file/folder properties dialog. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14610 To: shubham, rkflx, dfaure, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14449: Modify device usage information

ngraham added a task: T9297: Polish file/folder properties dialog. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14449 To: shubham, ngraham, #frameworks, rkflx Cc: pino, rkflx, dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns

D14501: Top-align labels in properties dialog

ngraham added a task: T9297: Polish file/folder properties dialog. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14501 To: rkflx, dhaumann, ngraham, cfeck Cc: cfeck, kde-frameworks-devel, michaelh, ngraham, bruns

D14640: Use appropriate icon for a cancel button that will ask for a new name

ngraham added a comment. Yes indeed, oops. Corrected. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14640 To: ngraham, #frameworks, #vdg Cc: dfaure, kde-frameworks-devel, michaelh, ngraham, bruns

D14640: Use appropriate icon for a cancel button that will ask for a new name

ngraham edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14640 To: ngraham, #frameworks, #vdg Cc: dfaure, kde-frameworks-devel, michaelh, ngraham, bruns

D14162: Figure out the escaped path list on kconfig

apol updated this revision to Diff 39182. apol added a comment. Addressed issues by David and Anthony REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14162?vs=37886=39182 BRANCH master REVISION DETAIL https://phabricator.kde.org/D14162 AFFECTED FILES

D14162: Figure out the escaped path list on kconfig

apol marked 3 inline comments as done. apol added inline comments. INLINE COMMENTS > dfaure wrote in kconfiggroup.cpp:163 > I don't understand why this needs a vector. Isn't this only about consecutive > backslashes? > Wouldn't a counter be enough? We're extracting the whole string and then

D14162: Figure out the escaped path list on kconfig

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kconfigtest.cpp:524 > << "hostname[$e]=$(hostname)" << endl > -<< "noeol=foo"; // no EOL > +<< "noeol=foo" << endl // no

D14606: KCrash: DrKonqi cancelled = able to start...

dfaure added a comment. We only stop printing it at the 4th recursion, I guess just in case that printing itself is the reason for the recursive crash... if (crashRecursionCounter < 4) { fprintf(stderr, "Unable to start Dr. Konqi\n"); } REPOSITORY R285 KCrash REVISION

D14606: KCrash: DrKonqi cancelled = able to start...

rjvbb added a comment. > I don't see why. We try to start drkonqi even the very first time. Yes, you'd print it if you're sure that first time failed (the start function got pid==0). I don't see the point in stopping to print it if you had a crash or two in the crash handler itself

D14606: KCrash: DrKonqi cancelled = able to start...

dfaure added a comment. I don't see why. We try to start drkonqi even the very first time. REPOSITORY R285 KCrash REVISION DETAIL https://phabricator.kde.org/D14606 To: rjvbb, #frameworks, sitter Cc: dfaure, kde-frameworks-devel, michaelh, ngraham, bruns

D14606: KCrash: DrKonqi cancelled = able to start...

rjvbb added a comment. > The crash recursion counter is increased when a SEGV happens inside the crash handler itself. Yeah, that would make sense. But then wouldn't the "unable to start" message have to be printed when the recursion counter is larger than 2? REPOSITORY R285 KCrash

D6512: Add support for proposed tags addition in OCS 1.7

leinir requested review of this revision. REPOSITORY R235 Attica REVISION DETAIL https://phabricator.kde.org/D6512 To: leinir, #knewstuff, apol, whiting, #kde_store, ahiemstra Cc: cfeck, ahiemstra, ngraham, kde-frameworks-devel, #kde_store, michaelh, ZrenBot, bruns, akiraohgaki,

D6512: Add support for proposed tags addition in OCS 1.7

leinir updated this revision to Diff 39175. leinir added a comment. Address comments by cfeck Also mark new public API as @since 5.50 REPOSITORY R235 Attica CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6512?vs=16200=39175 REVISION DETAIL https://phabricator.kde.org/D6512

D6512: Add support for proposed tags addition in OCS 1.7

leinir marked 2 inline comments as done. REPOSITORY R235 Attica REVISION DETAIL https://phabricator.kde.org/D6512 To: leinir, #knewstuff, apol, whiting, #kde_store, ahiemstra Cc: cfeck, ahiemstra, ngraham, kde-frameworks-devel, #kde_store, michaelh, ZrenBot, bruns, akiraohgaki,

D6513: Add support for Attica tags support

leinir updated this revision to Diff 39174. leinir marked 3 inline comments as done. leinir added a comment. Address the various comments by dfaure, cfeck and ngraham - with thanks! REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6513?vs=38506=39174

D6513: Add support for Attica tags support

leinir marked 17 inline comments as done. leinir added inline comments. INLINE COMMENTS > dfaure wrote in engine.cpp:133 > That's out of bounds, if tagFilter is empty!! It will assert. > > You meant append or push_back, I think. i did indeed! > dfaure wrote in engine.cpp:138 > !? What's the

KDE CI: Frameworks kpackage kf5-qt5 AndroidQt5.11 - Build # 9 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20AndroidQt5.11/9/ Project: Frameworks kpackage kf5-qt5 AndroidQt5.11 Date of build: Mon, 06 Aug 2018 09:21:04 + Build duration: 2 min 30 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks kunitconversion kf5-qt5 AndroidQt5.11 - Build # 10 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kunitconversion%20kf5-qt5%20AndroidQt5.11/10/ Project: Frameworks kunitconversion kf5-qt5 AndroidQt5.11 Date of build: Mon, 06 Aug 2018 09:21:02 + Build duration: 43 sec and counting

Re: purpose unittest (AlternativesModelTest::runJobTest) fails randomly

On lundi 6 août 2018 10:52:52 CEST Ben Cooksley wrote: > On Mon, Aug 6, 2018 at 7:27 PM, David Faure wrote: > > On lundi 6 août 2018 01:18:44 CEST Aleix Pol wrote: > >> On Sat, Aug 4, 2018 at 12:31 PM David Faure wrote: > >> > Any idea about this test that fails sometimes? Timing issue? The

Re: purpose unittest (AlternativesModelTest::runJobTest) fails randomly

On Mon, Aug 6, 2018 at 7:27 PM, David Faure wrote: > On lundi 6 août 2018 01:18:44 CEST Aleix Pol wrote: >> On Sat, Aug 4, 2018 at 12:31 PM David Faure wrote: >> > Any idea about this test that fails sometimes? Timing issue? The wait() >> > should be longer in case of slow network? >> > >> >

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 350 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/350/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Mon, 06 Aug 2018 07:57:53 + Build duration: 18 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 195 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/195/ Project: Frameworks kio kf5-qt5 SUSEQt5.9 Date of build: Mon, 06 Aug 2018 07:57:53 + Build duration: 9 min 25 sec and counting JUnit Tests Name:

D14632: keyword rule: Spport for keywords inclusion from another language/file

cullmann added a comment. Great ;) I assume we can handle the missing things during that week for a real switch. ATM the basics already work, there are just some missing extras. (and the color configuration is a mess) If you have some time to take a look at the syntax-highlighting

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.10 - Build # 105 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.10/105/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.10 Date of build: Mon, 06 Aug 2018 07:57:53 + Build duration: 8 min 46 sec and counting JUnit Tests

D14632: keyword rule: Spport for keywords inclusion from another language/file

vkrause added a comment. In D14632#304149 , @cullmann wrote: > Volker, are you at the conference next week? Sure, I'll be there for the entire week. REPOSITORY R216 Syntax Highlighting REVISION DETAIL

D14632: keyword rule: Spport for keywords inclusion from another language/file

dhaumann added a comment. @jpoelen When adding such functionality, could you also also explain in the log message *why* this change is required or useful? I think we should have real-world use cases before integrating this. But in general, looks good. REPOSITORY R216 Syntax Highlighting

D14632: keyword rule: Spport for keywords inclusion from another language/file

cullmann added a comment. I think this needs to wait with merging until we finalized the usage of the syntax-highlighting framework in ktexteditor. Volker, are you at the conference next week? REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D14632 To:

D14610: Use KLineEdit for folder name if folder has write access, else use QLabel

This revision was automatically updated to reflect the committed changes. Closed by commit R241:e2c56f6ddc51: Use KLineEdit for folder name if folder has write access, else use QLabel (authored by shubham). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D14610: Use KLineEdit for folder name if folder has write access, else use QLabel

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. I disagree that it's more readable, but let's not nitpick :-) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14610 To: shubham, rkflx, dfaure, ngraham Cc:

D14610: Use KLineEdit for folder name if folder has write access, else use QLabel

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. (oops, misclicked) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14610 To: shubham, rkflx, dfaure, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14457: Forward-declare X509 structure

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. Can you explain why in the commit log, not just what? The diff tells us what already, but why? I assume this fixes a compilation error? Which one, on which platform? Thanks.

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 194 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/194/ Project: Frameworks kio kf5-qt5 SUSEQt5.9 Date of build: Mon, 06 Aug 2018 07:14:37 + Build duration: 30 min and counting JUnit Tests Name: (root)

  1   2   >