D14940: kformattest: Use plural suffix (s) consequently

habacker added a comment. According to the section'Handling of plurals' on http://doc.qt.io/qt-5/i18n-source-translation.html, for plurals an '(s)' is used instead of the 's' as suffx. You are refering to a different spec ? REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricato

D14938: Force ki18n to build with the libintl.so path

vonreth added a reviewer: Frameworks. REPOSITORY R877 Craft Blueprints for KDE REVISION DETAIL https://phabricator.kde.org/D14938 To: sdepiets, #craft, vonreth, #frameworks Cc: vonreth

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 379 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/379/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Wed, 22 Aug 2018 03:45:41 + Build duration: 8 min 23 sec and counting JUnit Tests Name: (roo

D14237: Make Konqi look good in HiDPI

bruns added a comment. There was some cruft in the file (empty layers, unused definitions ...) F6208866: src_aboutkde.svg REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D14237 To: ngraham, broulik, cfeck, #frameworks, #vdg, br

D14908: Bindings: Add support for scoped enums

bruns planned changes to this revision. bruns added a comment. Ok, then I will update the requirements in the clang check. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D14908 To: bruns, #frameworks Cc: mpyne, kde-frameworks-devel, kde-buildsystem, micha

D14908: Bindings: Add support for scoped enums

mpyne added a comment. As long as older versions of LLVM result in the Python binding generation step being skipped completely (we already check for libclang in the find-package for this, right?), I don't think the dependency increase is a problem. REPOSITORY R240 Extra CMake Modules REV

D14984: Explicitly request Qt 5.7's QtQuick to make use of Connections.enabled

mpyne created this revision. mpyne added reviewers: Frameworks, Plasma, mart. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. mpyne requested review of this revision. REVISION SUMMARY I recently rebuilt my Qt, KF5, and Plasma 5 environments from scratch. I noticed tha

D13627: [KSharedDataCache] Assume lock before flush changes

mpyne accepted this revision. mpyne added a comment. This change has worked fine for me in my testing (including KDE games and Plasma themes) so I think it's fine to commit. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D13627 To: anthonyfieroni, davidedmundson

D14983: Set breeze as fallback icon theme

aacid created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision. TEST PLAN Ran okular with QT_QPA_PLATFORMTHEME=gtk3 with and without this patch. With icons show up everywhere and looks generally nicer :)

D14971: Combine display OSD icon files and move to plasma icon theme

ngraham added a comment. When I apply this patch and compile and deploy plasma-framework to `/usr/` and then delete the Breeze icons versions, I still don't see the new icons in the switcher. What am I doing wrong? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabr

D14966: Added support for disabling the loading of translations

aacid added a comment. I personally don't think this is the way to go and as said many times think that loading a custom translation for tests like ki18n way does is the way to go. Your issue with that seems to be that it won't work on windows, well then i'd say skip the test on windows

D14967: Disable loading of translations for kformattest, which was not designed with translations

aacid added a comment. I personally don't think this is the way to go and as said many times think that loading a custom translation for tests like ki18n way does is the way to go. Your issue with that seems to be that it won't work on windows, well then i'd say skip the test on windows

D14940: kformattest: Use plural suffix (s) consequently

aacid requested changes to this revision. aacid added a comment. This revision now requires changes to proceed. This is not how plurals for decimals work, they are always in plural. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D14940 To: habacker, aacid Cc: kde

D14978: Add unit test that checks Format data

dhaumann added a comment. The problem likely was that Alerts.xml does not have the indentationBasedFolding attribute set. But it's needed in e.g. Python. dh@eriador:syntax :-) (check-full-formats) $ grep Alerts_indent * alert_indent.xml: coffee.xml: coffee.xml:

D14978: Add unit test that checks Format data

dhaumann updated this revision to Diff 40172. dhaumann added a comment. - Simplify code REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14978?vs=40167&id=40172 BRANCH check-full-formats (branched from master) REVISION DETAIL https://phabric

D14978: Add unit test that checks Format data

cullmann added a comment. Given that hl definition is "eaten" during the include cycle, I guess one can just delete it and directly include the other one. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D14978 To: dhaumann, cullmann, vkrause Cc: kwrite-de

D14978: Add unit test that checks Format data

cullmann added a comment. I think the issue is, that if you have just include rules and a context with include rules, you will skip that one context completely during including. Therefore it is missing in the end result, I assume. REPOSITORY R216 Syntax Highlighting REVISION DETAIL htt

D14978: Add unit test that checks Format data

dhaumann added a comment. Yes: 1. Why don't we see Alert_indent.xml 2. Is Alert_indent.xml still needed with the new KSyntaxHighlighting framework? REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D14978 To: dhaumann, cullmann, vkrause Cc: kwrite-de

D14978: Add unit test that checks Format data

dhaumann added a reviewer: vkrause. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D14978 To: dhaumann, cullmann, vkrause Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, demsking, cullmann, sars, dhaumann

D14978: Add unit test that checks Format data

cullmann added a comment. Still the question is: why is that not seen in includedDefinitions. That hl ist not at all found, thought it is included. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D14978 To: dhaumann, cullmann Cc: kwrite-devel, kde-framewo

D14978: Add unit test that checks Format data

dhaumann added a comment. From kate.git: commit 6c9ee3c58549d6cad46b9a42cf7407d25cdfa62e Author: Joseph Wenninger Date: Thu Sep 17 23:33:39 2009 + I'm temporarily adding an alert highlighting whic

D14978: Add unit test that checks Format data

dhaumann added a comment. Interesting: alert_indent.xml has no rules except one IncludeRules (And I am supposed to be the author?!): REPOSITORY R216 Syntax Highlighting REV

D14978: Add unit test that checks Format data

cullmann added a comment. Btw., the test is a bit easier to read with: // collect all formats, shall be numbered from 1.. QSet formatIds; for (auto d : qAsConst(includedDefs)) { const auto formats = d.formats(); for (const auto format : formats) { // n

D14978: Add unit test that checks Format data

dhaumann added a comment. What fails here is Jira.xml: QDEBUG : KSyntaxHighlighting::RepositoryTest::testIncludedFormats() syntaxrepository_test(4584)/(default) ?[31m?[34mKSyntaxHighlighting::RepositoryTest::testIncludedFormats?[0m: QVector(1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14,

D14978: Add unit test that checks Format data

cullmann added a comment. contains 363 Normal Text Alerts_indent is missing. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D14978 To: dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, demsking, cullmann, s

D14978: Add unit test that checks Format data

dhaumann created this revision. dhaumann added a reviewer: cullmann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. dhaumann requested review of this revision. REVISION SUMMARY This unit test loads just one definition including its included

Re: Upcoming reorganisation of the CI system

Hi Ben I don't know if this is on you radar or not, but here goes. I have noticed that quite a few of the KDevelop unittests are failing on the Windows CI. Running the tests locally they work fine. If I look at the output of the failing tests it is similar to that pasted below. Searching broug

D14308: [Exe Thumbnailer] Improve icon selection algorithm

bruns accepted this revision. This revision is now accepted and ready to land. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D14308 To: broulik, #frameworks, dfaure, ngraham, pali, vonreth, antlarr, bruns Cc: bruns

D14952: Fix includedDefinitions, handle definition change in context switch

This revision was automatically updated to reflect the committed changes. Closed by commit R216:612343c96543: handle context switch attributes of the contexts themself (authored by cullmann). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D14952?vs=40067&id=40158#toc REPOSITORY R216 Syn

Re: Upcoming reorganisation of the CI system

On Wed, Aug 22, 2018 at 2:36 AM Morten Volden wrote: > > Hi Ben Hi Morten, > > I don't know if this is on you radar or not, but here goes. > > I have noticed that quite a few of the KDevelop unittests are failing on the > Windows CI. > > Running the tests locally they work fine. > > If I look a

D14971: Combine display OSD icon files and move to plasma icon theme

broulik accepted this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D14971 To: pstefan, ngraham, #vdg, broulik Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D14971: Combine display OSD icon files and move to plasma icon theme

pstefan updated this revision to Diff 40157. pstefan added a comment. - changed osd-sbs-right to osd-sbs-sright REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14971?vs=40156&id=40157 BRANCH master REVISION DETAIL https://phabricator

D14971: Combine display OSD icon files and move to plasma icon theme

pstefan updated this revision to Diff 40156. pstefan added a comment. - Modes OSD files out of video.svgz into osd.svgz. Removed the 64-64- prefix. REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14971?vs=40154&id=40156 BRANCH master R

D11193: Sonnet : use current hunspell API

kfunk added a comment. Please see concerns on https://phabricator.kde.org/R246:0a96acf251baa5c9dd042d093ab2bf8fcee10502 REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D11193 To: rjvbb, #frameworks, dfaure, mlaurent, vkrause Cc: kfunk, kde-frameworks-devel, michaelh,

D14971: Combine display OSD icon files and move to plasma icon theme

broulik requested changes to this revision. broulik added a comment. This revision now requires changes to proceed. File looking good, not really a fan of the new thin lined icon style, but the file must be named `osd.svgz` (Plasma always uses the part before the first hyphen for lookup) REP

D14971: Combine display OSD icon files and move to plasma icon theme

pstefan updated this revision to Diff 40154. pstefan added a comment. - Reverse name change REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14971?vs=40143&id=40154 BRANCH master REVISION DETAIL https://phabricator.kde.org/D14971 AFF

Re: Upcoming reorganisation of the CI system

Hi all, Final call for objections or queries for this change - i'll be looking to roll this out this weekend. Note: Plasma and KDevelop, i'm not subscribed to your lists so please ensure i'm in CC for any responses. Cheers, Ben

D14946: [DialogShadows] Use 0 offset for disabled borders on Wayland

davidedmundson added a comment. Yeah, I'm reviewing that now, it just has a lot of maths to get through :) REPOSITORY R242 Plasma Framework (Library) BRANCH wayland-shadows REVISION DETAIL https://phabricator.kde.org/D14946 To: zzag, davidedmundson Cc: kde-frameworks-devel, michaelh,

D14946: [DialogShadows] Use 0 offset for disabled borders on Wayland

zzag added a comment. This change depends on D14783 . I also think that we don't need to attach empty tiles on X11. But it works, the Sliding Popups effect was fixed... So, maybe, that's fine. REPOSITORY R242 Plasma Framework (Library) BRANCH wayl

D14946: [DialogShadows] Use 0 offset for disabled borders on Wayland

zzag updated this revision to Diff 40150. zzag added a comment. "QMarginsF margins = QMarginsF();" => "QMarginsF margins;" REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14946?vs=40044&id=40150 BRANCH wayland-shadows REVISION DETAIL

D14971: Combine display OSD icon files and move to plasma icon theme

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. If we rename the icons, we will need to correspondingly change the OSD code itself to use the new names: https://cgit.kde.org/kscreen.git/tree/kded/qml/OsdSelector.qml#n51

D14971: Combine display OSD icon files and move to plasma icon theme

pstefan updated this revision to Diff 40143. pstefan added a comment. - Moved all OSD icons into video.svgz and renamed some of them. REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14971?vs=40135&id=40143 BRANCH master REVISION DETAIL

D14956: avoid any heap allocation for default constructed Format() as used as "invalid"

This revision was automatically updated to reflect the committed changes. Closed by commit R216:61a401b0e523: avoid any heap allocation for default constructed Format() as used as "invalid" (authored by cullmann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabrica

D14956: avoid any heap allocation for default constructed Format() as used as "invalid"

vkrause accepted this revision. vkrause added a comment. This revision is now accepted and ready to land. Looks good to me, and is indeed a lot less code. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D14956 To: cullmann, vkrause Cc: dhaumann, kwrite-dev

D14956: avoid any heap allocation for default constructed Format() as used as "invalid"

cullmann updated this revision to Diff 40134. cullmann added a comment. Simpler variant with shared default FormatPrivate. REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14956?vs=40073&id=40134 REVISION DETAIL https://phabricator.kde.org/D149

D14952: Fix includedDefinitions, handle definition change in context switch

cullmann reopened this revision. cullmann added a comment. This revision is now accepted and ready to land. I got told that I missed some more ContextSwitch variants. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D14952 To: cullmann, vkrause, dhaumann Cc

D14956: avoid any heap allocation for default constructed Format() as used as "invalid"

cullmann added a comment. Hmm, if we go that route, what to do in: REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D14956 To: cullmann, vkrause Cc: dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, demsking, cullmann, sa

D14946: [DialogShadows] Use 0 offset for disabled borders on Wayland

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH wayland-shadows REVISION DETAIL https://phabricator.kde.org/D14946 To: zzag, davidedmundson Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D10937: Retouching of Screen Layout Selection OSD Icons

pstefan abandoned this revision. pstefan added a comment. Moved to D14971 REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D10937 To: pstefan, #breeze, ngraham Cc: gladhorn, broulik, bruns, #vdg, kde-frameworks-devel, emateli,

D14971: Combine display OSD icon files and mobe to plasma icon theme

pstefan edited the summary of this revision. pstefan added reviewers: ngraham, VDG. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D14971 To: pstefan, ngraham, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14971: Combine display OSD icon files and move to plasma icon theme

pstefan retitled this revision from "Combine display OSD icon files and mobe to plasma icon theme" to "Combine display OSD icon files and move to plasma icon theme". REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D14971 To: pstefan, ngraham, #vdg Cc:

D14971: Combine display OSD icon files and mobe to plasma icon theme

pstefan created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. pstefan requested review of this revision. REVISION SUMMARY Move the icons from [D10937 ] to plasma-frameworks and combine all the sizes TEST

D14927: KConfig: handle directory symlinks correctly.

adridg added a comment. Sorry, this is getting very confusing: - when running all tests, unpatched: testDelete and testThreads fail - when running all tests, patched: testDefaults fails I suspect there are some more missing canonicalizations, but I don't have time right now to go h

D14308: [Exe Thumbnailer] Improve icon selection algorithm

broulik updated this revision to Diff 40131. broulik added a comment. - Update wording REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14308?vs=39645&id=40131 REVISION DETAIL https://phabricator.kde.org/D14308 AFFECTED FILES thumbnail/icoutils_commo

D14779: Fix 'kformattest fails with installed kcoreaddons language package'

habacker abandoned this revision. habacker added a comment. superseeded by D14967 (tried to updated this review with arc diff, but forgot to add the annoying --verbatim argument to let phabricator know that I have a changed commit message :-/) REPOSITORY

D14967: Disable loading of translations for kformattest, which was not designed with translations

habacker created this revision. habacker added reviewers: dfaure, aacid. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. habacker requested review of this revision. REVISION SUMMARY Required reviews: D14940 D14966

D14966: Added support for disabling the loading of translations

habacker created this revision. habacker added reviewers: aacid, dfaure. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. habacker requested review of this revision. REVISION SUMMARY With this commit ecm_create_qm_loader() creates

D14779: Fix 'kformattest fails with installed kcoreaddons language package'

habacker added a comment. In D14779#311871 , @habacker wrote: > Thanks for this pointer - with this setting the german translation is not fetched anymore. A further look into the windows implementation of the qm loader part (https://cgit

D14956: avoid any heap allocation for default constructed Format() as used as "invalid"

cullmann added a comment. That looks much nicer an avoids the !d checks, which are tedious. I think the one ref count change is no issue, at least that is orders of magnitude better than some malloc on Windows :) I will adapt the patch. REPOSITORY R216 Syntax Highlighting REVISIO