D15072: [server] Abort drag start on correct conditions and without posting error

romangg added a comment. I updated the autotest. Note that the old autotest was broken anyway because the wrong pointer button serial was used when the drag was started and by that aborted in SeatInterface. The new test fails on `testDragInternally` with: QFATAL :

D7010: KSqueezedTextLabel: call updateGeometry() when text changes

dfaure accepted this revision. dfaure added a comment. Makes sense to me, actually. A unittest is difficult to write but an interactive test program would be an easy way to see the difference that this makes. Henrik: everything OK? I see you unsubscribed from a number of phabricator

Re: KDE CI: Frameworks kservice kf5-qt5 WindowsMSVCQt5.10 - Build # 41 - Still unstable!

On Sun, Aug 26, 2018 at 12:00 AM David Faure wrote: > > On vendredi 24 août 2018 14:00:12 CEST Ben Cooksley wrote: > > > > I guess this is something the CI tooling will need to be handling? > > > > > > I'm confused, because surely something has been done already, no? > > > Any lookup done by lib

D15072: [server] Abort drag start on correct conditions and without posting error

romangg created this revision. romangg added a reviewer: KWin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. romangg requested review of this revision. REVISION SUMMARY A drag start request should be dismissed when the client does not have an implicit

D9987: Lessen log spam by not checking for existence of file with empty name

rkflx abandoned this revision. Herald added a subscriber: kde-frameworks-devel. REPOSITORY R303 KInit REVISION DETAIL https://phabricator.kde.org/D9987 To: rkflx, #frameworks Cc: kde-frameworks-devel, dhaumann, michaelh, ngraham, bruns

D14912: Bindings: Make generator forward compatible with Python 3

arojas added a comment. Python3 still can't be used after this change: python2 is explicitely required at FindPythonModuleGeneration.cmake:177 (and all subsequent calls to sip_generator.py are done with ${GPB_PYTHON2_COMMAND}). This can be adjusted in another review though. REPOSITORY

D13906: add missing include

This revision was automatically updated to reflect the committed changes. Closed by commit R286:9ba0d27ef263: add missing include (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13906?vs=37210=40405 REVISION DETAIL

D15074: [server] Do not try to create data offers without source

romangg created this revision. romangg added a reviewer: KWin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. romangg requested review of this revision. REVISION SUMMARY An internal drag is without data source. Still we tried to create offers. TEST PLAN

Re: KDE CI: Frameworks kservice kf5-qt5 WindowsMSVCQt5.10 - Build # 41 - Still unstable!

On vendredi 24 août 2018 14:00:12 CEST Ben Cooksley wrote: > > > I guess this is something the CI tooling will need to be handling? > > > > I'm confused, because surely something has been done already, no? > > Any lookup done by lib code has to find the files installed by that lib. > > I know we

D15072: [server] Abort drag start on correct conditions and without posting error

romangg updated this revision to Diff 40406. romangg added a comment. - Update autotest REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15072?vs=40403=40406 BRANCH startDragAbortFix REVISION DETAIL https://phabricator.kde.org/D15072 AFFECTED FILES

D15072: [server] Abort drag start on correct conditions and without posting error

romangg edited the test plan for this revision. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D15072 To: romangg, #kwin Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14940: kformattest: Use plural suffix (s) consequently

habacker added a comment. https://forum.wordreference.com/threads/decimals-plural-singular.2054431/#post-10279600 listed many public organisations that are using signular for values between 1 and -1. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D14940 To:

D9987: Lessen log spam by not checking for existence of file with empty name

dhaumann added a subscriber: dfaure. dhaumann added a comment. @rkflx I think this patch is definitely good enough to not let it go. @dfaure Can you give another +1? REPOSITORY R303 KInit REVISION DETAIL https://phabricator.kde.org/D9987 To: rkflx, #frameworks Cc: dfaure,

D14912: Bindings: Make generator forward compatible with Python 3

bruns added a comment. In D14912#315093 , @arojas wrote: > Python3 still can't be used after this change: python2 is explicitely required at FindPythonModuleGeneration.cmake:177 (and all subsequent calls to sip_generator.py are done with

D15081: replace own wildcard matcher with QRegularExpression combining all wildcards add validator to index tool, only ? and * wildcard stuff is valid fix some syntax files that had e.g. , instead of

cullmann updated this revision to Diff 40429. cullmann added a comment. improve definitionForName code, already for matching take into account the priority that saves some matching time and avoid later sorting REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE

KDE CI: Frameworks syndication kf5-qt5 WindowsMSVCQt5.11 - Build # 1 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20syndication%20kf5-qt5%20WindowsMSVCQt5.11/1/ Project: Frameworks syndication kf5-qt5 WindowsMSVCQt5.11 Date of build: Sat, 25 Aug 2018 15:28:15 + Build duration: 2 min 22 sec and counting

KDE CI: Frameworks syndication kf5-qt5 FreeBSDQt5.11 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20syndication%20kf5-qt5%20FreeBSDQt5.11/1/ Project: Frameworks syndication kf5-qt5 FreeBSDQt5.11 Date of build: Sat, 25 Aug 2018 15:28:14 + Build duration: 1 min 1 sec and counting

D15071: Don't draw frames and shadows around images with transparency

ngraham added a comment. @markg I'm in favor of keeping the conditional logic for the frames. If we think of this from an aesthetic point of view, we should draw frames and shadows around images that actually look better as a result. Those would be square and rectangular images with no

D15081: replace own wildcard matcher with QRegularExpression combining all wildcards add validator to index tool, only ? and * wildcard stuff is valid fix some syntax files that had e.g. , instead of

cullmann added a comment. Rational for the static convertExtensionsToRegularExpression method: Allows to nice unit tests + allows e.g. KTextEditor to use that later, too, as replacement for its own copy of the wildcard matcher code for the modelines. REPOSITORY R216 Syntax Highlighting

KDE CI: Frameworks syndication kf5-qt5 SUSEQt5.10 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20syndication%20kf5-qt5%20SUSEQt5.10/1/ Project: Frameworks syndication kf5-qt5 SUSEQt5.10 Date of build: Sat, 25 Aug 2018 15:28:12 + Build duration: 5 min 0 sec and counting JUnit Tests

D15071: Don't draw frames and shadows around images with an alpha channel

ngraham edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15071 To: ngraham, #frameworks, #dolphin, #vdg, broulik, cfeck Cc: abetts, bruns, kde-frameworks-devel, michaelh, ngraham

KDE CI: Frameworks syndication kf5-qt5 WindowsMSVCQt5.11 - Build # 2 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20syndication%20kf5-qt5%20WindowsMSVCQt5.11/2/ Project: Frameworks syndication kf5-qt5 WindowsMSVCQt5.11 Date of build: Sat, 25 Aug 2018 16:07:20 + Build duration: 2 min 30 sec and counting

D15000: Display mounted file system type and mounted from fields in properties dialog

shubham added a comment. ping? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15000 To: shubham, dfaure, broulik, ngraham Cc: ngraham, broulik, kde-frameworks-devel, michaelh, bruns

D14912: Bindings: Make generator forward compatible with Python 3

bruns added a dependent revision: D14914: Bindings: Use python version matching the found clang python module. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D14912 To: bruns, #frameworks Cc: arojas, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham,

D14914: Bindings: Use python version matching the found clang python module

bruns added a dependency: D14912: Bindings: Make generator forward compatible with Python 3. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D14914 To: bruns, #frameworks Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D15071: Don't draw frames and shadows around images with transparency

ngraham retitled this revision from "Don't draw frames and shadows around images with an alpha channel" to "Don't draw frames and shadows around images with transparency". REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15071 To: ngraham, #frameworks, #dolphin, #vdg,

D15081: replace own wildcard matcher with QRegularExpression combining all wildcards

cullmann updated this revision to Diff 40435. cullmann added a comment. avoid to use capture groups REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15081?vs=40429=40435 BRANCH master REVISION DETAIL https://phabricator.kde.org/D15081

D13643: Add LabPlot project file icon

ngraham added a comment. Whoops, sorry this was missed. I can merge it for you, since it looks great! In order to do this, I'll need to know your real name and preferred email address. Can you tell me those? REPOSITORY R266 Breeze Icons REVISION DETAIL

D15081: replace own wildcard matcher with QRegularExpression combining all wildcards

cullmann added a comment. As Sebastian agreed to MIT, we can think about this after the 5.50 release. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D15081 To: cullmann, vkrause, dhaumann Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew,

D15071: Don't draw frames and shadows around images with transparency

markg added a comment. (repost from D15069 ) Hi Nate, I'm afraid this will give inconsistent frames, at least that will be the perception of the user. The hasAlpha function on a QPixmap (probably) boils down to executing this function:

D15071: Don't draw frames and shadows around images with transparency

ngraham edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15071 To: ngraham, #frameworks, #dolphin, #vdg, broulik, cfeck Cc: markg, abetts, bruns, kde-frameworks-devel, michaelh, ngraham

D15081: replace own wildcard matcher with QRegularExpression combining all wildcards add validator to index tool, only ? and * wildcard stuff is valid fix some syntax files that had e.g. , instead of

cullmann created this revision. cullmann added reviewers: vkrause, dhaumann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. cullmann requested review of this revision. REVISION SUMMARY ...will never match as it tried to match the file path

D15071: Don't draw frames and shadows around images with an alpha channel

bruns added a comment. I think this is welcome. Nate, can you prepare a pair of screenshots where you have one icon per type (SVG, PNG, PNG+alpha, JPEG, ...), giving each file a speaking name? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15071 To: ngraham,

D13643: Add LabPlot project file icon

mtrescott added a comment. Bump. Please, can someone merge this? For all that I read on Planet KDE about "streamlined onboarding of contributors" nothing has happened here. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D13643 To: mtrescott, #labplot, #vdg,

D15081: replace own wildcard matcher with QRegularExpression combining all wildcards add validator to index tool, only ? and * wildcard stuff is valid fix some syntax files that had e.g. , instead of

cullmann updated this revision to Diff 40428. cullmann added a comment. all code is now MIT only non-MIT parts are e.g. some generator scripts for highlighting and many highlighting data files REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE

KDE CI: Frameworks syndication kf5-qt5 SUSEQt5.9 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20syndication%20kf5-qt5%20SUSEQt5.9/1/ Project: Frameworks syndication kf5-qt5 SUSEQt5.9 Date of build: Sat, 25 Aug 2018 15:28:09 + Build duration: 4 min 9 sec and counting JUnit Tests

D15081: replace own wildcard matcher with QRegularExpression combining all wildcards add validator to index tool, only ? and * wildcard stuff is valid fix some syntax files that had e.g. , instead of

dhaumann added a comment. The old wildcard matcher existed for performance reasons. Did you check? PS: When doing review requests, could you please have a nice subject, and not put very long lines into its stead? :-p Especially since this line will also appear in Davids release notes?

D15071: Don't draw frames and shadows around images with an alpha channel

abetts added a comment. I support this 100% REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15071 To: ngraham, #frameworks, #dolphin, #vdg, broulik, cfeck Cc: abetts, bruns, kde-frameworks-devel, michaelh, ngraham

D14938: Force ki18n to build with the libintl.so path

vonreth added a comment. Does anyone know why it prevents the usage of libintl? And if there is a specific reason for that behaviour should we stop providing gettext on mac? REPOSITORY R877 Craft Blueprints for KDE REVISION DETAIL https://phabricator.kde.org/D14938 To: sdepiets,

D15081: replace own wildcard matcher with QRegularExpression combining all wildcards

cullmann added a comment. Some trivial QBenchmark stuff tells QBENCHMARK { m_repo->definitionForFileName(QLatin1String("ksldjfklsdjfkl.c")); m_repo->definitionForFileName(QLatin1String("ksldjfklsdjfkl.sdfdsf"));

D15071: Don't draw frames and shadows around images with an alpha channel

ngraham added a subscriber: markg. ngraham added a comment. @bruns, done. @broulik, @markg I too was concerned about the case of images that have an alpha channel but not actual transparency. I did not actually have any images on my computer that had an alpha channel but no

D15081: replace own wildcard matcher with QRegularExpression combining all wildcards

cullmann retitled this revision from "replace own wildcard matcher with QRegularExpression combining all wildcards add validator to index tool, only ? and * wildcard stuff is valid fix some syntax files that had e.g. , instead of ; and spaces mixed in remove asterisk definition, that..." to

D15081: replace own wildcard matcher with QRegularExpression combining all wildcards

cullmann added a comment. For the accessor: I actually would prefer a const QRegularExpression & as return value, but most other methods use values to hide the internals. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D15081 To: cullmann, vkrause,

D13643: Add LabPlot project file icon

mtrescott added a comment. Sure. Real name: Matthew Trescott Email: matthewtresc...@gmail.com REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D13643 To: mtrescott, #labplot, #vdg, #breeze, ngraham Cc: abetts, asemke, ngraham, kde-frameworks-devel, michaelh,

D13643: Add LabPlot project file icon

ngraham closed this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D13643 To: mtrescott, #labplot, #vdg, #breeze, ngraham Cc: abetts, asemke, ngraham, kde-frameworks-devel, michaelh, bruns

D15084: Change documentation to reflect the real toolchain CMake name

bport created this revision. bport added a reviewer: apol. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. bport requested review of this revision. REPOSITORY R240 Extra CMake Modules BRANCH fix_android_toolchain_documentation

D9987: Lessen log spam by not checking for existence of file with empty name

dfaure added a comment. +2 REPOSITORY R303 KInit REVISION DETAIL https://phabricator.kde.org/D9987 To: rkflx, #frameworks Cc: dfaure, kde-frameworks-devel, dhaumann, michaelh, ngraham, bruns

D15076: Build failures with KSyntaxHighlighting 5.49

mpyne added a comment. I don't know the cause myself but the ECM version works up until 5.38.0 in my own testing. So presumably the change in behavior is something introduced in that release of ECM? REPOSITORY R55 Cantor REVISION DETAIL https://phabricator.kde.org/D15076 To: asemke,

D15081: replace own wildcard matcher with QRegularExpression combining all wildcards

dhaumann added a subscriber: dfaure. dhaumann added a comment. Do you need the public methods in Definition outside of KSyntaxHighlighting? In general: +1 If you want this to be in 5.50, you need to get a +2 from @vkrause and ping @dfaure to retag. INLINE COMMENTS >

D13643: Add LabPlot project file icon

ngraham added a comment. Thanks again for your contribution! Next time, we'll try to be more on the ball about the review. :) REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D13643 To: mtrescott, #labplot, #vdg, #breeze, ngraham Cc: abetts, asemke, ngraham,

D15084: Change documentation to reflect the real toolchain CMake name

alexeymin accepted this revision. alexeymin added a comment. This revision is now accepted and ready to land. Looks harmless and correct REPOSITORY R240 Extra CMake Modules BRANCH fix_android_toolchain_documentation REVISION DETAIL https://phabricator.kde.org/D15084 To: bport, apol,

D15076: Build failures with KSyntaxHighlighting 5.49

mpyne added a comment. The ECM documentation points to a specific change that may be related: https://api.kde.org/ecm/kde-module/KDECMakeSettings.html#build-settings Using the `KDE_SKIP_BUILD_SETTINGS` option that is described just leads to different build failures for me, however. I

D9987: Lessen log spam by not checking for existence of file with empty name

dhaumann added a comment. @rkflx can you please reopen so we can accept this? REPOSITORY R303 KInit REVISION DETAIL https://phabricator.kde.org/D9987 To: rkflx, #frameworks Cc: dfaure, kde-frameworks-devel, dhaumann, michaelh, ngraham, bruns

D15000: Display mounted file system type and mounted from fields in properties dialog

ngraham accepted this revision. ngraham added reviewers: Frameworks, cfeck. ngraham added a comment. This revision is now accepted and ready to land. Works great and looks fine to me, and the code seems sensible too given that this dialog is currently implemented with a GridLayout. I'd like

D15076: Build failures with KSyntaxHighlighting 5.49

cullmann edited reviewers, added: Frameworks; removed: Framework: Syntax Highlighting. cullmann added a comment. Perhaps other frameworks people know the exact cause. REPOSITORY R55 Cantor REVISION DETAIL https://phabricator.kde.org/D15076 To: asemke, #kde_edu, #cantor, #frameworks,

D14449: Modify device usage information

ngraham added a comment. Do you plan to submit a new version of this after the layout has been converted to use `QFormLayout`? I do hope some form of this patch makes it in, since IMHO it's a nice little quality-of-life improvement. REPOSITORY R241 KIO REVISION DETAIL

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 380 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/380/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Sun, 26 Aug 2018 03:38:43 + Build duration: 34 min and counting JUnit Tests Name: (root)

D14449: Modify device usage information

shubham added a comment. In D14449#315524 , @ngraham wrote: > Do you plan to submit a new version of this after the layout has been converted to use `QFormLayout`? I do hope some form of this patch makes it in, since IMHO it's a nice little

KDE CI: Frameworks kio kf5-qt5 WindowsMSVCQt5.11 - Build # 2 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20WindowsMSVCQt5.11/2/ Project: Frameworks kio kf5-qt5 WindowsMSVCQt5.11 Date of build: Sun, 26 Aug 2018 03:38:43 + Build duration: 1 hr 57 min and counting JUnit Tests

KDE CI: Frameworks khtml kf5-qt5 FreeBSDQt5.11 - Build # 2 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20khtml%20kf5-qt5%20FreeBSDQt5.11/2/ Project: Frameworks khtml kf5-qt5 FreeBSDQt5.11 Date of build: Sun, 26 Aug 2018 03:38:33 + Build duration: 17 min and counting

D14449: Modify device usage information

shubham added a comment. You plz proceed on it. Right now working on some other patch. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14449 To: shubham, ngraham, #frameworks, rkflx Cc: pino, rkflx, dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns

D15081: replace own wildcard matcher with QRegularExpression combining all wildcards

cullmann added a comment. I had some more improvement ideas, this can wait a release. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D15081 To: cullmann, vkrause, dhaumann Cc: dfaure, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham,

D14449: Modify device usage information

ngraham added a comment. Great! Are you gonna do the QFormLayout patch, or should I? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14449 To: shubham, ngraham, #frameworks, rkflx Cc: pino, rkflx, dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 225 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/225/ Project: Frameworks kio kf5-qt5 SUSEQt5.9 Date of build: Sun, 26 Aug 2018 03:38:43 + Build duration: 48 min and counting JUnit Tests Name: (root)