D15084: Change documentation to reflect the real toolchain CMake name

apol added a comment. Thanks! REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D15084 To: bport, apol, alexeymin Cc: alexeymin, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D15099: add a new property headerVisible

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R236 KWidgetsAddons BRANCH phab/headerVisible REVISION DETAIL https://phabricator.kde.org/D15099 To: mart, #plasma, #frameworks, davidedmundson Cc: abetts, kde-frameworks-devel, michaelh,

D15089: Add syntax highlighting for SELinux kernel policy language

nibags added a comment. I'll do the commit this week, because I want to do a last test... REPOSITORY R216 Syntax Highlighting BRANCH add-selinux REVISION DETAIL https://phabricator.kde.org/D15089 To: nibags, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel,

D14983: Set breeze as fallback icon theme

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Looks sound to me. REPOSITORY R302 KIconThemes BRANCH master REVISION DETAIL https://phabricator.kde.org/D14983 To: aacid, apol Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D15091: Compile python bindings with the same sipname used by PyQt

arojas added a comment. In D15091#316243 , @rdieter wrote: > I was asking mostly because that's what pyqt upstream strongly suggested (to use all sip_flags) when I asked them. Oh, if upstream recommends it then I guess it should cause no

ECM Behaviour: Setting QT_PLUGIN_PATH on Windows

Hi all, We currently have a severe bug in ECM's AddTest macro due to it's behaviour around the setting of QT_PLUGIN_PATH. On Windows it would appear that the code in ECMAddTest mangles the environment variable, removing crucial paths that the CI system includes within this variable which are

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 205 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/205/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 Date of build: Tue, 28 Aug 2018 09:27:21 + Build duration: 3 min 8 sec and counting

D15021: Workaround bug with native rendering and opacity in TextField text

This revision was automatically updated to reflect the committed changes. Closed by commit R242:2faa71a55a75: Workaround bug with native rendering and opacity in TextField text (authored by davidedmundson). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D15091: Compile python bindings with the same sipname used by PyQt

rdieter added a comment. These 2 threads: https://www.riverbankcomputing.com/pipermail/pyqt/2018-August/040759.html https://www.riverbankcomputing.com/pipermail/pyqt/2018-August/040771.html REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D15091 To:

D15125: Improve skip offset handling, allow to skip full line on no match

vkrause accepted this revision. vkrause added a comment. This revision is now accepted and ready to land. Nice find! And a nice showcase of a contribution we wouldn't have gotten without MIT relicensing I guess :) REPOSITORY R216 Syntax Highlighting REVISION DETAIL

D15125: Improve skip offset handling, allow to skip full line on no match

cullmann created this revision. cullmann added reviewers: vkrause, dhaumann. cullmann added a project: Framework: Syntax Highlighting. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. cullmann requested review of this revision. REVISION

D15127: Fix typos for "Show line count"

shubham created this revision. shubham added reviewers: cullmann, vkrause. shubham added projects: KTextEditor, Frameworks. Herald added a project: Kate. Herald added subscribers: kde-frameworks-devel, kwrite-devel. shubham requested review of this revision. REPOSITORY R39 KTextEditor REVISION

D15127: Fix typos for "Show line count"

shubham updated this revision to Diff 40564. REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15127?vs=40563=40564 REVISION DETAIL https://phabricator.kde.org/D15127 AFFECTED FILES src/dialogs/katedialogs.cpp

D15125: Improve skip offset handling, allow to skip full line on no match

cullmann added a comment. ;=) Yeah, given I can spend now some work-time on profiling things as we start to use the current master for our tools, I hope I can contribute some more things like this. A colleague has seen a massive slow-down compared to our old highlighter for some

D15091: Compile python bindings with the same sipname used by PyQt

arojas planned changes to this revision. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D15091 To: arojas, #frameworks, bruns Cc: rdieter, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D15071: Don't draw frames and shadows around images with transparency

ngraham added a comment. So do we have any firm conclusions here? The current state is already rather broken both conceptually and in practice, as illustrated by the "before" images. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15071 To: ngraham, #frameworks,

D15127: Fix typos for "Show line count"

shubham edited the test plan for this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D15127 To: shubham, cullmann, vkrause Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, demsking, head7, cullmann, kfunk, sars, dhaumann

D15125: Improve skip offset handling, allow to skip full line on no match

This revision was automatically updated to reflect the committed changes. Closed by commit R216:184483443f4f: Improve skip offset handling, allow to skip full line on no match (authored by cullmann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE

D15129: improve performance of Rule::isWordDelimiter and KeywordListRule::doMatch

cullmann updated this revision to Diff 40572. cullmann added a comment. optimize html exporter, 23% => 15% of runtime for applyFormat in unit test REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15129?vs=40571=40572 BRANCH master REVISION

D15127: Fix typos for "Show line count"

shubham added a comment. Going to land this now REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D15127 To: shubham, cullmann, vkrause Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, demsking, head7, cullmann, kfunk, sars, dhaumann

D15127: Fix typos for "Show line count"

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Ok with this. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D15127 To: shubham, cullmann, vkrause Cc: kwrite-devel, kde-frameworks-devel, michaelh,

D14991: Track state acked by XDG Client

davidedmundson abandoned this revision. davidedmundson added a comment. Edit. I need to track in shellclient anyway for positionAfterResize. May as well do it all there REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D14991 To: davidedmundson, #kwin Cc:

D15129: improve performance of Rule::isWordDelimiter and KeywordListRule::doMatch

vkrause accepted this revision. vkrause added a comment. This revision is now accepted and ready to land. Very nice, thank you! REPOSITORY R216 Syntax Highlighting BRANCH master REVISION DETAIL https://phabricator.kde.org/D15129 To: cullmann, vkrause, dhaumann Cc: kwrite-devel,

D15129: improve performance of Rule::isWordDelimiter and KeywordListRule::doMatch

cullmann updated this revision to Diff 40573. cullmann added a comment. add my copyright, too REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15129?vs=40572=40573 BRANCH master REVISION DETAIL https://phabricator.kde.org/D15129 AFFECTED

D15127: Fix typos for "Show line count"

This revision was automatically updated to reflect the committed changes. Closed by commit R39:4c43ab238ec2: Fix typos for Show line count (authored by shubham). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15127?vs=40564=40575 REVISION DETAIL

D15091: Compile python bindings with the same sip flags used by PyQt

arojas updated this revision to Diff 40570. arojas retitled this revision from "Compile python bindings with the same sipname used by PyQt" to "Compile python bindings with the same sip flags used by PyQt". arojas edited the summary of this revision. REPOSITORY R240 Extra CMake Modules

D15129: improve performance of Rule::isWordDelimiter and KeywordListRule::doMatch

cullmann created this revision. cullmann added reviewers: vkrause, dhaumann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. cullmann requested review of this revision. TEST PLAN make && make test before, perf tells for perf

D15129: improve performance of Rule::isWordDelimiter and KeywordListRule::doMatch

cullmann added a comment. And yes, you see even the costs for the auto defData = DefinitionData::get(m_def.definition()); as a high percentage, close to the total costs of KeywordListRule::doMatch now. REPOSITORY R216 Syntax Highlighting REVISION DETAIL

KDE CI: Frameworks kiconthemes kf5-qt5 WindowsMSVCQt5.11 - Build # 2 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kiconthemes%20kf5-qt5%20WindowsMSVCQt5.11/2/ Project: Frameworks kiconthemes kf5-qt5 WindowsMSVCQt5.11 Date of build: Tue, 28 Aug 2018 20:44:55 + Build duration: 2 min 9 sec and counting

D15134: decrease StateData space by more than 50% and half the number of needed mallocs

dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. Lgtm. REPOSITORY R216 Syntax Highlighting BRANCH master REVISION DETAIL https://phabricator.kde.org/D15134 To: cullmann, vkrause, dhaumann Cc: kwrite-devel,

D15134: decrease StateData space by more than 50% and half the number of needed mallocs

cullmann reopened this revision. cullmann added a comment. This revision is now accepted and ready to land. I fixed the tests again by adding the m_defData back. I am not sure, if that really is the right fix. That was like this before, but can't by accident the refData just point again

KDE CI: Frameworks syntax-highlighting kf5-qt5 SUSEQt5.10 - Build # 189 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20syntax-highlighting%20kf5-qt5%20SUSEQt5.10/189/ Project: Frameworks syntax-highlighting kf5-qt5 SUSEQt5.10 Date of build: Tue, 28 Aug 2018 22:30:11 + Build duration: 1 min 33 sec and counting

D14922: Assert if trying to use a KCatalog without a QCoreApplication

aacid closed this revision. REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D14922 To: aacid, dfaure Cc: dfaure, ltoscano, ilic, kde-frameworks-devel, michaelh, ngraham, bruns

D14674: handle non-ASCII encodings of file names in tar archives

aacid closed this revision. REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D14674 To: ibragimovrinat, dfaure, kossebau Cc: xyquadrat, broulik, cfeck, ibragimovrinat, kde-frameworks-devel, michaelh, ngraham, bruns

D15129: improve performance of Rule::isWordDelimiter and KeywordListRule::doMatch

dhaumann added a comment. Very nice. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D15129 To: cullmann, vkrause, dhaumann Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, demsking, cullmann, sars, dhaumann

KDE CI: Frameworks karchive kf5-qt5 SUSEQt5.10 - Build # 37 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20karchive%20kf5-qt5%20SUSEQt5.10/37/ Project: Frameworks karchive kf5-qt5 SUSEQt5.10 Date of build: Tue, 28 Aug 2018 21:50:51 + Build duration: 1 min 6 sec and counting JUnit Tests

KDE CI: Frameworks syntax-highlighting kf5-qt5 SUSEQt5.10 - Build # 188 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20syntax-highlighting%20kf5-qt5%20SUSEQt5.10/188/ Project: Frameworks syntax-highlighting kf5-qt5 SUSEQt5.10 Date of build: Tue, 28 Aug 2018 22:06:45 + Build duration: 1 min 44 sec and counting

D15131: add acronym ASCII to general.entities

lueck created this revision. Herald added projects: Frameworks, Documentation. Herald added subscribers: kde-doc-english, kde-frameworks-devel. lueck requested review of this revision. REVISION SUMMARY 16 hits in trunk l10n-kf5/documentation REPOSITORY R238 KDocTools REVISION DETAIL

D15131: add acronym ASCII to general.entities

ltoscano accepted this revision. This revision is now accepted and ready to land. REPOSITORY R238 KDocTools REVISION DETAIL https://phabricator.kde.org/D15131 To: lueck, ltoscano Cc: kde-frameworks-devel, kde-doc-english, michaelh, ngraham, bruns, skadinna

D14674: handle non-ASCII encodings of file names in tar archives

aacid added a comment. @ibragimovrinat KArchiveTest::testTarShortNonASCIINames is failing both in CI [1] and for me locally 23:54:20 FAIL! : KArchiveTest::testTarShortNonASCIINames() Compared values are not the same 23:54:20Actual (listing.count()): 0 23:54:20Expected (1)

D14674: handle non-ASCII encodings of file names in tar archives

aacid added a comment. @ibragimovrinat ah my fault, arc didn't create the tar.gz file correctly from the diff REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D14674 To: ibragimovrinat, dfaure, kossebau Cc: aacid, xyquadrat, broulik, cfeck, ibragimovrinat,

D15134: decrease StateData space by more than 50% and half the number of needed mallocs

This revision was automatically updated to reflect the committed changes. Closed by commit R216:1508e568d858: decrease StateData space by more than 50% and half the number of needed mallocs (authored by cullmann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE

D14674: handle non-ASCII encodings of file names in tar archives

aacid added a comment. @ibragimovrinat Actually can you please send me that tarball file to aa...@kde.org ? I don't seem to be able to recreate that from the diff file you attached. REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D14674 To: ibragimovrinat, dfaure,

KDE CI: Frameworks syntax-highlighting kf5-qt5 SUSEQt5.9 - Build # 134 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20syntax-highlighting%20kf5-qt5%20SUSEQt5.9/134/ Project: Frameworks syntax-highlighting kf5-qt5 SUSEQt5.9 Date of build: Tue, 28 Aug 2018 22:30:11 + Build duration: 6 min 24 sec and counting

Re: KDE apps have missing icons when not on Breeze

El dijous, 16 d’agost de 2018, a les 15:19:36 CEST, Albert Astals Cid va escriure: > Missatge de Albert Vaca del dia dj., 16 d’ag. 2018 a > les 13:57: > > > Hi everyone, > > > > If we want to reach more potential users, we have to make sure KDE > > apps look properly in every desktop. Take a

D14983: Set breeze as fallback icon theme

aacid closed this revision. REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D14983 To: aacid, apol Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks syntax-highlighting kf5-qt5 SUSEQt5.9 - Build # 133 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20syntax-highlighting%20kf5-qt5%20SUSEQt5.9/133/ Project: Frameworks syntax-highlighting kf5-qt5 SUSEQt5.9 Date of build: Tue, 28 Aug 2018 22:06:45 + Build duration: 4 min 51 sec and counting

D14674: handle non-ASCII encodings of file names in tar archives

kossebau added a comment. Someone still needs to land this in the karchive repo, no? :) @ibragimovrinat I assume this is your first contribution, so you cannot yet push commits yourself, right? For that we will need an email address for the authorship of this patch in the commit, next to

KDE CI: Frameworks karchive kf5-qt5 SUSEQt5.9 - Build # 30 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20karchive%20kf5-qt5%20SUSEQt5.9/30/ Project: Frameworks karchive kf5-qt5 SUSEQt5.9 Date of build: Tue, 28 Aug 2018 21:50:51 + Build duration: 4 min 3 sec and counting JUnit Tests

D15134: decrease StateData space by more than 50% and half the number of needed mallocs

cullmann created this revision. cullmann added reviewers: vkrause, dhaumann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. cullmann requested review of this revision. REVISION SUMMARY less space used by the object itself and only one

KDE CI: Frameworks karchive kf5-qt5 WindowsMSVCQt5.11 - Build # 2 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20karchive%20kf5-qt5%20WindowsMSVCQt5.11/2/ Project: Frameworks karchive kf5-qt5 WindowsMSVCQt5.11 Date of build: Tue, 28 Aug 2018 21:50:51 + Build duration: 2 min 5 sec and counting JUnit

D15134: decrease StateData space by more than 50% and half the number of needed mallocs

cullmann added a comment. I improved the unit tests, too. No need to call diff if the files are really equal, improves testing speed + makes the tests much nicer to use as benchmarks. REPOSITORY R216 Syntax Highlighting BRANCH master REVISION DETAIL

D15134: decrease StateData space by more than 50% and half the number of needed mallocs

cullmann updated this revision to Diff 40584. cullmann added a comment. compare of references works without diff, just missing diff output this avoid spawning processes at all if all tests are fine > nicer to use unit test (as long as they work) for perf

D15129: improve performance of Rule::isWordDelimiter and KeywordListRule::doMatch

This revision was automatically updated to reflect the committed changes. Closed by commit R216:9556855dcf18: improve performance of Rule::isWordDelimiter and KeywordListRule::doMatch (authored by cullmann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE

KDE CI: Frameworks syntax-highlighting kf5-qt5 WindowsMSVCQt5.11 - Build # 14 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20syntax-highlighting%20kf5-qt5%20WindowsMSVCQt5.11/14/ Project: Frameworks syntax-highlighting kf5-qt5 WindowsMSVCQt5.11 Date of build: Tue, 28 Aug 2018 22:06:45 + Build duration: 3 min 34 sec

D15134: decrease StateData space by more than 50% and half the number of needed mallocs

cullmann reopened this revision. cullmann added a comment. This revision is now accepted and ready to land. Hmpf, thought tests did work :P But memory faults are hard. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D15134 To: cullmann, vkrause, dhaumann

D15134: decrease StateData space by more than 50% and half the number of needed mallocs

This revision was automatically updated to reflect the committed changes. Closed by commit R216:2827c4fc89eb: add defData again for valid state check (authored by cullmann). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D15134?vs=40585=40587#toc REPOSITORY R216 Syntax Highlighting

D15136: Fixed a typeo

ssloan created this revision. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. ssloan requested review of this revision. REVISION SUMMARY Fixed a typeo in the index size output BUG: 397843 REPOSITORY R293 Baloo BRANCH bug397843 (branched

D15131: add acronym ASCII to general.entities

This revision was automatically updated to reflect the committed changes. Closed by commit R238:0d36318396e2: add acronym ASCII to general.entities (authored by lueck). REPOSITORY R238 KDocTools CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15131?vs=40578=40597 REVISION DETAIL

KDE CI: Frameworks kdoctools kf5-qt5 SUSEQt5.10 - Build # 53 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kdoctools%20kf5-qt5%20SUSEQt5.10/53/ Project: Frameworks kdoctools kf5-qt5 SUSEQt5.10 Date of build: Wed, 29 Aug 2018 03:41:08 + Build duration: 3 min 50 sec and counting JUnit Tests

D15136: Fixed a typeo

mlaurent accepted this revision. mlaurent added a comment. This revision is now accepted and ready to land. Thanks can you commit it ? Do you have commit access ? REPOSITORY R293 Baloo BRANCH bug397843 (branched from master) REVISION DETAIL https://phabricator.kde.org/D15136 To:

D15136: Fixed a typeo

ssloan added a comment. New to this, so I don’t have commit access. REPOSITORY R293 Baloo BRANCH bug397843 (branched from master) REVISION DETAIL https://phabricator.kde.org/D15136 To: ssloan, mlaurent Cc: mlaurent, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich,

KDE CI: Frameworks kactivities kf5-qt5 FreeBSDQt5.11 - Build # 2 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kactivities%20kf5-qt5%20FreeBSDQt5.11/2/ Project: Frameworks kactivities kf5-qt5 FreeBSDQt5.11 Date of build: Wed, 29 Aug 2018 04:36:32 + Build duration: 50 sec and counting

D15113: Add license text of GPL 2.0, LGPL 2.0 and LGPL 2.1

fvogt created this revision. fvogt added a reviewer: Frameworks. fvogt requested review of this revision. REVISION SUMMARY Missing previously. TEST PLAN git add and commit worked. REPOSITORY R320 KIO Extras BRANCH Applications/18.08 REVISION DETAIL https://phabricator.kde.org/D15113

D15113: Add license text of GPL 2.0, LGPL 2.0 and LGPL 2.1

lbeltrame added a comment. +1 REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D15113 To: fvogt, #frameworks Cc: lbeltrame