D15479: fix for macOS

2018-09-17 Thread Yurii Kolesnykov
yurikoles added a comment. In D15479#325443 , @bcooksley wrote: > Does this still build on Linux systems? I have problems building it under Linux even without a patch. I had tried Arch AUR (kdnssd-git) and Ubuntu 18.10 (cosmic), which

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.9 - Build # 56 - Still Unstable!

2018-09-17 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.9/56/ Project: kf5-qt5 SUSEQt5.9 Date of build: Mon, 17 Sep 2018 22:27:19 + Build duration: 3 min 32 sec and counting JUnit Tests Name: (root)

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.10 - Build # 112 - Still Unstable!

2018-09-17 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.10/112/ Project: kf5-qt5 SUSEQt5.10 Date of build: Mon, 17 Sep 2018 22:27:19 + Build duration: 4 min 7 sec and counting JUnit Tests Name: (root)

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.10 - Build # 107 - Still Unstable!

2018-09-17 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.10/107/ Project: kf5-qt5 SUSEQt5.10 Date of build: Mon, 17 Sep 2018 15:20:47 + Build duration: 1 min 9 sec and counting JUnit Tests Name: (root)

D15576: kcfg_compiler now documents valid inputs for its 'Color' type

2018-09-17 Thread Harald Sitter
This revision was automatically updated to reflect the committed changes. Closed by commit R237:39cdcdf6c1d5: kcfg_compiler now documents valid inputs for its Color type (authored by sitter). REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15576?vs=41837=41849

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.9 - Build # 51 - Still Unstable!

2018-09-17 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.9/51/ Project: kf5-qt5 SUSEQt5.9 Date of build: Mon, 17 Sep 2018 15:20:47 + Build duration: 4 min 48 sec and counting JUnit Tests Name: (root)

KDE CI: Frameworks » kwindowsystem » kf5-qt5 SUSEQt5.10 - Build # 40 - Still Unstable!

2018-09-17 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.10/40/ Project: kf5-qt5 SUSEQt5.10 Date of build: Mon, 17 Sep 2018 23:08:59 + Build duration: 2 min 29 sec and counting JUnit Tests Name:

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 223 - Still Unstable!

2018-09-17 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/223/ Project: kf5-qt5 SUSEQt5.10 Date of build: Mon, 17 Sep 2018 23:11:58 + Build duration: 3 min 2 sec and counting JUnit Tests Name:

D15582: Reference product "KF5" in widget metadata, instead of "KDE"

2018-09-17 Thread Friedrich W. H. Kossebau
kossebau created this revision. kossebau added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REPOSITORY R298 KDesignerPlugin BRANCH kdeiskf5now REVISION DETAIL

D14632: keyword rule: Spport for keywords inclusion from another language/file

2018-09-17 Thread jonathan poelen
jpoelen updated this revision to Diff 41872. jpoelen added a comment. - restore operators list - lazy load keyword lists REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14632?vs=41298=41872 BRANCH kwinclude REVISION DETAIL

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 402 - Unstable!

2018-09-17 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/402/ Project: kf5-qt5 SUSEQt5.10 Date of build: Mon, 17 Sep 2018 22:37:59 + Build duration: 7 min 9 sec and counting JUnit Tests Name: (root) Failed:

KDE CI: Frameworks » kpackage » kf5-qt5 AndroidQt5.11 - Build # 23 - Still Failing!

2018-09-17 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20AndroidQt5.11/23/ Project: kf5-qt5 AndroidQt5.11 Date of build: Mon, 17 Sep 2018 23:02:34 + Build duration: 38 sec and counting CONSOLE OUTPUT [...truncated

KDE CI: Frameworks » kpackage » kf5-qt5 SUSEQt5.9 - Build # 54 - Still Unstable!

2018-09-17 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20SUSEQt5.9/54/ Project: kf5-qt5 SUSEQt5.9 Date of build: Mon, 17 Sep 2018 23:02:34 + Build duration: 1 min 10 sec and counting JUnit Tests Name: (root)

KDE CI: Frameworks » kpackage » kf5-qt5 SUSEQt5.10 - Build # 76 - Still Unstable!

2018-09-17 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20SUSEQt5.10/76/ Project: kf5-qt5 SUSEQt5.10 Date of build: Mon, 17 Sep 2018 23:02:34 + Build duration: 4 min 19 sec and counting JUnit Tests Name: (root)

KDE CI: Frameworks » kwindowsystem » kf5-qt5 SUSEQt5.9 - Build # 28 - Still Unstable!

2018-09-17 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.9/28/ Project: kf5-qt5 SUSEQt5.9 Date of build: Mon, 17 Sep 2018 23:08:59 + Build duration: 2 min 44 sec and counting JUnit Tests Name: (root)

D14632: keyword rule: Spport for keywords inclusion from another language/file

2018-09-17 Thread jonathan poelen
jpoelen added a comment. (I inadvertently edit the operators list in the previous commit) Finally, I added a parameter to `load()` and `loadHighlighting()` rather than a new function because there was a lot of code duplication. REPOSITORY R216 Syntax Highlighting REVISION DETAIL

KDE CI: Frameworks » kio » kf5-qt5 WindowsMSVCQt5.11 - Build # 16 - Still unstable!

2018-09-17 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20WindowsMSVCQt5.11/16/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Mon, 17 Sep 2018 22:37:59 + Build duration: 1 hr 21 min and counting JUnit Tests Name:

D15573: replace custom backtracing in SlaveBase with KCrash

2018-09-17 Thread David Faure
dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D15573 To: sitter, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14072: Don't try to restore invalid user places

2018-09-17 Thread David Faure
dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. Shouldn't this skip the invalid bookmark rather than abort completely ? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14072 To: jtamate, dfaure,

D15220: implement more basic tags for taglibwriter

2018-09-17 Thread Alexander Stippich
astippich added a comment. In D15220#325580 , @bruns wrote: > Can you add some Unicode exercising tests? I plan to extend the tests in a later patch, if you don't mind, I would prefer to add this there. INLINE COMMENTS > bruns wrote in

D15096: [PreviewJob] Send enabled thumbnail plugins to the thumbnail slave

2018-09-17 Thread David Faure
dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15096 To: broulik, dfaure, fvogt, kossebau Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15220: implement more basic tags for taglibwriter

2018-09-17 Thread Alexander Stippich
astippich updated this revision to Diff 41856. astippich added a comment. - check for values greater than zero for tracknumber and year REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15220?vs=40861=41856 BRANCH taglib_write REVISION DETAIL

D13676: Make it possible to change directory up even with trailing slashes in the url

2018-09-17 Thread David Faure
dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D13676 To: jtamate, dfaure, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14006: Fix WebDAV destination header on COPY and MOVE operations

2018-09-17 Thread David Faure
dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. FullyEncoded makes perfect sense for sending in a protocol implementation. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D14006 To: dantti, dfaure,

D13316: manually set format in jpeg thumbnail creator

2018-09-17 Thread David Faure
dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D13316 To: miklosm, dfaure, elvisangelaccio, #frameworks Cc: ngraham

KDE CI: Frameworks » kio » kf5-qt5 WindowsMSVCQt5.11 - Build # 15 - Still Failing!

2018-09-17 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20WindowsMSVCQt5.11/15/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Mon, 17 Sep 2018 17:47:28 + Build duration: 1.3 sec and counting CONSOLE OUTPUT Started by

D14006: Fix WebDAV destination header on COPY and MOVE operations

2018-09-17 Thread Daniel Nicoletti
This revision was automatically updated to reflect the committed changes. Closed by commit R241:1f24f49baba4: Fix WebDAV destination header on COPY and MOVE operations (authored by dantti). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14006?vs=37460=41858

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.9 - Build # 246 - Fixed!

2018-09-17 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.9/246/ Project: kf5-qt5 SUSEQt5.9 Date of build: Mon, 17 Sep 2018 17:47:27 + Build duration: 5 min 24 sec and counting JUnit Tests Name: (root) Failed: 0

D15583: [Balooctl] fix directory parent check

2018-09-17 Thread Nathaniel Graham
ngraham created this revision. ngraham added reviewers: Baloo, Dolphin, bruns. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY [Submitting this patch on behalf of James Ausmus, who attached it

D15557: Improve "insufficient disk space" error messgae

2018-09-17 Thread Shubham
shubham added a comment. Maybe "Dont have enough space available on the disk" REPOSITORY R241 KIO BRANCH improve-insufficient-disk-space-error-message (branched from master) REVISION DETAIL https://phabricator.kde.org/D15557 To: ngraham, #frameworks, #vdg, #dolphin, shubham Cc:

KDE CI: Frameworks » kio » kf5-qt5 WindowsMSVCQt5.11 - Build # 17 - Still Failing!

2018-09-17 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20WindowsMSVCQt5.11/17/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Tue, 18 Sep 2018 02:22:45 + Build duration: 2 sec and counting CONSOLE OUTPUT Started by

D15557: Improve "insufficient disk space" error message

2018-09-17 Thread Nathaniel Graham
ngraham retitled this revision from "Improve "insufficient disk space" error messgae" to "Improve "insufficient disk space" error message". REPOSITORY R241 KIO BRANCH improve-insufficient-disk-space-error-message (branched from master) REVISION DETAIL https://phabricator.kde.org/D15557

D15557: Improve "insufficient disk space" error message

2018-09-17 Thread Nathaniel Graham
ngraham closed this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15557 To: ngraham, #frameworks, #vdg, #dolphin, shubham Cc: broulik, abetts, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 403 - Fixed!

2018-09-17 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/403/ Project: kf5-qt5 SUSEQt5.10 Date of build: Tue, 18 Sep 2018 02:22:45 + Build duration: 7 min 17 sec and counting JUnit Tests Name: (root) Failed:

D13316: manually set format in jpeg thumbnail creator

2018-09-17 Thread Nathaniel Graham
ngraham edited the summary of this revision. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D13316 To: miklosm, dfaure, elvisangelaccio, #frameworks Cc: ngraham

D13316: manually set format in jpeg thumbnail creator

2018-09-17 Thread Nathaniel Graham
ngraham added a comment. @miklosm, can this go in now, or it is dependent on either of your other two patches? REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D13316 To: miklosm, dfaure, elvisangelaccio, #frameworks Cc: ngraham

D13416: image thumbnailer: instruct Qt to look at the file contents when detecting its format

2018-09-17 Thread Nathaniel Graham
ngraham edited the summary of this revision. ngraham added reviewers: Frameworks, Dolphin, dfaure, elvisangelaccio. ngraham set the repository for this revision to R320 KIO Extras. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D13416 To: miklosm, #frameworks,

D13315: Detect mime type of local files based on their contents

2018-09-17 Thread Nathaniel Graham
ngraham edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D13315 To: miklosm, #frameworks, dfaure Cc: broulik, ngraham, apol, kde-frameworks-devel, michaelh, bruns

D13315: Detect mime type of local files based on their contents

2018-09-17 Thread Nathaniel Graham
ngraham added a reviewer: broulik. ngraham added a comment. @broulik, given your recent crusade against blocking calls, can you think of a better way to do this? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D13315 To: miklosm, #frameworks, dfaure, broulik Cc:

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 224 - Still Unstable!

2018-09-17 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/224/ Project: kf5-qt5 SUSEQt5.10 Date of build: Tue, 18 Sep 2018 04:57:46 + Build duration: 4 min 0 sec and counting JUnit Tests Name:

D14632: keyword rule: Spport for keywords inclusion from another language/file

2018-09-17 Thread Christoph Cullmann
cullmann added a comment. I don't know if the added complexity for loading only keywords is needed, but in any case one needs some recursive keyword resolving with a cycle guard. e.g. if you use a list that again includes another one. REPOSITORY R216 Syntax Highlighting REVISION DETAIL

D15353: Use _NET_WM_WINDOW_TYPE_COMBO instead of _NET_WM_WINDOW_TYPE_COMBOBOX

2018-09-17 Thread Vlad Zagorodniy
zzag added a comment. Ping. REPOSITORY R278 KWindowSystem REVISION DETAIL https://phabricator.kde.org/D15353 To: zzag, #kwin Cc: aacid, kde-frameworks-devel, michaelh, ngraham, bruns

D15566: Add QT_NO_NARROWING_CONVERSIONS_IN_CONNECT as default compile flags

2018-09-17 Thread David Faure
dfaure added a comment. Do all frameworks build with this change? REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D15566 To: mlaurent, dfaure Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D15405: [EPS] Fix crash at app shutdown (being tried to persist clipboard image)

2018-09-17 Thread David Faure
dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R287 KImageFormats BRANCH fixepscrashonappshutdown REVISION DETAIL https://phabricator.kde.org/D15405 To: kossebau, zccrs, dfaure, pino Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15417: [AppImage Thumbnailer] Avoid creating QTemporaryFile

2018-09-17 Thread Anthony Fieroni
anthonyfieroni added a comment. https://phabricator.kde.org/source/kio-extras/browse/master/thumbnail/CMakeLists.txt$10 It should be specified the version that contains appimage_read_file_into_buffer_following_symlinks REPOSITORY R320 KIO Extras REVISION DETAIL

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.9 - Build # 50 - Unstable!

2018-09-17 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.9/50/ Project: kf5-qt5 SUSEQt5.9 Date of build: Mon, 17 Sep 2018 11:42:22 + Build duration: 4 min 47 sec and counting JUnit Tests Name: (root)

D15566: Add QT_NO_NARROWING_CONVERSIONS_IN_CONNECT as default compile flags

2018-09-17 Thread Laurent Montel
mlaurent added a comment. I fixed 2 repos. Otherwise all compiles fine (ok I don't test on windows/mac and perhaps some module is not compiles on my computer) REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D15566 To: mlaurent, dfaure Cc:

D6513: Add support for Attica tags support

2018-09-17 Thread Dan Leinir Turthra Jensen
leinir requested review of this revision. leinir added a comment. Previous patch had BIC issues - new patch attempts to address this, but as a result (of course) requires another round of review. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D6513 To: leinir,

D15417: [AppImage Thumbnailer] Avoid creating QTemporaryFile

2018-09-17 Thread Anthony Fieroni
anthonyfieroni requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D15417 To: broulik, #frameworks, TheAssassin, anthonyfieroni

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.10 - Build # 106 - Unstable!

2018-09-17 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.10/106/ Project: kf5-qt5 SUSEQt5.10 Date of build: Mon, 17 Sep 2018 11:42:22 + Build duration: 1 min 13 sec and counting JUnit Tests Name:

D15573: replace custom backtracing in SlaveBase with KCrash

2018-09-17 Thread Harald Sitter
sitter created this revision. sitter added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY as discussed on mailing list. KCrash originally was automatically initialized, but

D15417: [AppImage Thumbnailer] Avoid creating QTemporaryFile

2018-09-17 Thread Anthony Fieroni
anthonyfieroni added a comment. Maybe it's better to make new code conditional to version that satisfy appimage_read_file_into_buffer_following_symlinks REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D15417 To: broulik, #frameworks, TheAssassin, anthonyfieroni

KDE CI: Frameworks » kimageformats » kf5-qt5 SUSEQt5.9 - Build # 20 - Still Unstable!

2018-09-17 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20SUSEQt5.9/20/ Project: kf5-qt5 SUSEQt5.9 Date of build: Mon, 17 Sep 2018 09:54:41 + Build duration: 4 min 0 sec and counting JUnit Tests Name: (root)

KDE CI: Frameworks » kimageformats » kf5-qt5 SUSEQt5.10 - Build # 27 - Still Unstable!

2018-09-17 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20SUSEQt5.10/27/ Project: kf5-qt5 SUSEQt5.10 Date of build: Mon, 17 Sep 2018 10:10:11 + Build duration: 57 sec and counting JUnit Tests Name: (root)

KDE CI: Frameworks » kimageformats » kf5-qt5 SUSEQt5.9 - Build # 21 - Still Unstable!

2018-09-17 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20SUSEQt5.9/21/ Project: kf5-qt5 SUSEQt5.9 Date of build: Mon, 17 Sep 2018 10:10:11 + Build duration: 3 min 57 sec and counting JUnit Tests Name: (root)

Re: kio slaves + kcrash + drkonqi

2018-09-17 Thread Harald Sitter
On Sun, Sep 16, 2018 at 10:48 AM David Faure wrote: > How about just killing the KDE_DEBUG check *and* the code that prints out a > backtrace? I'm always in favor of less code, so I'll prepare a diff for this. > > - Possibly KCRASH_AUTO_RESTARTED needs setting by something in KIO. > > From what

D14757: Warn user before copy/move operation if available space is not enough

2018-09-17 Thread David Faure
dfaure added a comment. Looks OK now. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14757 To: shubham, pino, dfaure, broulik, ngraham Cc: ngraham, dfaure, pino, kde-frameworks-devel, michaelh, bruns

D15405: [EPS] Fix crash at app shutdown (being tried to persist clipboard image)

2018-09-17 Thread Friedrich W. H. Kossebau
This revision was automatically updated to reflect the committed changes. Closed by commit R287:98c65a438dfb: [EPS] Fix crash at app shutdown (being tried to persist clipboard image) (authored by kossebau). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D15405?vs=41341=41808#toc

KDE CI: Frameworks » kimageformats » kf5-qt5 SUSEQt5.10 - Build # 26 - Still Unstable!

2018-09-17 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20SUSEQt5.10/26/ Project: kf5-qt5 SUSEQt5.10 Date of build: Mon, 17 Sep 2018 09:54:41 + Build duration: 1 min 51 sec and counting JUnit Tests Name:

D15443: [server] Allow multiple touch interfaces per client

2018-09-17 Thread David Edmundson
davidedmundson added inline comments. INLINE COMMENTS > seat_interface.cpp:1332 > -d->touchInterface.focus.touch->down(id, serial, globalPosition - > d->touchInterface.focus.offset); > -} else if (id == 0 && focusedTouchSurface()) { > #if HAVE_LINUX_INPUT_H what happened to the

D6513: Add support for Attica tags support

2018-09-17 Thread Dan Leinir Turthra Jensen
leinir updated this revision to Diff 41815. leinir added a comment. After discovering that the previous version of this patch had introduced a binary incompatibility, and panicking momentarily that this had been done in a release, Jonathan reverted it (as i was away for a bit and unable to

D15576: kcfg_compiler now documents valid inputs for its 'Color' type

2018-09-17 Thread Harald Sitter
sitter added a subscriber: broulik. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D15576 To: sitter Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D15576: kcfg_compiler now documents valid inputs for its 'Color' type

2018-09-17 Thread Harald Sitter
sitter created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY it wasn't exactly clear what the inputs for a Color type may be. this is now explained along with special type

D15576: kcfg_compiler now documents valid inputs for its 'Color' type

2018-09-17 Thread Kai Uwe Broulik
broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R237 KConfig BRANCH master REVISION DETAIL https://phabricator.kde.org/D15576 To: sitter, broulik Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D8708: Introduce AbstractAnnotationItemDelegate for more control by consumer

2018-09-17 Thread Friedrich W. H. Kossebau
kossebau added a comment. In D8708#326590 , @dhaumann wrote: > What I would like to see is a comment // KF6: Merge KTextEditor::AnnotationViewInterfaceV2 into KTextEditor::AnnotationViewInterface (kossebau). > For me, this comment is really

D15417: [AppImage Thumbnailer] Avoid creating QTemporaryFile

2018-09-17 Thread TheAssassin
TheAssassin added a comment. The AppImage project doesn't do any versioning right now. We've recently extracted libappimage into a separate project to be able to start versioning of it, as projects like KDE expect and somehow need that. We're discussing a suitable versioning scheme right

D8708: Introduce AbstractAnnotationItemDelegate for more control by consumer

2018-09-17 Thread Friedrich W. H. Kossebau
kossebau updated this revision to Diff 41828. kossebau added a comment. also add todo about merging KTextEditor::AnnotationViewInterfaceV2 into KTextEditor::AnnotationViewInterface REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8708?vs=41778=41828

D15557: Improve "insufficient disk space" error messgae

2018-09-17 Thread Andres Betts
abetts added a comment. In D15557#327094 , @ngraham wrote: > We can't use the words "file" or "move" since this part of the code can't know whether the user is moving or copying, or whether the thing being moved or copied is a file or a

D15557: Improve "insufficient disk space" error messgae

2018-09-17 Thread Kai Uwe Broulik
broulik added a comment. +1 REPOSITORY R241 KIO BRANCH improve-insufficient-disk-space-error-message (branched from master) REVISION DETAIL https://phabricator.kde.org/D15557 To: ngraham, #frameworks, #vdg, #dolphin, shubham Cc: broulik, abetts, kde-frameworks-devel, michaelh,