D12520: [PasteJob] Emit KDirNotify on paste

This revision was automatically updated to reflect the committed changes. Closed by commit R241:681501c276ee: [PasteJob] Emit KDirNotify on paste (authored by broulik). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12520?vs=33081=41885 REVISION DETAIL

D6513: Add support for Attica tags support

leinir updated this revision to Diff 41886. leinir added a comment. Forgot `@since 5.51` in the new api in Provider.h REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6513?vs=41815=41886 REVISION DETAIL https://phabricator.kde.org/D6513 AFFECTED FILES

KDE CI: Frameworks » kio » kf5-qt5 WindowsMSVCQt5.11 - Build # 18 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20WindowsMSVCQt5.11/18/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Tue, 18 Sep 2018 08:38:07 + Build duration: 1 hr 19 min and counting JUnit Tests Name:

KDE CI: Frameworks » kio » kf5-qt5 WindowsMSVCQt5.11 - Build # 19 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20WindowsMSVCQt5.11/19/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Tue, 18 Sep 2018 09:57:46 + Build duration: 0.93 sec and counting CONSOLE OUTPUT Started

D15096: [PreviewJob] Send enabled thumbnail plugins to the thumbnail slave

This revision was automatically updated to reflect the committed changes. Closed by commit R241:b582cd477f65: [PreviewJob] Send enabled thumbnail plugins to the thumbnail slave (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D15096?vs=40495=41883#toc REPOSITORY

D15451: Let KUrlCombo operate on QIcon instead of QPixmap

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. loadMimeTypeIcon also has the fallback to application-octet-stream if the mimetype icon isn't found, you could pass that as 2nd argument to fromTheme(). As to the extra

D13315: Detect mime type of local files based on their contents

dfaure added a comment. (BTW thanks for what you said about FUSE, I agree 100% and it makes me glad to see some people from the opposite camp, when so many people are trying to convince me that network mounts via FUSE is the solution to all problems on earth, see bug 75324) >

D13416: image thumbnailer: instruct Qt to look at the file contents when detecting its format

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. In code that is specific to images, I have no problem with determination from content. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D13416 To: miklosm,

Re: KDE CI: Frameworks » kio » kf5-qt5 WindowsMSVCQt5.11 - Build # 17 - Still Failing!

Hi all, As this is a recurring issue on the CI system i've gone ahead and attached a debugger to one of the "hung" instances of kioslave.exe. In this instance at least kioslave.exe is stuck in the destructor for OrgKdeKSSLDInterface, cleaning up it's children. In particular, it's trying to

Re: KDE CI: Frameworks » kio » kf5-qt5 WindowsMSVCQt5.11 - Build # 17 - Still Failing!

Hi Thiago, this looks like another issue with QtDBus using a separate thread, a deadlock on shutdown, on Windows. I remember seeing discussions about that in the past, I thought it was fixed? Maybe not in this particular case... Cheers, David. On mardi 18 septembre 2018 09:08:18 CEST Ben

D15479: fix for macOS

yurikoles added a comment. In D15479#327944 , @bcooksley wrote: > Okay. That's quite an unusual error as that should work. > > We'll have to let the CI system confirm this one. Please go ahead and commit. I have no rights.

D13315: Detect mime type of local files based on their contents

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. No, no. Too unreliable and against the MIME spec. You're testing it for the ideal case, images, which have proper headers. But there's no reliable "magic" (determination

D15591: Add Open Document thumbnailer

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. OK then! :) REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D15591 To: broulik, #frameworks, #vdg, ngraham, kossebau Cc: kossebau, jtamate, ngraham

KDE CI: Frameworks » kio » kf5-qt5 WindowsMSVCQt5.11 - Build # 23 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20WindowsMSVCQt5.11/23/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Tue, 18 Sep 2018 17:24:45 + Build duration: 1 hr 10 min and counting JUnit Tests Name:

KDE CI: Frameworks » kio » kf5-qt5 WindowsMSVCQt5.11 - Build # 24 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20WindowsMSVCQt5.11/24/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Tue, 18 Sep 2018 18:35:24 + Build duration: 1 sec and counting CONSOLE OUTPUT Started by

D15591: Add Open Document thumbnailer

broulik planned changes to this revision. broulik added a comment. > ...that doesn't seem likely, that'd be like Plasma using Kicker classes from KDE3 times, which is the last time Calligra was called that ;) I wanted to say `Ko` classes as that's what they're prefixed with but I didn't

D15591: Add Open Document thumbnailer

ngraham added a reviewer: kossebau. ngraham added a subscriber: kossebau. ngraham added a comment. Hmm, looks like Calligra already has code that does some of this: https://cgit.kde.org/calligra.git/tree/extras/thumbnail/calligracreator.cpp. Ideally we would have the thumbnailer for

D15591: Add Open Document thumbnailer

broulik added a comment. > Does this thumbnailer ask for password for password protected files, No. I don't know how a password-protected document work but if it's encrypted like a ZIP file the file will just fail to open and generate, like you cannot open an encrypted file in `zip:/`

D15591: Add Open Document thumbnailer

jtamate requested changes to this revision. jtamate added a comment. This revision now requires changes to proceed. I'm trying to check if it works with password-protected files, but I can't install it. The patch is missing opendocumentthumbnail.desktop. I have a question: If you have

D15591: Add Open Document thumbnailer

leinir added a comment. In D15591#328150 , @broulik wrote: > [...]actually uses KOffice classes ...that doesn't seem likely, that'd be like Plasma using Kicker classes from KDE3 times, which is the last time Calligra was called

Re: Re: KDE CI: Frameworks » kio » kf5-qt5 WindowsMSVCQt5.11 - Build # 17 - Still Failing!

On Wed, 19 Sep 2018, 02:50 David Faure, wrote: > Hmm So we need to kill it? > Except regular kill doesn't work. It's immune to that. Process Explorer (Sysinternals) and Task Manager (built in) can kill it though, not sure how though. The solutions I can see in this case are: a) Don't

D15468: [server] Do not return early on fail in touchDown fall back code

This revision was automatically updated to reflect the committed changes. Closed by commit R127:3cf4825c8050: [server] Do not return early on fail in touchDown fall back code (authored by romangg). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.10 - Build # 87 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.10/87/ Project: kf5-qt5 SUSEQt5.10 Date of build: Tue, 18 Sep 2018 19:57:10 + Build duration: 4 min 1 sec and counting JUnit Tests Name: (root)

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.9 - Build # 60 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.9/60/ Project: kf5-qt5 SUSEQt5.9 Date of build: Tue, 18 Sep 2018 19:57:10 + Build duration: 12 min and counting JUnit Tests Name: (root) Failed: 2

D15443: [server] Allow multiple touch interfaces per client

romangg added inline comments. INLINE COMMENTS > davidedmundson wrote in seat_interface.cpp:1332 > what happened to the > if (id == 0 ) > > which is making sure if you multi touch we only send the first as a mouse > event. Good catch. Thanks. > davidedmundson wrote in

D15591: Add Open Document thumbnailer

broulik created this revision. broulik added reviewers: Frameworks, VDG. broulik requested review of this revision. REVISION SUMMARY Provides thumbnails for ODT, ODS, ODP, ODG, ODF files as well as their template counterparts TEST PLAN Some code I had written a while ago, not knowing there

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 225 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/225/ Project: kf5-qt5 SUSEQt5.10 Date of build: Tue, 18 Sep 2018 15:52:44 + Build duration: 3 min 37 sec and counting JUnit Tests Name:

D15591: Add Open Document thumbnailer

ngraham accepted this revision as: VDG. ngraham added a comment. Wow, that's pretty simple. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D15591 To: broulik, #frameworks, #vdg Cc: ngraham

D15591: Add Open Document thumbnailer

ngraham edited the summary of this revision. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D15591 To: broulik, #frameworks, #vdg Cc: ngraham

D15591: Add Open Document thumbnailer

jtamate added a comment. I haven't tested it, therefore I ask: Does this thumbnailer ask for password for password protected files, like in https://bugs.kde.org/show_bug.cgi?id=394284 ? REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D15591 To: broulik,

D13676: Make it possible to change directory up even with trailing slashes in the url

This revision was automatically updated to reflect the committed changes. Closed by commit R241:6ab78df8c86e: Make it possible to change directory up even with trailing slashes in the url (authored by jtamate). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D14072: Don't try to restore invalid user places

This revision was automatically updated to reflect the committed changes. Closed by commit R241:2b52b47211a6: Dont try to restore invalid user places (authored by jtamate). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14072?vs=41879=41907 REVISION DETAIL

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.9 - Build # 253 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.9/253/ Project: kf5-qt5 SUSEQt5.9 Date of build: Tue, 18 Sep 2018 17:24:45 + Build duration: 5 min 54 sec and counting JUnit Tests Name: (root) Failed: 0

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 408 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/408/ Project: kf5-qt5 SUSEQt5.10 Date of build: Tue, 18 Sep 2018 17:24:45 + Build duration: 5 min 6 sec and counting JUnit Tests Name: (root) Failed: 0

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 409 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/409/ Project: kf5-qt5 SUSEQt5.10 Date of build: Tue, 18 Sep 2018 17:29:52 + Build duration: 6 min 43 sec and counting JUnit Tests Name: (root) Failed:

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.9 - Build # 254 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.9/254/ Project: kf5-qt5 SUSEQt5.9 Date of build: Tue, 18 Sep 2018 17:30:40 + Build duration: 4 min 43 sec and counting JUnit Tests Name: (root) Failed: 2

D15591: Add Open Document thumbnailer

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Hmm, yeah, we need to make sure to not even try to generate thumbnails for password-protected files. Good catch, @jtamate REPOSITORY R320 KIO Extras REVISION DETAIL

D15443: [server] Allow multiple touch interfaces per client

romangg updated this revision to Diff 41916. romangg added a comment. Do not forget id equals 0 check and add assert. REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15443?vs=41513=41916 BRANCH refactorSeatTouch REVISION DETAIL

D13316: manually set format in jpeg thumbnail creator

miklosm added a comment. In D13316#327854 , @ngraham wrote: > @miklosm, can this go in now, or it is dependent on either of your other two patches? All three patches need to be in place to fix bug 220496. The thumbnail creators need

D15591: Add Open Document thumbnailer

kossebau added a comment. Just FYI, as I was added, I currently have no time reserved for document related code work: There is such a thumbnailer for OpenDocument Format document which exposes the preview/thumbnail picture from the data since ages on what now is store.kde.org, here my

D14632: keyword rule: Spport for keywords inclusion from another language/file

dhaumann added a comment. @cullmann If the other solution is easier to maintain then I am fine with this. Still, I would like to avoid that includedDefinitions() for sass returns css just because of keywords. In fact, that was my main motivation for this solution. REPOSITORY R216 Syntax

D15464: [server] Touch drag support

romangg marked 3 inline comments as done. romangg added inline comments. INLINE COMMENTS > davidedmundson wrote in seat_interface.cpp:1331 > If I add 2 IDs > > [0,1] > > then remove ID 0 > > [1] > > with the old code I would get the ID 2, with this I'll get a second ID 1 Redid this one too

D15464: [server] Touch drag support

romangg updated this revision to Diff 41923. romangg marked an inline comment as done. romangg added a comment. - Fix id setting and cancel touch drags - Reapply position of first touch on drag REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE

D13315: Detect mime type of local files based on their contents

miklosm added a comment. In D13315#327933 , @dfaure wrote: > No, no. Too unreliable and against the MIME spec. > > You're testing it for the ideal case, images, which have proper headers. > But there's no reliable "magic" (determination

KDE CI: Frameworks » kio » kf5-qt5 WindowsMSVCQt5.11 - Build # 21 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20WindowsMSVCQt5.11/21/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Tue, 18 Sep 2018 11:15:53 + Build duration: 1.8 sec and counting CONSOLE OUTPUT Started by

KDE CI: Frameworks » kio » kf5-qt5 WindowsMSVCQt5.11 - Build # 20 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20WindowsMSVCQt5.11/20/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Tue, 18 Sep 2018 10:02:34 + Build duration: 1 hr 13 min and counting JUnit Tests Name:

D15479: fix for macOS

bcooksley added a comment. Okay. That's quite an unusual error as that should work. We'll have to let the CI system confirm this one. Please go ahead and commit. REPOSITORY R272 KDNSSD REVISION DETAIL https://phabricator.kde.org/D15479 To: yurikoles, arichardson Cc: bcooksley,

D14072: Don't try to restore invalid user places

jtamate updated this revision to Diff 41879. jtamate added a comment. Continue processing the XML with invalid urls. And a trivial code deduplication, I couldn't resist. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14072?vs=37631=41879 REVISION DETAIL

D14072: Don't try to restore invalid user places

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14072 To: jtamate, dfaure, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

Fwd: Re: KDE CI: Frameworks » kio » kf5-qt5 WindowsMSVCQt5.11 - Build # 17 - Still Failing!

Hmm So we need to kill it? -- Forwarded Message -- Subject: Re: KDE CI: Frameworks » kio » kf5-qt5 WindowsMSVCQt5.11 - Build # 17 - Still Failing! Date: mardi 18 septembre 2018, 16:09:33 CEST From: Thiago Macieira To: David Faure On Tuesday, 18 September 2018

D15573: replace custom backtracing in SlaveBase with KCrash

This revision was automatically updated to reflect the committed changes. Closed by commit R241:d428fc8e6447: replace custom backtracing in SlaveBase with KCrash (authored by sitter). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15573?vs=41822=41887 REVISION

D15096: [PreviewJob] Send enabled thumbnail plugins to the thumbnail slave

wbauer added inline comments. INLINE COMMENTS > previewjob.cpp:641 > job->addMetaData(QStringLiteral("plugin"), > currentItem.plugin->library()); > +//job->addMetaData(QStringLiteral("enabledPlugins"), > enabledPlugins.join(QLatin1Char(','))); > if (sequenceIndex) { That line is

D15096: [PreviewJob] Send enabled thumbnail plugins to the thumbnail slave

broulik added inline comments. INLINE COMMENTS > wbauer wrote in previewjob.cpp:641 > That line is commented out. Is this intentional? > I don't see how this will change anything... ;-/ Aw, crap, that's what happens when you have unstaged changes, I was testing stuff and acceidentally pushed

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.9 - Build # 252 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.9/252/ Project: kf5-qt5 SUSEQt5.9 Date of build: Tue, 18 Sep 2018 13:24:33 + Build duration: 5 min 46 sec and counting JUnit Tests Name: (root) Failed: 1

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 407 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/407/ Project: kf5-qt5 SUSEQt5.10 Date of build: Tue, 18 Sep 2018 13:24:33 + Build duration: 5 min 45 sec and counting JUnit Tests Name: (root) Failed:

KDE CI: Frameworks » kio » kf5-qt5 WindowsMSVCQt5.11 - Build # 22 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20WindowsMSVCQt5.11/22/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Tue, 18 Sep 2018 13:24:34 + Build duration: 1 hr 31 min and counting JUnit Tests Name: