D15851: Fix signals not being emitted when merging two persons

[Igor Poboiko]

poboiko created this revision.
poboiko added reviewers: Frameworks, dvratil.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
poboiko requested review of this revision.

REVISION SUMMARY
  If I have 4 contacts, i.e. `{A,B,C,D}`, then merge `{A,B}->1` and `{C,D}->2`, 
and then merge `{1,2}->1`,
  inside the model I get only signals that contacts `{C,D}` were removed from 
person `2`, ending up with 3 contacts in the model `{1,C,D}`, instead of just 
`1`.
  Apparently, the line was simply missing.

TEST PLAN
  With this patch, merging works as expected

REPOSITORY
  R307 KPeople

BRANCH
  forgotten-signal (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15851

AFFECTED FILES
  src/personmanager.cpp

To: poboiko, #frameworks, dvratil
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D6513: Add support for Attica tags support

[Dan Leinir Turthra Jensen]

leinir added a comment.


  Sorry for pinging again, but i'd really quite like to not have to wait (yet) 
another cycle for this to get out...

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D6513

To: leinir, #knewstuff, apol, #kde_store, whiting, ahiemstra, mlaurent, dfaure, 
cfeck
Cc: rikmills, dfaure, cfeck, mlaurent, ngraham, ahiemstra, 
kde-frameworks-devel, #knewstuff, michaelh, ZrenBot, bruns

D15853: Change drive-harddisk to more adaptable style

[Noah Davis]

ndavis created this revision.
ndavis added a reviewer: VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ndavis requested review of this revision.

REVISION SUMMARY
  T9740 
  
  The old 16 and 22 px drive-harddisk icons didn't look like hard drives. The 
new design for 16, 22 and 64 px is easier to resize and adapt. Symbols can be 
added to the light area on top of the 64px icon to show different types of 
drives (e.g., a globe for iSCSI)

REPOSITORY
  R266 Breeze Icons

BRANCH
  new-harddisk-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15853

AFFECTED FILES
  icons-dark/devices/16/drive-harddisk.svg
  icons-dark/devices/22/drive-harddisk.svg
  icons-dark/devices/64/drive-harddisk.svg
  icons/devices/16/drive-harddisk.svg
  icons/devices/22/drive-harddisk.svg
  icons/devices/64/drive-harddisk.svg

To: ndavis, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15853: Change drive-harddisk to more adaptable style

[Noah Davis]

ndavis edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D15853

To: ndavis, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15853: Change drive-harddisk to more adaptable style

[Noah Davis]

ndavis edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D15853

To: ndavis, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15853: Change drive-harddisk to more adaptable style

[Noah Davis]

ndavis edited the summary of this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D15853

To: ndavis, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15853: Change drive-harddisk to more adaptable style

[Noah Davis]

ndavis edited the summary of this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D15853

To: ndavis, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15853: Change drive-harddisk to more adaptable style

[Noah Davis]

ndavis added a comment.


  I only added 16, 22 and 64 px icons in the current revision, but I also have 
a 32px version. Is there a reason that there are only 16, 22 and 64 px versions 
for all device icons?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D15853

To: ndavis, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D6513: Add support for Attica tags support

[Christoph Feck]

cfeck accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D6513

To: leinir, #knewstuff, apol, #kde_store, whiting, ahiemstra, mlaurent, dfaure, 
cfeck
Cc: rikmills, dfaure, cfeck, mlaurent, ngraham, ahiemstra, 
kde-frameworks-devel, #knewstuff, michaelh, ZrenBot, bruns

D15843: Allow FileIndexerConfig to check device mounted status by path.

[Stefan Brüns]

bruns requested changes to this revision.
bruns added a comment.
This revision now requires changes to proceed.


  Most obvious problem with this change - as far as I can deduce from your 
description, this is about runtime behaviour. The config class is the wrong 
place to add this method.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D15843

To: smithjd, #baloo, bruns
Cc: ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, 
spoorun, bruns, abrahams

D15853: Change drive-harddisk to more adaptable style

[Stefan Brüns]

bruns added a comment.


  In D15853#334188 , @ndavis wrote:
  
  > I only added 16, 22 and 64 px icons in the current revision, but I also 
have a 32px version. Is there a reason that there are only 16, 22 and 64 px 
versions for all device icons?
  >
  > The 64 px version already scales down to 50% size quite well, but the 32px 
version might be useful to people making icons for alternative harddrive types.
  
  
  I think "64 px version already scales down to 50% size quite well" is the 
reason to omit these icons. 16/22 have to be specifically designed to be 
recognizable, but omitting 32 avoids wasting disk space and avoids the 
potential problem of differing design for 32/64/128.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D15853

To: ndavis, #vdg
Cc: bruns, kde-frameworks-devel, michaelh, ngraham

D15859: allow non-local file:// redirect to a M$-WebDav URL

[Martin Koller]

mkoller created this revision.
mkoller added a reviewer: dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mkoller requested review of this revision.

REVISION SUMMARY
  In our mainly windows company environment, I often receive links in emails 
like this
  file://some.server/DavWWWRoot/pwa/some/path/to/a/document
  
  The files are served by a Sharepoint server, and M$ introduced the special 
"DavWWWRoot" prefix to notify
  then WebDav shall be used.
  
  See https://www.webdavsystem.com/server/access/windows
  
  With this patch I can now nicely click such an URL and get the same as 
colleagues using win get

TEST PLAN
  Using kioclient5 exec URL and clicking such an URL in kmail

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15859

AFFECTED FILES
  file.cpp
  file.h
  file_unix.cpp
  file_win.cpp

To: mkoller, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15070: Bindings: Query the install directory from python

[Stefan Brüns]

bruns planned changes to this revision.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D15070

To: bruns, #frameworks
Cc: cgiboudeaux, bcooksley, kde-frameworks-devel, kde-buildsystem, michaelh, 
ngraham, bruns

D15070: Bindings: Query the install directory from python

[Stefan Brüns]

bruns updated this revision to Diff 42605.
bruns added a comment.


  rebase

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15070?vs=40398&id=42605

BRANCH
  python3_support

REVISION DETAIL
  https://phabricator.kde.org/D15070

AFFECTED FILES
  find-modules/FindPythonModuleGeneration.cmake

To: bruns, #frameworks
Cc: cgiboudeaux, bcooksley, kde-frameworks-devel, kde-buildsystem, michaelh, 
ngraham, bruns

D15859: allow non-local file:// redirect to a M$-WebDav URL

[Nathaniel Graham]

ngraham added a reviewer: Frameworks.
ngraham added a comment.


  Code change looks pretty sane to me. Can we change "M$" to "MS"  or 
"Microsoft" though? It's not the most professional, and the symbolism is even 
rather dated; there are many many companies that have more money than Microsoft 
these days...

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15859

To: mkoller, dfaure, #frameworks
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D15859: allow non-local file:// redirect to a M$-WebDav URL

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> file.cpp:338
> +// if we would redirect into the windows world, let's also check for the
> +// DavWWWRoot "token" which in the m$-world tells win explorer to access
> +// a webdav url

Can you please replace the m$. Also, 'Windows' is likely more correct here, MS 
does even do Linux these days ...

> file.cpp:344
> +redir.setPath(redir.path().mid(11));  // remove /DavWWWRoot
> +redir.setScheme(QLatin1String("webdav"));
> +}

Is this also working in all cases for SSL connections? `webdavs` might be 
required.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15859

To: mkoller, dfaure, #frameworks
Cc: bruns, ngraham, kde-frameworks-devel, michaelh

D12820: Add KWayland virtual desktop protocol

[Nathaniel Graham]

ngraham added a dependent revision: D13887: use the new plasma virtual desktop 
protocol.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D12820

To: mart, #kwin, #plasma, graesslin, hein
Cc: davidedmundson, zzag, bshah, romangg, kde-frameworks-devel, michaelh, 
ngraham, bruns

D15845: Remove misleading use of KDE_INSTALL_PYTHONBINDINGSDIR

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  Feel free to push all changes such as this one without review.

REPOSITORY
  R283 KAuth

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15845

To: bruns, #frameworks, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15845: Remove misleading use of KDE_INSTALL_PYTHONBINDINGSDIR

[Stefan Brüns]

bruns added a comment.


  Ok, will do for the few remaining ones, Thx.

REPOSITORY
  R283 KAuth

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15845

To: bruns, #frameworks, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15845: Remove misleading use of KDE_INSTALL_PYTHONBINDINGSDIR

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R283:b3288d1464c9: Remove misleading use of 
KDE_INSTALL_PYTHONBINDINGSDIR (authored by bruns).

REPOSITORY
  R283 KAuth

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15845?vs=42577&id=42609

REVISION DETAIL
  https://phabricator.kde.org/D15845

AFFECTED FILES
  src/CMakeLists.txt

To: bruns, #frameworks, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15846: Remove misleading use of KDE_INSTALL_PYTHONBINDINGSDIR

[Stefan Brüns]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R270:8c6ab8618eab: Remove misleading use of 
KDE_INSTALL_PYTHONBINDINGSDIR (authored by bruns).

REPOSITORY
  R270 KCodecs

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15846?vs=42578&id=42610

REVISION DETAIL
  https://phabricator.kde.org/D15846

AFFECTED FILES
  src/CMakeLists.txt

To: bruns, #frameworks, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15848: Remove misleading use of KDE_INSTALL_PYTHONBINDINGSDIR

[Stefan Brüns]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R237:a66158ba350c: Remove misleading use of 
KDE_INSTALL_PYTHONBINDINGSDIR (authored by bruns).

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15848?vs=42580&id=42611

REVISION DETAIL
  https://phabricator.kde.org/D15848

AFFECTED FILES
  src/core/CMakeLists.txt
  src/gui/CMakeLists.txt

To: bruns, #frameworks, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15847: Remove misleading use of KDE_INSTALL_PYTHONBINDINGSDIR

[Stefan Brüns]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R284:754cd63a288e: Remove misleading use of 
KDE_INSTALL_PYTHONBINDINGSDIR (authored by bruns).

REPOSITORY
  R284 KCompletion

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15847?vs=42579&id=42612

REVISION DETAIL
  https://phabricator.kde.org/D15847

AFFECTED FILES
  src/CMakeLists.txt

To: bruns, #frameworks, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15853: Change drive-harddisk to more adaptable style

[Nathaniel Graham]

ngraham added a task: T9740: Improve disk presentation in the Places panel.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D15853

To: ndavis, #vdg
Cc: bruns, kde-frameworks-devel, michaelh, ngraham

D15853: Change drive-harddisk to more adaptable style

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Wow, this is amazingly better. Here's how it looks in the Places Panel at 
various sizes:
  
  Small (default): F6295828: Small.png 
  
  Large: F6295829: Large.png 
  
  Huge: F6295830: Huge.png 

REPOSITORY
  R266 Breeze Icons

BRANCH
  new-harddisk-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15853

To: ndavis, #vdg, ngraham
Cc: ngraham, bruns, kde-frameworks-devel, michaelh

D15853: Change drive-harddisk to more adaptable style

[Phil Stefan]

pstefan requested changes to this revision.
pstefan added a comment.
This revision now requires changes to proceed.


  In the monochrome icons (size 16px and 22px) you forgot to add the 
stylesheet. Without it, the monochrome icons won't be able to adapt to a 
changing color scheme. 
  You will have to run the scripts "apply-stylesheet.sh" and 
"currentColorFillFix.sh" –from here 
– with your 
files as arguments. You will need the program "xmlstarlet" as dependency. 
  Or, if these scripts do not work correctly, you'll have to do it by hand. I 
will take icons-dark/devices/16/drive-harddisk.svg as an example.
  You'd need to copy line 2-9 from the old file to the new file. You would also 
need to change the fill to "fill:currentColor", and then add the 
"class="ColorScheme-Text" ". But if you are lucky the script will work and you 
won't need to do a thing :)
  
  PS somewhere there's a script that changes the color of your monochrome 
automagically to the dark variant. So you don't have to do it by hand.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D15853

To: ndavis, #vdg, ngraham, pstefan
Cc: pstefan, ngraham, bruns, kde-frameworks-devel, michaelh

D15853: Change drive-harddisk to more adaptable style

[Noah Davis]

ndavis added a comment.


  In D15853#334415 , @pstefan wrote:
  
  > In the monochrome icons (size 16px and 22px) you forgot to add the 
stylesheet. Without it, the monochrome icons won't be able to adapt to a 
changing color scheme. 
  >  You will have to run the scripts "apply-stylesheet.sh" and 
"currentColorFillFix.sh" –from here 
– with your 
files as arguments. You will need the program "xmlstarlet" as dependency. 
  >  Or, if these scripts do not work correctly, you'll have to do it by hand. 
I will take icons-dark/devices/16/drive-harddisk.svg as an example.
  >  You'd need to copy line 2-9 from the old file to the new file. You would 
also need to change the fill to "fill:currentColor", and then add the 
"class="ColorScheme-Text" ". But if you are lucky the script will work and you 
won't need to do a thing :)
  >
  > PS somewhere there's a script that changes the color of your monochrome 
automagically to the dark variant. So you don't have to do it by hand.
  
  
  Ouch, I was not aware of this. All of the other monochrome icons I made that 
have been committed to master probably lack this as as well. It would be nice 
to have all the required info for making icons on a wiki somewhere. The icon 
HIG doesn't say anything about this.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D15853

To: ndavis, #vdg, ngraham, pstefan
Cc: pstefan, ngraham, bruns, kde-frameworks-devel, michaelh

D15853: Change drive-harddisk to more adaptable style

[Noah Davis]

ndavis updated this revision to Diff 42621.
ndavis added a comment.


  Fix stylesheet

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15853?vs=42591&id=42621

BRANCH
  new-harddisk-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15853

AFFECTED FILES
  icons-dark/devices/16/drive-harddisk.svg
  icons-dark/devices/22/drive-harddisk.svg
  icons-dark/devices/64/drive-harddisk.svg
  icons/devices/16/drive-harddisk.svg
  icons/devices/22/drive-harddisk.svg
  icons/devices/64/drive-harddisk.svg

To: ndavis, #vdg, ngraham, pstefan
Cc: pstefan, ngraham, bruns, kde-frameworks-devel, michaelh

D15853: Change drive-harddisk to more adaptable style

[Nathaniel Graham]

ngraham added a comment.


  In D15853#334425 , @ndavis wrote:
  
  > Ouch, I was not aware of this. All of the other monochrome icons I made 
that have been committed to master probably lack this as as well. It would be 
nice to have all the required info for making icons on a wiki somewhere. The 
icon HIG doesn't say anything about this.
  
  
  Sounds like we should document it there. Wanna submit a patch? The repo is 
git://anongit.kde.org/websites/hig-kde-org.git :)
  
  Feel free to also submit a patch to do this for the other icons you've 
recently made.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D15853

To: ndavis, #vdg, ngraham, pstefan
Cc: pstefan, ngraham, bruns, kde-frameworks-devel, michaelh

D15853: Change drive-harddisk to more adaptable style

[Noah Davis]

ndavis added a comment.


  In D15853#334455 , @ngraham wrote:
  
  > In D15853#334425 , @ndavis wrote:
  >
  > > Ouch, I was not aware of this. All of the other monochrome icons I made 
that have been committed to master probably lack this as as well. It would be 
nice to have all the required info for making icons on a wiki somewhere. The 
icon HIG doesn't say anything about this.
  >
  >
  > Sounds like we should document it there. Wanna submit a patch? The repo is 
git://anongit.kde.org/websites/hig-kde-org.git :)
  >
  > Feel free to also submit a patch to do this for the other icons you've 
recently made.
  
  
  I would, but I feel like there may be other things I don't know and I don't 
want to be a blind man leading the blind. Right now, what I know is "copy this 
code into the file". Why? Because it somehow improves compatibility with the 
system colors. It's not only an unsatisfying answer, but it seems like an 
inelegant solution as well.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D15853

To: ndavis, #vdg, ngraham, pstefan
Cc: pstefan, ngraham, bruns, kde-frameworks-devel, michaelh

D15853: Change drive-harddisk to more adaptable style

[Nathaniel Graham]

ngraham added a comment.


  Makes sense. @pstefan, could you take charge on that since you seem to have 
some knowledge about this process that the rest of us lack?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D15853

To: ndavis, #vdg, ngraham, pstefan
Cc: pstefan, ngraham, bruns, kde-frameworks-devel, michaelh

D15091: Compile python bindings with the same sip flags used by PyQt

[Stefan Brüns]

bruns accepted this revision.
bruns added a comment.
This revision is now accepted and ready to land.


  Confirmed to work with PyQt 5.10.1 and Qt 5.11.1

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D15091

To: arojas, #frameworks, bruns
Cc: rdieter, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D15091: Compile python bindings with the same sip flags used by PyQt

[Antonio Rojas]

This revision was automatically updated to reflect the committed changes.
Closed by commit R240:05bd97492704: Compile python bindings with the same sip 
flags used by PyQt (authored by arojas).

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15091?vs=42116&id=42625

REVISION DETAIL
  https://phabricator.kde.org/D15091

AFFECTED FILES
  find-modules/FindPythonModuleGeneration.cmake
  find-modules/run-sip.py

To: arojas, #frameworks, bruns
Cc: rdieter, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D15859: allow non-local file:// redirect to a M$-WebDav URL

[Martin Koller]

mkoller updated this revision to Diff 42626.
mkoller added a comment.


  M$ -> windows
  
  About SSL: I have no idea how an SSL url from a sharepoint server would look 
like, since it seems the setup we use does not use ssl.
  The mentioned webdavsystem.com link just describes how it would look like as 
a win-UNC path, but since I receive urls in mail which are not in the unc 
syntax, I'm not sure if they will contain this @ssl token or not

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15859?vs=42603&id=42626

REVISION DETAIL
  https://phabricator.kde.org/D15859

AFFECTED FILES
  file.cpp
  file.h
  file_unix.cpp
  file_win.cpp

To: mkoller, dfaure, #frameworks
Cc: bruns, ngraham, kde-frameworks-devel, michaelh

D15843: Allow FileIndexerConfig to check device mounted status by path.

[James Smith]

smithjd added a comment.


  In D15843#334230 , @bruns wrote:
  
  > Most obvious problem with this change - as far as I can deduce from your 
description, this is about runtime behaviour. The config class is the wrong 
place to add this method.
  
  
  This isn't that different from shouldBeIndexed and it's related methods. 
Anywhere else would require exporting the StorageDevices object, already 
actively opposed by you: https://phabricator.kde.org/D15047?
  
  Please provide a credible alternative if you're going to oppose new 
additions, or oppose new features and clearly explain your opposition if you 
intend to block them by opposing new additions.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D15843

To: smithjd, #baloo, bruns
Cc: ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, 
spoorun, bruns, abrahams

D15866: Reduce emblem size for very small icons to prevent obscuring too much of the icon

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: Frameworks, Dolphin, VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  An icon's emblem can take up 25% of the total icon area in certain cases, 
which obscures enough of the icon that it may become hard to tell what it is. 
This is especially noticeable with 16x16 and 32x32 icons in Dolphin's Places 
Panel. See T9740#162147  for examples.
  
  This patch adjusts the calculation so that the emblem never takes up more 
then 18.75% of the total area of an icon, even at small sizes. As a result, the 
icons are less obscured by their emblems.

TEST PLAN
  [images go here]
  
  [images depict the new hard drive icon introduced with D15853 
]

REPOSITORY
  R302 KIconThemes

BRANCH
  smaller-emblems-at-small-sizes (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15866

AFFECTED FILES
  src/kiconloader.cpp

To: ngraham, #frameworks, #dolphin, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15866: Reduce emblem size for very small icons to prevent obscuring too much of the icon

[Nathaniel Graham]

ngraham added a task: T9740: Improve disk presentation in the Places panel.

REPOSITORY
  R302 KIconThemes

REVISION DETAIL
  https://phabricator.kde.org/D15866

To: ngraham, #frameworks, #dolphin, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15866: Reduce emblem size for very small icons to prevent obscuring too much of the icon

[Nathaniel Graham]

ngraham edited the summary of this revision.
ngraham edited the test plan for this revision.

REPOSITORY
  R302 KIconThemes

REVISION DETAIL
  https://phabricator.kde.org/D15866

To: ngraham, #frameworks, #dolphin, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15843: Allow FileIndexerConfig to check device mounted status by path.

[Stefan Brüns]

bruns added a comment.


  To cite myself from the mentioned review:
  
  > There is no need for this, just create a new StorageDevices where you need 
it.
  >  Creating a second StorageDevices instance in a process is quite cheap.
  
  If you need the info in DatabaseSanitizer, create the StorageDevices there ...

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D15843

To: smithjd, #baloo, bruns
Cc: ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, 
spoorun, bruns, abrahams

D15843: Allow FileIndexerConfig to check device mounted status by path.

[Stefan Brüns]

bruns added a comment.


  As a side note - cross-device indexing is broken anyway and can never work 
reliably in the current scheme using device ids as part of the baloo document 
id. Device ids are not stable. For the home partition it works somewhat 
reliable as the device setup is sufficiently fixed, but for any network share, 
Vault, disk image, whatever, it depends on the mounting order.
  
  I will keep opposing any changes trying to paper over it.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D15843

To: smithjd, #baloo, bruns
Cc: ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, 
spoorun, bruns, abrahams

D14632: keyword rule: Spport for keywords inclusion from another language/file

[jonathan poelen]

jpoelen updated this revision to Diff 42628.
jpoelen added a comment.


  - fix the recursion detection and handling of nested included keyword lists

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14632?vs=41872&id=42628

BRANCH
  kwinclude

REVISION DETAIL
  https://phabricator.kde.org/D14632

AFFECTED FILES
  autotests/syntaxrepository_test.cpp
  data/schema/language.xsd
  data/syntax/scss.xml
  src/indexer/katehighlightingindexer.cpp
  src/lib/definition.cpp
  src/lib/definition_p.h
  src/lib/keywordlist.cpp
  src/lib/keywordlist_p.h

To: jpoelen, #framework_syntax_highlighting, cullmann, dhaumann
Cc: kwrite-devel, vkrause, kde-frameworks-devel, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D15739: [Places panel] Don't show Root by default

[Roman Gilg]

romangg added a comment.


  Imo this patch can go in as it is, but before that I would like to see a 
patch to have the disk with the root file system getting specially marked 
(icon, color or text) for the case that several block devices are mounted at 
the same time.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15739

To: ngraham, #dolphin, #vdg, davidedmundson
Cc: romangg, bruns, davidedmundson, abetts, svenmauch, broulik, acrouthamel, 
kde-frameworks-devel, michaelh, ngraham

D15843: Allow FileIndexerConfig to check device mounted status by path.

[James Smith]

smithjd added a comment.


  >> There is no need for this, just create a new StorageDevices where you need 
it.
  >> Creating a second StorageDevices instance in a process is quite cheap.
  > 
  > Creating a separate object cluttered the console with duplicated debug 
output and raised a threading error.
  
  No go.
  
  This patch is a little bit tidier than exporting the StorageDevices object. 
Both are sufficient for being able to verify that the path is mounted.
  
  > As a side note - cross-device indexing is broken anyway and can never work 
reliably in the current scheme using device ids as part of the baloo document 
id. Device ids are not stable. For the home partition it works somewhat 
reliable as the device setup is sufficiently fixed, but for any network share, 
Vault, disk image, whatever, it depends on the mounting order.
  
  
  
  > I will keep opposing any changes trying to paper over it.
  
  I have not had a problem with mounted external volumes. FYI, complain to the 
Solid people about the non-randomness of the udi. That isn't a fault of Baloo.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D15843

To: smithjd, #baloo, bruns
Cc: ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, 
spoorun, bruns, abrahams

D15843: Allow FileIndexerConfig to check device mounted status by path.

[Stefan Brüns]

bruns added a comment.


  In D15843#334515 , @smithjd wrote:
  
  > >> There is no need for this, just create a new StorageDevices where you 
need it.
  > >> Creating a second StorageDevices instance in a process is quite cheap.
  > > 
  > > Creating a separate object cluttered the console with duplicated debug 
output and raised a threading error.
  >
  > No go.
  >
  > This patch is a little bit tidier than exporting the StorageDevices object. 
Both are sufficient for being able to verify that the path is mounted.
  
  
  You should not export it but create an instance ...
  
  >> As a side note - cross-device indexing is broken anyway and can never work 
reliably in the current scheme using device ids as part of the baloo document 
id. Device ids are not stable. For the home partition it works somewhat 
reliable as the device setup is sufficiently fixed, but for any network share, 
Vault, disk image, whatever, it depends on the mounting order.
  > 
  > 
  > 
  >> I will keep opposing any changes trying to paper over it.
  > 
  > I have not had a problem with mounted external volumes. FYI, complain to 
the Solid people about the non-randomness of the udi. That isn't a fault of 
Baloo.
  
  You clearly lack understanding of the problem. This is not about solid UDIs, 
but about device ids provided by the kernel (man 7 inode) . Complain to the 
Linux folks!?

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D15843

To: smithjd, #baloo, bruns
Cc: ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, 
spoorun, bruns, abrahams

D15843: Allow FileIndexerConfig to check device mounted status by path.

[James Smith]

smithjd added a comment.


  >>> As a side note - cross-device indexing is broken anyway and can never 
work reliably in the current scheme using device ids as part of the baloo 
document id. Device ids are not stable. For the home partition it works 
somewhat reliable as the device setup is sufficiently fixed, but for any 
network share, Vault, disk image, whatever, it depends on the mounting order.
  >> 
  >> 
  >> 
  >>> I will keep opposing any changes trying to paper over it.
  >> 
  >> I have not had a problem with mounted external volumes. FYI, complain to 
the Solid people about the non-randomness of the udi. That isn't a fault of 
Baloo.
  > 
  > You clearly lack understanding of the problem. This is not about solid 
UDIs, but about device ids provided by the kernel (man 7 inode) . Complain to 
the Linux folks!?
  
  That isn't a problem I'm particularly concerned with, that observance being 
unrelated to this patch. Is there a bug filed?

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D15843

To: smithjd, #baloo, bruns
Cc: ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, 
spoorun, bruns, abrahams

D15843: Allow FileIndexerConfig to check device mounted status by path.

[Nathaniel Graham]

ngraham added a comment.


  Perhaps we should discuss the implementation of multi-device indexing in a 
Phab ticket instead of across the comments of multiple patches. Then we can 
settle on an agreed-upon approach and go implement it instead of going in 
circles with different approaches.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D15843

To: smithjd, #baloo, bruns
Cc: ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, 
spoorun, bruns, abrahams

D15866: Reduce emblem size for very small icons to prevent obscuring too much of the icon

[Noah Davis]

ndavis added a comment.


  The emblem for the 16px version is too small to read. What if instead of the 
emblem being on top of the icon, it was off to the side? Then it wouldn't 
matter what size the emblem is as long as it looks good where it is.

REPOSITORY
  R302 KIconThemes

REVISION DETAIL
  https://phabricator.kde.org/D15866

To: ngraham, #frameworks, #dolphin, #vdg
Cc: ndavis, kde-frameworks-devel, michaelh, ngraham, bruns

D15070: Bindings: Query the install directory from python

[Stefan Brüns]

bruns updated this revision to Diff 42629.
bruns added a comment.


  Use same pattern as KDE_INSTALL_USE_QT_SYS_PATHS

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15070?vs=42605&id=42629

BRANCH
  python3_support

REVISION DETAIL
  https://phabricator.kde.org/D15070

AFFECTED FILES
  find-modules/FindPythonModuleGeneration.cmake

To: bruns, #frameworks
Cc: cgiboudeaux, bcooksley, kde-frameworks-devel, kde-buildsystem, michaelh, 
ngraham, bruns

D15867: Bindings: Remove INSTALL_DIR_SUFFIX from ecm_generate_python_binding

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Frameworks, apol.
Herald added projects: Frameworks, Build System.
Herald added subscribers: kde-buildsystem, kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  The option is no longer used from any framework, and was always defaulting
  to site-packages previously, as INSTALL_DIR_SUFFIX was empty.
  
  Also see D15558 , D15845 
.

TEST PLAN
  build e.g kcoreaddons

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D15867

AFFECTED FILES
  find-modules/FindPythonModuleGeneration.cmake

To: bruns, #frameworks, apol
Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D15070: Bindings: Query the install directory from python

[Stefan Brüns]

bruns added a dependency: D15867: Bindings: Remove INSTALL_DIR_SUFFIX from 
ecm_generate_python_binding.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D15070

To: bruns, #frameworks
Cc: cgiboudeaux, bcooksley, kde-frameworks-devel, kde-buildsystem, michaelh, 
ngraham, bruns

D15867: Bindings: Remove INSTALL_DIR_SUFFIX from ecm_generate_python_binding

[Stefan Brüns]

bruns added a dependent revision: D15070: Bindings: Query the install directory 
from python.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D15867

To: bruns, #frameworks, apol
Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D15070: Bindings: Query the install directory from python

[Stefan Brüns]

bruns added a comment.


  Thanks to arc for throwing my commit message away ...

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D15070

To: bruns, #frameworks
Cc: cgiboudeaux, bcooksley, kde-frameworks-devel, kde-buildsystem, michaelh, 
ngraham, bruns

D15070: Bindings: Support using sys paths for python install directory

[Stefan Brüns]

bruns updated this revision to Diff 42631.
bruns retitled this revision from "Bindings: Query the install directory from 
python" to "Bindings: Support using sys paths for python install directory".
bruns edited the summary of this revision.
bruns edited the test plan for this revision.
bruns added a comment.


  Update summary/test plan

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15070?vs=42629&id=42631

REVISION DETAIL
  https://phabricator.kde.org/D15070

AFFECTED FILES
  find-modules/FindPythonModuleGeneration.cmake

To: bruns, #frameworks
Cc: cgiboudeaux, bcooksley, kde-frameworks-devel, kde-buildsystem, michaelh, 
ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 414 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/414/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 01 Oct 2018 03:47:29 +
 Build duration:
5 min 58 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 58 test(s), Skipped: 0 test(s), Total: 60 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesmodeltestFailed: TestSuite.kiofilewidgets-kfilewidgettest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(261/397)66%
(261/397)52%
(31473/6)36%
(15934/43890)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(56/56)100%
(56/56)91%
(8607/9499)42%
(3792/8928)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(113/166)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(100/116)86%
(100/116)58%
(8297/14346)50%
(4637/9275)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets76%
(28/37)76%
(28/37)49%
(3862/7923)33%
(1536/4667)src.gui100%
(2/2)100%
(2/2)94%
(103/109)74%
(49/66)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(527/1022)38%
(315/830)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1364)0%
(0/1414)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/245)0%
(0/144)src.ioslaves.http88%
(7/8)88%
(7/8)41%
(1775/4317)35%
(1304/3684)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1331)55%
(620/1123)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/257)7%
(14/212)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%
(0/12)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash56%
(5/9)56%
   

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.9 - Build # 259 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.9/259/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Mon, 01 Oct 2018 03:47:29 +
 Build duration:
27 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 59 test(s), Skipped: 0 test(s), Total: 60 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(261/397)66%
(261/397)53%
(31548/6)36%
(15976/43888)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(56/56)100%
(56/56)91%
(8607/9499)42%
(3792/8928)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(113/166)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(100/116)86%
(100/116)58%
(8372/14347)50%
(4672/9279)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets76%
(28/37)76%
(28/37)49%
(3846/7922)33%
(1530/4667)src.gui100%
(2/2)100%
(2/2)94%
(103/109)74%
(49/66)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(528/1022)38%
(316/830)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1364)0%
(0/1414)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/245)0%
(0/144)src.ioslaves.http88%
(7/8)88%
(7/8)41%
(1770/4317)35%
(1306/3684)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(629/1331)55%
(619/1123)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/257)7%
(14/212)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%
(0/12)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash56%
(5/9)56%
(5/9)52%
  

D15853: Change drive-harddisk to more adaptable style

[Phil Stefan]

pstefan accepted this revision.
pstefan added a comment.
This revision is now accepted and ready to land.


  Thank you for the changes!
  
  And I will change once I come around to it.

REPOSITORY
  R266 Breeze Icons

BRANCH
  new-harddisk-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15853

To: ndavis, #vdg, ngraham, pstefan
Cc: pstefan, ngraham, bruns, kde-frameworks-devel, michaelh