D16488: [KFileMetaData] Add helper for XML encoded Dublin Core metadata

bruns created this revision. bruns added reviewers: Frameworks, astippich. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY Dublin Core metadata is used by several file formats, e.g. ODF,

D5802: ViewPrivate, KateSearchBar, KateVi::MatchHighlighter: use selection foreground for search highlights

intelfx added a comment. In D5802#349761 , @dhaumann wrote: > - just because we cannot match a theme 100% does not imply that we have to adapt our implementation (there will always be a color in theme xy that does not properly exist in

D16494: Take 1..n KMainWindows in kRestoreMainWindows

tobiasdeiminger created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. tobiasdeiminger requested review of this revision. REVISION SUMMARY We've got C++11 and can turn KMainWindow::kRestoreMainWindows into a variadic template to support more

D16498: [KFileMetaData] Add extractor for DSC conforming (Encapsulated) Postscript

bruns created this revision. bruns added reviewers: Frameworks, Baloo, astippich, ngraham, poboiko. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY Postscript files currently fall back to the

D15070: Bindings: Support using sys paths for python install directory

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R240:258d6e412435: Bindings: Support using sys paths for python install directory (authored by bruns). REPOSITORY R240

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.9 - Build # 76 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.9/76/ Project: kf5-qt5 SUSEQt5.9 Date of build: Sun, 28 Oct 2018 16:59:46 + Build duration: 1 min 40 sec and counting JUnit Tests Name: (root)

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.9 - Build # 75 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.9/75/ Project: kf5-qt5 SUSEQt5.9 Date of build: Sun, 28 Oct 2018 16:53:29 + Build duration: 6 min 16 sec and counting JUnit Tests Name: (root)

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.9 - Build # 79 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.9/79/ Project: kf5-qt5 SUSEQt5.9 Date of build: Sun, 28 Oct 2018 17:11:35 + Build duration: 5 min 25 sec and counting JUnit Tests Name: (root)

D16464: [KSambaShare] Trim trailing / from share path

aacid added a comment. In case you didn't see it, you broke compilation with Qt 5.9 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16464 To: bruns, #frameworks, broulik Cc: aacid, kde-frameworks-devel, michaelh, ngraham, bruns

D16494: Take 1..n KMainWindows in kRestoreMainWindows

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R263 KXmlGui BRANCH restore_more_windows REVISION DETAIL https://phabricator.kde.org/D16494 To: tobiasdeiminger, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16490: [KFileMetaData] Add unittest for XML extractor

bruns added a dependency: D16489: [KFileMetaData] Add extractor for generic XML and SVG. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D16490 To: bruns, #frameworks, astippich Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun,

D16489: [KFileMetaData] Add extractor for generic XML and SVG

bruns added a dependent revision: D16490: [KFileMetaData] Add unittest for XML extractor. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D16489 To: bruns, #frameworks, astippich Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun,

D16464: [KSambaShare] Trim trailing / from share path

bruns added a comment. In D16464#349869 , @aacid wrote: > In case you didn't see it, you broke compilation with Qt 5.9 Should be fixed: https://commits.kde.org/kio/9eb7e24aeb993f48d95b9dd4f6a3c18c33402f92 REPOSITORY R241 KIO

D16486: implement support for reading ID3 tags from aiff and wav files

bruns accepted this revision. This revision is now accepted and ready to land. REPOSITORY R286 KFileMetaData BRANCH extract_aiff_riff REVISION DETAIL https://phabricator.kde.org/D16486 To: astippich, mgallien, bruns Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich,

D16500: Wait for docbookl10nhelper to be built before building our own manpages

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R238 KDocTools BRANCH master REVISION DETAIL https://phabricator.kde.org/D16500 To: aacid, apol Cc: kde-frameworks-devel, kde-doc-english, ltoscano, michaelh, ngraham, bruns, skadinna

D16486: implement support for reading ID3 tags from aiff and wav files

astippich created this revision. astippich added reviewers: mgallien, bruns. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY implement ID3 tags for aiff and wav files as supported by

D16490: [KFileMetaData] Add unittest for XML extractor

bruns created this revision. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. bruns requested review of this revision. REPOSITORY R286 KFileMetaData BRANCH xml_extractor REVISION DETAIL https://phabricator.kde.org/D16490 AFFECTED FILES

D16490: [KFileMetaData] Add unittest for XML extractor

bruns edited the test plan for this revision. bruns added reviewers: Frameworks, astippich. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D16490 To: bruns, #frameworks, astippich Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun,

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.9 - Build # 294 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.9/294/ Project: kf5-qt5 SUSEQt5.9 Date of build: Sun, 28 Oct 2018 17:37:04 + Build duration: 5 min 34 sec and counting JUnit Tests Name: (root) Failed: 0

D16488: [KFileMetaData] Add helper for XML encoded Dublin Core metadata

bruns added a dependent revision: D16489: [KFileMetaData] Add extractor for generic XML and SVG. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D16488 To: bruns, #frameworks, astippich Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun,

D16489: [KFileMetaData] Add extractor for generic XML and SVG

bruns created this revision. bruns added reviewers: Frameworks, astippich. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY Currently, both XML and SVG documents are indexed as plain text

D16500: Wait for docbookl10nhelper to be built before building our own manpages

aacid created this revision. Herald added projects: Frameworks, Documentation. Herald added subscribers: kde-doc-english, kde-frameworks-devel. aacid requested review of this revision. REVISION SUMMARY BUGS: 398263 REPOSITORY R238 KDocTools BRANCH master REVISION DETAIL

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 97 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/97/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sun, 28 Oct 2018 17:08:34 + Build duration: 1 min 22 sec and counting JUnit Tests Name:

D16464: [KSambaShare] Trim trailing / from share path

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH net_usershare REVISION DETAIL https://phabricator.kde.org/D16464 To: bruns, #frameworks, broulik Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15960: Don't check if file is directory based on mime-type

bruns requested changes to this revision. bruns added a comment. This revision now requires changes to proceed. Can you update the summary? Code wise its good to go. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D15960 To: poboiko, #baloo, #frameworks, bruns Cc:

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.9 - Build # 78 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.9/78/ Project: kf5-qt5 SUSEQt5.9 Date of build: Sun, 28 Oct 2018 17:08:34 + Build duration: 3 min 0 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 98 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/98/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sun, 28 Oct 2018 17:10:44 + Build duration: 1 min 24 sec and counting JUnit Tests Name:

D15645: Add scheme selection menu with a "System" entry.

amhndu updated this revision to Diff 44342. amhndu added a comment. > kcolorschemedemo.cpp does not actually seem to build an executable. It should build `kcolorschemedemo` in `kconfigwidgets/bin` (also has `kcolorschemedemo` target in make) > Regardless, wouldn't it make sense to

D16464: [KSambaShare] Trim trailing / from share path

This revision was automatically updated to reflect the committed changes. Closed by commit R241:0c8506f982e0: [KSambaShare] Trim trailing / from share path (authored by bruns). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16464?vs=44320=44358 REVISION DETAIL

D16283: implement more tags for asf metadata

bruns accepted this revision. bruns added a comment. This revision is now accepted and ready to land. Add the comment, otherwise its fine. INLINE COMMENTS > taglibextractor.cpp:843 > +} else if (mimeType == QLatin1String("audio/x-ms-wma")) { > +TagLib::ASF::Tag* asfTags =

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 94 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/94/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sun, 28 Oct 2018 16:53:29 + Build duration: 1 min 33 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 95 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/95/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sun, 28 Oct 2018 16:55:04 + Build duration: 2 min 4 sec and counting JUnit Tests Name: (root)

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 99 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/99/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sun, 28 Oct 2018 17:18:14 + Build duration: 1 min 29 sec and counting JUnit Tests Name: (root)

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.9 - Build # 80 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.9/80/ Project: kf5-qt5 SUSEQt5.9 Date of build: Sun, 28 Oct 2018 17:18:14 + Build duration: 1 min 29 sec and counting JUnit Tests Name: (root)

D16347: Expose KTextEditor::ViewPrivate:setInputMode(InputMode) to KTextEditor::View

kossebau resigned from this revision. kossebau added a comment. Not my domain, so resigning as reviewer :) REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D16347 To: demsking, mlaurent, vkrause, dhaumann, cullmann Cc: cullmann, kwrite-devel, kde-frameworks-devel,

D5802: ViewPrivate, KateSearchBar, KateVi::MatchHighlighter: use selection foreground for search highlights

kossebau added a comment. No insight into the topic, but seeing this in my review request list (KDevelop): Given KTextEditor was ported to KSyntaxHighlighting now, what can be said about this patch? Does it still apply? What foreground color options are there now for search highlights?

D16282: extract ape tags from ape and wavpack files

bruns accepted this revision. This revision is now accepted and ready to land. REPOSITORY R286 KFileMetaData BRANCH extract_ape_wavpack REVISION DETAIL https://phabricator.kde.org/D16282 To: astippich, mgallien, bruns Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich,

D16197: provide a list of supported mimetypes for embeddedimagedata

bruns accepted this revision. This revision is now accepted and ready to land. REPOSITORY R286 KFileMetaData BRANCH mimetypes_embedded_image REVISION DETAIL https://phabricator.kde.org/D16197 To: astippich, bruns, mgallien Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh,

D16197: provide a list of supported mimetypes for embeddedimagedata

This revision was automatically updated to reflect the committed changes. Closed by commit R286:1e9705162343: provide a list of supported mimetypes for embeddedimagedata (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.9 - Build # 77 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.9/77/ Project: kf5-qt5 SUSEQt5.9 Date of build: Sun, 28 Oct 2018 17:03:19 + Build duration: 55 sec and counting CONSOLE OUTPUT [...truncated

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 96 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/96/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sun, 28 Oct 2018 17:03:19 + Build duration: 1 min 31 sec and counting JUnit Tests Name:

D16283: implement more tags for asf metadata

This revision was automatically updated to reflect the committed changes. Closed by commit R286:02e8cab069ff: implement more tags for asf metadata (authored by astippich). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D16283?vs=43885=44366#toc REPOSITORY R286 KFileMetaData CHANGES

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.9 - Build # 293 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.9/293/ Project: kf5-qt5 SUSEQt5.9 Date of build: Sun, 28 Oct 2018 15:32:24 + Build duration: 3 min 44 sec and counting CONSOLE OUTPUT [...truncated 224.56

D16281: update epub test data and test for comment property

bruns accepted this revision. This revision is now accepted and ready to land. REPOSITORY R286 KFileMetaData BRANCH description_test_preparation REVISION DETAIL https://phabricator.kde.org/D16281 To: astippich, bruns Cc: cfeck, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh,

D16282: extract ape tags from ape and wavpack files

This revision was automatically updated to reflect the committed changes. Closed by commit R286:4582ba5f3d7a: extract ape tags from ape and wavpack files (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16282?vs=43821=44365

D16281: update epub test data and test for comment property

This revision was automatically updated to reflect the committed changes. Closed by commit R286:d97b15679179: update epub test data and test for comment property (authored by astippich). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D16281?vs=43887=44364#toc REPOSITORY R286

D15645: Add scheme selection menu with a "System" entry.

amhndu marked an inline comment as done. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D15645 To: amhndu, #frameworks, broulik, cfeck, elvisangelaccio, ngraham, pino Cc: pino, ngraham, broulik, kde-frameworks-devel, michaelh, bruns

D5802: ViewPrivate, KateSearchBar, KateVi::MatchHighlighter: use selection foreground for search highlights

dhaumann added a comment. As I see we have the following situation - the current implementation does work reasonably well - just because we cannot match a theme 100% does not imply that we have to adapt our implementation (there will always be a color in theme xy that does not

D15826: [Balooshow] Avoid out-of-bounds access when accessing corrupt db data

bruns marked 3 inline comments as done. bruns added a comment. @poboiko - good to go? REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D15826 To: bruns, #baloo, #frameworks, poboiko Cc: anthonyfieroni, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun,

D15826: [Balooshow] Avoid out-of-bounds access when accessing corrupt db data

bruns marked 11 inline comments as done. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D15826 To: bruns, #baloo, #frameworks, poboiko Cc: anthonyfieroni, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D16395: Update the "About KDE" text

ngraham added a comment. So are folks good with the current text now? REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D16395 To: ngraham, #vdg, #plasma, #frameworks, #kde_applications, #kde_promo Cc: xyquadrat, rizzitello, ltoscano, aspotashev, abetts,

D15999: Add icons with added background to system.svgz

ngraham added a comment. Any update on this, @pstefan? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D15999 To: pstefan, ngraham, #vdg Cc: broulik, filipf, kde-frameworks-devel, michaelh, ngraham, bruns