D15999: Add icons with added background to system.svgz

[Nathaniel Graham]

ngraham added a comment.


  Any update on this, @pstefan?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D15999

To: pstefan, ngraham, #vdg
Cc: broulik, filipf, kde-frameworks-devel, michaelh, ngraham, bruns

D16395: Update the "About KDE" text

[Nathaniel Graham]

ngraham added a comment.


  So are folks good with the current text now?

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D16395

To: ngraham, #vdg, #plasma, #frameworks, #kde_applications, #kde_promo
Cc: xyquadrat, rizzitello, ltoscano, aspotashev, abetts, kde-frameworks-devel, 
michaelh, ngraham, bruns

D16500: Wait for docbookl10nhelper to be built before building our own manpages

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R238 KDocTools

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16500

To: aacid, apol
Cc: kde-frameworks-devel, kde-doc-english, ltoscano, michaelh, ngraham, bruns, 
skadinna

D16494: Take 1..n KMainWindows in kRestoreMainWindows

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R263 KXmlGui

BRANCH
  restore_more_windows

REVISION DETAIL
  https://phabricator.kde.org/D16494

To: tobiasdeiminger, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16500: Wait for docbookl10nhelper to be built before building our own manpages

[Albert Astals Cid]

aacid created this revision.
Herald added projects: Frameworks, Documentation.
Herald added subscribers: kde-doc-english, kde-frameworks-devel.
aacid requested review of this revision.

REVISION SUMMARY
  BUGS: 398263

REPOSITORY
  R238 KDocTools

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16500

AFFECTED FILES
  KF5DocToolsMacros.cmake

To: aacid
Cc: kde-frameworks-devel, kde-doc-english, ltoscano, michaelh, ngraham, bruns, 
skadinna

D16498: [KFileMetaData] Add extractor for DSC conforming (Encapsulated) Postscript

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Frameworks, Baloo, astippich, ngraham, poboiko.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  Postscript files currently fall back to the plaintext extractor due to
  mimetype inheritance. This adds lots of garbage to the index and misses
  any useful data in the DSC comments.

TEST PLAN
  make && ctest

REPOSITORY
  R286 KFileMetaData

BRANCH
  postscript_dsc

REVISION DETAIL
  https://phabricator.kde.org/D16498

AFFECTED FILES
  autotests/CMakeLists.txt
  autotests/postscriptdscextractortest.cpp
  autotests/postscriptdscextractortest.h
  autotests/samplefiles/test.eps
  autotests/samplefiles/test.ps
  src/extractors/CMakeLists.txt
  src/extractors/postscriptdscextractor.cpp
  src/extractors/postscriptdscextractor.h

To: bruns, #frameworks, #baloo, astippich, ngraham, poboiko
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D16494: Take 1..n KMainWindows in kRestoreMainWindows

[Tobias Deiminger]

tobiasdeiminger created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
tobiasdeiminger requested review of this revision.

REVISION SUMMARY
  We've got C++11 and can turn KMainWindow::kRestoreMainWindows into a variadic 
template to support more than 3 different toplevel widgets. Gives also minor 
code deduplication.

TEST PLAN
  Compile and execute kmainwindowrestoretest.

REPOSITORY
  R263 KXmlGui

BRANCH
  restore_more_windows

REVISION DETAIL
  https://phabricator.kde.org/D16494

AFFECTED FILES
  src/kmainwindow.h

To: tobiasdeiminger
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D5802: ViewPrivate, KateSearchBar, KateVi::MatchHighlighter: use selection foreground for search highlights

[Ivan Shapovalov]

intelfx added a comment.


  In D5802#349761 , @dhaumann wrote:
  
  > - just because we cannot match a theme 100% does not imply that we have to 
adapt our implementation (there will always be a color in theme xy that does 
not properly exist in KTextEditor)
  
  
  Solarized is not just a random color scheme. It's a pretty popular one. It 
could make sense to actually exert some effort to support it properly.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D5802

To: intelfx, #kdevelop, #ktexteditor, #kate, mwolff
Cc: kossebau, cullmann, kde-frameworks-devel, brauch, dhaumann, mwolff, 
kwrite-devel, michaelh, ngraham, bruns, demsking, sars

D16486: implement support for reading ID3 tags from aiff and wav files

[Stefan Brüns]

bruns accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R286 KFileMetaData

BRANCH
  extract_aiff_riff

REVISION DETAIL
  https://phabricator.kde.org/D16486

To: astippich, mgallien, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D16489: [KFileMetaData] Add extractor for generic XML and SVG

[Stefan Brüns]

bruns added a dependent revision: D16490: [KFileMetaData] Add unittest for XML 
extractor.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D16489

To: bruns, #frameworks, astippich
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D16490: [KFileMetaData] Add unittest for XML extractor

[Stefan Brüns]

bruns added a dependency: D16489: [KFileMetaData] Add extractor for generic XML 
and SVG.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D16490

To: bruns, #frameworks, astippich
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.9 - Build # 294 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.9/294/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Sun, 28 Oct 2018 17:37:04 +
 Build duration:
5 min 34 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 60 test(s), Skipped: 0 test(s), Total: 60 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(261/397)66%
(261/397)53%
(31997/59983)38%
(16493/43916)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(56/56)100%
(56/56)95%
(9078/9517)48%
(4272/8942)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(113/166)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(100/116)86%
(100/116)58%
(8339/14319)50%
(4662/9265)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets76%
(28/37)76%
(28/37)49%
(3885/7923)34%
(1589/4691)src.gui100%
(2/2)100%
(2/2)94%
(103/109)74%
(49/66)src.ioslaves.file100%
(5/5)100%
(5/5)51%
(525/1023)37%
(315/850)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1364)0%
(0/1414)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/144)src.ioslaves.http88%
(7/8)88%
(7/8)41%
(1774/4316)35%
(1304/3684)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(629/1331)55%
(619/1123)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/257)7%
(14/212)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%
(0/12)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash56%
(5/9)56%
(5/9)51%
(697/1372)42%

D16490: [KFileMetaData] Add unittest for XML extractor

[Stefan Brüns]

bruns edited the test plan for this revision.
bruns added reviewers: Frameworks, astippich.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D16490

To: bruns, #frameworks, astippich
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D16488: [KFileMetaData] Add helper for XML encoded Dublin Core metadata

[Stefan Brüns]

bruns added a dependent revision: D16489: [KFileMetaData] Add extractor for 
generic XML and SVG.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D16488

To: bruns, #frameworks, astippich
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D16489: [KFileMetaData] Add extractor for generic XML and SVG

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Frameworks, astippich.
Herald added projects: Frameworks, Baloo.
Herald added subscribers: Baloo, kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  Currently, both XML and SVG documents are indexed as plain text due
  to mimetype inheritance. This fills the content index with meaningless
  data (tags, attributes, attribute values ...).
  
  Use QDomElement::text() for generic XML documents and  nodes
  for SVG to extract the content. Also try do find Dublin Core metadata
  and add the relevant properties.
  
  Depends on D16488 

REPOSITORY
  R286 KFileMetaData

BRANCH
  xml_extractor

REVISION DETAIL
  https://phabricator.kde.org/D16489

AFFECTED FILES
  src/extractors/CMakeLists.txt
  src/extractors/xmlextractor.cpp
  src/extractors/xmlextractor.h

To: bruns, #frameworks, astippich
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D16490: [KFileMetaData] Add unittest for XML extractor

[Stefan Brüns]

bruns created this revision.
Herald added projects: Frameworks, Baloo.
Herald added subscribers: Baloo, kde-frameworks-devel.
bruns requested review of this revision.

REPOSITORY
  R286 KFileMetaData

BRANCH
  xml_extractor

REVISION DETAIL
  https://phabricator.kde.org/D16490

AFFECTED FILES
  autotests/CMakeLists.txt
  autotests/samplefiles/test_with_metadata.svg
  autotests/xmlextractortest.cpp
  autotests/xmlextractortest.h

To: bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D16488: [KFileMetaData] Add helper for XML encoded Dublin Core metadata

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Frameworks, astippich.
Herald added projects: Frameworks, Baloo.
Herald added subscribers: Baloo, kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  Dublin Core metadata is used by several file formats, e.g. ODF,
  MS Office 2007 (Office XML) and SVG. Add a helper which can be
  used by the extractors.

REPOSITORY
  R286 KFileMetaData

BRANCH
  xml_extractor

REVISION DETAIL
  https://phabricator.kde.org/D16488

AFFECTED FILES
  src/extractors/dublincoreextractor.cpp
  src/extractors/dublincoreextractor.h

To: bruns, #frameworks, astippich
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D16464: [KSambaShare] Trim trailing / from share path

[Stefan Brüns]

bruns added a comment.


  In D16464#349869 , @aacid wrote:
  
  > In case you didn't see it, you broke compilation with Qt 5.9
  
  
  Should be fixed:
  https://commits.kde.org/kio/9eb7e24aeb993f48d95b9dd4f6a3c18c33402f92

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D16464

To: bruns, #frameworks, broulik
Cc: aacid, kde-frameworks-devel, michaelh, ngraham, bruns

D16464: [KSambaShare] Trim trailing / from share path

[Albert Astals Cid]

aacid added a comment.


  In case you didn't see it, you broke compilation with Qt 5.9

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D16464

To: bruns, #frameworks, broulik
Cc: aacid, kde-frameworks-devel, michaelh, ngraham, bruns

D16486: implement support for reading ID3 tags from aiff and wav files

[Alexander Stippich]

astippich created this revision.
astippich added reviewers: mgallien, bruns.
Herald added projects: Frameworks, Baloo.
Herald added subscribers: Baloo, kde-frameworks-devel.
astippich requested review of this revision.

REVISION SUMMARY
  implement ID3 tags for aiff and wav files as supported by taglib

REPOSITORY
  R286 KFileMetaData

BRANCH
  extract_aiff_riff

REVISION DETAIL
  https://phabricator.kde.org/D16486

AFFECTED FILES
  autotests/samplefiles/test.aif
  autotests/samplefiles/test.mp3
  autotests/samplefiles/test.wav
  autotests/taglibextractortest.cpp
  src/extractors/taglibextractor.cpp

To: astippich, mgallien, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 99 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/99/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sun, 28 Oct 2018 17:18:14 +
 Build duration:
1 min 29 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 15 test(s), Skipped: 0 test(s), Total: 15 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report80%
(4/5)86%
(43/50)86%
(43/50)80%
(2770/3456)48%
(4128/8606)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(14/14)100%
(14/14)98%
(704/722)49%
(1563/3194)src75%
(18/24)75%
(18/24)79%
(998/1266)45%
(479/1073)src.extractors100%
(10/10)100%
(10/10)73%
(1027/1399)48%
(2014/4176)src.writers100%
(1/1)100%
(1/1)98%
(41/42)48%
(72/151)tests0%
(0/1)0%
(0/1)0%
(0/27)0%
(0/12)

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.9 - Build # 80 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.9/80/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Sun, 28 Oct 2018 17:18:14 +
 Build duration:
1 min 29 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 15 test(s), Skipped: 0 test(s), Total: 15 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report80%
(4/5)86%
(43/50)86%
(43/50)80%
(2771/3456)48%
(4113/8570)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(14/14)100%
(14/14)98%
(704/722)49%
(1563/3194)src75%
(18/24)75%
(18/24)79%
(999/1266)45%
(480/1073)src.extractors100%
(10/10)100%
(10/10)73%
(1027/1399)48%
(1998/4140)src.writers100%
(1/1)100%
(1/1)98%
(41/42)48%
(72/151)tests0%
(0/1)0%
(0/1)0%
(0/27)0%
(0/12)

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.9 - Build # 79 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.9/79/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Sun, 28 Oct 2018 17:11:35 +
 Build duration:
5 min 25 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 14 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.taglibextractortest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report80%
(4/5)86%
(43/50)86%
(43/50)80%
(2771/3456)48%
(4112/8570)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(14/14)100%
(14/14)98%
(704/722)49%
(1564/3194)src75%
(18/24)75%
(18/24)79%
(999/1266)45%
(480/1073)src.extractors100%
(10/10)100%
(10/10)73%
(1027/1399)48%
(1996/4140)src.writers100%
(1/1)100%
(1/1)98%
(41/42)48%
(72/151)tests0%
(0/1)0%
(0/1)0%
(0/27)0%
(0/12)

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 98 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/98/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sun, 28 Oct 2018 17:10:44 +
 Build duration:
1 min 24 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 14 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.taglibextractortest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report80%
(4/5)86%
(43/50)86%
(43/50)80%
(2770/3456)48%
(4127/8606)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(14/14)100%
(14/14)98%
(704/722)49%
(1564/3194)src75%
(18/24)75%
(18/24)79%
(998/1266)45%
(479/1073)src.extractors100%
(10/10)100%
(10/10)73%
(1027/1399)48%
(2012/4176)src.writers100%
(1/1)100%
(1/1)98%
(41/42)48%
(72/151)tests0%
(0/1)0%
(0/1)0%
(0/27)0%
(0/12)

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.9 - Build # 78 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.9/78/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Sun, 28 Oct 2018 17:08:34 +
 Build duration:
3 min 0 sec and counting
   CONSOLE OUTPUT
  [...truncated 197.57 KB...][ 51%] Linking CXX shared module ../../bin/kf5/kfilemetadata/kfilemetadata_exiv2extractor.so[ 52%] Building CXX object src/extractors/CMakeFiles/kfilemetadata_taglibextractor.dir/kfilemetadata_taglibextractor_autogen/mocs_compilation.cpp.o[ 53%] Linking CXX shared module ../../bin/kf5/kfilemetadata/kfilemetadata_officeextractor.so[ 53%] Built target kfilemetadata_exiv2extractor[ 53%] Built target kfilemetadata_officeextractorScanning dependencies of target popplerextractortestScanning dependencies of target usermetadatawritertest[ 54%] Building CXX object autotests/CMakeFiles/usermetadatawritertest.dir/usermetadatawritertest.cpp.o[ 55%] Building CXX object autotests/CMakeFiles/popplerextractortest.dir/popplerextractortest.cpp.o[ 56%] Linking CXX shared module ../../bin/kf5/kfilemetadata/kfilemetadata_poextractor.so[ 56%] Built target kfilemetadata_poextractorScanning dependencies of target propertyinfotest[ 57%] Building CXX object autotests/CMakeFiles/propertyinfotest.dir/propertyinfotest.cpp.o[ 58%] Linking CXX shared module ../../bin/kf5/kfilemetadata/kfilemetadata_odfextractor.so[ 58%] Linking CXX shared module ../../bin/kf5/kfilemetadata/kfilemetadata_taglibextractor.so[ 59%] Building CXX object src/writers/CMakeFiles/kfilemetadata_taglibwriter.dir/kfilemetadata_taglibwriter_autogen/mocs_compilation.cpp.o[ 59%] Built target kfilemetadata_odfextractorScanning dependencies of target epubextractortest[ 59%] Building CXX object autotests/CMakeFiles/epubextractortest.dir/epubextractortest.cpp.o[ 59%] Built target kfilemetadata_taglibextractorScanning dependencies of target officeextractortest[ 59%] Building CXX object autotests/CMakeFiles/officeextractortest.dir/office2007extractortest.cpp.o[ 60%] Building CXX object autotests/CMakeFiles/popplerextractortest.dir/__/src/extractors/popplerextractor.cpp.o[ 60%] Building CXX object autotests/CMakeFiles/usermetadatawritertest.dir/__/src/usermetadata.cpp.o[ 60%] Linking CXX shared module ../../bin/kfilemetadata_taglibwriter.so[ 60%] Built target kfilemetadata_taglibwriterScanning dependencies of target exiv2extractortest[ 61%] Building CXX object autotests/CMakeFiles/exiv2extractortest.dir/exiv2extractortest.cpp.o[ 61%] Building CXX object autotests/CMakeFiles/propertyinfotest.dir/propertyinfotest_autogen/mocs_compilation.cpp.o[ 62%] Building CXX object autotests/CMakeFiles/epubextractortest.dir/__/src/extractors/epubextractor.cpp.o/home/jenkins/workspace/Frameworks/kfilemetadata/kf5-qt5 SUSEQt5.9/src/extractors/popplerextractor.cpp: In member function ���virtual void KFileMetaData::PopplerExtractor::extract(KFileMetaData::ExtractionResult*)���:/home/jenkins/workspace/Frameworks/kfilemetadata/kf5-qt5 SUSEQt5.9/src/extractors/popplerextractor.cpp:79:77: warning: ���QDateTime Poppler::convertDate(char*)��� is deprecated [-Wdeprecated-declarations] result->add(Property::CreationDate, Poppler::convertDate(utf8.data())); ^In file included from /home/jenkins/workspace/Frameworks/kfilemetadata/kf5-qt5 SUSEQt5.9/src/extractors/popplerextractor.h:25, from /home/jenkins/workspace/Frameworks/kfilemetadata/kf5-qt5 SUSEQt5.9/src/extractors/popplerextractor.cpp:22:/usr/include/poppler/qt5/poppler-qt5.h:1965:52: note: declared here POPPLER_QT5_EXPORT Q_DECL_DEPRECATED QDateTime convertDate( char *dateString );^~~/home/jenkins/workspace/Frameworks/kfilemetadata/kf5-qt5 SUSEQt5.9/src/extractors/popplerextractor.cpp:79:77: warning: ���QDateTime Poppler::convertDate(char*)��� is deprecated [-Wdeprecated-declarations] result->add(Property::CreationDate, Poppler::convertDate(utf8.data())); ^In file included from /home/jenkins/workspace/Frameworks/kfilemetadata/kf5-qt5 SUSEQt5.9/src/extractors/popplerextractor.h:25, from /home/jenkins/workspace/Frameworks/kfilemetadata/kf5-qt5 SUSEQt5.9/src/extractors/popplerextractor.cpp:22:/usr/include/poppler/qt5/poppler-qt5.h:1965:52: note: declared here POPPLER_QT5_EXPORT Q_DECL_DEPRECATED QDateTime convertDate( char *dateString );^~~[ 63%] Building CXX object autotests/CMakeFiles/officeextractortest.dir/__/src/extractors/office2007extractor.cpp.o[ 64%] Building CXX object autotests/CMakeFiles/usermetadatawritertest.dir/usermetadatawritertest_autogen/mocs_compilation.cpp.o[ 64%] Building CXX object autotests/CMakeFiles/popplerextractortest.dir/popplerextractortest_autogen/mocs_compilation.cpp.o[ 65%] Linking CXX 

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 97 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/97/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sun, 28 Oct 2018 17:08:34 +
 Build duration:
1 min 22 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 14 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.taglibextractortest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report80%
(4/5)86%
(43/50)86%
(43/50)80%
(2770/3456)48%
(4127/8606)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(14/14)100%
(14/14)98%
(704/722)49%
(1564/3194)src75%
(18/24)75%
(18/24)79%
(998/1266)45%
(479/1073)src.extractors100%
(10/10)100%
(10/10)73%
(1027/1399)48%
(2012/4176)src.writers100%
(1/1)100%
(1/1)98%
(41/42)48%
(72/151)tests0%
(0/1)0%
(0/1)0%
(0/27)0%
(0/12)

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 96 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/96/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sun, 28 Oct 2018 17:03:19 +
 Build duration:
1 min 31 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.epubextractortestFailed: TestSuite.taglibextractortest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report80%
(4/5)86%
(43/50)86%
(43/50)80%
(2770/3456)48%
(4127/8606)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(14/14)100%
(14/14)98%
(704/722)49%
(1564/3194)src75%
(18/24)75%
(18/24)79%
(998/1266)45%
(479/1073)src.extractors100%
(10/10)100%
(10/10)73%
(1027/1399)48%
(2012/4176)src.writers100%
(1/1)100%
(1/1)98%
(41/42)48%
(72/151)tests0%
(0/1)0%
(0/1)0%
(0/27)0%
(0/12)

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.9 - Build # 77 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.9/77/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Sun, 28 Oct 2018 17:03:19 +
 Build duration:
55 sec and counting
   CONSOLE OUTPUT
  [...truncated 213.29 KB...]Scanning dependencies of target propertyinfotest[ 60%] Built target kfilemetadata_odfextractor[ 61%] Building CXX object autotests/CMakeFiles/propertyinfotest.dir/propertyinfotest.cpp.oScanning dependencies of target epubextractortest[ 61%] Building CXX object autotests/CMakeFiles/epubextractortest.dir/epubextractortest.cpp.o[ 61%] Built target kfilemetadata_taglibwriter[ 61%] Building CXX object autotests/CMakeFiles/propertyinfotest.dir/propertyinfotest_autogen/mocs_compilation.cpp.oScanning dependencies of target officeextractortest[ 62%] Building CXX object autotests/CMakeFiles/epubextractortest.dir/__/src/extractors/epubextractor.cpp.o[ 63%] Linking CXX executable ../bin/popplerextractortest[ 63%] Building CXX object autotests/CMakeFiles/officeextractortest.dir/office2007extractortest.cpp.o[ 64%] Building CXX object autotests/CMakeFiles/epubextractortest.dir/epubextractortest_autogen/mocs_compilation.cpp.o[ 65%] Building CXX object autotests/CMakeFiles/officeextractortest.dir/__/src/extractors/office2007extractor.cpp.o[ 65%] Built target popplerextractortest[ 66%] Building CXX object autotests/CMakeFiles/officeextractortest.dir/officeextractortest_autogen/mocs_compilation.cpp.oScanning dependencies of target exiv2extractortest[ 67%] Building CXX object autotests/CMakeFiles/exiv2extractortest.dir/exiv2extractortest.cpp.o[ 68%] Linking CXX executable ../bin/usermetadatawritertest[ 68%] Built target usermetadatawritertestScanning dependencies of target taglibwritertest[ 69%] Building CXX object autotests/CMakeFiles/taglibwritertest.dir/taglibwritertest.cpp.oScanning dependencies of target taglibextractortest[ 69%] Building CXX object autotests/CMakeFiles/taglibextractortest.dir/taglibextractortest.cpp.o[ 70%] Building CXX object autotests/CMakeFiles/taglibwritertest.dir/__/src/writers/taglibwriter.cpp.o[ 71%] Linking CXX executable ../bin/epubextractortest[ 71%] Building CXX object autotests/CMakeFiles/taglibwritertest.dir/taglibwritertest_autogen/mocs_compilation.cpp.o[ 72%] Linking CXX executable ../bin/propertyinfotestScanning dependencies of target embeddedimagedatatest[ 73%] Linking CXX executable ../bin/officeextractortest[ 73%] Building CXX object autotests/CMakeFiles/embeddedimagedatatest.dir/embeddedimagedatatest.cpp.o[ 74%] Building CXX object autotests/CMakeFiles/exiv2extractortest.dir/__/src/extractors/exiv2extractor.cpp.o[ 74%] Building CXX object autotests/CMakeFiles/exiv2extractortest.dir/exiv2extractortest_autogen/mocs_compilation.cpp.o[ 74%] Built target epubextractortest[ 74%] Built target propertyinfotest[ 75%] Building CXX object autotests/CMakeFiles/embeddedimagedatatest.dir/embeddedimagedatatest_autogen/mocs_compilation.cpp.oScanning dependencies of target externalextractortest[ 76%] Building CXX object autotests/CMakeFiles/externalextractortest.dir/externalextractortest.cpp.o[ 76%] Built target officeextractortest[ 77%] Building CXX object autotests/CMakeFiles/taglibextractortest.dir/__/src/extractors/taglibextractor.cpp.o[ 78%] Building CXX object autotests/CMakeFiles/taglibextractortest.dir/taglibextractortest_autogen/mocs_compilation.cpp.o[ 79%] Linking CXX executable ../bin/taglibwritertest[ 79%] Building CXX object autotests/CMakeFiles/externalextractortest.dir/__/src/externalextractor.cpp.o[ 80%] Building CXX object autotests/CMakeFiles/externalextractortest.dir/kfilemetadata_debug.cpp.o[ 81%] Building CXX object autotests/CMakeFiles/externalextractortest.dir/externalextractortest_autogen/mocs_compilation.cpp.o[ 82%] Linking CXX executable ../bin/embeddedimagedatatest/home/jenkins/workspace/Frameworks/kfilemetadata/kf5-qt5 SUSEQt5.9/src/extractors/exiv2extractor.cpp: In constructor ���std::auto_ptr<  >::auto_ptr(std::auto_ptr<  >::element_type*) [with _Tp = Exiv2::Image; std::auto_ptr<  >::element_type = Exiv2::Image]���:/home/jenkins/workspace/Frameworks/kfilemetadata/kf5-qt5 SUSEQt5.9/src/extractors/exiv2extractor.cpp:145:27: warning: zero as null pointer constant [-Wzero-as-null-pointer-constant] Exiv2::Image::AutoPtr image;   ^[ 82%] Built target taglibwritertestScanning dependencies of target indexextractortest[ 83%] Building CXX object autotests/CMakeFiles/indexextractortest.dir/indexerextractortests.cpp.o[ 83%] Built target embeddedimagedatatestScanning dependencies of target odfextractortest[ 84%] Building CXX object autotests/CMakeFiles/odfextractortest.dir/odfextractortest.cpp.oScanning dependencies of target extractorcollectiontest[ 85%] Building CXX object autotests/CMakeFiles/extractorcollectiontest.dir/extractorcollectiontest.cpp.o[ 86%] Linking CXX executable ../bin/exiv2extractortest[ 86%] Building CXX object 

D16283: implement more tags for asf metadata

[Alexander Stippich]

This revision was automatically updated to reflect the committed changes.
Closed by commit R286:02e8cab069ff: implement more tags for asf metadata 
(authored by astippich).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D16283?vs=43885=44366#toc

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16283?vs=43885=44366

REVISION DETAIL
  https://phabricator.kde.org/D16283

AFFECTED FILES
  autotests/samplefiles/test.wma
  autotests/taglibextractortest.cpp
  autotests/taglibextractortest.h
  src/extractors/taglibextractor.cpp
  src/extractors/taglibextractor.h

To: astippich, mgallien, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.9 - Build # 76 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.9/76/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Sun, 28 Oct 2018 16:59:46 +
 Build duration:
1 min 40 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 14 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.epubextractortest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report80%
(4/5)86%
(43/50)86%
(43/50)80%
(2683/3361)48%
(3954/8262)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(14/14)100%
(14/14)97%
(659/677)49%
(1486/3040)src75%
(18/24)75%
(18/24)79%
(999/1266)45%
(480/1073)src.extractors100%
(10/10)100%
(10/10)73%
(984/1349)48%
(1916/3986)src.writers100%
(1/1)100%
(1/1)98%
(41/42)48%
(72/151)tests0%
(0/1)0%
(0/1)0%
(0/27)0%
(0/12)

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.9 - Build # 75 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.9/75/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Sun, 28 Oct 2018 16:53:29 +
 Build duration:
6 min 16 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 14 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.epubextractortest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report80%
(4/5)86%
(43/50)86%
(43/50)80%
(2683/3361)48%
(3954/8262)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(14/14)100%
(14/14)97%
(659/677)49%
(1486/3040)src75%
(18/24)75%
(18/24)79%
(999/1266)45%
(480/1073)src.extractors100%
(10/10)100%
(10/10)73%
(984/1349)48%
(1916/3986)src.writers100%
(1/1)100%
(1/1)98%
(41/42)48%
(72/151)tests0%
(0/1)0%
(0/1)0%
(0/27)0%
(0/12)

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 95 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/95/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sun, 28 Oct 2018 16:55:04 +
 Build duration:
2 min 4 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 14 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.epubextractortest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report80%
(4/5)86%
(43/50)86%
(43/50)80%
(2682/3361)48%
(3969/8298)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(14/14)100%
(14/14)97%
(659/677)49%
(1486/3040)src75%
(18/24)75%
(18/24)79%
(998/1266)45%
(479/1073)src.extractors100%
(10/10)100%
(10/10)73%
(984/1349)48%
(1932/4022)src.writers100%
(1/1)100%
(1/1)98%
(41/42)48%
(72/151)tests0%
(0/1)0%
(0/1)0%
(0/27)0%
(0/12)

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 94 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/94/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sun, 28 Oct 2018 16:53:29 +
 Build duration:
1 min 33 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 14 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.epubextractortest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report80%
(4/5)86%
(43/50)86%
(43/50)80%
(2670/3349)48%
(3950/8266)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(14/14)100%
(14/14)97%
(655/673)49%
(1482/3032)src75%
(18/24)75%
(18/24)79%
(998/1266)45%
(479/1073)src.extractors100%
(10/10)100%
(10/10)73%
(976/1341)48%
(1917/3998)src.writers100%
(1/1)100%
(1/1)98%
(41/42)48%
(72/151)tests0%
(0/1)0%
(0/1)0%
(0/27)0%
(0/12)

D16282: extract ape tags from ape and wavpack files

[Alexander Stippich]

This revision was automatically updated to reflect the committed changes.
Closed by commit R286:4582ba5f3d7a: extract ape tags from ape and wavpack files 
(authored by astippich).

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16282?vs=43821=44365

REVISION DETAIL
  https://phabricator.kde.org/D16282

AFFECTED FILES
  autotests/samplefiles/test.ape
  autotests/samplefiles/test.mpc
  autotests/samplefiles/test.wv
  autotests/taglibextractortest.cpp
  src/extractors/taglibextractor.cpp

To: astippich, mgallien, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D16281: update epub test data and test for comment property

[Alexander Stippich]

This revision was automatically updated to reflect the committed changes.
Closed by commit R286:d97b15679179: update epub test data and test for comment 
property (authored by astippich).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D16281?vs=43887=44364#toc

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16281?vs=43887=44364

REVISION DETAIL
  https://phabricator.kde.org/D16281

AFFECTED FILES
  autotests/epubextractortest.cpp
  autotests/samplefiles/test.epub

To: astippich, bruns
Cc: cfeck, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D16197: provide a list of supported mimetypes for embeddedimagedata

[Alexander Stippich]

This revision was automatically updated to reflect the committed changes.
Closed by commit R286:1e9705162343: provide a list of supported mimetypes for 
embeddedimagedata (authored by astippich).

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16197?vs=43888=44363

REVISION DETAIL
  https://phabricator.kde.org/D16197

AFFECTED FILES
  autotests/embeddedimagedatatest.cpp
  src/embeddedimagedata.cpp
  src/embeddedimagedata.h

To: astippich, bruns, mgallien
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D16282: extract ape tags from ape and wavpack files

[Stefan Brüns]

bruns accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R286 KFileMetaData

BRANCH
  extract_ape_wavpack

REVISION DETAIL
  https://phabricator.kde.org/D16282

To: astippich, mgallien, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D16283: implement more tags for asf metadata

[Stefan Brüns]

bruns accepted this revision.
bruns added a comment.
This revision is now accepted and ready to land.


  Add the comment, otherwise its fine.

INLINE COMMENTS

> taglibextractor.cpp:843
> +} else if (mimeType == QLatin1String("audio/x-ms-wma")) {
> +TagLib::ASF::Tag* asfTags = dynamic_cast(tags);
> +if (asfTags) {

Can you add a comment here for why the dynamic_cast is used here?

REPOSITORY
  R286 KFileMetaData

BRANCH
  extract_asf

REVISION DETAIL
  https://phabricator.kde.org/D16283

To: astippich, mgallien, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D15960: Don't check if file is directory based on mime-type

[Stefan Brüns]

bruns requested changes to this revision.
bruns added a comment.
This revision now requires changes to proceed.


  Can you update the summary? Code wise its good to go.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D15960

To: poboiko, #baloo, #frameworks, bruns
Cc: bruns, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, abrahams

D16197: provide a list of supported mimetypes for embeddedimagedata

[Stefan Brüns]

bruns accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R286 KFileMetaData

BRANCH
  mimetypes_embedded_image

REVISION DETAIL
  https://phabricator.kde.org/D16197

To: astippich, bruns, mgallien
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D16281: update epub test data and test for comment property

[Stefan Brüns]

bruns accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R286 KFileMetaData

BRANCH
  description_test_preparation

REVISION DETAIL
  https://phabricator.kde.org/D16281

To: astippich, bruns
Cc: cfeck, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D15826: [Balooshow] Avoid out-of-bounds access when accessing corrupt db data

[Stefan Brüns]

bruns marked 3 inline comments as done.
bruns added a comment.


  @poboiko - good to go?

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D15826

To: bruns, #baloo, #frameworks, poboiko
Cc: anthonyfieroni, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D15826: [Balooshow] Avoid out-of-bounds access when accessing corrupt db data

[Stefan Brüns]

bruns marked 11 inline comments as done.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D15826

To: bruns, #baloo, #frameworks, poboiko
Cc: anthonyfieroni, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.9 - Build # 293 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.9/293/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Sun, 28 Oct 2018 15:32:24 +
 Build duration:
3 min 44 sec and counting
   CONSOLE OUTPUT
  [...truncated 224.56 KB...][  6%] Generating kcookieserveradaptor.mocScanning dependencies of target ktelnetservice5[  6%] Building CXX object src/ioslaves/telnet/CMakeFiles/ktelnetservice5.dir/ktelnetservice.cpp.oScanning dependencies of target kded_kcookiejar[  6%] Building CXX object src/ioslaves/http/kcookiejar/CMakeFiles/kded_kcookiejar.dir/kcookiejar.cpp.o[  7%] Linking CXX shared library ../../bin/libKF5KIONTLM.so[  7%] Built target KF5KIONTLM[  7%] Building CXX object src/ioslaves/http/kcookiejar/CMakeFiles/kded_kcookiejar.dir/kcookieserver.cpp.o[  7%] Building CXX object src/protocoltojson/CMakeFiles/protocoltojson.dir/protocoltojson_autogen/mocs_compilation.cpp.o[  8%] Linking CXX executable ../../bin/protocoltojson[  8%] Built target protocoltojsonScanning dependencies of target lockingtest[  9%] Building CXX object src/ioslaves/trash/tests/CMakeFiles/lockingtest.dir/lockingtest.cpp.o[  9%] Building CXX object src/ioslaves/telnet/CMakeFiles/ktelnetservice5.dir/ktelnetservice5_autogen/mocs_compilation.cpp.o[  9%] Linking CXX executable ../../../bin/ktelnetservice5[  9%] Building CXX object src/ioslaves/http/kcookiejar/CMakeFiles/kcookiejar5.dir/main.cpp.o[  9%] Built target ktelnetservice5[  9%] Building CXX object src/ioslaves/trash/tests/CMakeFiles/lockingtest.dir/__/kinterprocesslock.cpp.oBuilding up file structure...Insert custom filters...Insert help data for filter section (1 of 1)...Insert files...Insert contents...Insert indices...Documentation successfully generated.Scanning dependencies of target kpac_dhcp_helper[  9%] Building C object src/kpac/CMakeFiles/kpac_dhcp_helper.dir/kpac_dhcp_helper.c.o[  9%] Built target KF5KIO_QCH[  9%] Building CXX object src/ioslaves/http/kcookiejar/CMakeFiles/kcookiejar5.dir/kcookiejar5_autogen/mocs_compilation.cpp.o[  9%] Building CXX object src/kpac/CMakeFiles/kpac_dhcp_helper.dir/kpac_dhcp_helper_autogen/mocs_compilation.cpp.oScanning dependencies of target httpheaderdispositiontestScanning dependencies of target httpheadertokenizetest[  9%] Building CXX object autotests/http/CMakeFiles/httpheaderdispositiontest.dir/httpheaderdispositiontest.cpp.o[  9%] Linking CXX executable ../../bin/kpac_dhcp_helper[  9%] Building CXX object autotests/http/CMakeFiles/httpheadertokenizetest.dir/httpheadertokenizetest.cpp.o[  9%] Built target kpac_dhcp_helperScanning dependencies of target httpfiltertest[  9%] Building CXX object autotests/http/CMakeFiles/httpfiltertest.dir/httpfiltertest.cpp.o[  9%] Building CXX object src/ioslaves/trash/tests/CMakeFiles/lockingtest.dir/lockingtest_autogen/mocs_compilation.cpp.o[  9%] Linking CXX executable ../../../../bin/lockingtest[  9%] Built target lockingtest[  9%] Building CXX object autotests/http/CMakeFiles/httpheaderdispositiontest.dir/httpheaderdispositiontest_autogen/mocs_compilation.cpp.o[  9%] Linking CXX executable ../../../../bin/kcookiejar5[  9%] Building CXX object src/ioslaves/http/kcookiejar/CMakeFiles/kded_kcookiejar.dir/kcookiewin.cpp.o[  9%] Built target kcookiejar5[ 10%] Building CXX object src/ioslaves/http/kcookiejar/CMakeFiles/kded_kcookiejar.dir/kcookieserveradaptor.cpp.o[ 10%] Building CXX object src/ioslaves/http/kcookiejar/CMakeFiles/kded_kcookiejar.dir/kded_kcookiejar_autogen/mocs_compilation.cpp.o[ 10%] Building CXX object autotests/http/CMakeFiles/httpfiltertest.dir/__/__/src/ioslaves/http/httpfilter.cpp.o[ 11%] Building CXX object autotests/http/CMakeFiles/httpheadertokenizetest.dir/httpheadertokenizetest_autogen/mocs_compilation.cpp.o[ 11%] Linking CXX executable ../../bin/httpheaderdispositiontest[ 11%] Built target httpheaderdispositiontest[ 11%] Generating kpasswdserver_interface.cpp, kpasswdserver_interface.h[ 11%] Generating klauncher_interface.cpp, klauncher_interface.h[ 11%] Building CXX object autotests/http/CMakeFiles/httpfiltertest.dir/httpfiltertest_autogen/mocs_compilation.cpp.o[ 11%] Generating kpasswdserver_interface.moc[ 11%] Generating klauncher_interface.moc[ 11%] Linking CXX executable ../../bin/httpheadertokenizetest[ 12%] Linking CXX executable ../../bin/httpfiltertest[ 12%] Linking CXX shared module ../../../../bin/kf5/kded/kcookiejar.so[ 12%] Built target httpfiltertest[ 12%] Built target httpheadertokenizetestScanning dependencies of target KF5KIOCore[ 13%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/connection.cpp.o[ 13%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/klocalsocket.cpp.o[ 13%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/connectionbackend.cpp.o[ 13%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/idleslave.cpp.o[ 13%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/connectionserver.cpp.o[ 13%] Built target kded_kcookiejar[ 13%] Building CXX 

D16464: [KSambaShare] Trim trailing / from share path

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:0c8506f982e0: [KSambaShare] Trim trailing / from share 
path (authored by bruns).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16464?vs=44320=44358

REVISION DETAIL
  https://phabricator.kde.org/D16464

AFFECTED FILES
  src/core/ksambashare.cpp

To: bruns, #frameworks, broulik
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16464: [KSambaShare] Trim trailing / from share path

[Kai Uwe Broulik]

broulik accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  net_usershare

REVISION DETAIL
  https://phabricator.kde.org/D16464

To: bruns, #frameworks, broulik
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D5802: ViewPrivate, KateSearchBar, KateVi::MatchHighlighter: use selection foreground for search highlights

[Dominik Haumann]

dhaumann added a comment.


  As I see we have the following situation
  
  - the current implementation does work reasonably well
  - just because we cannot match a theme 100% does not imply that we have to 
adapt our implementation (there will always be a color in theme xy that does 
not properly exist in KTextEditor)
  - KTextEditor does not use color themes from KSyntaxHighlighting yet, so the 
transition is not complete
  
  Given no action in a long time, this indeed looks like a 'reject'. Still, 
maybe we should reevaluate? Volunterrs? ;)

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D5802

To: intelfx, #kdevelop, #ktexteditor, #kate, mwolff
Cc: kossebau, cullmann, kde-frameworks-devel, brauch, dhaumann, mwolff, 
kwrite-devel, michaelh, ngraham, bruns, demsking, sars

D5802: ViewPrivate, KateSearchBar, KateVi::MatchHighlighter: use selection foreground for search highlights

[Friedrich W. H. Kossebau]

kossebau added a comment.


  No insight into the topic, but seeing this in my review request list 
(KDevelop):
  Given KTextEditor was ported to KSyntaxHighlighting now, what can be said 
about this patch? Does it still apply? What foreground color options are there 
now for search highlights?
  
  Or should this patch/RFC be abandoned officially, given discussion has 
petered out with no results/goals?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D5802

To: intelfx, #kdevelop, #ktexteditor, #kate, mwolff
Cc: kossebau, cullmann, kde-frameworks-devel, brauch, dhaumann, mwolff, 
kwrite-devel, michaelh, ngraham, bruns, demsking, sars

D15070: Bindings: Support using sys paths for python install directory

[Stefan Brüns]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R240:258d6e412435: Bindings: Support using sys paths for 
python install directory (authored by bruns).

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15070?vs=42697=44354

REVISION DETAIL
  https://phabricator.kde.org/D15070

AFFECTED FILES
  find-modules/FindPythonModuleGeneration.cmake

To: bruns, #frameworks
Cc: bcooksley, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D16347: Expose KTextEditor::ViewPrivate:setInputMode(InputMode) to KTextEditor::View

[Friedrich W. H. Kossebau]

kossebau resigned from this revision.
kossebau added a comment.


  Not my domain, so resigning as reviewer :)

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D16347

To: demsking, mlaurent, vkrause, dhaumann, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, 
demsking, sars, dhaumann

D15645: Add scheme selection menu with a "System" entry.

[Amish Naidu]

amhndu marked an inline comment as done.

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D15645

To: amhndu, #frameworks, broulik, cfeck, elvisangelaccio, ngraham, pino
Cc: pino, ngraham, broulik, kde-frameworks-devel, michaelh, bruns

D15645: Add scheme selection menu with a "System" entry.

[Amish Naidu]

amhndu updated this revision to Diff 44342.
amhndu added a comment.


  > kcolorschemedemo.cpp does not actually seem to build an executable.
  
  It should build `kcolorschemedemo` in `kconfigwidgets/bin` (also has 
`kcolorschemedemo` target in make)
  
  > Regardless, wouldn't it make sense to expose this new feature in the 
existing Settings → Color Theme menu? Or are you planning to do that in another 
patch?
  
  Yes, that would require a patch for each application that'd use it. The 
problem is that with the new menu,
  we need a way to distinguish between the reset action and the other actions.
  So that applications don't just save the current system scheme in their 
config, if they did,
  the application would still use the previous scheme even after the user 
changed the system scheme. While resetting should mean the app
  should now be following the scheme, just as before setting anything manually.
  The new variant has the index as the data instead of the path, this allows 
checking the index's DisplayRole
  and the action's text to distinguish the reset, this is admittedly not a very 
good solution.
  I couldnnott think of anything else that's simple and wouldn't require much 
change in client code.
  What could be an alternative solution here ?
  I've thought of creating a subclass of KActionMenu which has two signals - 
one for reset and one for setting a scheme and returning that,
  but that would again require modifying applications to use these signals 
instead.
  
  > instead of a custom variant, what about creating new versions of the 
createSchemeSelectionMenu functions that take flags instead?
  
  I created a new variant since this isn't compatible with the other overload, 
as explained above.

REPOSITORY
  R265 KConfigWidgets

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15645?vs=44279=44342

BRANCH
  system-default

REVISION DETAIL
  https://phabricator.kde.org/D15645

AFFECTED FILES
  src/kcolorschememanager.cpp
  src/kcolorschememanager.h
  src/kcolorschememanager_p.h
  tests/kcolorschemedemo.cpp

To: amhndu, #frameworks, broulik, cfeck, elvisangelaccio, ngraham, pino
Cc: pino, ngraham, broulik, kde-frameworks-devel, michaelh, bruns