D16677: Add BrightScript syntax

dlevin updated this revision to Diff 44885. dlevin added a comment. Changed syntax license to MIT. REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16677?vs=44881=44885 REVISION DETAIL https://phabricator.kde.org/D16677 AFFECTED FILES

D16677: Add BrightScript syntax

cullmann added a comment. Hi, thanks for the contribution. Could you use the MIT license for the files? REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D16677 To: dlevin, #framework_syntax_highlighting Cc: cullmann, kwrite-devel, kde-frameworks-devel,

D16593: [ExtractorCollection] Use only best matching extractor plugin

bcooksley added a comment. As noted in the build log on the CI system, kfilemetadata doesn't depend on kcoreaddons so you therefore cannot rely on the kde5.xml file being available: [kf5-qt5 SUSEQt5.9] Running shell script + python3 -u ci-tooling/helpers/prepare-dependencies.py

Re: [sysadmin/ci-tooling] /: Disable parts of the System Dependency building on Android CI until rsync can be made available.

On Mon, Nov 5, 2018 at 2:01 PM Aleix Pol wrote: > > On Sun, Nov 4, 2018 at 2:52 AM Ben Cooksley wrote: > > > > On Sun, 4 Nov 2018, 14:18 Aleix Pol >> > >> I'm confused, this adds rsync and comments rsync out. > > > > > > I had to comment rsync out because we can't rebuild the image at the

D16678: Fix root disk icon change so that it doesn't erroneously change other icons

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R245 Solid BRANCH fix-root-icon-change (branched from master) REVISION DETAIL https://phabricator.kde.org/D16678 To: ngraham, bruns, broulik, davidedmundson Cc: kde-frameworks-devel, michaelh,

D16678: Fix root disk icon change so that it doesn't erroneously change other icons

ngraham updated this revision to Diff 44884. ngraham added a comment. Use `isStorageAccess()` rather than `isStorageVolume()` REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16678?vs=44883=44884 BRANCH fix-root-icon-change (branched from master) REVISION

D16678: Fix root disk icon change so that it doesn't erroneously change other icons

ngraham marked 2 inline comments as done. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D16678 To: ngraham, bruns, broulik, davidedmundson Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16678: Fix root disk icon change so that it doesn't erroneously change other icons

ngraham updated this revision to Diff 44883. ngraham added a comment. Address review comments REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16678?vs=44882=44883 BRANCH fix-root-icon-change (branched from master) REVISION DETAIL

D16678: Fix root disk icon change so that it doesn't erroneously change other icons

broulik added inline comments. INLINE COMMENTS > udisksdevice.cpp:874 > +{ > +if (queryDeviceInterface(Solid::DeviceInterface::StorageAccess)) { > +const UDisks2::StorageAccess accessIface(const_cast(this)); Can you check whether using `isStorageAccess()` is more

D16653: Use the new `drive-harddisk-root` icon for the root volume

ngraham added a comment. Hopefully this should fix it: D16678 REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D16653 To: ngraham, romangg, #vdg, #dolphin, #frameworks, bruns, abetts Cc: abetts, kde-frameworks-devel, michaelh,

D16678: Fix root disk icon change so that it doesn't erroneously change other icons

ngraham edited the test plan for this revision. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D16678 To: ngraham, bruns, broulik, davidedmundson Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16678: Fix root disk icon change so that it doesn't erroneously change other icons

ngraham created this revision. ngraham added reviewers: bruns, broulik, davidedmundson. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY I committed D16653 too

D16653: Use the new `drive-harddisk-root` icon for the root volume

ngraham added a comment. This broke icons for other things; currently investigating and will fix ASAP. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D16653 To: ngraham, romangg, #vdg, #dolphin, #frameworks, bruns, abetts Cc: abetts, kde-frameworks-devel, michaelh,

D16677: Add BrightScript syntax

dlevin created this revision. dlevin added a reviewer: Framework: Syntax Highlighting. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. dlevin requested review of this revision. REVISION SUMMARY Accurate implementation of BrightScript

D16643: Correct the accept flag of the event object on DragMove

trmdi added a comment. In D16643#354120 , @bruns wrote: > `m_enabled` may change between //consecutive// DragMove events, but not during an event. > > In this case, though, it does not, and is constantly true. You can verify this by

D16633: Add root version of drive-harddisk

acrouthamel added a comment. > I did not add drive-harddisk-home in this commit because it was simply too difficult to make an easily readable symbol for home on the 16px version. What about ~ or $ ? Tilde would probably be the best, and you could exaggerate

D16676: [server] Put (de-)activate, en-/disable callbacks in child classes

romangg added a dependency: D16675: [server] Put set surrounding text callback with uint in v0 class. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D16676 To: romangg, #kwin, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16675: [server] Put set surrounding text callback with uint in v0 class

romangg added a dependent revision: D16676: [server] Put (de-)activate, en-/disable callbacks in child classes. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D16675 To: romangg, #kwin, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16676: [server] Put (de-)activate, en-/disable callbacks in child classes

romangg created this revision. romangg added reviewers: KWin, Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. romangg requested review of this revision. REVISION SUMMARY The activate/deactivate and enable/disable callback functionality was in the

Re: [sysadmin/ci-tooling] /: Disable parts of the System Dependency building on Android CI until rsync can be made available.

On Sun, Nov 4, 2018 at 2:52 AM Ben Cooksley wrote: > > On Sun, 4 Nov 2018, 14:18 Aleix Pol > >> I'm confused, this adds rsync and comments rsync out. > > > I had to comment rsync out because we can't rebuild the image at the moment. > > I added it to the image for later on, when we can rebuild

D16665: Add programmaticaly useful error signalling

apol requested changes to this revision. apol added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > engine.h:430 > + */ > +void signalErrorCode(const KNSCore::ErrorCode , const QVariant > ); > I would include the error message here and deprecate

D16674: MTP: fix runtime warning when showing a warning to the user.

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R320 KIO Extras BRANCH master REVISION DETAIL https://phabricator.kde.org/D16674 To: dfaure, akrutzler, elvisangelaccio, apol Cc: kde-frameworks-devel, kfm-devel, alexde, sourabhboss, feverfew,

D15999: Add icons with added background to system.svgz

ngraham added a comment. Hmm, I just deployed with the latest change and suddenly the icons are weird: F6391195: Weird icons.jpeg REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D15999 To: pstefan,

D16672: Add support for speex files to taglibextractor

bruns accepted this revision. This revision is now accepted and ready to land. REPOSITORY R286 KFileMetaData BRANCH speex REVISION DETAIL https://phabricator.kde.org/D16672 To: astippich, mgallien, bruns Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun,

D16653: Use the new `drive-harddisk-root` icon for the root volume

This revision was automatically updated to reflect the committed changes. Closed by commit R245:b34d13cb1861: Use the new `drive-harddisk-root` icon for the root volume (authored by ngraham). REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16653?vs=44871=44875

D16653: Use the new `drive-harddisk-root` icon for the root volume

abetts accepted this revision. abetts added a comment. Minor detail with great impact. Thank you for the work. REPOSITORY R245 Solid BRANCH arcpatch-D16653 REVISION DETAIL https://phabricator.kde.org/D16653 To: ngraham, romangg, #vdg, #dolphin, #frameworks, bruns, abetts Cc: abetts,

D16675: [server] Put set surrounding text callback with uint in v0 class

romangg added a comment. Could the renaming be problematic in regards to binary compatibility? All are private interfaces though. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D16675 To: romangg, #kwin, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham,

D16675: [server] Put set surrounding text callback with uint in v0 class

romangg retitled this revision from "[server] Set surrounding text callback with uint in v0 class" to "[server] Put set surrounding text callback with uint in v0 class". REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D16675 To: romangg, #kwin, #frameworks Cc:

D16675: [server] Set surrounding text callback with uint in v0 class

romangg created this revision. romangg added reviewers: KWin, Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. romangg requested review of this revision. REVISION SUMMARY The set surrounding text request is only in v0 of text-input with uint

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.9 - Build # 73 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.9/73/ Project: kf5-qt5 SUSEQt5.9 Date of build: Sun, 04 Nov 2018 22:29:31 + Build duration: 5 min 46 sec and counting JUnit Tests Name: (root)

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.10 - Build # 99 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.10/99/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sun, 04 Nov 2018 22:29:31 + Build duration: 5 min 13 sec and counting JUnit Tests Name: (root)

D16674: MTP: fix runtime warning when showing a warning to the user.

dfaure created this revision. dfaure added reviewers: akrutzler, elvisangelaccio. Herald added projects: Dolphin, Frameworks. Herald edited subscribers, added: kfm-devel, kde-frameworks-devel; removed: Dolphin. dfaure requested review of this revision. REVISION SUMMARY KIO says the following:

D12114: Revive 'Description' property for DublinCore metadata

bruns accepted this revision. bruns added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > office2007extractortest.cpp:52 > QCOMPARE(result.properties().value(Property::Language), > QVariant(QStringLiteral("en-US"))); > +

KDE CI: Frameworks » kwindowsystem » kf5-qt5 SUSEQt5.9 - Build # 38 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.9/38/ Project: kf5-qt5 SUSEQt5.9 Date of build: Sun, 04 Nov 2018 22:20:56 + Build duration: 10 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.9 - Build # 72 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.9/72/ Project: kf5-qt5 SUSEQt5.9 Date of build: Sun, 04 Nov 2018 22:20:46 + Build duration: 8 min 34 sec and counting JUnit Tests Name: (root)

D16673: [server] Put some text-input v0 exclusive callbacks in v0 class

This revision was automatically updated to reflect the committed changes. Closed by commit R127:be0ad76729b6: [server] Put some text-input v0 exclusive callbacks in v0 class (authored by romangg). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE

D16653: Use the new `drive-harddisk-root` icon for the root volume

bruns accepted this revision. This revision is now accepted and ready to land. REPOSITORY R245 Solid BRANCH arcpatch-D16653 REVISION DETAIL https://phabricator.kde.org/D16653 To: ngraham, romangg, #vdg, #dolphin, #frameworks, bruns Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16653: Use the new `drive-harddisk-root` icon for the root volume

ngraham updated this revision to Diff 44871. ngraham marked 2 inline comments as done. ngraham added a comment. Fix embarrassing errors REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16653?vs=44808=44871 BRANCH arcpatch-D16653 REVISION DETAIL

KDE CI: Frameworks » kwindowsystem » kf5-qt5 SUSEQt5.10 - Build # 50 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.10/50/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sun, 04 Nov 2018 22:20:56 + Build duration: 4 min 36 sec and counting JUnit Tests Name:

D16653: Use the new `drive-harddisk-root` icon for the root volume

bruns added inline comments. INLINE COMMENTS > udisksdevice.cpp:619 > +const UDisks2::StorageAccess accessIface(const_cast(this)); > +if (accessIface.filePath() == "/") { > +return "drive-harddisk-root"; QLatin1String > udisksdevice.cpp:620 > +if

KDE CI: Frameworks » kdelibs4support » kf5-qt5 SUSEQt5.9 - Build # 47 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20SUSEQt5.9/47/ Project: kf5-qt5 SUSEQt5.9 Date of build: Sun, 04 Nov 2018 22:17:21 + Build duration: 5 min 5 sec and counting JUnit Tests Name: (root)

KDE CI: Frameworks » kdelibs4support » kf5-qt5 SUSEQt5.10 - Build # 73 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20SUSEQt5.10/73/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sun, 04 Nov 2018 22:17:21 + Build duration: 3 min 54 sec and counting JUnit Tests Name:

D16673: [server] Put some text-input v0 exclusive callbacks in v0 class

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R127 KWayland BRANCH textInputRestructure REVISION DETAIL https://phabricator.kde.org/D16673 To: romangg, #kwin, #frameworks, davidedmundson Cc: kde-frameworks-devel, michaelh, ngraham,

D16673: [server] Put some text-input v0 exclusive callbacks in v0 class

romangg created this revision. romangg added reviewers: KWin, Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. romangg requested review of this revision. REVISION SUMMARY Requests - reset - commit_state - invoke_action are used in

D16643: Correct the accept flag of the event object on DragMove

bruns added a comment. In D16643#353672 , @trmdi wrote: > In D16643#353670 , @bruns wrote: > > > This is not covered by your summary - you have only listed cases where the drag is erroneously

D16370: KTextEditor : syntax definition priority UI usability

ngraham added a comment. FWIW, inline "what's this" help is something we're considering removing altogether for a variety of reasons (T9986 ), so I would prefer to ensure user-friendliness via an intuitive UI, tooltips, and non-inline documentation. Often

D16672: Add support for speex files to taglibextractor

astippich created this revision. astippich added reviewers: mgallien, bruns. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY Probably not widely used anymore, but support can easily

D16671: Refactor embedded image extractor for greater extensibility

astippich created this revision. astippich added reviewers: mgallien, bruns. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY refactor the embedded image data extractor so that

D15999: Add icons with added background to system.svgz

pstefan edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D15999 To: pstefan, ngraham, #vdg Cc: broulik, filipf, kde-frameworks-devel, michaelh, ngraham, bruns

D15999: Add icons with added background to system.svgz

pstefan updated this revision to Diff 44862. pstefan added a comment. - Sized down icons somewhat - Added "*-translucent" option of the icons in go.svgz (go-home, go-previous, etc). 32px only for now - Made background darker - Removed outer circle - Merge branch 'master' of

D16370: KTextEditor : syntax definition priority UI usability

rjvbb added a comment. > I would prefer to set this in the ui file: The maximum is already set to 99. Of course. FWIW, I decided against it because my approach ensures the range is always symmetric and esp. because the comment makes it less likely that someone will clamp the minimum

D16643: Correct the accept flag of the event object on DragMove

trmdi updated this revision to Diff 44860. trmdi added a comment. git diff -U -- DeclarativeDropArea.cpp > patch.diff REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16643?vs=44784=44860 REVISION DETAIL https://phabricator.kde.org/D16643

D16370: KTextEditor : syntax definition priority UI usability

dhaumann added subscribers: ngraham, dhaumann. dhaumann added inline comments. INLINE COMMENTS > katemodeconfigpage.cpp:95 > +// having to increase the priority of (all) those definitions. > +ui->sbPriority->setMinimum(-ui->sbPriority->maximum()); > +// make the context help a bit

D16665: Add programmaticaly useful error signalling

leinir created this revision. leinir added reviewers: KNewStuff, apol. leinir added a project: KNewStuff. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. leinir requested review of this revision. REVISION SUMMARY Previously, KNSCore only signalled errors

D16298: prevent avahi signal racing

ngraham added a reviewer: Frameworks. REPOSITORY R272 KDNSSD REVISION DETAIL https://phabricator.kde.org/D16298 To: sitter, mdawson, broulik, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16299: RFC fallback to dnssd service discovery if smb listDir failed on root

ngraham added a comment. OK, I guess that's the best we can do for now. Can we push forward on this? REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D16299 To: sitter, #frameworks, #dolphin Cc: bcooksley, ngraham, kde-frameworks-devel, kfm-devel, alexde,

D16593: [ExtractorCollection] Use only best matching extractor plugin

bruns added a subscriber: bcooksley. bruns added a comment. In D16593#353801 , @astippich wrote: > This or the commit before causes CI to fail the ExtractorCollectionTest on Qt 5.9, 5.10, and Windows Most likely the new check in D16592

D16370: KTextEditor : syntax definition priority UI usability

rjvbb added a comment. > For the tooltip stuff: I am not sure if that is not inconsistent with the remaining stuff on these pages. Is there a platform-agnostic way to trigger the display of the "what's this" pop-up? If so a reminder of that could be shown somewhere, somehow?

D16643: Correct the accept flag of the event object on DragMove

ngraham added a comment. In D16643#353679 , @trmdi wrote: > @ngraham > How to see the full file content from this page? "Show raw file" doesn't work. Sorry, I'm new to Phabricator. You need to either use `arc` to create the diff (see

D16370: KTextEditor : syntax definition priority UI usability

cullmann added a comment. +1 for the negative priority idea, might help some people. For the tooltip stuff: I am not sure if that is not inconsistent with the remaining stuff on these pages. Other opinions? REPOSITORY R39 KTextEditor REVISION DETAIL

D16196: add a description property to KFileMetaData

astippich added a dependent revision: D12114: Revive 'Description' property for DublinCore metadata. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D16196 To: astippich, mgallien, bruns Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich,

D12114: Revive 'Description' property for DublinCore metadata

astippich updated this revision to Diff 44834. astippich edited the summary of this revision. astippich added a comment. - rebase on top of D16196 REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE

D12114: Revive 'Description' property for DublinCore metadata

astippich added a dependency: D16196: add a description property to KFileMetaData. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D12114 To: astippich, #baloo, #frameworks, bruns Cc: kde-frameworks-devel, bruns, ashaposhnikov, michaelh, astippich, spoorun,

D12114: Revive 'Description' property for DublinCore metadata

astippich retitled this revision from "Revive 'Description' property" to "Revive 'Description' property for DublinCore metadata". astippich edited the summary of this revision. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D12114 To: astippich, #baloo,

D12114: Revive 'Description' property

astippich updated this revision to Diff 44833. astippich edited the summary of this revision. astippich added a comment. - use description property for dublincore description REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12114?vs=31887=44833 BRANCH

D12114: Revive 'Description' property

astippich commandeered this revision. astippich added a reviewer: michaelh. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D12114 To: astippich, #baloo, #frameworks, michaelh Cc: kde-frameworks-devel, bruns, ashaposhnikov, michaelh, astippich, spoorun, ngraham,

D12114: Revive 'Description' property

astippich edited reviewers, added: bruns; removed: michaelh. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D12114 To: astippich, #baloo, #frameworks, bruns Cc: kde-frameworks-devel, bruns, ashaposhnikov, michaelh, astippich, spoorun, ngraham, abrahams

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 115 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/115/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sun, 04 Nov 2018 10:55:38 + Build duration: 1 min 45 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.9 - Build # 94 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.9/94/ Project: kf5-qt5 SUSEQt5.9 Date of build: Sun, 04 Nov 2018 10:55:37 + Build duration: 1 min 48 sec and counting JUnit Tests Name: (root)

D16196: add a description property to KFileMetaData

astippich updated this revision to Diff 44832. astippich added a comment. - rebase REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16196?vs=43586=44832 BRANCH description_property REVISION DETAIL https://phabricator.kde.org/D16196 AFFECTED

D16311: RFC: [KFilePlacesView] Use asynchronous KIO::FileSystemFreeSpaceJob

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. This map will keep growing and growing... REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16311 To: broulik, #frameworks, dfaure, lbeltrame Cc:

D16593: [ExtractorCollection] Use only best matching extractor plugin

astippich added a comment. This or the commit before causes CI to fail the ExtractorCollectionTest on Qt 5.9, 5.10, and Windows REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D16593 To: bruns, #frameworks, astippich Cc: kde-frameworks-devel, #baloo,

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.9 - Build # 93 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.9/93/ Project: kf5-qt5 SUSEQt5.9 Date of build: Sun, 04 Nov 2018 09:50:22 + Build duration: 2 min 15 sec and counting JUnit Tests Name: (root)

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 114 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/114/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sun, 04 Nov 2018 09:50:22 + Build duration: 2 min 6 sec and counting JUnit Tests Name:

D16583: use qlatin1 for embedded image extractor

This revision was automatically updated to reflect the committed changes. Closed by commit R286:0a26d39b27cb: use qlatin1 for embedded image extractor (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16583?vs=44718=44826 REVISION

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.9 - Build # 92 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.9/92/ Project: kf5-qt5 SUSEQt5.9 Date of build: Sun, 04 Nov 2018 09:48:01 + Build duration: 1 min 41 sec and counting JUnit Tests Name: (root)

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.9 - Build # 91 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.9/91/ Project: kf5-qt5 SUSEQt5.9 Date of build: Sun, 04 Nov 2018 09:39:41 + Build duration: 8 min 18 sec and counting JUnit Tests Name: (root)

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 113 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/113/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sun, 04 Nov 2018 09:45:59 + Build duration: 1 min 40 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 112 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/112/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sun, 04 Nov 2018 09:44:28 + Build duration: 1 min 30 sec and counting JUnit Tests Name:

D16560: create a separate test file for embedded images test

This revision was automatically updated to reflect the committed changes. Closed by commit R286:e04ef70aa855: create a separate test file for embedded images test (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE

D16554: move supported mimetypes to static string list

This revision was automatically updated to reflect the committed changes. Closed by commit R286:0375eee8a128: move supported mimetypes to static string list (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16554?vs=44661=44825

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 111 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/111/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sun, 04 Nov 2018 09:42:31 + Build duration: 1 min 55 sec and counting JUnit Tests Name:

D16618: add explicit to constructors

This revision was automatically updated to reflect the committed changes. Closed by commit R286:2b20e8720ae3: add explicit to constructors (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16618?vs=44731=44822 REVISION DETAIL

D16585: simplify handling of id3 tags

This revision was automatically updated to reflect the committed changes. Closed by commit R286:053de81bafc1: simplify handling of id3 tags (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16585?vs=44621=44823 REVISION DETAIL

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 110 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/110/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sun, 04 Nov 2018 09:39:41 + Build duration: 2 min 34 sec and counting JUnit Tests Name:

D16619: add missing license information

This revision was automatically updated to reflect the committed changes. Closed by commit R286:2fb80c005e95: add missing license information (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16619?vs=44726=44821 REVISION DETAIL