D16964: Change archive-* action icons to represent archives

trickyricky26 edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16964 To: trickyricky26, #vdg, ngraham, ndavis Cc: ngraham, ndavis, kde-frameworks-devel, michaelh, bruns

Re: firewall-applet icons break breeze auto tests

El dissabte, 17 de novembre de 2018, a les 20:43:04 CET, Noah Davis va escriure: > On Saturday, November 17, 2018 11:17:15 AM EST Albert Astals Cid wrote: > > El dissabte, 17 de novembre de 2018, a les 14:03:45 CET, Noah Davis va > escriure: > > > On Saturday, November 17, 2018 5:37:36 AM EST

D16966: Fix typo in i18n message (cmdline option description)

mlaurent accepted this revision. This revision is now accepted and ready to land. REPOSITORY R290 KPackage BRANCH opt-i18n REVISION DETAIL https://phabricator.kde.org/D16966 To: aspotashev, mlaurent Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16964: Change archive-* action icons to represent archives

trickyricky26 updated this revision to Diff 45719. trickyricky26 added a comment. - Make zipper consistent with archive mimetype icons; tightened the gap for the emblems to be more consistent; 32px icons with 2px margins REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE

D16964: Change archive-* action icons to represent archives

trickyricky26 added a comment. Do you think this is more consistent: F6430252: archive-extract-22-new.svg.png F6430251: archive-extract-16-new.svg.png I shortened the zipper to make more room for the

D16951: Add mouse button icons

trickyricky26 added a comment. I would suggest making the mouse wheel itself turn blue as highlighting REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16951 To: ndavis, #vdg Cc: trickyricky26, abetts, ngraham, rizzitello, nicolasfella, kde-frameworks-devel,

D16938: FindQHelpGenerator: try to find Qt5Help instead of Qt5Core

pino closed this revision. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D16938 To: pino, kossebau Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D16963: Fix running kdoctools-install autotest without kdoctools installed

This revision was automatically updated to reflect the committed changes. Closed by commit R238:0a714c220662: Fix running kdoctools-install autotest without kdoctools installed (authored by habacker). REPOSITORY R238 KDocTools CHANGES SINCE LAST UPDATE

KDE CI: Frameworks » kdoctools » kf5-qt5 SUSEQt5.10 - Build # 68 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kdoctools/job/kf5-qt5%20SUSEQt5.10/68/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sun, 18 Nov 2018 09:40:06 + Build duration: 4 min 22 sec and counting JUnit Tests Name: (root)

KDE CI: Frameworks » kdoctools » kf5-qt5 SUSEQt5.9 - Build # 54 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kdoctools/job/kf5-qt5%20SUSEQt5.9/54/ Project: kf5-qt5 SUSEQt5.9 Date of build: Sun, 18 Nov 2018 09:40:06 + Build duration: 5 min 23 sec and counting CONSOLE OUTPUT [...truncated

D16984: [RenameDialog] Fix layout when using the NoRename flag

elvisangelaccio created this revision. elvisangelaccio added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. elvisangelaccio requested review of this revision. REVISION SUMMARY The code was wrongly checking whether the

D16984: [RenameDialog] Fix layout when using the NoRename flag

elvisangelaccio added a comment. Before: F6430863: norename_before.png After: F6430865: norename_after.png REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16984 To:

D16985: Fix apidox of RenameDialog_Option

elvisangelaccio created this revision. elvisangelaccio added reviewers: Frameworks, dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. elvisangelaccio requested review of this revision. REVISION SUMMARY This patch moves the descriptions after the enum

D16882: [KDevelop/Shell] prevent duplicate added contextmenu actions

kossebau added a comment. For the record, related commits are: Adding the principal clean-up logic: R32:b837392d5f05394794a813afb7ca94e54650fcff Changing it from clean-on-hide to clean-on-about-to-show-again:

D16983: Add 48px firewall-applet* icons

ndavis added a comment. In D16983#361758 , @aacid wrote: > I'm sorry but this makes no sense at all, why is firewall-applet-error now suddenly firewall-config? > > And why do you say users will never need a 48px verison of it?

persistence of ktexteditor backup files

Hi, Has anything changed in KTextEditor's management of (old) backup files since 5.47.0 OR has the default become to set it to ON if the user didn't enable or disable the feature explicitly? I'm asking because I'm seeing backup files littering my work directories that all date from after I

D16983: Add 48px firewall-applet icon

ndavis added a comment. @ngraham Realistically, users will never need the 48px versions of each icon. Can I just make more symlinks of `firewall-config` or should I make icons that actually represent the other icons? REPOSITORY R266 Breeze Icons REVISION DETAIL

D16964: Change archive-* action icons to represent archives

ngraham accepted this revision. ngraham added a comment. +1 shipit! REPOSITORY R266 Breeze Icons BRANCH change-archive-action-icons (branched from master) REVISION DETAIL https://phabricator.kde.org/D16964 To: trickyricky26, #vdg, ngraham, ndavis Cc: ngraham, ndavis,

D16984: [RenameDialog] Fix layout when using the NoRename flag

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH fix-norename-layout REVISION DETAIL https://phabricator.kde.org/D16984 To: elvisangelaccio, #frameworks, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16951: Add mouse button icons

trickyricky26 added a comment. I think it's not quite clear enough on it's own, however together with the other icons it will be clear REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16951 To: ndavis, #vdg Cc: trickyricky26, abetts, ngraham, rizzitello,

D16981: [kfilewidget] Ctrl+L returns editable URL navigator to breadcrumb mode only when it has focus

ngraham created this revision. ngraham added reviewers: Frameworks, Dolphin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY Currently, [Ctrl] + [+] toggles the location bar between editable and

D16964: Change archive-* action icons to represent archives

This revision was automatically updated to reflect the committed changes. Closed by commit R266:aace21a15667: Change archive-* action icons to represent archives (authored by trickyricky26, committed by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.9 - Build # 77 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.9/77/ Project: kf5-qt5 SUSEQt5.9 Date of build: Sun, 18 Nov 2018 18:01:15 + Build duration: 1 min 55 sec and counting JUnit Tests Name: (root)

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.10 - Build # 133 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.10/133/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sun, 18 Nov 2018 18:01:15 + Build duration: 1 min 47 sec and counting JUnit Tests Name:

D16983: Add 48px firewall-applet icon

ndavis created this revision. ndavis added reviewers: VDG, Breeze. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY Added a symlink from `firewall-config.svg` to `firewall-applet.svg`

D16951: Add mouse button icons

nicolasfella added a comment. Looks good! +1 REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16951 To: ndavis, #vdg Cc: trickyricky26, abetts, ngraham, rizzitello, nicolasfella, kde-frameworks-devel, michaelh, bruns

Re: firewall-applet icons break breeze auto tests

On Sunday, November 18, 2018 5:34:02 AM EST Albert Astals Cid wrote: > El dissabte, 17 de novembre de 2018, a les 20:43:04 CET, Noah Davis va escriure: > > On Saturday, November 17, 2018 11:17:15 AM EST Albert Astals Cid wrote: > > > El dissabte, 17 de novembre de 2018, a les 14:03:45 CET, Noah

D16882: [KDevelop/Shell] prevent duplicate added contextmenu actions

rjvbb added a subscriber: egospodinova. rjvbb added a comment. > I would see the flaw also in that there is no specification in the KTextEditor API how the context menu is shared/reused. Did you see the reaction to my proposed KTextEditor fix? My argument "sounds reasonable". To me

D16882: [KDevelop/Shell] prevent duplicate added contextmenu actions

kossebau added a comment. In D16882#361733 , @rjvbb wrote: > > `KTextEditor::View::contextMenu()` talks about "the xmlgui menu" or custom set "context menu object", but no hint/promise whether there is any instance sharing done, e.g. between

D16983: Add 48px firewall-applet* icons

aacid added a comment. I'm sorry but this makes no sense at all, why is firewall-applet-error now suddenly firewall-config? And why do you say users will never need a 48px verison of it? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16983 To: ndavis,

D8021: Don't switch Location Bar mode with Escape key

ngraham abandoned this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8021 To: ngraham, #frameworks, elvisangelaccio, broulik, dfaure Cc: kde-frameworks-devel, rkflx, #frameworks, michaelh, ngraham, bruns

D8021: Don't switch Location Bar mode with Escape key

ngraham added a comment. Herald added a subscriber: kde-frameworks-devel. Abandoning in favor of D16980 , which I think makes more sense. In retrospect, you guys were right and this was a stupid idea: the escape key should definitely continue to work like

Re: Increasing KF5 cmake requirement to 3.6?

On samedi 17 novembre 2018 18:10:33 CET Albert Astals Cid wrote: > The KF5 minimum cmake requirement sits at 3.0 > > I doubt anyone is using that to build KF5 so it's a bit of a "lie". > > I'm going to suggest it to increase it to 3.6, it would still most probably > be a lie since i don't think

D16983: Add 48px firewall-applet icon

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. The scalable test still fails; you need to add more symlinks: FAIL! : ScalableTest::test_scalable(icons:Applications) The following icons are not available in a scalable

D16983: Add 48px firewall-applet* icons

ndavis retitled this revision from "Add 48px firewall-applet icon" to "Add 48px firewall-applet* icons". ndavis edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16983 To: ndavis, #vdg, #breeze, ngraham Cc: ngraham,

D16983: Add 48px firewall-applet icon

ndavis updated this revision to Diff 45746. ndavis added a comment. Add more symlinks REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16983?vs=45739=45746 BRANCH add-firewall-applet-48px (branched from master) REVISION DETAIL

D16951: Add mouse button icons

ndavis updated this revision to Diff 45755. ndavis added a comment. Detach MMB, increase highlight length, make colors match new HIG, turn MMB click highligh into outline REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16951?vs=45703=45755 BRANCH

D16951: Add mouse button icons

ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16951 To: ndavis, #vdg Cc: trickyricky26, abetts, ngraham, rizzitello, nicolasfella, kde-frameworks-devel, michaelh, bruns

D16964: Change archive-* action icons to represent archives

ndavis added a comment. In D16964#361357 , @trickyricky26 wrote: > Do you think this is more consistent: > F6430252: archive-extract-22-new.svg.png > F6430251: archive-extract-16-new.svg.png

D16964: Change archive-* action icons to represent archives

ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. I've had a good look at your patch now and everything is ok. Unless @ngraham has anything else to say, I think it's time to land this. REPOSITORY R266 Breeze Icons BRANCH

D17001: Add unittest for document replacement

bruns created this revision. bruns added reviewers: Baloo, Frameworks, poboiko, ngraham. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY Updating a file in place (i.e. when keeping the same

D17000: Make sure there is only one MTime per document in the MTimeDB

bruns created this revision. bruns added reviewers: Baloo, Frameworks, poboiko, ngraham. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY Previously, every time a file was was modified in place

D17000: Make sure there is only one MTime per document in the MTimeDB

bruns added a dependent revision: D17001: Add unittest for document replacement. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D17000 To: bruns, #baloo, #frameworks, poboiko, ngraham Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns,

D17000: Make sure there is only one MTime per document in the MTimeDB

bruns removed a dependency: D17001: Add unittest for document replacement. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D17000 To: bruns, #baloo, #frameworks, poboiko, ngraham Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns,

D17001: Add unittest for document replacement

bruns removed a dependent revision: D17000: Make sure there is only one MTime per document in the MTimeDB. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D17001 To: bruns, #baloo, #frameworks, poboiko, ngraham Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich,

D17001: Add unittest for document replacement

bruns added a dependency: D17000: Make sure there is only one MTime per document in the MTimeDB. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D17001 To: bruns, #baloo, #frameworks, poboiko, ngraham Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun,

D16946: Port more search providers to HTTPS

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. LGTM. About the rest, probably not, do you think that there's any that would be a big loss? I would assume by now that if they don't work with https it's probably because it's abandoned.

D16882: [KDevelop/Shell] prevent duplicate added contextmenu actions

rjvbb updated this revision to Diff 45761. rjvbb added a comment. Apologies, the tear-off bit shouldn't have been included of course. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16882?vs=45759=45761 REVISION DETAIL https://phabricator.kde.org/D16882 AFFECTED FILES

Re: Increasing KF5 cmake requirement to 3.6?

On Sat, Nov 17, 2018 at 8:04 PM Wolfgang Bauer wrote: > > > -Original Message- > > I'm going to suggest it to increase it to 3.6, it would still most > probably be a lie > > since i don't think any of use uses such an old (2 years version) either > > We currently do still build the latest

D16999: Extend diagnostic output for DB autotests

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D16999 To: bruns, #baloo, #frameworks, poboiko, ngraham Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns,

D17000: Make sure there is only one MTime per document in the MTimeDB

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D17000 To: bruns, #baloo, #frameworks, poboiko, ngraham Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns,

D16951: Add mouse button icons

ngraham accepted this revision. ngraham added a reviewer: nicolasfella. ngraham added a comment. This revision is now accepted and ready to land. Looks good to me now! Let's make sure @nicolasfella is happy too, since he's going to be the inaugural user. :) REPOSITORY R266 Breeze Icons

D17001: Add unittest for document replacement

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH mtime_fix REVISION DETAIL https://phabricator.kde.org/D17001 To: bruns, #baloo, #frameworks, poboiko, ngraham Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich,

D16983: Add 48px firewall-applet* icons

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Thanks, much better now. @aacid all of this confused me too at first, but these icons are targeting a particular piece of software and use case where they make sense. REPOSITORY

D16852: Add Documents to the default list of Places

ngraham added a comment. So the only problem I have with this patch is the fact that is results in Dolphin having a scrollbar for its Places panel because the default size of the main window is now one item's worth of height too short: F6431560: Scrollbar.png

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.9 - Build # 326 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.9/326/ Project: kf5-qt5 SUSEQt5.9 Date of build: Mon, 19 Nov 2018 04:16:42 + Build duration: 8 min 53 sec and counting JUnit Tests Name: (root) Failed: 1

D17000: Make sure there is only one MTime per document in the MTimeDB

bruns added a dependency: D17001: Add unittest for document replacement. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D17000 To: bruns, #baloo, #frameworks, poboiko, ngraham Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D17001: Add unittest for document replacement

bruns added a dependency: D16999: Extend diagnostic output for DB autotests. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D17001 To: bruns, #baloo, #frameworks, poboiko, ngraham Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns,

D17000: Make sure there is only one MTime per document in the MTimeDB

bruns added a dependency: D16999: Extend diagnostic output for DB autotests. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D17000 To: bruns, #baloo, #frameworks, poboiko, ngraham Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns,

D17001: Add unittest for document replacement

bruns added a dependent revision: D17000: Make sure there is only one MTime per document in the MTimeDB. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D17001 To: bruns, #baloo, #frameworks, poboiko, ngraham Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich,

D16999: Extend diagnostic output for DB autotests

bruns added dependent revisions: D17000: Make sure there is only one MTime per document in the MTimeDB, D17001: Add unittest for document replacement. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D16999 To: bruns, #baloo, #frameworks, poboiko, ngraham Cc:

D16999: Extend diagnostic output for DB autotests

bruns created this revision. bruns added reviewers: Baloo, Frameworks, poboiko, ngraham. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY For some of the DBs, no detailed output was printed when

D16882: [KDevelop/Shell] prevent duplicate added contextmenu actions

rjvbb updated this revision to Diff 45759. rjvbb added a comment. updated as suggested: - moves the context menu added stuff logic into a dedicated class (as an upbeat to possible future improvement) - caches the QMenu* to which actions were last added, and removes them from that menu

D16882: [KDevelop/Shell] prevent duplicate added contextmenu actions

rjvbb set the repository for this revision to R32 KDevelop. REPOSITORY R32 KDevelop REVISION DETAIL https://phabricator.kde.org/D16882 To: rjvbb, #kdevelop, kossebau Cc: egospodinova, kossebau, kde-frameworks-devel, kdevelop-devel, glebaccon, antismap, iodelay, vbspam, geetamc, Pilzschaf,

D16951: Add mouse button icons

ndavis added a comment. F6430803: Screenshot_20181118_123558.png Is this too small or not legible enough? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16951 To: ndavis, #vdg Cc: trickyricky26, abetts, ngraham,

D16882: [KDevelop/Shell] prevent duplicate added contextmenu actions

kossebau added a comment. In D16882#360857 , @rjvbb wrote: > Re-opening because I found an actual flaw in KDevelop after noticing that context menu duplication still occurred when only the active view receives the aboutToShowContextMenu signal.