D17554: [KFileItem] Fix isLocal check in checkDesktopFile

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: dfaure, davidedmundson, shubham.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.

REVISION SUMMARY
  This was accidentally removed in 16edef0dca46f4292bf83d22874a02d8e6fe15e7 
 and 
then cleaned up improperly in c08ee4577168070896a4a46220cd39df4e4e32cf 

  
  BUG: 401947

TEST PLAN
  "Empty Trash" now shows up for Trash on desktop again, as `desktop:/` URL is 
correctly treated as local again

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17554

AFFECTED FILES
  src/core/kfileitem.cpp

To: broulik, dfaure, davidedmundson, shubham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17500: Restore mobipocket extractor

[Matthieu Gallien]

mgallien added a comment.


  In D17500#376221 , @aacid wrote:
  
  > In D17500#375753 , @astippich 
wrote:
  >
  > > Oh, thanks for the hint, didn't know that. That makes it a lot more 
complicated than a straight port :(
  > >  Looking at the code of kdegraphics-mobipocket, shouldn't the thumbnail 
extractor actually be part of kio-extras? Seems quite kio-specific, and a quick 
look at lxr didn't reveal any usages of the thumbnailer.
  >
  >
  > Why would it be part of kio-extras? the beauty of plugins is that they can 
live wherever, no?
  >
  > Do I understand that the answer to my "Is it possible to move the extractor 
to kdegraphics-mobipocket instead of having it in kfilemetadata? " question is 
no?
  
  
  There is support for external extractors in KFileMetaData. As far as I know, 
it has not yeet been used.
  That is probably the safest way to do what you suggest.
  
  > If so, that probably needs fixing, the fact that you can't have external 
plugins means that the code is probably not as good as it should

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D17500

To: astippich, bruns
Cc: mgallien, aacid, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.9 - Build # 208 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.9/208/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Thu, 13 Dec 2018 07:18:27 +
 Build duration:
11 min and counting
   BUILD ARTIFACTS
  compat_reports/KF5Plasma_compat_report.html
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3608/13322)18%
(1817/9850)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(612/1117)29%
(315/1086)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)13%
(299/2247)7%
(96/1454)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1410/3491)28%
(787/2821)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(674/1574)29%
(301/1034)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(582/2017)18%
(313/1721)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1178)0%
(0/1028)tests.dpi0%
(0/2)0%
   

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.11 - Build # 6 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.11/6/
 Project:
kf5-qt5 SUSEQt5.11
 Date of build:
Thu, 13 Dec 2018 07:18:27 +
 Build duration:
8 min 0 sec and counting
   BUILD ARTIFACTS
  compat_reports/KF5Plasma_compat_report.html
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3608/13324)18%
(1817/9848)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(612/1117)29%
(315/1086)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)13%
(299/2248)7%
(96/1456)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1410/3491)28%
(787/2817)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(674/1574)29%
(301/1034)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(582/2018)18%
(313/1721)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1178)0%
(0/1028)tests.dpi0%
(0/2)0%
  

D17505: Add preferences-system-bluetooth-battery to preferences.svgz

[Noah Davis]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:2f99869c1071: Add preferences-system-bluetooth-battery to 
preferences.svgz (authored by ndavis).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17505?vs=47357=47492

REVISION DETAIL
  https://phabricator.kde.org/D17505

AFFECTED FILES
  src/desktoptheme/breeze/icons/preferences.svgz

To: ndavis, #vdg, #plasma, broulik, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17550: Make the open url in tab feature a bit more discoverable

[Nathaniel Graham]

ngraham accepted this revision as: ngraham.
ngraham added a comment.
This revision is now accepted and ready to land.


  +1 for the idea and the UX as texted. No comment on the code change; I'm 
definitely not smart enough to understand it all!

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17550

To: apol, #dolphin, ngraham, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17545: Do not stat move/copy job if the destination file system does not support writing

[Shubham]

shubham added a subscriber: ngraham.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17545

To: shubham, #frameworks, dfaure
Cc: ngraham, broulik, kde-frameworks-devel, michaelh, bruns

D17550: Make the open url in tab feature a bit more discoverable

[Aleix Pol Gonzalez]

apol created this revision.
apol added reviewers: Dolphin, ngraham.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
apol requested review of this revision.

REVISION SUMMARY
  Introduce a context menu item that invites to open the button under the menu 
in a tab.
  It used to just work with the middle button, now it works with control+click 
as well, much like in web browsers.
  
  BUG: 402073

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17550

AFFECTED FILES
  src/filewidgets/kurlnavigator.cpp
  src/filewidgets/kurlnavigator.h
  src/filewidgets/kurlnavigatorbutton.cpp
  src/filewidgets/kurlnavigatorbutton_p.h
  src/widgets/kfileitemactions.cpp

To: apol, #dolphin, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17550: Make the open url in tab feature a bit more discoverable

[Aleix Pol Gonzalez]

apol added a reviewer: Frameworks.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17550

To: apol, #dolphin, ngraham, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17500: Restore mobipocket extractor

[Albert Astals Cid]

aacid added a comment.


  In D17500#375753 , @astippich 
wrote:
  
  > Oh, thanks for the hint, didn't know that. That makes it a lot more 
complicated than a straight port :(
  >  Looking at the code of kdegraphics-mobipocket, shouldn't the thumbnail 
extractor actually be part of kio-extras? Seems quite kio-specific, and a quick 
look at lxr didn't reveal any usages of the thumbnailer.
  
  
  Why would it be part of kio-extras? the beauty of plugins is that they can 
live wherever, no?
  
  Do I understand that the answer to my "Is it possible to move the extractor 
to kdegraphics-mobipocket instead of having it in kfilemetadata? " question is 
no?
  
  If so, that probably needs fixing, the fact that you can't have external 
plugins means that the code is probably not as good as it should

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D17500

To: astippich, bruns
Cc: aacid, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

T3689: Add abi compliance checker to CI

[Sandro Knauß]

knauss added a comment.


  I use the ci-docker images to test the create-abi, but I can't reproduce why 
those are failing:
  
  - messagelib
  - kdav
  - libksieve
  - akonadi-import-wizard
  - kpkpass
  - libkgapi
  
  maybe those are also fixed by D17534  
otherwise I need more details.
  
  @bcooksley there is also an issue with akonadi-mime - that I don't understand.
  Build #2 

 is fine:
  
  - create-abi-dump.py is run successful
  - check-abi.py is happy: "Let's do a ABI check 
32025ac9cc671b7adf956d117555336703725ee4 
 
against 1dae8da6ab3ebe1f8f5acf5cd0c563557cd3cbda 
"
  
  but at Build #3 
:
  
  - create-abi-dump.py is run successful
  - check-abi does NOT check anything.
  
  running this step locally machine is successful:
  "Let's do a ABI check 327ed59cd15e6038bf3303ca5f30b4b51b2f61f0 
 
against 1dae8da6ab3ebe1f8f5acf5cd0c563557cd3cbda 
 "
  May this be an issue of publishing the buildArtifacts?

TASK DETAIL
  https://phabricator.kde.org/T3689

To: knauss
Cc: dfaure, kde-frameworks-devel, bcooksley, sysadmin, scarlettclark, aacid, 
knauss, alexeymin, kaning, blazquez

D17530: improve highlighting of complex numbers

[Dominik Haumann]

dhaumann added a comment.


  Well, if it's copy & pasted, it must be correct ;)

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D17530

To: cullmann, dhaumann, vkrause, #frameworks
Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

T3689: Add abi compliance checker to CI

[Sandro Knauß]

knauss added a comment.


  I now looked at every repository that failed to build successfully a ABI dump 
  for Pim. Most of them build successful, but a few of them have issues:
  
  - kmime has an unexported header in kmime/kmime_newsarticle.h: `#include 
` that lives in src/supertrait.h
  
  - akonadi-search is unhappy that xapian.h is not imported as first file.
  
  F6473684: log.txt 
  
  - kitinerary has an unexported header in KPim/kitinerary/airportdb.h: 
`#include "timezonedb.h"` that lives in src/knowledgedb/timezonedb.h
  
  - PimCommonAkonadi adds 
$ to 
target_include_directories, but KF5::IMAP is a private dependency. Can we 
remove this?
  
  - kdepim-apps-libs: FollowupReminder adds 
$ to 
target_include_directories. But both files in src/libfollowupreminder/src/*h 
don't use relative links to AkonadiCore. Can we remove this?

TASK DETAIL
  https://phabricator.kde.org/T3689

To: knauss
Cc: dfaure, kde-frameworks-devel, bcooksley, sysadmin, scarlettclark, aacid, 
knauss, alexeymin, kaning, blazquez

D17548: Fixed link to the coding style wiki page

[Jan Przybylak]

janpr added a comment.


  Thanks for accepting the revision.
  I am not authorized to land it, someone else will have to do that.

REPOSITORY
  R293 Baloo

BRANCH
  fixed_typo_in_readme (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17548

To: janpr, #baloo, broulik
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D17522: BrightScript: Add workaround for QtCreator 'endsub' highlighting

[Daniel Levin]

dlevin added a comment.


  Yeah, this might be another bug in the QtCreator (already fixed one crash in 
their highlighting implementation). They asked me to not put much effort 
because that code it deprecated anyway in favor or KDE lib. But they just 
released Creator 4.8.0 and I do not expect any major updates in the nearest 
feature. So providing simple workaround in the XML should be good enough. 
Thanks for the quick review as always!

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D17522

To: dlevin, cullmann
Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.11 - Build # 8 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.11/8/
 Project:
kf5-qt5 SUSEQt5.11
 Date of build:
Wed, 12 Dec 2018 19:34:30 +
 Build duration:
17 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 61 test(s), Skipped: 0 test(s), Total: 61 test(s)Name: projectroot.autotests.src Failed: 1 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 5 test(s)Failed: projectroot.autotests.src.vimode.vimode_keys
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report79%
(22/28)88%
(254/289)88%
(254/289)68%
(32960/48239)51%
(15852/30984)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.src100%
(37/37)100%
(37/37)94%
(4431/4730)49%
(1696/3450)autotests.src.vimode100%
(9/9)100%
(9/9)99%
(5483/5523)58%
(996/1712)src.buffer88%
(15/17)88%
(15/17)90%
(1697/1881)76%
(1214/1596)src.completion100%
(11/11)100%
(11/11)57%
(1772/3109)43%
(1160/2717)src.completion.expandingtree100%
(3/3)100%
(3/3)40%
(184/459)22%
(76/348)src.dialogs0%
(0/4)0%
(0/4)0%
(0/732)0%
(0/176)src.document100%
(4/4)100%
(4/4)59%
(1870/3165)47%
(1565/3313)src.export0%
(0/4)0%
(0/4)0%
(0/119)0%
(0/162)src.include.ktexteditor93%
(14/15)93%
(14/15)91%
(221/244)65%
(146/226)src.inputmode100%
(8/8)100%
(8/8)63%
(189/302)51%
(39/77)src.mode83%
(5/6)83%
(5/6)41%
(171/417)40%
(111/275)src.part0%
(0/1)0%
(0/1)0%
(0/7)100%
(0/0)src.printing0%
(0/4)0%
(0/4)0%
(0/830)0%
(0/294)src.render100%
(7/7)100%
(7/7)77%
(953/1244)67%
(627/942)src.schema29%
(2/7)29%
(2/7)1%
(20/1492)1%
(6/673)src.script100%
(16/16)100%
(16/16)68%
(731/1069)58%
(268/465)src.search100%
(6/6)100%
(6/6)74%
(1109/1498)64%

T3689: Add abi compliance checker to CI

[Sandro Knauß]

knauss added subscribers: kde-frameworks-devel, dfaure.
knauss added a comment.


  I now looked at every repository that failed to build successfully a ABI dump 
for Frameworks.
  As I'm not really deep into the Framworks code, so I'm unsure, if those are 
real issues or if those Frameworks need special handling.
  Please give me any response you have to those issues. (@aacid , @dfaure, 
@kde-frameworks-devel)
  
  From 79 packages inside Frameworks a lot run successfully. From those 5 
packages I'm quite sure, that those are real issues, that needs to get fixed:
  
  - kdelibs4support
- missing dependency to frameworks/kitemmodels
- failed to find #include 
  
  F6473565: log.txt 
  
  - kwayland
- KWayland/Client/xdgforeign_v2.h ->  missing `include "xdgforeign.h"`
  
  - kjs
- no include/KF5/kjs in INTERFACE_INCLUDE_DIRECTORIES
- CompileState.h includes non exported opcodes.h and bytecodes/opcodes.h 
#401955
  
  *plasma-framework
  
  - no include/KF5/KF5PlasmaQuick in INTERFACE_INCLUDE_DIRECTORIES for 
KF5PlasmaQuick
  
  compiles but has still error on the log:
  
  - networkmanager-qt
- failing building headers
  
  F6473566: log.txt 
  
  And some repositories, that have no public library. Is this intended?
  
  - KF5NewStuffQuick has no library (KF5NewStuff is fine)
  - extra-cmake-modules
  - kdesignerplugin
  - kinit
  - qqc2-desktop-style
  
  How this ABI checker tool works. As input the tool uses the output made while 
installing the package.
  
  - It scans this output for installs of ".*Config.cmake$" files
  - runs cmake in trace-expand mode for "find_package({name} CONFIG REQUIRED)"
  - scans this cmake output for
- PACKAGE_VERSION -> this is the library version
- IMPORTED_SONAME_DEBUG,  -> to get the soversion
- IMPORTED_LOCATION_DEBUG -> the the path of the lib
- INTERFACE_INCLUDE_DIRECTORIES -> all needed include directories
  
  - each exported header file is tried to be compiled and symbols are extracted.
  
  The sourcecode of this script you find in 
sysadmin/ci-tooling/helpers/create-abi-dump.py

TASK DETAIL
  https://phabricator.kde.org/T3689

To: knauss
Cc: dfaure, kde-frameworks-devel, bcooksley, sysadmin, scarlettclark, aacid, 
knauss, alexeymin, kaning, blazquez

KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.11 - Build # 7 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.11/7/
 Project:
kf5-qt5 SUSEQt5.11
 Date of build:
Wed, 12 Dec 2018 19:16:56 +
 Build duration:
17 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 61 test(s), Skipped: 0 test(s), Total: 61 test(s)Name: projectroot.autotests.src Failed: 1 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 5 test(s)Failed: projectroot.autotests.src.vimode.vimode_keys
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report79%
(22/28)88%
(254/289)88%
(254/289)68%
(32962/48239)51%
(15852/30986)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.src100%
(37/37)100%
(37/37)94%
(4431/4730)49%
(1696/3450)autotests.src.vimode100%
(9/9)100%
(9/9)99%
(5483/5523)58%
(996/1712)src.buffer88%
(15/17)88%
(15/17)90%
(1699/1881)76%
(1215/1598)src.completion100%
(11/11)100%
(11/11)57%
(1772/3109)43%
(1160/2717)src.completion.expandingtree100%
(3/3)100%
(3/3)40%
(184/459)22%
(76/348)src.dialogs0%
(0/4)0%
(0/4)0%
(0/732)0%
(0/176)src.document100%
(4/4)100%
(4/4)59%
(1870/3165)47%
(1565/3313)src.export0%
(0/4)0%
(0/4)0%
(0/119)0%
(0/162)src.include.ktexteditor93%
(14/15)93%
(14/15)91%
(221/244)65%
(146/226)src.inputmode100%
(8/8)100%
(8/8)63%
(189/302)51%
(39/77)src.mode83%
(5/6)83%
(5/6)41%
(171/417)40%
(111/275)src.part0%
(0/1)0%
(0/1)0%
(0/7)100%
(0/0)src.printing0%
(0/4)0%
(0/4)0%
(0/830)0%
(0/294)src.render100%
(7/7)100%
(7/7)77%
(953/1244)67%
(627/942)src.schema29%
(2/7)29%
(2/7)1%
(20/1492)1%
(6/673)src.script100%
(16/16)100%
(16/16)68%
(731/1069)58%
(268/465)src.search100%
(6/6)100%
(6/6)74%
(1109/1498)64%

D17055: Avoid Q_FOREACH

[Christoph Cullmann]

This revision was automatically updated to reflect the committed changes.
Closed by commit R246:59fcd4bd2aff: Avoid Q_FOREACH (authored by loh.tar, 
committed by cullmann).

REPOSITORY
  R246 Sonnet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17055?vs=45897=47477

REVISION DETAIL
  https://phabricator.kde.org/D17055

AFFECTED FILES
  data/parsetrigrams.cpp
  src/core/guesslanguage.cpp
  src/plugins/hspell/hspelldict.cpp
  src/plugins/hunspell/hunspellclient.cpp
  src/plugins/voikko/voikkodict.cpp

To: loh.tar, davidedmundson, cullmann
Cc: cullmann, kde-frameworks-devel, michaelh, ngraham, bruns

D17457: use STL were no implicit sharing is required

[Christoph Cullmann]

This revision was automatically updated to reflect the committed changes.
Closed by commit R39:765d5674c5e5: use STL were no implicit sharing is required 
(authored by cullmann).

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17457?vs=47378=47476

REVISION DETAIL
  https://phabricator.kde.org/D17457

AFFECTED FILES
  src/buffer/katetextblock.cpp
  src/buffer/katetextblock.h

To: cullmann, dhaumann
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, 
bruns, demsking, cullmann, sars

D16347: Expose KTextEditor::ViewPrivate:setInputMode(InputMode) to KTextEditor::View

[Christoph Cullmann]

This revision was automatically updated to reflect the committed changes.
Closed by commit R39:d338c398aa87: Expose 
KTextEditor::ViewPrivate:setInputMode(InputMode) to KTextEditor::View (authored 
by cullmann).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D16347?vs=47389=47475#toc

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16347?vs=47389=47475

REVISION DETAIL
  https://phabricator.kde.org/D16347

AFFECTED FILES
  src/include/ktexteditor/view.h
  src/utils/ktexteditor.cpp

To: cullmann, mlaurent, vkrause, dhaumann, demsking
Cc: cullmann, kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, 
bruns, demsking, sars, dhaumann

D17457: use STL were no implicit sharing is required

[Christoph Cullmann]

cullmann marked an inline comment as done.
cullmann added inline comments.

INLINE COMMENTS

> dhaumann wrote in katetextblock.cpp:64
> Is there a reason why this assert is useless now?

.at() will throw (or abort)

REPOSITORY
  R39 KTextEditor

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17457

To: cullmann, dhaumann
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, 
bruns, demsking, cullmann, sars

D17457: use STL were no implicit sharing is required

[Christoph Cullmann]

cullmann marked 2 inline comments as done.

REPOSITORY
  R39 KTextEditor

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17457

To: cullmann, dhaumann
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, 
bruns, demsking, cullmann, sars

D17522: BrightScript: Add workaround for QtCreator 'endsub' highlighting

[Christoph Cullmann]

This revision was automatically updated to reflect the committed changes.
Closed by commit R216:abd1bb407e69: BrightScript: Add workaround for QtCreator 
endsub highlighting (authored by dlevin, committed by cullmann).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17522?vs=47414=47474

REVISION DETAIL
  https://phabricator.kde.org/D17522

AFFECTED FILES
  data/syntax/brightscript.xml

To: dlevin, cullmann
Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D17522: BrightScript: Add workaround for QtCreator 'endsub' highlighting

[Christoph Cullmann]

cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  If that helps the QtCreator implementation, I am ok with it, thought I would 
like to see that they use the framework :P

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D17522

To: dlevin, cullmann
Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D17548: Fixed link to the coding style wiki page

[Jan Przybylak]

janpr added a reviewer: Baloo.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D17548

To: janpr, #baloo
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D17548: Fixed link to the coding style wiki page

[Jan Przybylak]

janpr created this revision.
Herald added projects: Frameworks, Baloo.
Herald added subscribers: Baloo, kde-frameworks-devel.
janpr requested review of this revision.

REVISION SUMMARY
  The page has been moved from the TechBase to the community wiki

REPOSITORY
  R293 Baloo

BRANCH
  fixed_typo_in_readme (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17548

AFFECTED FILES
  README.md

To: janpr
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D17498: Xdg Decoration Support

[Vlad Zagorodniy]

zzag accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R127 KWayland

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17498

To: davidedmundson, #kwin, zzag
Cc: zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D17542: Reset parentItem when mainItem changes

[David Edmundson]

davidedmundson added a comment.


  Oh, to fix fallout from the other review. NM

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D17542

To: broulik, #plasma, mart
Cc: davidedmundson, kde-frameworks-devel, michaelh, ngraham, bruns

D17545: Do not stat move/copy job if the destination file system does not support writing

[Shubham]

shubham added a reviewer: dfaure.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17545

To: shubham, #frameworks, dfaure
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.9 - Build # 375 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.9/375/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Wed, 12 Dec 2018 16:16:56 +
 Build duration:
10 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 51 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiogui_favicontestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(262/398)66%
(262/398)53%
(32048/60117)38%
(16553/44090)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(57/57)100%
(57/57)95%
(9091/9538)48%
(4276/8965)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(113/166)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(100/116)86%
(100/116)58%
(8328/14339)50%
(4668/9267)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets76%
(28/37)76%
(28/37)49%
(3908/7970)34%
(1604/4743)src.gui100%
(2/2)100%
(2/2)88%
(95/108)68%
(45/66)src.ioslaves.file100%
(5/5)100%
(5/5)51%
(531/1036)37%
(318/868)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1344)0%
(0/1416)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/248)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)41%
(1770/4288)35%
(1305/3692)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1330)55%
(626/1135)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%
(0/12)100%
   

D17498: Xdg Decoration Support

[David Edmundson]

davidedmundson updated this revision to Diff 47468.
davidedmundson added a comment.


  remove unused

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17498?vs=47339=47468

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17498

AFFECTED FILES
  autotests/client/CMakeLists.txt
  autotests/client/test_xdg_decoration.cpp
  src/client/CMakeLists.txt
  src/client/protocols/xdg-decoration-unstable-v1.xml
  src/client/registry.cpp
  src/client/registry.h
  src/client/xdgdecoration.cpp
  src/client/xdgdecoration.h
  src/server/CMakeLists.txt
  src/server/display.cpp
  src/server/display.h
  src/server/xdgdecoration_interface.cpp
  src/server/xdgdecoration_interface.h
  src/server/xdgshell_interface.h
  src/tools/mapping.txt

To: davidedmundson, #kwin
Cc: zzag, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.11 - Build # 14 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.11/14/
 Project:
kf5-qt5 SUSEQt5.11
 Date of build:
Wed, 12 Dec 2018 16:16:56 +
 Build duration:
7 min 2 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 51 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiogui_favicontestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(262/398)66%
(262/398)53%
(32051/60118)38%
(16560/44090)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(57/57)100%
(57/57)95%
(9091/9538)48%
(4281/8965)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(113/166)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(100/116)86%
(100/116)58%
(8331/14340)50%
(4670/9263)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets76%
(28/37)76%
(28/37)49%
(3908/7970)34%
(1604/4743)src.gui100%
(2/2)100%
(2/2)88%
(95/108)68%
(45/66)src.ioslaves.file100%
(5/5)100%
(5/5)51%
(531/1036)37%
(318/868)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1344)0%
(0/1416)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/248)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)41%
(1770/4288)35%
(1304/3692)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1330)55%
(626/1135)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%
(0/12)100%
 

D17542: Reset parentItem when mainItem changes

[David Edmundson]

davidedmundson added a comment.


  What's the benefit?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D17542

To: broulik, #plasma, mart
Cc: davidedmundson, kde-frameworks-devel, michaelh, ngraham, bruns

D17545: Do not stat move/copy job if the destination file system does not support writing

[Shubham]

shubham updated this revision to Diff 47465.

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17545?vs=47462=47465

REVISION DETAIL
  https://phabricator.kde.org/D17545

AFFECTED FILES
  src/core/copyjob.cpp

To: shubham, #frameworks
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D17173: Add error value for job owner dying

[Kai Uwe Broulik]

broulik accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17173

To: davidedmundson, dfaure, broulik
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D17173: Add error value for job owner dying

[David Edmundson]

davidedmundson updated this revision to Diff 47464.
davidedmundson added a comment.


  rebase

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17173?vs=46261=47464

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17173

AFFECTED FILES
  src/core/global.h

To: davidedmundson, dfaure
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D17173: Add error value for job owner dying

[Kai Uwe Broulik]

broulik added a reviewer: dfaure.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17173

To: davidedmundson, dfaure
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D17173: Add error value for job owner dying

[Kai Uwe Broulik]

broulik added a comment.


  Now that `ERR_FILE_TOO_LARGE_FOR_FAT32` is in you can rebase this

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17173

To: davidedmundson
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D17545: Do not stat move/copy job if the destination file system does not support writing

[Kai Uwe Broulik]

broulik added a comment.


  The bug report is about checking whether it's writable, you're checking the 
protocol here, and `file` will always "support writing". This patch could still 
make sense, though.

INLINE COMMENTS

> copyjob.cpp:864
> +QPointer that = q;
> +emit q->warning(q, buildErrorString(ERR_CYCLIC_COPY, 
> m_currentDestURL.toDisplayString()));
> +if (that) {

Not sure `ERR_CYCLIC_COPY` is the correct error for this?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17545

To: shubham, #frameworks
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D17545: Do not stat move/copy job if the destination file system does not support writing

[Shubham]

shubham created this revision.
shubham added a reviewer: Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
shubham requested review of this revision.

REVISION SUMMARY
  BUG: 141564

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17545

AFFECTED FILES
  src/core/copyjob.cpp

To: shubham, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17505: Add preferences-system-bluetooth-battery to preferences.svgz

[Nathaniel Graham]

ngraham accepted this revision.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  bluetooth-battery-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17505

To: ndavis, #vdg, #plasma, broulik, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17505: Add preferences-system-bluetooth-battery to preferences.svgz

[Kai Uwe Broulik]

broulik accepted this revision.
broulik added a comment.
This revision is now accepted and ready to land.


  Thanks!

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  bluetooth-battery-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17505

To: ndavis, #vdg, #plasma, broulik
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17543: [Dialog] Don't alter mainItem's visibility

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, mart.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.

REVISION SUMMARY
  The item's `visible` property is independent of the window visibility, which 
can be checked using `Window.visible`.

TEST PLAN
  Needs D17542  to fix tooltips
  Other than that, kickoff, systray, panelcontroller, notification popups, task 
manager group dialogs, visibility of pager depending on panelcontroller 
opening, still works.
  dialogqmltest and dialogstatetest still pass, dialognativetest is broken 
before and after
  
  Notifications no longer get bogus `containsMouse` and properly times out:
  When you closed notification popup by clicking the X button inside the popup, 
and the popup shows again later, because we manually set `visible` to `true`, 
`QQuickMouseArea` enters the following code
  
case ItemVisibleHasChanged:
   if (acceptHoverEvents() && d->hovered != (isVisible() && 
isUnderMouse())) {
   if (!d->hovered) {
   QPointF cursorPos = 
QGuiApplicationPrivate::lastCursorPosition;
   d->lastScenePos = 
d->window->mapFromGlobal(cursorPos.toPoint());
   d->lastPos = mapFromScene(d->lastScenePos);
   }
   setHovered(!d->hovered);
   }
  
  `QGuiApplicationPrivate::lastCursorPosition` is only updated when a 
`plasmashell` window is hovered, which is usually not the case when you just 
dismissed a notification popup ontop of another application. Hence, the 
position is incorrect and opening the dialog again causes it to think it's 
hovered.
  `isUnderMouse()` basically checks 
`contains(QGuiApplicationPrivate::lastCursorPosition)`.
  If we don't mess with visibility, none of this happens.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D17543

AFFECTED FILES
  src/plasmaquick/dialog.cpp

To: broulik, #plasma, mart
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17518: Adapt favicon test to www.kde.org changes

[Stefan Brüns]

bruns added a comment.


  In D17518#375713 , @broulik wrote:
  
  > I also thought the favicon was too large for `FavIconJob` to download
  
  
  The now existing www.kde.org/favicon.ico ideed was to large for the favicon 
job, so the unchanged code got an "too large" error instead of the expected 
"does not exist". After pointing the job to a nonexisting file, this no longer 
is an issue.

REPOSITORY
  R241 KIO

BRANCH
  favicon_test

REVISION DETAIL
  https://phabricator.kde.org/D17518

To: bruns, #frameworks, ngraham
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D17542: Reset parentItem when mainItem changes

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, mart.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Otherwise we'll keep piling up custom tooltip items in the dialog. They're 
invisible but they're still there.

TEST PLAN
  Kept the contentItem visible, moved between TM and kickoff, tooltip no longer 
ends up with multiple items in it:
  Before:
  F6473103: Screenshot_20181212_151924.png 

  They're not "leaked" as it doesn't change ownership (`parent` vs 
`parentItem`) but it still adds unnccessary invisible items to the window

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D17542

AFFECTED FILES
  src/plasmaquick/dialog.cpp

To: broulik, #plasma, mart
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17491: Fix documentation, QValueList isn't a thing anymore

[Aleix Pol Gonzalez]

apol closed this revision.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D17491

To: apol, #frameworks, aacid
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17491: Fix documentation, QValueList isn't a thing anymore

[Albert Astals Cid]

aacid accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R237 KConfig

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17491

To: apol, #frameworks, aacid
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17529: [proxysetting] Fix build with NM 1.4

[Wolfgang Bauer]

This revision was automatically updated to reflect the committed changes.
Closed by commit R282:88f3093c5237: [proxysetting] Fix build with NM 1.4 
(authored by wbauer).

REPOSITORY
  R282 NetworkManagerQt

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17529?vs=47446=47454

REVISION DETAIL
  https://phabricator.kde.org/D17529

AFFECTED FILES
  src/settings/proxysetting.h

To: wbauer, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17530: improve highlighting of complex numbers

[Christoph Cullmann]

This revision was automatically updated to reflect the committed changes.
Closed by commit R216:ea5a88d1df28: improve highlighting of complex numbers 
(authored by cullmann).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17530?vs=47430=47450

REVISION DETAIL
  https://phabricator.kde.org/D17530

AFFECTED FILES
  autotests/folding/test.c.fold
  autotests/html/test.c.html
  autotests/input/test.c
  autotests/reference/test.c.ref
  data/syntax/c.xml

To: cullmann, dhaumann, vkrause, #frameworks
Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D17529: [proxysetting] Fix build with NM 1.4

[Jan Grulich]

jgrulich accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R282 NetworkManagerQt

REVISION DETAIL
  https://phabricator.kde.org/D17529

To: wbauer, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17529: [proxysetting] Fix build with NM 1.4

[Wolfgang Bauer]

wbauer edited the summary of this revision.

REPOSITORY
  R282 NetworkManagerQt

REVISION DETAIL
  https://phabricator.kde.org/D17529

To: wbauer, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17529: [proxysetting] Fix build with NM 1.4

[Wolfgang Bauer]

wbauer requested review of this revision.

REPOSITORY
  R282 NetworkManagerQt

REVISION DETAIL
  https://phabricator.kde.org/D17529

To: wbauer, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17529: [proxysetting] Fix build with NM 1.4

[Wolfgang Bauer]

wbauer updated this revision to Diff 47446.
wbauer edited the summary of this revision.
wbauer added a comment.


  Don't define the enum, rather use the numbers directly

REPOSITORY
  R282 NetworkManagerQt

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17529?vs=47426=47446

REVISION DETAIL
  https://phabricator.kde.org/D17529

AFFECTED FILES
  src/settings/proxysetting.h

To: wbauer, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17530: improve highlighting of complex numbers

[Christoph Cullmann]

cullmann added a comment.


  It's "stolen" 1:1 from the C++ stuff.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17530

To: cullmann, dhaumann, vkrause, #frameworks
Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D17530: improve highlighting of complex numbers

[Dominik Haumann]

dhaumann accepted this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.


  Reviewing correct context popping is always not so easy - I trust this part 
is correct?! ;)

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17530

To: cullmann, dhaumann, vkrause, #frameworks
Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D17529: [proxysetting] Fix build with NM 1.4

[Jan Grulich]

jgrulich added a comment.


  In D17529#375913 , @wbauer wrote:
  
  > In D17529#375909 , @jgrulich 
wrote:
  >
  > > So maybe go with the easiest approach and just instead of defines use 0 
and 1?
  >
  >
  > Fine with me.
  >
  > Should I make that conditional depending on the NM version maybe, or just 
unconditionally use the numbers?
  
  
  Unconditionally. It doesn't matter if it uses defines or numbers directly.

REPOSITORY
  R282 NetworkManagerQt

REVISION DETAIL
  https://phabricator.kde.org/D17529

To: wbauer, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17529: [proxysetting] Fix build with NM 1.4

[Wolfgang Bauer]

wbauer added a comment.


  In D17529#375909 , @jgrulich wrote:
  
  > So maybe go with the easiest approach and just instead of defines use 0 and 
1?
  
  
  Fine with me.
  
  Should I make that conditional depending on the NM version maybe, or just 
unconditionally use the constants?

REPOSITORY
  R282 NetworkManagerQt

REVISION DETAIL
  https://phabricator.kde.org/D17529

To: wbauer, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17529: [proxysetting] Fix build with NM 1.4

[Jan Grulich]

jgrulich added a comment.


  So maybe go with the easiest approach and just instead of defines use 0 and 1?

REPOSITORY
  R282 NetworkManagerQt

REVISION DETAIL
  https://phabricator.kde.org/D17529

To: wbauer, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17529: [proxysetting] Fix build with NM 1.4

[Wolfgang Bauer]

wbauer added a comment.


  Hm, maybe I should add `extern "C"` though?
  This is inside `G_BEGIN_DECLS`/`G_END_DECLS` in nm-setting-proxy.h, which are 
defined as `extern "C" {` and `}` (according to the docs).

REPOSITORY
  R282 NetworkManagerQt

REVISION DETAIL
  https://phabricator.kde.org/D17529

To: wbauer, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17529: [proxysetting] Fix build with NM 1.4

[Wolfgang Bauer]

wbauer added a comment.


  In D17529#375882 , @wbauer wrote:
  
  > I don't think that really is a problem here though, as it is defined in 
libnm/nm-setting-proxy.h (in NM 1.6+) which is included by this file (via 
NetworkManager.h that's included by setting.h).
  >  I.e. the enum will still be there when building against NM 1.6.0+ 
(otherwise the build would fail in the first place anyway, as it is used just a 
few lines below).
  
  
  Sorry, I somehow read "API incompatible"...
  
  TBH, I'm not sure about ABI either. But as this is outside of any class, it 
shouldn't be a problem? (as mentioned, it would be defined by another include 
file anyway when building against  NM 1.6.0+)

REPOSITORY
  R282 NetworkManagerQt

REVISION DETAIL
  https://phabricator.kde.org/D17529

To: wbauer, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17529: [proxysetting] Fix build with NM 1.4

[Jan Grulich]

jgrulich accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R282 NetworkManagerQt

REVISION DETAIL
  https://phabricator.kde.org/D17529

To: wbauer, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17529: [proxysetting] Fix build with NM 1.4

[Wolfgang Bauer]

wbauer added a comment.


  In D17529#375867 , @jgrulich wrote:
  
  > I think the easiest solution here is just to set 0 and 1 to the enum 
values, instead of NM defines.
  
  
  Sure, that would work as well.
  
  But IMHO the version check would make it easier to remove this "hack" when 
the minimum NM version would be raised at some point in the future.
  
  Whatever you prefer though.
  
  > I'm not sure if adding/removing enum is ABI compatible change, because the 
enum will disapper once you build it against NM 1.6.0+.
  
  Hm, I see what you mean.
  
  I don't think that really is a problem here though, as it is defined in 
libnm/nm-setting-proxy.h (in NM 1.6+) which is included by this file (via 
NetworkManager.h that's included by setting.h).
  I.e. the enum will still be there when building against NM 1.6.0+ (otherwise 
the build would fail in the first place anyway, as it is used just a few lines 
below).

REPOSITORY
  R282 NetworkManagerQt

REVISION DETAIL
  https://phabricator.kde.org/D17529

To: wbauer, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17529: [proxysetting] Fix build with NM 1.4

[Jan Grulich]

jgrulich added a comment.


  I think the easiest solution here is just to set 0 and 1 to the enum values, 
instead of NM defines. I'm not sure if adding/removing enum is ABI compatible 
change, because the enum will disapper once you build it against NM 1.6.0+.

REPOSITORY
  R282 NetworkManagerQt

REVISION DETAIL
  https://phabricator.kde.org/D17529

To: wbauer, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kpackage » kf5-qt5 SUSEQt5.11 - Build # 3 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20SUSEQt5.11/3/
 Project:
kf5-qt5 SUSEQt5.11
 Date of build:
Wed, 12 Dec 2018 10:10:32 +
 Build duration:
4 min 32 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 3 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: projectroot.autotests.testfallbackpackage_appstreamFailed: projectroot.autotests.testpackage_appstreamFailed: projectroot.autotests.testpackage_nodisplay_appstream
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(5/5)95%
(20/21)95%
(20/21)72%
(1565/2166)51%
(1076/2124)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(6/6)100%
(6/6)99%
(531/533)51%
(242/470)autotests.mockdepresolver100%
(1/1)100%
(1/1)78%
(14/18)58%
(7/12)src.kpackage75%
(3/4)75%
(3/4)74%
(557/753)64%
(598/935)src.kpackage.private100%
(7/7)100%
(7/7)79%
(302/380)49%
(104/211)src.kpackagetool100%
(3/3)100%
(3/3)33%
(161/482)25%
(125/496)

D17302: add simple test for string merging

[Alexander Stippich]

astippich added a comment.


  I was recently wondering if this is actually desired behavior. Right now it 
is definitely required since KFileMetaData wrongly outputs QStrings instead of 
a QStringList, but when this is fixed, this behavior should be removed imho. 
Otherwise, querying metadata via KFileMetaData and via Baloo differs in output, 
which it shouldn't.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D17302

To: astippich, #baloo, bruns
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D17530: improve highlighting of complex numbers

[Christoph Cullmann]

cullmann added a comment.


  I didn't include rules as I need to rule out the user literal suffixes.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D17530

To: cullmann, dhaumann, vkrause, #frameworks
Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D17530: improve highlighting of complex numbers

[Christoph Cullmann]

cullmann updated this revision to Diff 47430.
cullmann added a comment.


  update unit tests

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17530?vs=47429=47430

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17530

AFFECTED FILES
  autotests/folding/test.c.fold
  autotests/html/test.c.html
  autotests/input/test.c
  autotests/reference/test.c.ref
  data/syntax/c.xml

To: cullmann
Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D17530: improve highlighting of complex numbers

[Christoph Cullmann]

cullmann added reviewers: dhaumann, vkrause, Frameworks.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D17530

To: cullmann, dhaumann, vkrause, #frameworks
Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D17530: improve highlighting of complex numbers

[Christoph Cullmann]

cullmann created this revision.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
cullmann requested review of this revision.

REVISION SUMMARY
  CHANGELOG: support more variants of C number literals
  
  BUG: 402002

TEST PLAN
  adapted unit tests to cover problematic cases

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17530

AFFECTED FILES
  autotests/input/test.c
  data/syntax/c.xml

To: cullmann
Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D17496: Change network/web color icons to consistent style

[Noah Davis]

ndavis added a comment.


  I did notice that symlinks for `applications-internet` exist in `apps/16` and 
`apps/22`, so maybe there needs to be a scalable version in the same category? 
There was no `apps/48/applications-internet`, but there was a 
`preferences/32/applications-internet`. I removed that because it seemed 
redundant and out of place. Are applications able to specify which `Context` an 
icon they want to use comes from?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17496

To: ndavis, #vdg, ngraham
Cc: abetts, ngraham, kde-frameworks-devel, michaelh, bruns

D17529: [proxysetting] Fix build with NM 1.4

[Wolfgang Bauer]

wbauer added a reviewer: jgrulich.

REPOSITORY
  R282 NetworkManagerQt

REVISION DETAIL
  https://phabricator.kde.org/D17529

To: wbauer, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17529: [proxysetting] Fix build with NM 1.4

[Wolfgang Bauer]

wbauer created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
wbauer requested review of this revision.

REVISION SUMMARY
  The `NMSettingProxyMethod` enum only exists since NetworkManager 1.6.
  So define it appropriately when building with a lower version (i.e. 1.4.x).

TEST PLAN
  Builds fine now with NM 1.4.x, before there were compiler errors:
  
In file included from 
/home/abuild/rpmbuild/BUILD/networkmanager-qt-VERSIONgit.20181211T113515~4332597/src/settings/proxysetting.cpp:21:0:

/home/abuild/rpmbuild/BUILD/networkmanager-qt-VERSIONgit.20181211T113515~4332597/src/settings/proxysetting.h:43:16:
 error: 'NM_SETTING_PROXY_METHOD_NONE' was not declared in this scope
 None = NM_SETTING_PROXY_METHOD_NONE,
^

/home/abuild/rpmbuild/BUILD/networkmanager-qt-VERSIONgit.20181211T113515~4332597/src/settings/proxysetting.h:44:16:
 error: 'NM_SETTING_PROXY_METHOD_AUTO' was not declared in this scope
 Auto = NM_SETTING_PROXY_METHOD_AUTO
^
  
  Still compiles with newer versions, tested with 1.6.0, 1.10.6, and 1.14.4.

REPOSITORY
  R282 NetworkManagerQt

REVISION DETAIL
  https://phabricator.kde.org/D17529

AFFECTED FILES
  src/settings/proxysetting.h

To: wbauer
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17528: Refactor SlaveInterface::calcSpeed

[Chinmoy Ranjan Pradhan]

chinmoyr created this revision.
chinmoyr added a reviewer: dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
chinmoyr requested review of this revision.

REVISION SUMMARY
  Use QLinkedList instead of a static array.
  Use QElapsedTimer instead of QDateTime for elapsed time.

TEST PLAN
  Copied several large files(5-20Gb). The difference between current and 
previous speed calculation was within 0-300Kb.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17528

AFFECTED FILES
  src/core/slaveinterface.cpp
  src/core/slaveinterface_p.h

To: chinmoyr, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17500: Restore mobipocket extractor

[Alexander Stippich]

astippich added a comment.


  Oh, thanks for the hint, didn't know that. That makes it a lot more 
complicated than a straight port :(
  Looking at the code of kdegraphics-mobipocket, shouldn't the thumbnail 
extractor actually be part of kio-extras? Seems quite kio-specific, and a quick 
look at lxr didn't reveal any usages of the thumbnailer.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D17500

To: astippich, bruns
Cc: aacid, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D17496: Change network/web color icons to consistent style

[Noah Davis]

ndavis added a comment.


  In D17496#375658 , @ngraham wrote:
  
  > Looks good visually, but the `scalable` test now fails:
  >
  >   $ grep -A 1 FAIL.*scalable Testing/Temporary/LastTest.log 
  >   FAIL!  : ScalableTest::test_scalable(icons:Applications) The following 
icons are not available in a scalable directory:
  > applications-internet
  >   --
  >   FAIL!  : ScalableTest::test_scalable(icons-dark:Applications) The 
following icons are not available in a scalable directory:
  > applications-internet
  >
  
  
  This shouldn't be possible. `categories/32` is a scalable directory according 
to `index.theme:
  
[categories/32]
Size=32
Context=Categories
Type=Scalable
MinSize=32
MaxSize=256

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17496

To: ndavis, #vdg, ngraham
Cc: abetts, ngraham, kde-frameworks-devel, michaelh, bruns

D16347: Expose KTextEditor::ViewPrivate:setInputMode(InputMode) to KTextEditor::View

[Christoph Cullmann]

cullmann added a comment.


  Hmm, actually, not sure if we need to make it virtual, on the other side, it 
avoids to maintain the redirection.
  I can add a KF6 todo and push it.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D16347

To: cullmann, mlaurent, vkrause, dhaumann, demsking
Cc: cullmann, kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, 
bruns, demsking, sars, dhaumann