D17619: fix for bug 401552

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. Please change the summary to something more descriptive. A bug number is pretty opaque in itself. The patch itself looks good. I also don't understand "kdirmodeltest

D17550: Make the open url in tab feature a bit more discoverable

apol closed this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17550 To: apol, #dolphin, ngraham, #frameworks, elvisangelaccio Cc: elvisangelaccio, kde-frameworks-devel, michaelh, ngraham, bruns

D17178: Don't ask for confimation when reloading

nicolasfella updated this revision to Diff 47740. nicolasfella added a comment. - delete m_modOnHdHandler REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17178?vs=46283=47740 BRANCH arcpatch-D17178 REVISION DETAIL https://phabricator.kde.org/D17178

D17245: Add string formatting function to property info

bruns added inline comments. INLINE COMMENTS > formatstrings.cpp:27 > + > +const KFormat FormatStrings::form; > + I don't think using a static default constructed KFormat is a good idea ... > formatstrings.cpp:50 > +QTime time = dt.time(); > +if (!time.hour() && !time.minute()

D17245: Add string formatting function to property info

bruns added a reviewer: Frameworks. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D17245 To: astippich, broulik, bruns, mgallien, #frameworks Cc: ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, bruns, abrahams

D17623: Add YaST icons

ndavis added a comment. In D17623#378553 , @ngraham wrote: > In D17623#378253 , @ndavis wrote: > > > We can turn the `yast-*` into symlinks and rename the real icons to proper names when we need

D17550: Make the open url in tab feature a bit more discoverable

elvisangelaccio accepted this revision. REPOSITORY R241 KIO BRANCH arcpatch-D17550 REVISION DETAIL https://phabricator.kde.org/D17550 To: apol, #dolphin, ngraham, #frameworks, elvisangelaccio Cc: elvisangelaccio, kde-frameworks-devel, michaelh, ngraham, bruns

D17619: Change the path for every item of the subdirectories in a directory rename

jtamate added a comment. I'll work on the unit test this weekend. I don't currently have enough free time on weekdays. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17619 To: jtamate, dfaure, #frameworks Cc: elvisangelaccio, kde-frameworks-devel, michaelh, ngraham,

D17623: Add YaST icons

ngraham added a comment. In D17623#378253 , @ndavis wrote: > We can turn the `yast-*` into symlinks and rename the real icons to proper names when we need them. You're asking me to guess what the right names for the future would be before we

D17619: Change the path for every item of the subdirectories in a directory rename

jtamate retitled this revision from "fix for bug 401552" to "Change the path for every item of the subdirectories in a directory rename". REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17619 To: jtamate, dfaure, #frameworks Cc: elvisangelaccio, kde-frameworks-devel,

D17619: fix for bug 401552

jtamate updated this revision to Diff 47731. jtamate marked an inline comment as done. jtamate retitled this revision from "Unit test and fix for bug 401552" to "fix for bug 401552". jtamate edited the summary of this revision. jtamate edited the test plan for this revision. jtamate added a

D17619: fix for bug 401552

jtamate edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17619 To: jtamate, dfaure, #frameworks Cc: elvisangelaccio, kde-frameworks-devel, michaelh, ngraham, bruns

D16966: Fix typo in i18n message (cmdline option description)

mlaurent added a comment. no commited yet ?:) REPOSITORY R290 KPackage BRANCH opt-i18n REVISION DETAIL https://phabricator.kde.org/D16966 To: aspotashev, mlaurent Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17647: Fix KGlobalAccel build with Qt 5.13 prerelease

mpyne created this revision. mpyne added reviewers: Frameworks, graesslin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mpyne requested review of this revision. REVISION SUMMARY After a recent system upgrade to Qt git `dev` branch (for upcoming 5.13),

D17623: Add YaST icons

ngraham added a comment. Thanks! Here's a preliminary suggestion: Current icon What it should be a symlink to apps/32/yast-apparmor.svg preferences/32/preferences-security-apparmor.svg

D17528: Refactor SlaveInterface::calcSpeed

chinmoyr updated this revision to Diff 47726. chinmoyr added a comment. Removed vector initialization. Increased vector capacity in constructor. Appended {0,0} at first. Stored time and size before appending to prevent extraction. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D17641: Change default sort order in the download dialog to "Most downloads"

GB_2 created this revision. GB_2 added reviewers: Frameworks, VDG. GB_2 added projects: Frameworks, VDG. Herald added a subscriber: kde-frameworks-devel. GB_2 requested review of this revision. REVISION SUMMARY BUG: 399163 This changes the default sort ordering of the download dialog to

D17641: Change default sort order in the download dialog to "Most downloads"

GB_2 edited the summary of this revision. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D17641 To: GB_2, #frameworks, #vdg Cc: #vdg, kde-frameworks-devel, #frameworks, squeakypancakes, alexde, IohannesPetros, GB_2, trickyricky26, michaelh, crozbo, ndavis, firef,

D17617: Display error instead of silently failing when asked to create folder that already exists

ngraham marked an inline comment as done. ngraham added inline comments. INLINE COMMENTS > anthonyfieroni wrote in knewfilemenu.cpp:916 > Can you verify that if it has tabs it will display on current tab not in all. It displays on the current tab, as expected. REPOSITORY R241 KIO REVISION

D17617: Display error instead of silently failing when asked to create folder that already exists

ngraham marked 2 inline comments as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17617 To: ngraham, #dolphin, elvisangelaccio, dfaure Cc: anthonyfieroni, dfaure, emateli, elvisangelaccio, Codezela, kde-frameworks-devel, michaelh, ngraham, bruns

D17617: Display error instead of silently failing when asked to create folder that already exists

dfaure accepted this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17617 To: ngraham, #dolphin, elvisangelaccio, dfaure Cc: dfaure, emateli, elvisangelaccio, Codezela, kde-frameworks-devel, michaelh, ngraham, bruns

D17617: Display error instead of silently failing when asked to create folder that already exists

anthonyfieroni added inline comments. INLINE COMMENTS > knewfilemenu.cpp:916 > job->uiDelegate()->setAutoErrorHandlingEnabled(true); > -KIO::FileUndoManager::self()->recordJob(KIO::FileUndoManager::Mkpath, > QList(), url, job); > +KJobWidgets::setWindow(job, m_parentWidget); >

D17617: Display error instead of silently failing when asked to create folder that already exists

anthonyfieroni added inline comments. INLINE COMMENTS > ngraham wrote in knewfilemenu.cpp:916 > It displays on the current tab, as expected. I still think it's better to emit errorMessage instead. Can you check it will be more difficult ? REPOSITORY R241 KIO REVISION DETAIL

D17632: Move/copy job: skip stat'ing sources if the destination dir isn't writable

chinmoyr added inline comments. INLINE COMMENTS > chinmoyr wrote in copyjob.cpp:419 > For file permissions, 'file:' and 'trash:' use the result of QT_LSTAT, > 'archive:' makes use of stat, 'sftp:' uses sftp_lstat, and smb sets > UDS_ACCESS to 0500. These are the kioslaves(I found) which KDE

D17632: Move/copy job: skip stat'ing sources if the destination dir isn't writable

chinmoyr added inline comments. INLINE COMMENTS > copyjob.cpp:419 > +// TODO: this is done only for local files, but we could use the > UDSEntry to do this portably > +// ... assuming all kioslaves set permissions correctly > +if (fileInfo.exists() &&

D17617: Display error instead of silently failing when asked to create folder that already exists

anthonyfieroni added inline comments. INLINE COMMENTS > ngraham wrote in knewfilemenu.cpp:916 > I don't see how that makes sense. What's wrong with the current approach of > expecting the jobs themselves to emit errors? Makes sense because it's done in one standard way, possible change in