Re: Power Management and Inhibition by Applications

Hi, I had thought that would only inhibit the screensaver instead of automatic sleep. KScreenLocker (previously KSMServer) that owns the org.freedesktop.ScreenSaver interface tells PowerDevil to keep the screen on when screensaver is inhibited. It makes no sense to prevent the screen from

KDE CI: Frameworks » breeze-icons » kf5-qt5 WindowsMSVCQt5.11 - Build # 82 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20WindowsMSVCQt5.11/82/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Wed, 23 Jan 2019 04:00:04 + Build duration: 5 min 21 sec and counting JUnit Tests

KDE CI: Frameworks » breeze-icons » kf5-qt5 WindowsMSVCQt5.11 - Build # 81 - Aborted!

Error processing tokens: Error while parsing action 'Text/ZeroOrMore/FirstOf/Token/DelimitedToken/DelimitedToken_Action3' at input position (line 1, pos 38): ${JELLY_SCRIPT,template="html_gmail"} ^ hudson.remoting.ChannelClosedException: Channel "unknown":

D18380: KIO: make file dialog columns resizable again (and movable)

ngraham added a comment. The behavior is better now, thanks. I think it will be sufficient to fix the bug and not generate user complaints about anything! I'll let someone else do the code review. Maybe someone from #frameworks or #dolphin

D18439: Add proper edit-delete-shred icons

ngraham added a comment. Better, though for the 32px version, the shreds feel too skinny. Maybe making them 2px wide might improve the look? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18439 To: trickyricky26, #vdg Cc: ngraham, kde-frameworks-devel,

D18163: KateRenderer: when printing initially set the color scheme to Printing

dhaumann added a comment. Is KateRenderer::setPrinterFriendly() only called in print preview mode? I think not. What is the bahavior currently when you print a page with another schema, and then print a page again? Does it always fallback to Printing without the patch, or does it

D18380: KIO: make file dialog columns resizable again (and movable)

rjvbb set the repository for this revision to R241 KIO. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18380 To: rjvbb, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18380: KIO: make file dialog columns resizable again (and movable)

rjvbb updated this revision to Diff 50084. rjvbb added a comment. the change to the headerfile was now redundant. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18380?vs=50083=50084 REVISION DETAIL https://phabricator.kde.org/D18380 AFFECTED FILES

D18380: KIO: make file dialog columns resizable again (and movable)

rjvbb set the repository for this revision to R241 KIO. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18380 To: rjvbb, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18380: KIO: make file dialog columns resizable again (and movable)

rjvbb updated this revision to Diff 50083. rjvbb added a comment. Well, that was "interesting". It turns out that Qt has what looks like another path through which section sizes are calculated and through which they're shown, which apparently isn't used in file dialogs but which

D18167: Move -Wsuggest-override -Wlogical-op to regular compiler settings

zzag added a comment. In D18167#398076 , @graesslin wrote: > The human error exists as long as clang-tidy is not used. What I fear is that someone does a hand porting - we have seen several attempts to do that in KWin from various developers.

D17949: ViewPrivate: Make 'Apply Word Wrap' more comfortable

loh.tar updated this revision to Diff 50082. loh.tar retitled this revision from "ViewPrivate: Make applyWordWrap() more comfortable" to "ViewPrivate: Make 'Apply Word Wrap' more comfortable". loh.tar added a comment. - Use std::unique_ptr for the cursor - Oops!? Use 'if' instead of

D18167: Move -Wsuggest-override -Wlogical-op to regular compiler settings

davidedmundson added a comment. Almost every project has already been gone over with clang-tidy. Including kwin which was then force-pushed back by you. This was back in June 2017. I've got little sympathy if we have a warning after explicitly reverting the fix to the warning. I

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 6 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/6/ Project: kf5-qt5 SUSEQt5.10 Date of build: Tue, 22 Jan 2019 18:30:19 + Build duration: 6 min 17 sec and counting BUILD ARTIFACTS

D18450: Add extractor for AppImage files

astippich added a comment. Can you add a test please? In D18450#397920 , @kossebau wrote: > There seems to be some bug with the Comment field though, somehow in Dolphin the comment is not shown, where "dump" displays it as existing.

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 5 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/5/ Project: kf5-qt5 SUSEQt5.10 Date of build: Tue, 22 Jan 2019 18:23:58 + Build duration: 6 min 19 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.11 - Build # 15 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.11/15/ Project: kf5-qt5 SUSEQt5.11 Date of build: Tue, 22 Jan 2019 18:26:05 + Build duration: 2 min 1 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kfilemetadata » kf5-qt5 FreeBSDQt5.12 - Build # 7 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20FreeBSDQt5.12/7/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Tue, 22 Jan 2019 18:25:58 + Build duration: 55 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.11 - Build # 14 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.11/14/ Project: kf5-qt5 SUSEQt5.11 Date of build: Tue, 22 Jan 2019 18:23:58 + Build duration: 2 min 6 sec and counting BUILD ARTIFACTS

D18010: Fix failing test of exiv gps data

This revision was automatically updated to reflect the committed changes. Closed by commit R286:c3fbdea4f7f3: Fix failing test of exiv gps data (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18010?vs=49750=50079 REVISION DETAIL

KDE CI: Frameworks » kfilemetadata » kf5-qt5 FreeBSDQt5.12 - Build # 6 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20FreeBSDQt5.12/6/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Tue, 22 Jan 2019 18:23:58 + Build duration: 55 sec and counting JUnit Tests Name:

D18205: Test empty and zero gps data

This revision was automatically updated to reflect the committed changes. Closed by commit R286:15d8c42d8ce0: Test empty and zero gps data (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18205?vs=49749=50078 REVISION DETAIL

D18450: Add extractor for AppImage files

kossebau updated this revision to Diff 50077. kossebau added a comment. - skip getting the unlocalized description if there is a localized one REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18450?vs=50073=50077 BRANCH addappimageextractor

D18450: Add extractor for AppImage files

kossebau updated this revision to Diff 50073. kossebau added a comment. - switch and use any localized versions found matching the current system locale, should be more expected - also extract appdata and expose as plain text, even though that can be quite some data, but that's the UI's

D18457: Add a preferences-desktop-effects icon

This revision was automatically updated to reflect the committed changes. Closed by commit R266:9ee939e4b914: Add a preferences-desktop-effects icon (authored by trickyricky26, committed by Krešimir Čohar kco...@gmail.com). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE

Re: Power Management and Inhibition by Applications

Hello, On samedi 19 janvier 2019 12:19:10 CET Elvis Angelaccio wrote: > On 16/01/19 22:07, Matthieu Gallien wrote: > > Hello, > > > > I am trying to work on a feature request to add the ability to suppress > > laptop sleep when playing music. > > > > Currently, Juk is doing it via dbus calls to

D18457: Add a preferences-desktop-effects icon

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Love it! @trickyricky26 you might consider signing up for a developer account so you can land your own patches. See https://community.kde.org/Infrastructure/Get_a_Developer_Account

D18167: Move -Wsuggest-override -Wlogical-op to regular compiler settings

graesslin added a comment. The human error exists as long as clang-tidy is not used. What I fear is that someone does a hand porting - we have seen several attempts to do that in KWin from various developers. If devs don't know and now fix the warnings, they can bring in human error.

D18457: Add a preferences-desktop-effects icon

trickyricky26 edited the summary of this revision. trickyricky26 edited the test plan for this revision. trickyricky26 added a reviewer: VDG. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18457 To: trickyricky26, #vdg Cc: kde-frameworks-devel, michaelh, ngraham,

D18457: Add a preferences-desktop-effects icon

trickyricky26 created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. trickyricky26 requested review of this revision. REPOSITORY R266 Breeze Icons BRANCH add-effects-preferences-icon (branched from master) REVISION DETAIL

D18439: Add proper edit-delete-shred icons

trickyricky26 edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18439 To: trickyricky26, #vdg Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D18439: Add proper edit-delete-shred icons

trickyricky26 updated this revision to Diff 50067. trickyricky26 added a comment. - Use different, more recognizable pattern for the shredded part REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18439?vs=50026=50067 BRANCH proper-shred-icons

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.10 - Build # 5 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.10/5/ Project: kf5-qt5 SUSEQt5.10 Date of build: Tue, 22 Jan 2019 14:23:08 + Build duration: 13 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.12 - Build # 6 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.12/6/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Tue, 22 Jan 2019 14:23:08 + Build duration: 11 min and counting JUnit Tests Name:

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.11 - Build # 11 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.11/11/ Project: kf5-qt5 SUSEQt5.11 Date of build: Tue, 22 Jan 2019 14:23:08 + Build duration: 5 min 46 sec and counting BUILD ARTIFACTS

D17693: DocumentPrivate: Treat some chars also as "auto bracket" only when we have a selection

loh.tar updated this revision to Diff 50061. loh.tar edited the summary of this revision. loh.tar set the repository for this revision to R39 KTextEditor. loh.tar added a comment. - const QChar as value, not reference - Add , ; - + ^ ° § & just for completeness REPOSITORY R39 KTextEditor

D17691: Add rows info to the plasma virtual desktop protocol

This revision was automatically updated to reflect the committed changes. Closed by commit R127:d1e8b45d9310: Add rows info to the plasma virtual desktop protocol (authored by mart). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17691?vs=50046=50063

D18455: Port to new connect syntax

chinmoyr created this revision. chinmoyr added a reviewer: davidedmundson. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. chinmoyr requested review of this revision. REVISION SUMMARY Port some Q_PRIVATE_SLOTS in CopyJob and TransferJob to new syntax. TEST

D18380: KIO: make file dialog columns resizable again (and movable)

rjvbb added a comment. > I'm still going to try to fix this Good thing I did (am doing), because what you call the jarring exists also without font stretching. It's something in Qt that somehow doesn't occur in file dialogs but only with applications of the widget like in Kate. It is

D17691: Add rows info to the plasma virtual desktop protocol

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R127 KWayland BRANCH phab/virtualdesktoprows REVISION DETAIL https://phabricator.kde.org/D17691 To: mart, #plasma, #kwin, davidedmundson Cc: zzag, davidedmundson, hein,

D18116: Don't show document load trouble twice

cullmann added a comment. I would not change that here, I would just ignore it in the application, as said in the other diff. REVISION DETAIL https://phabricator.kde.org/D18116 To: loh.tar, #ktexteditor, cullmann, dhaumann Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, hase,

D18450: Add extractor for AppImage files

broulik added a comment. Cool! REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D18450 To: kossebau, #baloo Cc: broulik, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D18450: Add extractor for AppImage files

kossebau added a comment. Example screenshot: F6561839: Screenshot_20190122_102745.png There seems to be some bug with the Comment field though, somehow in Dolphin the comment is not shown, where "dump" displays it as existing. REPOSITORY R286

D18450: Add extractor for AppImage files

kossebau created this revision. kossebau added a reviewer: Baloo. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY Only a few properties currently can be mapped more or less to the existing

D18380: KIO: make file dialog columns resizable again (and movable)

rjvbb added a comment. Yikes, and I can reproduce that. Did you notice this with previous versions that used font stretch? (Probably not if stretch had no effect for the font(s) you tried it with...) I'm still going to try to fix this; even if in the end it doesn't go in there's be a

D17691: Add rows info to the plasma virtual desktop protocol

mart updated this revision to Diff 50046. mart added a comment. - bump versions REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17691?vs=49994=50046 BRANCH phab/virtualdesktoprows REVISION DETAIL https://phabricator.kde.org/D17691 AFFECTED FILES

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.11 - Build # 10 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.11/10/ Project: kf5-qt5 SUSEQt5.11 Date of build: Tue, 22 Jan 2019 08:54:28 + Build duration: 13 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.12 - Build # 5 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.12/5/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Tue, 22 Jan 2019 08:54:29 + Build duration: 11 min and counting JUnit Tests Name:

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.10 - Build # 4 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.10/4/ Project: kf5-qt5 SUSEQt5.10 Date of build: Tue, 22 Jan 2019 08:54:28 + Build duration: 11 min and counting BUILD ARTIFACTS

D18440: [client] Wrap wl_shell_surface_set_{class,title}

This revision was automatically updated to reflect the committed changes. Closed by commit R127:0a2c807ad21e: [client] Wrap wl_shell_surface_set_{class,title} (authored by zzag). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18440?vs=50030=50045 REVISION