ngraham added a comment.
The behavior is better now, thanks. I think it will be sufficient to fix the bug and not generate user complaints about anything! I'll let someone else do the code review. Maybe someone from #frameworks <https://phabricator.kde.org/tag/frameworks/> or #dolphin <https://phabricator.kde.org/tag/dolphin/>? That said, one thing sticks out at me: INLINE COMMENTS > kdiroperatordetailview.cpp:296 > + > +#include "kdiroperatordetailview.moc" This is almost always wrong. Can you explain why you think it's required here? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18380 To: rjvbb, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns
