D18601: Rewrite taglib writer to use property interface

astippich added a comment. In D18601#402905 , @bruns wrote: > I think this becomes better structured when you: > > 1. Create one function per file type, with parameters (Taglib::Filestream, KFM::PropertyMap) > 2. From this function, call a

D18663: KateSpellCheckDialog: Remove action "Spellcheck Selection"

loh.tar created this revision. loh.tar added a reviewer: KTextEditor. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. loh.tar requested review of this revision. REVISION SUMMARY ...and add logic to "Spelling.." and "Spelling (from cursor)"

D18533: Improve the Notfication Bell Icon by using the KAlarm design

trickyricky26 updated this revision to Diff 50703. trickyricky26 added a comment. - Use a less flat gradient with a silver ringer REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18533?vs=50280=50703 BRANCH improve-notification-bell-icon (branched

D14927: KConfig: handle directory symlinks correctly.

dfaure added a comment. ping? REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D14927 To: dfaure, adridg, arichardson Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18533: Improve the Notfication Bell Icon by using the KAlarm design

trickyricky26 edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18533 To: trickyricky26, #vdg Cc: abetts, ngraham, ndavis, djarvie, kde-frameworks-devel, michaelh, bruns

D18663: KateSpellCheckDialog: Remove action "Spellcheck Selection"

loh.tar added a comment. For my taste could be "Spelling (from cursor)" the only offered action (logic). Always to check from the start is rarely useful, but I guess no one like that idea. The current patch should cause no harm, except that someone need to reassign some shortcut or

D18638: Avoid using trimmed method

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. A better name would be "hasOnlySpaces" (with the opposite return value), but OK. REPOSITORY R246 Sonnet BRANCH remove_using_trimmed (branched from master) REVISION DETAIL

D12477: Add unit test to see that :/ files can work

dfaure accepted this revision. This revision is now accepted and ready to land. Herald added a subscriber: kde-frameworks-devel. REPOSITORY R306 KParts REVISION DETAIL https://phabricator.kde.org/D12477 To: svuorela, dfaure, kossebau, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham,

D18603: Implement more tags for taglib writer

astippich added inline comments. INLINE COMMENTS > bruns wrote in taglibwritertest.cpp:276 > You should probably add a warning when `extractorList.size() > 1`, as in this > case the extractor you run would be arbitrary. > > Though, I am currently not aware of cases where one mimetype is

D18603: Implement more tags for taglib writer

astippich updated this revision to Diff 50705. astippich added a comment. - rebase on latest parent revision REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18603?vs=50501=50705 BRANCH enhance_taglibwriter2 REVISION DETAIL

D18089: KLauncher: handle processes exiting without error

dfaure closed this revision. dfaure added a comment. Pushed as https://commits.kde.org/kinit/c29988a97b3ae7abc0d196a1166eb16ee6c3fa95 REPOSITORY R303 KInit REVISION DETAIL https://phabricator.kde.org/D18089 To: ahmadsamir, dfaure Cc: anthonyfieroni, kde-frameworks-devel, michaelh,

D18089: KLauncher: handle processes exiting without error

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Sorry for the delay REPOSITORY R303 KInit BRANCH klauncher-kateSessionManager (branched from master) REVISION DETAIL https://phabricator.kde.org/D18089 To: ahmadsamir, dfaure Cc:

KDE CI: Frameworks » kwindowsystem » kf5-qt5 SUSEQt5.12 - Build # 2 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.12/2/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 02 Feb 2019 10:39:05 + Build duration: 2 min 52 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kwindowsystem » kf5-qt5 FreeBSDQt5.12 - Build # 4 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20FreeBSDQt5.12/4/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 02 Feb 2019 10:39:05 + Build duration: 3 min 14 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kdelibs4support » kf5-qt5 SUSEQt5.12 - Build # 4 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20SUSEQt5.12/4/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 02 Feb 2019 10:39:15 + Build duration: 13 min and counting BUILD ARTIFACTS

D9822: Add benchmarks for KDirWatch

dfaure added a comment. Herald edited subscribers, added: kde-frameworks-devel; removed: Frameworks. Hi Milian, The benchNotifyWatcher() test seems to fail on CI. Can you take a look?

KDE CI: Frameworks » prison » kf5-qt5 AndroidQt5.11 - Build # 5 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/prison/job/kf5-qt5%20AndroidQt5.11/5/ Project: kf5-qt5 AndroidQt5.11 Date of build: Sat, 02 Feb 2019 10:18:06 + Build duration: 2 min 22 sec and counting CONSOLE OUTPUT

D18663: KateSpellCheckDialog: Remove action "Spellcheck Selection"

dhaumann added a comment. In general I am ok eith this. Although it's a tiny bit less transparent to the user. INLINE COMMENTS > spellcheckdialog.cpp:74 > { > -spellcheck(m_view->cursorPosition()); > +if (m_view->selection()) { > +spellcheckSelection(); I don't like the

KDE CI: Frameworks » kwindowsystem » kf5-qt5 SUSEQt5.10 - Build # 3 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.10/3/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 02 Feb 2019 10:39:05 + Build duration: 2 min 58 sec and counting BUILD ARTIFACTS

D18601: Rewrite taglib writer to use property interface

astippich updated this revision to Diff 50704. astippich added a comment. - rewrite for better readability and to avoid heap allocation REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18601?vs=50497=50704 BRANCH rewrite_taglib2 REVISION DETAIL

KDE CI: Frameworks » kdelibs4support » kf5-qt5 FreeBSDQt5.12 - Build # 9 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20FreeBSDQt5.12/9/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 02 Feb 2019 10:39:15 + Build duration: 5 min 37 sec and counting JUnit Tests

D12477: Add unit test to see that :/ files can work

dfaure added a comment. Right, this would fail if the part was not using QFile, indeed. Still, at the level of the KParts frameworks itself it's all fine ;) REPOSITORY R306 KParts REVISION DETAIL https://phabricator.kde.org/D12477 To: svuorela, dfaure, kossebau, #frameworks Cc:

CI for prison: missing dependency

On samedi 2 février 2019 11:20:28 CET CI System wrote: > -- The following REQUIRED packages have not been found: > > * QRencode, The QRencode library, Can this be added to the CI? -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5

KDE CI: Frameworks » kdelibs4support » kf5-qt5 SUSEQt5.10 - Build # 7 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20SUSEQt5.10/7/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 02 Feb 2019 10:39:15 + Build duration: 23 min and counting BUILD ARTIFACTS

D18662: Add and rename some YaST icon symlinks because of Qt bugs

fvogt added a comment. In D18662#403612 , @ndavis wrote: > @fvogt LCP said a Qt bug was the reason that the icons weren't working correctly and that you would know more about it. I never got around to asking you though. Do you know which bug it

D18664: Baloo engine: treat every non-success code as a failure

valeriymalov created this revision. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. valeriymalov requested review of this revision. REVISION SUMMARY Treating only MDB_NOTFOUND as an error leads to use of uninitliazed pointers and handle IDs in

D18664: Baloo engine: treat every non-success code as a failure

valeriymalov added a reviewer: Baloo. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D18664 To: valeriymalov, #baloo Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D18604: Implement support for writing rating information for taglib writer

astippich added inline comments. INLINE COMMENTS > bruns wrote in taglibwritertest.cpp:409 > What are the differences between the various mp3 test cases? It tests all possible ratings, since the commonly used numbers are somewhat arbitrary, and I wanted to make sure writing and extracting

D12477: Add unit test to see that :/ files can work

kossebau added a comment. In D12477#403709 , @dfaure wrote: > Still, at the level of the KParts frameworks itself it's all fine ;) Which "level" do you mean here? This test only works by pure chance given the current implementation

KDE CI: Frameworks » kdesu » kf5-qt5 FreeBSDQt5.12 - Build # 6 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdesu/job/kf5-qt5%20FreeBSDQt5.12/6/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 02 Feb 2019 13:15:55 + Build duration: 12 min and counting JUnit Tests Name: projectroot

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 9 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/9/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 02 Feb 2019 13:16:29 + Build duration: 21 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.12 - Build # 4 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.12/4/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 02 Feb 2019 13:16:29 + Build duration: 1 hr 9 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kdelibs4support » kf5-qt5 SUSEQt5.12 - Build # 5 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20SUSEQt5.12/5/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 02 Feb 2019 13:15:40 + Build duration: 1 hr 20 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kpackage » kf5-qt5 SUSEQt5.12 - Build # 2 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20SUSEQt5.12/2/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 02 Feb 2019 13:19:00 + Build duration: 1 hr 17 min and counting BUILD ARTIFACTS

D18384: Allow creating directory named '~' and throw a warning before creating it.

ngraham added a comment. I'm working on an alternative user interface for this. Stay tuned! REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18384 To: shubham, ngraham Cc: emateli, pino, dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns

D18676: Improve keyboard controls of the checksum widget

cfarrell created this revision. cfarrell added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. cfarrell requested review of this revision. REVISION SUMMARY Previously when using the tab key to navigate the widget, it would select the

KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.12 - Build # 25 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.12/25/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 02 Feb 2019 17:18:06 + Build duration: 5 min 43 sec and counting JUnit Tests Name:

D18676: Improve keyboard controls of the checksum widget

This revision was automatically updated to reflect the committed changes. Closed by commit R241:04082f3c2ce1: Improve keyboard controls of the checksum widget (authored by cfarrell, committed by elvisangelaccio). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

KDE CI: Frameworks » baloo » kf5-qt5 SUSEQt5.12 - Build # 4 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20SUSEQt5.12/4/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 02 Feb 2019 17:19:19 + Build duration: 13 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kservice » kf5-qt5 FreeBSDQt5.12 - Build # 8 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20FreeBSDQt5.12/8/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 02 Feb 2019 17:24:04 + Build duration: 31 min and counting JUnit Tests Name: projectroot

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 22 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/22/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 02 Feb 2019 17:50:08 + Build duration: 30 min and counting JUnit Tests Name: projectroot

KDE CI: Frameworks » kpackage » kf5-qt5 SUSEQt5.12 - Build # 3 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20SUSEQt5.12/3/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 02 Feb 2019 17:23:26 + Build duration: 1 hr 15 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 4 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/4/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 02 Feb 2019 17:25:19 + Build duration: 1 hr 31 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.10 - Build # 7 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.10/7/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 02 Feb 2019 13:15:11 + Build duration: 17 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » baloo » kf5-qt5 SUSEQt5.12 - Build # 3 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20SUSEQt5.12/3/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 02 Feb 2019 13:13:24 + Build duration: 17 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 20 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/20/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 02 Feb 2019 13:17:41 + Build duration: 25 min and counting JUnit Tests Name: projectroot

KDE CI: Frameworks » kpackage » kf5-qt5 SUSEQt5.10 - Build # 5 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20SUSEQt5.10/5/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 02 Feb 2019 13:19:00 + Build duration: 29 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kservice » kf5-qt5 FreeBSDQt5.12 - Build # 7 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20FreeBSDQt5.12/7/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 02 Feb 2019 13:19:52 + Build duration: 29 min and counting JUnit Tests Name: projectroot

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.12 - Build # 7 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.12/7/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 02 Feb 2019 13:22:04 + Build duration: 51 min and counting JUnit Tests Name: projectroot

KDE CI: Frameworks » kwindowsystem » kf5-qt5 SUSEQt5.12 - Build # 3 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.12/3/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 02 Feb 2019 13:20:47 + Build duration: 1 hr 20 min and counting BUILD ARTIFACTS

D18663: KateSpellCheckDialog: Remove action "Spellcheck Selection"

cullmann accepted this revision. This revision is now accepted and ready to land. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D18663 To: loh.tar, #ktexteditor, cullmann Cc: cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh,

D18662: Add and rename some YaST icon symlinks because of Qt bugs

hellcp added a comment. It's not really a workaround, all of those icons are valid when it comes to YaST, however previous batch of YaST icons into Breeze was build on idea that icon `xyz-abc.svg` will fallback to `xyz.svg` inside the same icon theme. In QIcon::fromTheme that is the case

D18516: Fix end of folding region in rules with lookAhead=true

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. I think that lookAhead rules don't publish their length sounds like a sane improvement. All in all, I think the folding still has some general issues in how we handle it.

D17437: SearchBar: Avoid malfunction with very large files

cullmann commandeered this revision. cullmann edited reviewers, added: loh.tar; removed: cullmann. cullmann added a comment. We have cancel now ;=) REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17437 To: cullmann, #ktexteditor, #vdg, loh.tar Cc: cullmann,

D17437: SearchBar: Avoid malfunction with very large files

cullmann abandoned this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17437 To: cullmann, #ktexteditor, #vdg, loh.tar Cc: cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, ngraham, bruns, demsking, sars, dhaumann

D18662: Add and rename some YaST icon symlinks

ndavis edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18662 To: ndavis, #vdg Cc: hellcp, fvogt, ngraham, kde-frameworks-devel, michaelh, bruns

D18563: Don't create directory tree when a new folder has a '/' in the name

ngraham added a comment. I'm working on an alternative user interface for this feature. Stay tuned! REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18563 To: shubham, ngraham, #frameworks, #dolphin, dfaure, elvisangelaccio, pino Cc: andriusr, emateli, cfeck,

D18673: Add symlinks for flatpak

GeeXT created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. GeeXT requested review of this revision. REVISION SUMMARY This patch creates symlinks (for every application I've found on Flathub and for which Breeze icon theme has an icon) to

D18675: Use different "None" item icon in grid view KCMs

GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. GB_2 requested review of this revision. REVISION SUMMARY Changes the icon for the "None" item in grid view KCMs (present in the Splash Screen KCM)

D18384: Allow creating directory named '~' and throw a warning before creating it.

ngraham added a comment. Yes, I think people are correct that these modal dialogs are annoying. I'm working on something to show the errors and warnings inline at the moment when you're typing the file/folder name in the first place. REPOSITORY R241 KIO REVISION DETAIL

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.12 - Build # 10 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.12/10/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 02 Feb 2019 17:20:42 + Build duration: 13 min and counting JUnit Tests Name:

KDE CI: Frameworks » kwindowsystem » kf5-qt5 SUSEQt5.10 - Build # 5 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.10/5/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 02 Feb 2019 17:24:44 + Build duration: 34 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 12 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/12/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 02 Feb 2019 17:25:19 + Build duration: 47 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kwindowsystem » kf5-qt5 SUSEQt5.12 - Build # 4 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.12/4/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 02 Feb 2019 17:24:44 + Build duration: 1 hr 21 min and counting BUILD ARTIFACTS

D18662: Add and rename some YaST icon symlinks

ndavis added a comment. I think I'll just land this. It fixes a bug caused by my misunderstanding of how YaST currently works. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18662 To: ndavis, #vdg Cc: hellcp, fvogt, ngraham, kde-frameworks-devel, michaelh,

D18665: Cleanup taglib writer test

astippich created this revision. astippich added a reviewer: bruns. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY Cleanup taglib writer test and add a warning when they are

D18604: Implement support for writing rating information for taglib writer

astippich added a dependent revision: D18665: Cleanup taglib writer test. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D18604 To: astippich, bruns, mgallien Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D18665: Cleanup taglib writer test

astippich added a dependency: D18604: Implement support for writing rating information for taglib writer. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D18665 To: astippich, bruns Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun,

KDE CI: Frameworks » kdelibs4support » kf5-qt5 FreeBSDQt5.12 - Build # 10 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20FreeBSDQt5.12/10/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 02 Feb 2019 13:15:40 + Build duration: 14 min and counting JUnit Tests Name:

D18533: Improve the Notfication Bell Icon by using the KAlarm design

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. I love it! REPOSITORY R266 Breeze Icons BRANCH improve-notification-bell-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D18533 To: trickyricky26, #vdg,

KDE CI: Frameworks » kconfig » kf5-qt5 FreeBSDQt5.12 - Build # 10 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kconfig/job/kf5-qt5%20FreeBSDQt5.12/10/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 02 Feb 2019 17:20:32 + Build duration: 10 min and counting JUnit Tests Name: projectroot

D18680: Fix ENABLE_CLAZY option with clazy >= 1.5

elvisangelaccio created this revision. elvisangelaccio added reviewers: apol, smartins. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. elvisangelaccio requested review of this revision. REVISION SUMMARY clazy 1.5 renamed its

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 21 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/21/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 02 Feb 2019 17:22:31 + Build duration: 27 min and counting JUnit Tests Name: projectroot

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.12 - Build # 13 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.12/13/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 02 Feb 2019 17:24:32 + Build duration: 40 min and counting JUnit Tests Name:

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.12 - Build # 8 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.12/8/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 02 Feb 2019 17:25:42 + Build duration: 46 min and counting JUnit Tests Name: projectroot

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.12 - Build # 4 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.12/4/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 02 Feb 2019 17:20:42 + Build duration: 1 hr 8 min and counting BUILD ARTIFACTS

D18638: Avoid using trimmed method

This revision was automatically updated to reflect the committed changes. Closed by commit R246:ef9c9253e5b4: Avoid using trimmed method (authored by mlaurent). REPOSITORY R246 Sonnet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18638?vs=50631=50710 REVISION DETAIL

KDE CI: Frameworks » kdelibs4support » kf5-qt5 SUSEQt5.10 - Build # 8 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20SUSEQt5.10/8/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 02 Feb 2019 13:15:40 + Build duration: 20 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.12 - Build # 3 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.12/3/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 02 Feb 2019 13:15:11 + Build duration: 1 hr 4 min and counting BUILD ARTIFACTS

D18663: KateSpellCheckDialog: Remove action "Spellcheck Selection"

cullmann added a comment. ;=) given ::spellcheck() has the same magic, I don't think we really need to rename the function. And spellcheckSelectionOrFromCursor is a bit strange, too. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D18663 To: loh.tar,

KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.12 - Build # 24 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.12/24/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 02 Feb 2019 15:24:41 + Build duration: 4 min 42 sec and counting JUnit Tests Name:

D18676: Improve keyboard controls of the checksum widget

elvisangelaccio accepted this revision. elvisangelaccio added a comment. This revision is now accepted and ready to land. Thanks! REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D18676 To: cfarrell, #vdg, elvisangelaccio Cc: elvisangelaccio,

KDE CI: Frameworks » kdesu » kf5-qt5 FreeBSDQt5.12 - Build # 7 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdesu/job/kf5-qt5%20FreeBSDQt5.12/7/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 02 Feb 2019 17:21:15 + Build duration: 14 min and counting JUnit Tests Name: projectroot

KDE CI: Frameworks » kdelibs4support » kf5-qt5 FreeBSDQt5.12 - Build # 11 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20FreeBSDQt5.12/11/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 02 Feb 2019 17:21:05 + Build duration: 15 min and counting JUnit Tests Name:

KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.12 - Build # 7 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.12/7/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 02 Feb 2019 17:18:06 + Build duration: 18 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.10 - Build # 8 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.10/8/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 02 Feb 2019 17:20:42 + Build duration: 17 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 16 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/16/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 02 Feb 2019 17:25:19 + Build duration: 44 min and counting JUnit Tests Name:

KDE CI: Frameworks » prison » kf5-qt5 AndroidQt5.11 - Build # 6 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/prison/job/kf5-qt5%20AndroidQt5.11/6/ Project: kf5-qt5 AndroidQt5.11 Date of build: Sat, 02 Feb 2019 13:21:40 + Build duration: 1 min 44 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.12 - Build # 9 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.12/9/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 02 Feb 2019 13:15:07 + Build duration: 10 min and counting JUnit Tests Name:

KDE CI: Frameworks » kpty » kf5-qt5 FreeBSDQt5.12 - Build # 5 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpty/job/kf5-qt5%20FreeBSDQt5.12/5/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 02 Feb 2019 13:19:31 + Build duration: 28 min and counting JUnit Tests Name: projectroot

KDE CI: Frameworks » kwindowsystem » kf5-qt5 SUSEQt5.10 - Build # 4 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.10/4/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 02 Feb 2019 13:20:47 + Build duration: 38 min and counting BUILD ARTIFACTS

D18116: Don't show document load trouble twice

cullmann requested changes to this revision. cullmann added a comment. This revision now requires changes to proceed. Just to be sure: We can apply D18117 and don't need to change here anything or? REVISION DETAIL https://phabricator.kde.org/D18116

D18533: Improve the Notfication Bell Icon by using the KAlarm design

This revision was automatically updated to reflect the committed changes. Closed by commit R266:19c936621729: Improve the Notfication Bell Icon by using the KAlarm design (authored by trickyricky26, committed by ngraham). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE

KDE CI: Frameworks » kpackage » kf5-qt5 SUSEQt5.10 - Build # 6 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20SUSEQt5.10/6/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 02 Feb 2019 17:23:26 + Build duration: 28 min and counting BUILD ARTIFACTS

D18680: Fix ENABLE_CLAZY option with clazy >= 1.5

elvisangelaccio added a comment. Note: this will break with older clazy versions. I'm not sure how to prevent that. One could argue that a developer interested in clazy should probably run the latest version anyway... REPOSITORY R240 Extra CMake Modules REVISION DETAIL

KDE CI: Frameworks » kpty » kf5-qt5 FreeBSDQt5.12 - Build # 6 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpty/job/kf5-qt5%20FreeBSDQt5.12/6/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 02 Feb 2019 17:23:48 + Build duration: 30 min and counting JUnit Tests Name: projectroot

KDE CI: Frameworks » kpackage » kf5-qt5 FreeBSDQt5.12 - Build # 7 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20FreeBSDQt5.12/7/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 02 Feb 2019 17:23:26 + Build duration: 27 min and counting JUnit Tests Name: projectroot

D18680: Fix ENABLE_CLAZY option with clazy >= 1.5

anthonyfieroni added inline comments. INLINE COMMENTS > KDECMakeSettings.cmake:296 > if(ENABLE_CLAZY) > -set(CMAKE_CXX_COMPILE_OBJECT "${CMAKE_CXX_COMPILE_OBJECT} -Xclang > -load -Xclang ClangLazy${CMAKE_SHARED_LIBRARY_SUFFIX} -Xclang -add-plugin > -Xclang clang-lazy") > +

D18680: Fix ENABLE_CLAZY option with clazy >= 1.5

arojas added a comment. You also need to change '-Xclang -add-plugin -Xclang clang-lazy' to '-Xclang -add-plugin -Xclang clazy' for the plugin to be actually loaded. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D18680 To: elvisangelaccio, apol,

D18662: Add and rename some YaST icons and symlinks

ndavis retitled this revision from "Add and rename some YaST icon symlinks" to "Add and rename some YaST icons and symlinks". REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18662 To: ndavis, #vdg Cc: hellcp, fvogt, ngraham, kde-frameworks-devel, michaelh, bruns

  1   2   >