D18877: Optimize Baloo::File copy assign operator, fix Baloo::File::load(url)

bruns created this revision. bruns added reviewers: Baloo, Frameworks, ngraham, poboiko. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY There is no need to delete and create a new Private on

D18878: Force NT1 protocol when listing smb:// network

mikhailnov added a comment. Samba developers told that currently other methods of browsong network, than using old SMB1 protocol, are not implemented. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D18878 To: mikhailnov Cc: kde-frameworks-devel, kfm-devel,

D18873: add baloo engine debugging category

bruns requested changes to this revision. bruns added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > baloo.categories:4 > kf5.kio.kio_timeline Baloo Timeline (KIO) DEFAULT_SEVERITY [WARNING] > IDENTIFIER [Baloo::KIO_TIMELINE] > +org.kde.baloo.engine Baloo

D18664: Baloo engine: treat every non-success code as a failure

valeriymalov added inline comments. INLINE COMMENTS > bruns wrote in documentdatadb.cpp:107 > see get Trying to delete a non-existent entry seems like an error to me REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D18664 To: valeriymalov, #baloo, bruns, poboiko Cc:

D18883: Add PDF thumbnailer

broulik created this revision. broulik added reviewers: dfaure, aacid, jtamate. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY This adds a PDF thumbnailer using libpoppler.

Re: [sysadmin/ci-tooling] build-specs/Plasma: Disable execution of tests for plasma-integration.

On Sun, Feb 10, 2019 at 8:35 AM David Faure wrote: > > On samedi 9 février 2019 20:11:53 CET Ben Cooksley wrote: > > On Sat, Feb 9, 2019 at 9:46 PM David Faure wrote: > > > Do you have more details? Which kioslave, from which test program? > > > > Looking more closely it seems that the issue is

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.12 - Build # 8 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.12/8/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 09 Feb 2019 13:08:02 + Build duration: 59 min and counting BUILD ARTIFACTS

D18873: add baloo engine debugging category

mlaurent requested changes to this revision. mlaurent added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > baloo.categories:4 > kf5.kio.kio_timeline Baloo Timeline (KIO) DEFAULT_SEVERITY [WARNING] > IDENTIFIER [Baloo::KIO_TIMELINE] > +org.kde.baloo.engine

D18819: Use content to determine mime type

This revision was automatically updated to reflect the committed changes. Closed by commit R293:7415aa60d9f6: Use content to determine mime type (authored by astippich). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18819?vs=51112=51258 REVISION DETAIL

D18873: add baloo engine debugging category

bruns added a comment. In D18873#408662 , @mlaurent wrote: > DEFAULT_SEVERITY [WARNING] is false too as you don't force it. i.e. add "DEFAULT_SEVERITY Warning" in ecm_qt_declare_logging_category compare with

D18664: Baloo engine: treat every non-success code as a failure

bruns added inline comments. INLINE COMMENTS > documentdatadb.cpp:42 > +if (rc) { > +qCDebug(ENGINE) << "DocumentDataDB::create" << mdb_strerror(rc); > +return 0; Warning > documentdatadb.cpp:54 > +if (rc) { > +qCDebug(ENGINE) << "DocumentDataDB::open" <<

D17932: Improvements to completion

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R39:7c42ba4a1aed: Improvements to completion (authored by thomassc, committed by cullmann). REPOSITORY R39 KTextEditor

D18664: Baloo engine: treat every non-success code as a failure

valeriymalov updated this revision to Diff 51284. valeriymalov marked 4 inline comments as done. valeriymalov added a comment. - fix ::del error logging criteria, don't return without closing cursor in REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE

Re: [sysadmin/ci-tooling] build-specs/Plasma: Disable execution of tests for plasma-integration.

On samedi 9 février 2019 20:11:53 CET Ben Cooksley wrote: > On Sat, Feb 9, 2019 at 9:46 PM David Faure wrote: > > Do you have more details? Which kioslave, from which test program? > > Looking more closely it seems that the issue is only happening on the > stable branch - did your fix land there

KDE CI: Frameworks » knotifications » kf5-qt5 AndroidQt5.11 - Build # 18 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/knotifications/job/kf5-qt5%20AndroidQt5.11/18/ Project: kf5-qt5 AndroidQt5.11 Date of build: Sat, 09 Feb 2019 13:09:46 + Build duration: 2 min 33 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.10 - Build # 9 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.10/9/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 09 Feb 2019 13:06:57 + Build duration: 18 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kdesu » kf5-qt5 FreeBSDQt5.12 - Build # 8 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdesu/job/kf5-qt5%20FreeBSDQt5.12/8/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 09 Feb 2019 13:07:39 + Build duration: 17 min and counting JUnit Tests Name: projectroot

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 13 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/13/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 09 Feb 2019 13:08:02 + Build duration: 17 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kdelibs4support » kf5-qt5 FreeBSDQt5.12 - Build # 13 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20FreeBSDQt5.12/13/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 09 Feb 2019 13:07:25 + Build duration: 18 min and counting JUnit Tests Name:

KDE CI: Frameworks » kpackage » kf5-qt5 FreeBSDQt5.12 - Build # 8 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20FreeBSDQt5.12/8/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 09 Feb 2019 13:09:58 + Build duration: 32 min and counting JUnit Tests Name: projectroot

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.12 - Build # 5 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.12/5/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 09 Feb 2019 13:06:57 + Build duration: 52 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kconfigwidgets » kf5-qt5 SUSEQt5.12 - Build # 5 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kconfigwidgets/job/kf5-qt5%20SUSEQt5.12/5/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 09 Feb 2019 13:06:52 + Build duration: 54 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.12 - Build # 16 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.12/16/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 09 Feb 2019 13:11:08 + Build duration: 50 min and counting JUnit Tests Name:

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 21 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/21/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 09 Feb 2019 13:11:56 + Build duration: 57 min and counting JUnit Tests Name:

D18873: add baloo engine debugging category

mlaurent accepted this revision. mlaurent added a comment. This revision is now accepted and ready to land. Ok so you need to commit this one first and making second patch dependancy against it. REPOSITORY R293 Baloo BRANCH master REVISION DETAIL https://phabricator.kde.org/D18873

D18873: add baloo engine debugging category

mlaurent added a comment. ecm_qt_declare_logging_category(kio_timeline_SRCS HEADER kio_timeline_debug.h IDENTIFIER Baloo::KIO_TIMELINE DEFAULT_SEVERITY Warning

KDE CI: Frameworks » kconfigwidgets » kf5-qt5 FreeBSDQt5.12 - Build # 10 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kconfigwidgets/job/kf5-qt5%20FreeBSDQt5.12/10/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 09 Feb 2019 13:06:52 + Build duration: 8 min 39 sec and counting JUnit Tests

KDE CI: Frameworks » kauth » kf5-qt5 WindowsMSVCQt5.11 - Build # 25 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kauth/job/kf5-qt5%20WindowsMSVCQt5.11/25/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Sat, 09 Feb 2019 13:06:21 + Build duration: 9 min 22 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks » kpty » kf5-qt5 FreeBSDQt5.12 - Build # 7 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpty/job/kf5-qt5%20FreeBSDQt5.12/7/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 09 Feb 2019 13:10:20 + Build duration: 34 min and counting JUnit Tests Name: projectroot

D18664: Baloo engine: treat every non-success code as a failure

bruns added inline comments. INLINE COMMENTS > valeriymalov wrote in documentdatadb.cpp:107 > Trying to delete a non-existent entry seems like an error to me Deleting is an idempotent operation, so e.g. doing it twice is fine. There may be multiple events queued leading to the deletion of a

KDE CI: Frameworks » kwindowsystem » kf5-qt5 FreeBSDQt5.12 - Build # 7 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20FreeBSDQt5.12/7/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 09 Feb 2019 13:11:20 + Build duration: 52 min and counting JUnit Tests Name:

D18664: Baloo engine: treat every non-success code as a failure

valeriymalov added a dependency: D18873: add baloo engine debugging category. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D18664 To: valeriymalov, #baloo, bruns, poboiko Cc: cullmann, ngraham, bruns, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich,

D18873: add baloo engine debugging category

valeriymalov added a dependent revision: D18664: Baloo engine: treat every non-success code as a failure. REPOSITORY R293 Baloo BRANCH master REVISION DETAIL https://phabricator.kde.org/D18873 To: valeriymalov, #baloo, mlaurent Cc: mlaurent, kde-frameworks-devel, ashaposhnikov,

D18878: Force NT1 protocol when listing smb:// network

mikhailnov added a comment. In D18878#408686 , @acrouthamel wrote: > How do dependencies work here? Does this force SMB1 to be installed and enabled in Dolphin now? I ask because many companies have disabled and removed version 1 due to the

D18822: Fix Windows build [hopefully]

kossebau added a comment. Given the autotests reuse the source files from the lib (and thus also using the headers) the export macros confuse windows here. So in autotests/CMakeLists,txt, one needs to extend target_compile_definitions(kauth_tests_static PUBLIC

D18664: Baloo engine: treat every non-success code as a failure

valeriymalov updated this revision to Diff 51282. valeriymalov marked 10 inline comments as done. valeriymalov added a comment. - update logging per review REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18664?vs=51252=51282 BRANCH master REVISION DETAIL

D18369: Create tel: links for phone numbers

svuorela accepted this revision. This revision is now accepted and ready to land. REPOSITORY R244 KCoreAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D18369 To: vkrause, svuorela Cc: apol, aacid, svuorela, nicolasfella, kde-frameworks-devel, michaelh, ngraham, bruns

Re: [sysadmin/ci-tooling] build-specs/Plasma: Disable execution of tests for plasma-integration.

On Sat, Feb 9, 2019 at 9:46 PM David Faure wrote: > > Do you have more details? Which kioslave, from which test program? Looking more closely it seems that the issue is only happening on the stable branch - did your fix land there by any chance? Cheers, Ben

D18873: add baloo engine debugging category

bruns added a comment. Looks good to me. @mlaurent ? REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D18873 To: valeriymalov, #baloo, mlaurent, bruns Cc: bruns, mlaurent, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, abrahams

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.12 - Build # 11 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.12/11/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 09 Feb 2019 13:06:57 + Build duration: 11 min and counting JUnit Tests Name:

KDE CI: Frameworks » kwindowsystem » kf5-qt5 SUSEQt5.10 - Build # 6 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.10/6/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 09 Feb 2019 13:11:20 + Build duration: 37 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 17 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/17/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 09 Feb 2019 13:11:56 + Build duration: 37 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » baloo » kf5-qt5 SUSEQt5.12 - Build # 11 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20SUSEQt5.12/11/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 09 Feb 2019 14:48:34 + Build duration: 3 min 28 sec and counting BUILD ARTIFACTS

D18882: [Image Thumbnailer] Support eps files

broulik created this revision. broulik added reviewers: jtamate, dfaure. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY There's a KImageFormats plugin for EPS files, so we can

D18883: Add PDF thumbnailer

ltoscano added a comment. Why can't this go to kdegraphics-thumbnailer? Kio-extras shouldn't be, IMHO, a "drop everything which does not fit elsewhere" REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D18883 To: broulik, dfaure, aacid, jtamate Cc: ltoscano,

KDE CI: Frameworks » kservice » kf5-qt5 FreeBSDQt5.12 - Build # 9 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20FreeBSDQt5.12/9/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 09 Feb 2019 13:10:38 + Build duration: 36 min and counting JUnit Tests Name: projectroot

D18824: Implement wl_eglstream_controller Server Interface

romangg requested changes to this revision. romangg added a comment. This revision now requires changes to proceed. Impressive. Some small issues to resolve. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D18824 To: ekurzinger, romangg, davidedmundson, zzag, #kwin

D18824: Implement wl_eglstream_controller Server Interface

romangg added inline comments. INLINE COMMENTS > CMakeLists.txt:349 >xdgoutput_interface.h > + eglstream_controller_interface.h > ) alphabetical sorted > display.cpp:529 > +} else { > +qCWarning(KWAYLAND_SERVER) << "Unable to load > libnvidia-egl-wayland.so.1"; > +}

D18731: Replace KIconThemes dependency with equivalent QIcon usage

cfeck accepted this revision. cfeck added a comment. But KDE also supports REPOSITORY R294 KBookmarks BRANCH master REVISION DETAIL https://phabricator.kde.org/D18731 To: vkrause, davidedmundson, cfeck Cc: broulik, cfeck, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.12 - Build # 9 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.12/9/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 09 Feb 2019 13:11:08 + Build duration: 1 hr 13 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kwindowsystem » kf5-qt5 SUSEQt5.12 - Build # 5 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.12/5/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 09 Feb 2019 13:11:20 + Build duration: 1 hr 14 min and counting BUILD ARTIFACTS

D18873: add baloo engine debugging category

mlaurent added a comment. DEFAULT_SEVERITY [WARNING] is false too as you don't force it. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D18873 To: valeriymalov, #baloo, mlaurent, bruns Cc: bruns, mlaurent, kde-frameworks-devel, ashaposhnikov, michaelh, astippich,

D18873: add baloo engine debugging category

mlaurent added a comment. Baloo::ENGINE it's wrong as you generate it as "IDENTIFIER "ENGINE" CATEGORY_NAME "org.kde.baloo.engine")" it's not Baloo::ENGINE but ENGINE so you need to change IDENTIFIER "ENGINE" in ecm_qt_declare_logging_category( REPOSITORY R293 Baloo REVISION DETAIL

D17632: Move/copy job: skip stat'ing sources if the destination dir isn't writable

shubham added a comment. Can someone experienced review this? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17632 To: dfaure, shubham, broulik, bruns, chinmoyr Cc: chinmoyr, kde-frameworks-devel, michaelh, ngraham, bruns

D18822: Fix Windows build [hopefully]

vonreth requested changes to this revision. vonreth added a comment. This revision now requires changes to proceed. Doesn't build yet, we really need pre commit ci Scanning dependencies of target KF5AuthCore_autogen [ 1%] Automatic MOC for target KF5AuthCore [ 1%] Built

D18878: Force NT1 protocol when listing smb:// network

acrouthamel added a comment. How do dependencies work here? Does this force SMB1 to be installed and enabled in Dolphin now? I ask because many companies have disabled and removed version 1 due to the security issues. REPOSITORY R320 KIO Extras REVISION DETAIL

D17245: Add string formatting function to property info

astippich updated this revision to Diff 51271. astippich added a comment. - rebase onto current master - rename header - update docs REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17245?vs=48690=51271 BRANCH display_value REVISION DETAIL

D18610: Introduce KF5AuthCore

rikmills added subscribers: sitter, rikmills. rikmills added a comment. Is this not breaking ABI? even if just moving to another lib? @sitter FYI I get https://paste.ubuntu.com/p/NHsbqg7DbN/ REPOSITORY R283 KAuth REVISION DETAIL https://phabricator.kde.org/D18610 To: aacid, apol

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 26 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/26/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 09 Feb 2019 13:08:55 + Build duration: 29 min and counting JUnit Tests Name: projectroot

D18664: Baloo engine: treat every non-success code as a failure

valeriymalov updated this revision to Diff 51252. valeriymalov added a comment. - move new logging category to D18873: add baloo engine debugging category REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE

D18664: Baloo engine: treat every non-success code as a failure

valeriymalov updated this revision to Diff 51251. valeriymalov marked 3 inline comments as done. valeriymalov added a comment. - clean up rest of the asserts REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18664?vs=50708=51251 BRANCH master REVISION

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.12 - Build # 9 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.12/9/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 09 Feb 2019 13:12:18 + Build duration: 1 hr 0 min and counting JUnit Tests Name:

KDE CI: Frameworks » kpackage » kf5-qt5 SUSEQt5.12 - Build # 4 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20SUSEQt5.12/4/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 09 Feb 2019 13:09:58 + Build duration: 1 hr 3 min and counting BUILD ARTIFACTS

D18873: add baloo engine debugging category

valeriymalov updated this revision to Diff 51261. valeriymalov added a comment. - update categories per review REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18873?vs=51255=51261 BRANCH master REVISION DETAIL https://phabricator.kde.org/D18873

D18883: Add PDF thumbnailer

pino added inline comments. INLINE COMMENTS > pdfcreator.cpp:45-46 > +{ > +Q_UNUSED(width); > +Q_UNUSED(height); > + please honor the requested width and height > pdfcreator.cpp:49 > +QScopedPointer document; > +document.reset(Document::load(QFile::encodeName(path))); > +

D18873: add baloo engine debugging category

valeriymalov created this revision. valeriymalov added a reviewer: Baloo. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. valeriymalov requested review of this revision. REPOSITORY R293 Baloo BRANCH master REVISION DETAIL

KDE CI: Frameworks » baloo » kf5-qt5 SUSEQt5.12 - Build # 10 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20SUSEQt5.12/10/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 09 Feb 2019 13:05:30 + Build duration: 4 min 17 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kpackage » kf5-qt5 SUSEQt5.10 - Build # 7 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20SUSEQt5.10/7/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 09 Feb 2019 13:09:57 + Build duration: 26 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 22 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/22/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 09 Feb 2019 13:08:54 + Build duration: 26 min and counting BUILD ARTIFACTS

D18788: Refactor KateViewInternal::mouseDoubleClickEvent(QMouseEvent *e)

shubham added a comment. Is it okay now? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D18788 To: shubham, cullmann Cc: dhaumann, sars, kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, demsking, cullmann

D18873: add baloo engine debugging category

valeriymalov marked an inline comment as done. valeriymalov added inline comments. INLINE COMMENTS > mlaurent wrote in CMakeLists.txt:31 > which files uses it ? > you generate it but it seems that you don't use it in file no ? I've been asked to split this from D18664: Baloo engine: treat every

D18873: add baloo engine debugging category

valeriymalov updated this revision to Diff 51255. valeriymalov added a comment. - use new syntax for baloo.categories REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18873?vs=51248=51255 BRANCH master REVISION DETAIL https://phabricator.kde.org/D18873

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 9 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/9/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 09 Feb 2019 13:11:56 + Build duration: 1 hr 25 min and counting BUILD ARTIFACTS

D18878: Force NT1 protocol when listing smb:// network

mikhailnov created this revision. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. mikhailnov requested review of this revision. REVISION SUMMARY Samba 4.8 changed default 'client max protocol' from NT1 to SMB3, together with fixes of

D18873: add baloo engine debugging category

valeriymalov updated this revision to Diff 51279. valeriymalov added a comment. is it now how it's supposed to look in the end? not really sure where .category syntax is defined REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18873?vs=51261=51279 BRANCH

D18883: Add PDF thumbnailer

pino added inline comments. INLINE COMMENTS > pdfcreator.cpp:23 > + > +#include > +#include the QFile include is no more needed now > broulik wrote in pdfcreator.cpp:45-46 > I can't. The `renderToImage` can only be told a resolution or part of the > page to render, to render downscaled into

D18882: [Image Thumbnailer] Support eps files

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Cool, this tiny change is certainly much simpler than the whole separate standalone thumbnailer in `kdegraphics-thumbnailers`. REPOSITORY R320 KIO Extras REVISION DETAIL

D18882: [Image Thumbnailer] Support eps files

broulik added a comment. You'll get a thumbnail either way \o/ REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D18882 To: broulik, jtamate, dfaure Cc: ngraham, kde-frameworks-devel, kfm-devel, alexde, feverfew, michaelh, spoorun, navarromorales, firef,

D18883: Add PDF thumbnailer

broulik added inline comments. INLINE COMMENTS > pino wrote in pdfcreator.cpp:45-46 > please honor the requested width and height I can't. The `renderToImage` can only be told a resolution or part of the page to render, to render downscaled into a certain box. The `ThumbnailJob` downscales

D18882: [Image Thumbnailer] Support eps files

ngraham added a comment. But what happens when both of the thumbnailers are installed? REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D18882 To: broulik, jtamate, dfaure Cc: ngraham, kde-frameworks-devel, kfm-devel, alexde, feverfew, michaelh, spoorun,

D18883: Add PDF thumbnailer

ngraham added a comment. Conceptually I think it makes sense to have all the thumbnailers in their own package so it's easy to remove them all if for people who really don't want them. That package (`kdegraphics-thumbnailers`) is shipped by default by at least Kubuntu, openSUSE, Manjaro and

D18883: Add PDF thumbnailer

broulik updated this revision to Diff 51292. broulik added a comment. - Render image at desired size already - Remove unused include REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18883?vs=51290=51292 REVISION DETAIL

D18891: Avoid leaking a QObject in ExternalExtractor

bruns created this revision. bruns added reviewers: Baloo, Frameworks, ngraham, poboiko, astippich. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY Passing a nullptr as a parent is fine, passing

D18883: Add PDF thumbnailer

broulik updated this revision to Diff 51290. broulik added a comment. - Remove mimetypes left from testing - Don't encode filename (missed that there's one other than the `QByteArray` one) REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE

D18882: [Image Thumbnailer] Support eps files

broulik added a comment. > OTOH this will not work if kimageformats is not installed, and the thumbnailer gives no hint about that. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D18882 To: broulik, jtamate, dfaure, ngraham Cc: pino, ngraham,

D18882: [Image Thumbnailer] Support eps files

broulik added a comment. Ah, yeah, it tries and if it fails, it aborts, it doesn't try every thumbnailer that claims to support a format. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D18882 To: broulik, jtamate, dfaure, ngraham Cc: pino, ngraham,

D18788: Refactor KateViewInternal::mouseDoubleClickEvent(QMouseEvent *e)

dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. I think it's ok, although it is arguably whether this improves anything. Still, let's move on. REPOSITORY R39 KTextEditor BRANCH arcpatch-D18788 REVISION DETAIL

D18610: Introduce KF5AuthCore

aacid added a comment. It's only BIC for windows IIRC, the rest of the world is fine, KF5Auth pulls KF5AuthCore so all the symbols are still tehre. i don't really think we care about abi in windows for KAuth which AFAICS doesn't even have a windows backend. REPOSITORY R283 KAuth

D18878: Force NT1 protocol when listing smb:// network

ngraham added reviewers: Dolphin, Frameworks, sitter, broulik. ngraham added a comment. This fixes https://bugs.kde.org/show_bug.cgi?id=390551, so you can add `BUG: 390551` to the Summary section. As far as I've been able to tell, there are two ways to resolve the problem of

D18882: [Image Thumbnailer] Support eps files

pino added a comment. OTOH this will not work if kimageformats is not installed, and the thumbnailer gives no hint about that. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D18882 To: broulik, jtamate, dfaure, ngraham Cc: pino, ngraham, kde-frameworks-devel,

D18878: Force NT1 protocol when listing smb:// network

mikhailnov updated this revision to Diff 51302. mikhailnov added a comment. smbc_setOptionProtocols() does not edit context. smbc_set_context(nullptr) will not change context, but will only return existing one. P.S. qCDebug(KIO_SMB) does not print anything for some reason now...

D18882: [Image Thumbnailer] Support eps files

broulik planned changes to this revision. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D18882 To: broulik, jtamate, dfaure, ngraham Cc: pino, ngraham, kde-frameworks-devel, kfm-devel, alexde, feverfew, michaelh, spoorun, navarromorales, firef, andrebarros, bruns,

D17245: Add string formatting function to property info

bruns accepted this revision. This revision is now accepted and ready to land. REPOSITORY R286 KFileMetaData BRANCH display_value REVISION DETAIL https://phabricator.kde.org/D17245 To: astippich, broulik, bruns, mgallien, #frameworks Cc: ngraham, kde-frameworks-devel, #baloo,

D18882: [Image Thumbnailer] Support eps files

pino added a comment. In D18882#408915 , @broulik wrote: > But that will create additional, potentially defunct entries in Previewer settings? without kio-extras there isn't any previewer available... REPOSITORY R320 KIO Extras

D18882: [Image Thumbnailer] Support eps files

broulik added a comment. But that will create additional, potentially defunct entries in Previewer settings? REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D18882 To: broulik, jtamate, dfaure, ngraham Cc: pino, ngraham, kde-frameworks-devel, kfm-devel, alexde,

D18883: Add PDF thumbnailer

pino added a comment. In D18883#408893 , @ngraham wrote: > Conceptually I think it makes sense to have all the thumbnailers in their own package so it's easy to remove them all if for people who really don't want them. ... resulting in

D18731: Replace KIconThemes dependency with equivalent QIcon usage

vkrause added a comment. Tested Konqueror bookmarks. New bookmarks don't seem to get the favicon set until you explicitly trigger the "Update Favicon" action, afterwards they have it and it remains across restarts. So this seems to work as expected. Regarding the indirect dependencies,

D18369: Create tel: links for phone numbers

vkrause added a comment. ping? REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D18369 To: vkrause Cc: apol, aacid, svuorela, nicolasfella, kde-frameworks-devel, michaelh, ngraham, bruns

Re: [sysadmin/ci-tooling] build-specs/Plasma: Disable execution of tests for plasma-integration.

Do you have more details? Which kioslave, from which test program?