D19074: [breeze-icons] Use new suspend, hibernate and switch user icons in Breeze icon theme

rooty added a comment. In D19074#413824 , @ngraham wrote: > While you're at it, can you also replace `system-switch-user` in the Breeze icon theme with the much better version that's in the Breeze Plasma theme? I'm so sorry, I didn't

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 19 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/19/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sun, 17 Feb 2019 04:32:41 + Build duration: 12 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » baloo » kf5-qt5 SUSEQt5.10 - Build # 24 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20SUSEQt5.10/24/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 16 Feb 2019 23:33:50 + Build duration: 3 min 38 sec and counting BUILD ARTIFACTS

D19074: [breeze-icons] Use new suspend, hibernate and switch user icons in Breeze icon theme

rooty retitled this revision from "[breeze-icons] Implement new suspend hibernate and switch user icons in Breeze icon theme" to "[breeze-icons] Use new suspend, hibernate and switch user icons in Breeze icon theme". REPOSITORY R266 Breeze Icons REVISION DETAIL

KDE CI: Frameworks » kservice » kf5-qt5 FreeBSDQt5.12 - Build # 10 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20FreeBSDQt5.12/10/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sun, 17 Feb 2019 02:44:46 + Build duration: 1 min 50 sec and counting JUnit Tests Name:

D19080: [WIP] Make file overwrite a bit safer

chinmoyr updated this revision to Diff 51876. chinmoyr added a comment. Skip unit test on windows. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19080?vs=51875=51876 BRANCH safe-overwrite REVISION DETAIL https://phabricator.kde.org/D19080 AFFECTED

D18798: [KIO/drag and drop] Fix file and folder drag and drop popup menu transparency

anemeth added a comment. In D18798#407428 , @elvisangelaccio wrote: > Wait, do we need to add this workaround to every popup menu around? What about 3d-party apps? > > Can't we fix the actual bug in Qt/breeze/whatever instead? I

D18798: [KIO/drag and drop] Fix file and folder drag and drop popup menu transparency

ngraham added a comment. The workaround isn't required everywhere, just in a small number of places. This is actually the last place that causes user-facing issues with blur that I'm aware of, and prior patches were accepted by Plasma developers, so it would be a shame not to land this last

D19030: Add 16 px and 22 px versions of the gamepad icon to devices/

rooty added a comment. @hein thoughts? I'm not keen on deleting that icon, God only knows what application might be using it :D REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19030 To: rooty, hein, #vdg Cc: ndavis, ngraham, kde-frameworks-devel, michaelh,

D19074: [breeze-icons] Implement new suspend and hibernate icons in Breeze icon theme

rooty updated this revision to Diff 51888. rooty added a comment. Update system-switch-user with version from system.svgz REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19074?vs=51822=51888 BRANCH new-suspend-hibernate (branched from master)

D19074: [breeze-icons] Implement new suspend hibernate and switch user icons in Breeze icon theme

rooty retitled this revision from "[breeze-icons] Implement new suspend and hibernate icons in Breeze icon theme" to "[breeze-icons] Implement new suspend hibernate and switch user icons in Breeze icon theme". rooty edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION

D19030: Add 16 px and 22 px versions of the gamepad icon to devices/

rooty updated this revision to Diff 51890. rooty added a comment. Use "-gamepad" instead REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19030?vs=51759=51890 BRANCH gamepad-icon-16-22-px (branched from master) REVISION DETAIL

D19087: Add standalone conversion functions for PropertyMap to Json and vice versa

bruns created this revision. bruns added reviewers: Baloo, Frameworks, ngraham, poboiko, astippich. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY Baloo caches property data, and uses Json for

D19088: Use propertymap to store properties in Baloo::Result

bruns created this revision. bruns added reviewers: Baloo, Frameworks, ngraham, poboiko, astippich. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY Storing properties directly in a PropertyMap

D19087: Add standalone conversion functions for PropertyMap to Json and vice versa

bruns added a dependent revision: D19088: Use propertymap to store properties in Baloo::Result. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D19087 To: bruns, #baloo, #frameworks, ngraham, poboiko, astippich Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich,

D19074: [breeze-icons] Implement new suspend and hibernate icons in Breeze icon theme

rooty added a comment. Sure thing... I always did find that weird arrow over the user icon kind of weird REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19074 To: rooty, #vdg, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » baloo » kf5-qt5 FreeBSDQt5.12 - Build # 24 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20FreeBSDQt5.12/24/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 16 Feb 2019 23:33:50 + Build duration: 3 min 25 sec and counting JUnit Tests Name:

KDE CI: Frameworks » baloo » kf5-qt5 SUSEQt5.12 - Build # 17 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20SUSEQt5.12/17/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 16 Feb 2019 23:33:50 + Build duration: 4 min 24 sec and counting BUILD ARTIFACTS

D19074: [breeze-icons] Implement new suspend and hibernate icons in Breeze icon theme

ngraham added a comment. While you're at it, can you also replace `system-switch-user` in the Breeze icon theme with the much better version that's in the Breeze Plasma theme? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19074 To: rooty, #vdg, ngraham Cc:

KDE CI: Frameworks » baloo » kf5-qt5 SUSEQt5.12 - Build # 18 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20SUSEQt5.12/18/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 17 Feb 2019 00:31:30 + Build duration: 3 min 24 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » baloo » kf5-qt5 SUSEQt5.10 - Build # 25 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20SUSEQt5.10/25/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sun, 17 Feb 2019 00:31:30 + Build duration: 3 min 22 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » baloo » kf5-qt5 FreeBSDQt5.12 - Build # 25 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20FreeBSDQt5.12/25/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sun, 17 Feb 2019 00:31:30 + Build duration: 2 min 59 sec and counting JUnit Tests Name:

D19074: [breeze-icons] Use new suspend, hibernate and switch user icons in Breeze icon theme

rooty updated this revision to Diff 51889. rooty added a comment. Use symbolic links instead (icons are already present) REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19074?vs=51888=51889 BRANCH new-suspend-hibernate (branched from master)

D17991: Refactor the way device backends are built and registered

pino updated this revision to Diff 51891. pino added a comment. Rebased on master. REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17991?vs=48745=51891 BRANCH cmake-backends-refactor (branched from master) REVISION DETAIL

D17991: Refactor the way device backends are built and registered

pino updated this revision to Diff 51892. pino added a comment. Hopefully rebase on master. REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17991?vs=51891=51892 BRANCH cmake-backends-refactor (branched from master) REVISION DETAIL

D19065: Cleanup idempotent entries from mimetype mapper table

This revision was automatically updated to reflect the committed changes. Closed by commit R293:3aa11093c8e2: Cleanup idempotent entries from mimetype mapper table (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19065?vs=51811=51884

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 11 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/11/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 17 Feb 2019 04:32:41 + Build duration: 3 min 23 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 23 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/23/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sun, 17 Feb 2019 04:32:41 + Build duration: 4 min 11 sec and counting JUnit Tests

D17991: Refactor the way device backends are built and registered

pino added subscribers: FreeBSD, Windows, Android, Frameworks. Herald removed a subscriber: Frameworks. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D17991 To: pino Cc: #android, #windows, #freebsd, apol, kde-frameworks-devel, michaelh, ngraham, bruns

D18968: Word-wrap KMessageWidget text

cfeck added a comment. Dolphin could simply call KStringHandler::*squeeze(), maybe only on the actual filepath, if squeezing is preferred to wrapping. REPOSITORY R318 Dolphin BRANCH word-wrap-long-kmessagewidget-text (branched from Applications/18.12) REVISION DETAIL

D19030: Add 16 px and 22 px versions of the gamepad icon to devices/

ngraham added a comment. Oh never mind, just ignore me then. Sounds like y'all had everything under control before I started confusing everyone. :) REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19030 To: rooty, hein, #vdg Cc: ndavis, ngraham,

D19080: [WIP] Make file overwrite a bit safer

chinmoyr updated this revision to Diff 51875. chinmoyr marked 4 inline comments as done. chinmoyr added a comment. Removed warning message. Removed arg(). Added test cases. Used QFile::resize(). Replying to a comment: > This test is called Overwrite, and passes the Overwrite

D19001: katetextbuffer: refactor TextBuffer::save() to better separate code paths

dhaumann added a comment. In D19001#413694 , @cullmann wrote: > This looks reasonable, but could we get some Qt/KDE style CamelCase enum values? > > enum SaveResult { > > SAVE_FAILED = 0, > SAVE_NO_PERMS, >

D19065: Cleanup idempotent entries from mimetype mapper table

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH submit REVISION DETAIL https://phabricator.kde.org/D19065 To: bruns, #baloo, #frameworks, ngraham, astippich, poboiko Cc: kde-frameworks-devel, ashaposhnikov, michaelh,

D18968: Word-wrap KMessageWidget text

elvisangelaccio added a comment. @cfeck What if we use a `KSqueezedTextLabel` in `KMessageWidget` instead? That would mostly fix also the '' case without requiring new API in QLabel. REPOSITORY R318 Dolphin BRANCH word-wrap-long-kmessagewidget-text (branched from

D19001: katetextbuffer: refactor TextBuffer::save() to better separate code paths

cullmann requested changes to this revision. cullmann added a comment. This revision now requires changes to proceed. This looks reasonable, but could we get some Qt/KDE style CamelCase enum values? enum SaveResult { SAVE_FAILED = 0, SAVE_NO_PERMS, SAVE_SUCCESS

D18798: [KIO/drag and drop] Fix file and folder drag and drop popup menu transparency

pino added a comment. In D18798#407428 , @elvisangelaccio wrote: > Wait, do we need to add this workaround to every popup menu around? What about 3d-party apps? Definitely not an option. IMHO it makes no nsense to add these lines in

D18997: Add functions returning all definitions for a mimetype or file name

dhaumann added a comment. Ping? REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D18997 To: davschul, vkrause, cullmann Cc: dhaumann, cullmann, kwrite-devel, kde-frameworks-devel, gennad, bmortimer, michaelh, genethomas, ngraham, bruns, demsking, vkrause,

D19081: Use correct KStandardGuiItem "no" icon

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. +1. Of course, Yes/No dialogs themselves should be avoided wherever possible in favor of buttons with more descriptive labels (e.g. "Do the Thing / Cancel").

D19081: Use correct KStandardGuiItem "no" icon

This revision was automatically updated to reflect the committed changes. Closed by commit R236:d5cdd29f9630: Use correct KStandardGuiItem no icon (authored by GB_2). REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19081?vs=51860=51871 REVISION DETAIL

D19030: Add 16 px and 22 px versions of the gamepad icon to devices/

ngraham added a comment. I think the idea was that we only needed `input-games` and `input-games-symbolic`, and not also `input-gaming` and `input-gaming-symbolic`. Right? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19030 To: rooty, hein, #vdg Cc: ndavis,

D19030: Add 16 px and 22 px versions of the gamepad icon to devices/

rooty added a comment. In D19030#413778 , @ngraham wrote: > I think the idea was that we only needed `input-games` and `input-games-symbolic`, and not also `input-gaming` and `input-gaming-symbolic`. Right? There already is a 64 px icon

D19075: Fix FindEGL

tcberner added a comment. In D19075#413462 , @hausmann wrote: > I think that it should be NAMES EGL/egl.h Yeah, then it might actuayll work without redefining the path -- but in both cases we are kind of assuming that all install egl.h

D18947: Bring FindUDev.cmake up to ECM standards

cgiboudeaux added inline comments. INLINE COMMENTS > FindUDev.cmake:10 > +# > +# ``UDev_INCLUDE_DIR`` > +# The libudev include directory. UDev_INCLUDE_DIRS > FindUDev.cmake:13 > +# > +# ``UDev_LIBS`` > +# The libudev libraries. UDev_LIBRARIES REPOSITORY R245 Solid BRANCH

D19075: Fix FindEGL

tcberner updated this revision to Diff 51847. tcberner added a comment. Simply set `NAMES EGL/egl.h` and fixup the header version check. REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19075?vs=51842=51847 BRANCH master REVISION DETAIL

D18952: new find module for Canberra

cgiboudeaux added a comment. In D18952#413454 , @aacid wrote: > Yes, imported targets are the future/present :) > > Canberra::Canberra sounds good to me as target name +1 You may also add a set_package_properties() call. see eg:

D18943: Add Fontconfig find modudle

cgiboudeaux added inline comments. INLINE COMMENTS > FindFontconfig.cmake:56 > +# in the FIND_PATH() and FIND_LIBRARY() calls > +find_package(PkgConfig) > +pkg_check_modules(PC_FONTCONFIG QUIET fontconfig) QUIET here as well > apol wrote in FindFontconfig.cmake:57 > If you use IMPORTED_TARGET

D18915: Fix batchrename changing extension to lower case

elvisangelaccio added inline comments. INLINE COMMENTS > cfoster wrote in batchrenamejob.cpp:62 > Without the fromStdString() I get the following compilation error. > > src/core/batchrenamejob.cpp:64:15: error: 'QString::QString(const char*)' is > private within this context > > QString

D18947: Bring FindUDev.cmake up to ECM standards

vkrause updated this revision to Diff 51848. vkrause added a comment. Fix typos. REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18947?vs=51845=51848 BRANCH arcpatch-D18947 REVISION DETAIL https://phabricator.kde.org/D18947 AFFECTED FILES

D18943: Add Fontconfig find modudle

vkrause updated this revision to Diff 51849. vkrause added a comment. Search for pkgconfig quietly. REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18943?vs=51524=51849 BRANCH arcpatch-D18943 REVISION DETAIL

D18762: Add support for portals in KRun

GeeXT added a comment. Ping? Btw, I couldn't find any usages of setEnableExternalBrowser in BrowserRun or KonqRun but there is an usage after instantiating an object of KonqRun (in KonqMainWindow::openUrl). It's strange that a caller must call the function itself or it will crash...

D18673: Add symlinks for flatpak

GeeXT added a reviewer: Frameworks. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18673 To: GeeXT, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19075: Fix FindEGL

hausmann requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D19075 To: tcberner, #automotive, hausmann, #freebsd Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham,

D19075: Fix FindEGL

hausmann added a comment. Yeah I think find_path should use the same style as the test program (EGL/egl.h). It is the style of inclusion as per the specification. I think that’s better than the ../ approach. REPOSITORY R240 Extra CMake Modules REVISION DETAIL

D19057: Compile our own helper against AuthCore and not Auth

aacid closed this revision. REPOSITORY R283 KAuth REVISION DETAIL https://phabricator.kde.org/D19057 To: aacid, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kconfigwidgets » kf5-qt5 SUSEQt5.12 - Build # 6 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kconfigwidgets/job/kf5-qt5%20SUSEQt5.12/6/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 16 Feb 2019 09:17:38 + Build duration: 1 min 40 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kconfigwidgets » kf5-qt5 FreeBSDQt5.12 - Build # 11 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kconfigwidgets/job/kf5-qt5%20FreeBSDQt5.12/11/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 16 Feb 2019 09:17:38 + Build duration: 51 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kconfigwidgets » kf5-qt5 SUSEQt5.10 - Build # 10 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kconfigwidgets/job/kf5-qt5%20SUSEQt5.10/10/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 16 Feb 2019 09:17:38 + Build duration: 1 min 44 sec and counting BUILD ARTIFACTS

D19060: Use AuthCore instead of Auth

aacid closed this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19060 To: aacid, apol Cc: kwrite-devel, kde-frameworks-devel, gennad, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D19056: Tell people they should mostly be using KF5::AuthCore

aacid updated this revision to Diff 51840. aacid added a comment. Wording improvements suggested by Aleix REPOSITORY R283 KAuth CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19056?vs=51800=51840 BRANCH arcpatch-D19056 (branched from master) REVISION DETAIL

D19054: Port cross-compilation support to KF5_HOST_TOOLING

vkrause added a comment. In D19054#413147 , @ltoscano wrote: > I trust @vkrause that this complicated part works, but I need to ask @habacker too, as he contributed part of the cross-compiling code. > > If anyone else from the #windows

D19075: Fix FindEGL

tcberner updated this revision to Diff 51842. tcberner added a comment. Store the path gathered via pkgconfig in `COMPLETE_EGL_INCLUDE_DIR` and use its parent directory for `EGL_INCLUDE_DIR`. REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE

D18952: new find module for Canberra

aacid added a comment. Yes, imported targets are the future/present :) Canberra::Canberra sounds good to me as target name REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D18952 To: sitter, cgiboudeaux Cc: aacid, apol, kde-frameworks-devel,

D19048: Namespace find_file result

This revision was automatically updated to reflect the committed changes. Closed by commit R283:22b9884a55f0: Namespace find_file result (authored by vkrause). REPOSITORY R283 KAuth CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19048?vs=51784=51843 REVISION DETAIL

D19049: Namespace find_file call

This revision was automatically updated to reflect the committed changes. Closed by commit R244:c9f878d46878: Namespace find_file call (authored by vkrause). REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19049?vs=51785=51844 REVISION DETAIL

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.12 - Build # 14 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.12/14/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 16 Feb 2019 10:18:33 + Build duration: 3 min 25 sec and counting JUnit Tests Name:

D19075: Fix FindEGL

hausmann added a comment. I think that it should be NAMES EGL/egl.h REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D19075 To: tcberner, #automotive, hausmann, #freebsd Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D19059: Use AuthCore instead of Auth

This revision was automatically updated to reflect the committed changes. Closed by commit R241:5b825feacd23: Use AuthCore instead of Auth (authored by aacid). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19059?vs=51804=51831 REVISION DETAIL

D19058: Add a note for KF6 to use the core version of KF5::Auth

This revision was automatically updated to reflect the committed changes. Closed by commit R265:ab95f9bdcf9f: Add a note for KF6 to use the core version of KF5::Auth (authored by aacid). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D19058?vs=51803=51830#toc REPOSITORY R265

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 28 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/28/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 16 Feb 2019 09:18:42 + Build duration: 7 min 7 sec and counting JUnit Tests Name:

D18947: Bring FindUDev.cmake up to ECM standards

aacid added inline comments. INLINE COMMENTS > FindUDev.cmake:75 > +IMPORTED_LOCATION "${UDev_LIBRARIES}" > +INTERFACE_INCLUDE_DIRECTORIES "${UDev_INCLUDE_DIRS}" > +) Do we need a INTERFACE_COMPILER_DEFINITIONS "${UDev_DEFINITIONS}" just in case that udev adds some

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.10 - Build # 12 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.10/12/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 16 Feb 2019 10:18:33 + Build duration: 4 min 30 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.12 - Build # 8 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.12/8/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 16 Feb 2019 10:18:33 + Build duration: 12 min and counting BUILD ARTIFACTS

D18947: Bring FindUDev.cmake up to ECM standards

vkrause updated this revision to Diff 51845. vkrause added a comment. Add IMPORTED_COMPILE_DEFINITIONS property. REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18947?vs=51485=51845 BRANCH arcpatch-D18947 REVISION DETAIL

D18947: Bring FindUDev.cmake up to ECM standards

cgiboudeaux accepted this revision. REPOSITORY R245 Solid BRANCH arcpatch-D18947 REVISION DETAIL https://phabricator.kde.org/D18947 To: vkrause, #build_system, cgiboudeaux, apol Cc: aacid, apol, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.12 - Build # 10 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.12/10/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 16 Feb 2019 12:46:58 + Build duration: 1 min 5 sec and counting JUnit Tests Name:

D18947: Bring FindUDev.cmake up to ECM standards

This revision was automatically updated to reflect the committed changes. Closed by commit R245:7464b55f0638: Bring FindUDev.cmake up to ECM standards (authored by vkrause). REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18947?vs=51848=51853 REVISION DETAIL

D19080: [WIP] Make file overwrite a bit safer

chinmoyr created this revision. chinmoyr added reviewers: dfaure, ngraham. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. chinmoyr requested review of this revision. REVISION SUMMARY The source is copied to a separate ".part" file, then the original

D19080: [WIP] Make file overwrite a bit safer

chinmoyr added a dependent revision: D18904: [FileCopyJob] Clean up after file copy operation is cancelled. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D19080 To: chinmoyr, dfaure, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18904: [FileCopyJob] Clean up after file copy operation is cancelled

chinmoyr added a dependency: D19080: [WIP] Make file overwrite a bit safer. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18904 To: chinmoyr, dfaure, dmitrio Cc: kde-frameworks-devel, ngraham, michaelh, bruns

D19081: Use correct KStandardGuiItem "no" icon

GB_2 edited the test plan for this revision. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D19081 To: GB_2, #plasma, #vdg Cc: #vdg, kde-frameworks-devel, #plasma, michaelh, ngraham, bruns

D19081: Use correct KStandardGuiItem "no" icon

GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. GB_2 requested review of this revision. REVISION SUMMARY Changes the "no" icon to the correct one that is used in other places too. Before:

D19080: [WIP] Make file overwrite a bit safer

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. Thanks for working on this, here's my review. INLINE COMMENTS > jobtest.cpp:1724 > > +void JobTest::safeOverwrite() > +{ This test is called Overwrite, and passes the