D19200: Return sorted definitions for file names and mime types

[Christoph Cullmann]

This revision was automatically updated to reflect the committed changes.
Closed by commit R216:a62af5713549: Return sorted definitions for file names 
and mime types (authored by davschul, committed by cullmann).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19200?vs=52268=52270

REVISION DETAIL
  https://phabricator.kde.org/D19200

AFFECTED FILES
  src/lib/repository.cpp
  src/lib/repository.h

To: davschul, cullmann, vkrause
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, bmortimer, michaelh, 
genethomas, ngraham, bruns, demsking, cullmann, vkrause, sars

D19200: Return sorted definitions for file names and mime types

[Christoph Cullmann]

cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  Ok, this seems to work now here, too ;) Will merge it, thanks again.

REVISION DETAIL
  https://phabricator.kde.org/D19200

To: davschul, cullmann, vkrause
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, bmortimer, michaelh, 
genethomas, ngraham, bruns, demsking, cullmann, vkrause, sars

D19215: Install DefinitionDownloader header

[David Schulz]

davschul created this revision.
davschul added reviewers: cullmann, vkrause.
davschul added a project: Framework: Syntax Highlighting.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
davschul requested review of this revision.

REVISION SUMMARY
  Makes it possible to use the exported definition downloader from an installed
  syntax highlighting engine.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D19215

AFFECTED FILES
  src/lib/CMakeLists.txt

To: davschul, cullmann, vkrause
Cc: kwrite-devel, kde-frameworks-devel, bmortimer, michaelh, genethomas, 
ngraham, bruns, demsking, cullmann, vkrause, sars, dhaumann

D19200: Return sorted definitions for file names and mime types

[David Schulz]

davschul updated this revision to Diff 52268.
davschul added a comment.


  Yeah, I just missed to recheck the sorting logic. Before the change we just 
needed the best match so the partial sort was completely sufficient. Now we 
need a complete sorted vector, so stable sort is the way to go ;)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19200?vs=52207=52268

REVISION DETAIL
  https://phabricator.kde.org/D19200

AFFECTED FILES
  src/lib/repository.cpp
  src/lib/repository.h

To: davschul, cullmann, vkrause
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, bmortimer, michaelh, 
genethomas, ngraham, bruns, demsking, cullmann, vkrause, sars

D19163: Make it possible to show all spaces in the document

[Christoph Cullmann]

cullmann added a comment.


  In D19163#417139 , @apol wrote:
  
  > In D19163#415907 , @cullmann 
wrote:
  >
  > > I like the feature, but for the implementation: Could we alter the config 
to itself hold the enum?
  >
  >
  > We could do that, I just didn't not to break currently existing systems
  
  
  I think it would be nicer to have it directly as enum in the config, 
otherwise in one year, we will be all confused how these two bools interact.
  
  > 
  > 
  >> An other thing: why was the non-printable regex altered?
  > 
  > Was trying things and forgot to remove, it's gone now. Thanks!
  
  No problem ;=)

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19163

To: apol, #kate
Cc: cullmann, ngraham, kwrite-devel, kde-frameworks-devel, michaelh, bruns, 
demsking, sars, dhaumann

D19200: Return sorted definitions for file names and mime types

[Christoph Cullmann]

cullmann added a comment.


  Thanks for taking a look again ;=)
  
  I would propose to just stable_sort the vector, that should always yield the 
same result.
  And I think the sorting is the only issue, the other problem I got did only 
occur with non-QRC syntax files and was introduced by myself ;=)

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D19200

To: davschul, cullmann, vkrause
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, bmortimer, michaelh, 
genethomas, ngraham, bruns, demsking, cullmann, vkrause, sars

D18249: [datamodel] Rework items insert/remove

[Anthony Fieroni]

anthonyfieroni abandoned this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D18249

To: anthonyfieroni, davidedmundson, broulik, ngraham, mart, #plasma
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 29 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/29/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Fri, 22 Feb 2019 04:35:27 +
 Build duration:
38 min and counting
   JUnit Tests
  Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest

KDE CI: Frameworks » khtml » kf5-qt5 SUSEQt5.10 - Build # 11 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/khtml/job/kf5-qt5%20SUSEQt5.10/11/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 22 Feb 2019 04:57:58 +
 Build duration:
5 min 13 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yaml
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report58%
(15/26)9%
(57/610)9%
(57/610)3%
(2383/92576)2%
(2202/143268)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(2/2)100%
(2/2)93%
(50/54)48%
(21/44)src41%
(12/29)41%
(12/29)10%
(893/8676)4%
(695/18399)src.css9%
(2/22)9%
(2/22)0%
(20/7604)0%
(8/11752)src.dom15%
(6/39)15%
(6/39)1%
(36/6304)0%
(14/4726)src.ecma2%
(1/46)2%
(1/46)0%
(3/9275)0%
(0/17928)src.editing29%
(2/7)29%
(2/7)1%
(18/1959)0%
(5/4266)src.html0%
(0/49)0%
(0/49)0%
(0/10863)0%
(0/16027)src.imload11%
(3/28)11%
(3/28)3%
(23/773)2%
(14/619)src.imload.decoders80%
(4/5)80%
(4/5)2%
(13/598)1%
(8/660)src.java0%
(0/12)0%
(0/12)0%
(0/1371)0%
(0/2849)src.kmultipart0%
(0/3)0%
(0/3)0%
(0/298)0%
(0/407)src.misc38%
(10/26)38%
(10/26)23%
(823/3630)14%
(696/4973)src.platform0%
(0/1)0%
(0/1)0%
(0/2)100%
(0/0)src.platform.graphics0%
(0/16)0%
(0/16)0%
(0/517)0%
(0/286)src.platform.graphics.qt0%
(0/7)0%
(0/7)0%
(0/225)0%
(0/178)src.platform.text0%
(0/1)0%
(0/1)0%
(0/7)0%
(0/4)src.rendering5%
(5/93)5%
(5/93)0%
(19/23309)0%
(3/32266)src.svg1%
(1/146)1%
(1/146)7%

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 17 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/17/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Fri, 22 Feb 2019 04:35:28 +
 Build duration:
28 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yaml
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3606/13330)18%
(1818/9850)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(610/1117)29%
(315/1086)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)13%
(299/2253)7%
(96/1458)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1415/3501)28%
(792/2827)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(673/1570)29%
(300/1032)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2013)18%
(310/1713)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1178)0%
(0/1028)tests.dpi0%
(0/2)0%
   

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 34 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/34/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Fri, 22 Feb 2019 04:34:48 +
 Build duration:
28 min and counting
   JUnit Tests
  Name: projectroot Failed: 5 test(s), Passed: 47 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_dropjobtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestFailed: projectroot.autotests.kiowidgets_kurifiltertestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.src.ioslaves.trash.tests.testtrashName: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 25 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/25/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 22 Feb 2019 04:35:28 +
 Build duration:
3 min 38 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yaml
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3608/13330)18%
(1818/9850)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(612/1117)29%
(315/1086)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)13%
(299/2253)7%
(96/1458)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1415/3501)28%
(792/2827)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(673/1570)29%
(300/1032)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2013)18%
(310/1713)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1178)0%
(0/1028)tests.dpi0%
(0/2)0%
 

KDE CI: Frameworks » khtml » kf5-qt5 SUSEQt5.10 - Build # 10 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/khtml/job/kf5-qt5%20SUSEQt5.10/10/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 22 Feb 2019 04:34:38 +
 Build duration:
57 sec and counting
   CONSOLE OUTPUT
  [...truncated 77 lines...][2019-02-22T04:35:25.786Z] Checking out Revision ca820e13e0e711805fe202d554f21de15203fecc (origin/master)[2019-02-22T04:35:25.798Z] Commit message: "Build KDE Itinerary without the KF5 umbrella dependency"[Pipeline] checkout[2019-02-22T04:35:25.938Z] No credentials specified[2019-02-22T04:35:25.939Z] Cloning the remote Git repository[2019-02-22T04:35:25.584Z]  > git config remote.origin.url https://anongit.kde.org/kde-build-metadata # timeout=10[2019-02-22T04:35:25.590Z]  > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10[2019-02-22T04:35:25.613Z]  > git config remote.origin.url https://anongit.kde.org/kde-build-metadata # timeout=10[2019-02-22T04:35:25.617Z] Fetching upstream changes from https://anongit.kde.org/kde-build-metadata[2019-02-22T04:35:25.617Z]  > git fetch --tags --force --progress https://anongit.kde.org/kde-build-metadata +refs/heads/*:refs/remotes/origin/* # timeout=10[2019-02-22T04:35:25.783Z]  > git rev-parse origin/master^{commit} # timeout=10[2019-02-22T04:35:25.787Z]  > git config core.sparsecheckout # timeout=10[2019-02-22T04:35:25.789Z]  > git checkout -f ca820e13e0e711805fe202d554f21de15203fecc # timeout=10[2019-02-22T04:35:26.673Z] Checking out Revision b72bc82e474ab027e2f9e762e2e41f221cd803da (origin/master)[2019-02-22T04:35:26.691Z] Commit message: "GIT_SILENT Upgrade KF5 version to 5.56.0."[Pipeline] checkout[2019-02-22T04:35:26.785Z] No credentials specified[2019-02-22T04:35:26.788Z] Cloning the remote Git repository[2019-02-22T04:35:25.940Z] Cloning repository https://anongit.kde.org/kapidox[2019-02-22T04:35:25.940Z]  > git init /home/jenkins/workspace/Frameworks/khtml/kf5-qt5 SUSEQt5.10/ci-tooling/kapidox # timeout=10[2019-02-22T04:35:25.946Z] Fetching upstream changes from https://anongit.kde.org/kapidox[2019-02-22T04:35:25.946Z]  > git --version # timeout=10[2019-02-22T04:35:25.948Z]  > git fetch --tags --force --progress https://anongit.kde.org/kapidox +refs/heads/*:refs/remotes/origin/* # timeout=10[2019-02-22T04:35:26.492Z]  > git config remote.origin.url https://anongit.kde.org/kapidox # timeout=10[2019-02-22T04:35:26.493Z]  > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10[2019-02-22T04:35:26.497Z]  > git config remote.origin.url https://anongit.kde.org/kapidox # timeout=10[2019-02-22T04:35:26.500Z] Fetching upstream changes from https://anongit.kde.org/kapidox[2019-02-22T04:35:26.500Z]  > git fetch --tags --force --progress https://anongit.kde.org/kapidox +refs/heads/*:refs/remotes/origin/* # timeout=10[2019-02-22T04:35:26.669Z]  > git rev-parse origin/master^{commit} # timeout=10[2019-02-22T04:35:26.674Z]  > git config core.sparsecheckout # timeout=10[2019-02-22T04:35:26.676Z]  > git checkout -f b72bc82e474ab027e2f9e762e2e41f221cd803da # timeout=10[2019-02-22T04:35:26.789Z] Cloning repository https://anongit.kde.org/kde-dev-scripts[2019-02-22T04:35:26.789Z]  > git init /home/jenkins/workspace/Frameworks/khtml/kf5-qt5 SUSEQt5.10/ci-tooling/kde-dev-scripts # timeout=10[2019-02-22T04:35:26.796Z] Fetching upstream changes from https://anongit.kde.org/kde-dev-scripts[2019-02-22T04:35:26.796Z]  > git --version # timeout=10[2019-02-22T04:35:26.798Z]  > git fetch --tags --force --progress https://anongit.kde.org/kde-dev-scripts +refs/heads/*:refs/remotes/origin/* # timeout=10[2019-02-22T04:35:28.663Z] Checking out Revision e05ffc93a57d7bfaa01b479e26a93803e9c4176b (origin/master)[2019-02-22T04:35:28.710Z] Commit message: "Don't die when finding an unknown email"[2019-02-22T04:35:28.387Z]  > git config remote.origin.url https://anongit.kde.org/kde-dev-scripts # timeout=10[2019-02-22T04:35:28.388Z]  > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10[2019-02-22T04:35:28.398Z]  > git config remote.origin.url https://anongit.kde.org/kde-dev-scripts # timeout=10[2019-02-22T04:35:28.402Z] Fetching upstream changes from https://anongit.kde.org/kde-dev-scripts[2019-02-22T04:35:28.402Z]  > git fetch --tags --force --progress https://anongit.kde.org/kde-dev-scripts +refs/heads/*:refs/remotes/origin/* # timeout=10[2019-02-22T04:35:28.658Z]  > git rev-parse origin/master^{commit} # timeout=10[2019-02-22T04:35:28.665Z]  > git config core.sparsecheckout # timeout=10[2019-02-22T04:35:28.669Z]  > git checkout -f e05ffc93a57d7bfaa01b479e26a93803e9c4176b # timeout=10[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Setup Dependencies)[Pipeline] sh[2019-02-22T04:35:29.860Z] + python3 -u ci-tooling/helpers/prepare-dependencies.py --product Frameworks --project khtml --branchGroup kf5-qt5 --environment production --platform SUSEQt5.10 --installTo 

D19163: Make it possible to show all spaces in the document

[Aleix Pol Gonzalez]

apol updated this revision to Diff 52260.
apol added a comment.


  oops

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19163?vs=52084=52260

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19163

AFFECTED FILES
  src/dialogs/katedialogs.cpp
  src/dialogs/textareaappearanceconfigwidget.ui
  src/render/katerenderer.cpp
  src/render/katerenderer.h
  src/utils/kateconfig.cpp
  src/utils/kateconfig.h

To: apol, #kate
Cc: cullmann, ngraham, kwrite-devel, kde-frameworks-devel, michaelh, bruns, 
demsking, sars, dhaumann

D19163: Make it possible to show all spaces in the document

[Aleix Pol Gonzalez]

apol added a comment.


  In D19163#415907 , @cullmann wrote:
  
  > I like the feature, but for the implementation: Could we alter the config 
to itself hold the enum?
  
  
  We could do that, I just didn't not to break currently existing systems
  
  > An other thing: why was the non-printable regex altered?
  
  Was trying things and forgot to remove, it's gone now. Thanks!

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19163

To: apol, #kate
Cc: cullmann, ngraham, kwrite-devel, kde-frameworks-devel, michaelh, bruns, 
demsking, sars, dhaumann

D19200: Return sorted definitions for file names and mime types

[Dominik Haumann]

dhaumann added inline comments.

INLINE COMMENTS

> repository.cpp:83
>  {
> -if (candidates.isEmpty())
> -return Definition();
> -
> -std::partial_sort(candidates.begin(), candidates.begin() + 1, 
> candidates.end(), [](const Definition , const Definition ) {
> +std::partial_sort(definitions.begin(), definitions.begin() + 1, 
> definitions.end(), [](const Definition , const Definition ) {
>  return lhs.priority() > rhs.priority();

Isn't std::stable_sort what we want here?

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D19200

To: davschul, cullmann, vkrause
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, bmortimer, michaelh, 
genethomas, ngraham, bruns, demsking, cullmann, vkrause, sars

D19170: Fix crash while moving files

[Christoph Feck]

cfeck added a comment.


  That a nested event loop of an error dialog caused the crashes makes sense, 
because they were reported for alien drives (NTFS) or transfers with permission 
problems. What actual error dialogs did you get and are they reproducible?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D19170

To: hallas, #frameworks, elvisangelaccio, dfaure
Cc: cfeck, dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns

D19198: BrightScript: Unary and hex numbers, @attribute

[Daniel Levin]

dlevin added a comment.


  Thanks for cleaning up the tests after me!

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D19198

To: dlevin, cullmann
Cc: kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, demsking, 
cullmann, sars, dhaumann

D19170: Fix crash while moving files

[David Hallas]

hallas edited the summary of this revision.
hallas edited the test plan for this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D19170

To: hallas, #frameworks, elvisangelaccio, dfaure
Cc: dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns

D19170: Fix crash while moving files

[David Hallas]

hallas updated this revision to Diff 52240.
hallas added a comment.


  Implement a proper fix

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19170?vs=52108=52240

BRANCH
  fix_crash_while_moving_files (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19170

AFFECTED FILES
  src/core/copyjob.cpp

To: hallas, #frameworks, elvisangelaccio, dfaure
Cc: dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns

D19170: Fix crash while moving files

[David Hallas]

hallas added a comment.


  I think I have finally found the root cause of this. The following events 
occurs:
  
  1. A FileCopyJob is created and added as a SubJob to CopyJob
  2. CopyJob::slotResult is notified
  3. CopyJobPrivate::slotResultCopyingFiles is called because it is in state 
STATE_COPYING_FILES
  4. CopyJobPrivate::slotResultErrorCopyingFiles is called bcause the 
FileCopyJob is reporting an error
  5. uiDelegateExtension()->askSkip is called to ask the user how to handle the 
error
  6. The askSkip function starts a modal QDialog and calls exec, this means a 
new QEventLoop is started and runs.
  7. Before the askSkip function returns, CopyJob::slotResult is notified again 
because a new error occurs on the same FileCopyJob
  8. CopyJobPrivate::slotResultCopyingFiles is called because it is in state 
STATE_COPYING_FILES
  9. CopyJobPrivate::slotResultErrorCopyingFiles is called bcause the 
FileCopyJob is reporting an error
  10. uiDelegateExtension()->askSkip is called to ask the user how to handle 
the error
  11. The user responds and the job is cancelled
  12. Finally the initial call to askSkip returns but we are now in an 
inconsistent state because the job that was notified has been deleted
  
  So to avoid getting notifications for the same Job while waiting for user 
feedback I have tried to simply call removeSubJob prior to calling askSkip, 
since that function disconnects from the result signal. Also removeSubJob will 
anyway be call after the user has responded. This also means that the problem 
is in KIO::CopyJob and not i KJob.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D19170

To: hallas, #frameworks, elvisangelaccio, dfaure
Cc: dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 33 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/33/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Thu, 21 Feb 2019 20:16:35 +
 Build duration:
6 min 46 sec and counting
   JUnit Tests
  Name: projectroot Failed: 5 test(s), Passed: 47 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_dropjobtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestFailed: projectroot.autotests.kiowidgets_kurifiltertestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.src.ioslaves.trash.tests.testtrashName: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D18762: Add support for portals in KRun

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:c063b1ce8489: Add support for portals in KRun (authored 
by GeeXT, committed by ngraham).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18762?vs=52163=52239

REVISION DETAIL
  https://phabricator.kde.org/D18762

AFFECTED FILES
  src/widgets/krun.cpp
  src/widgets/krun_p.h

To: GeeXT, jgrulich, apol, dfaure, #frameworks
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D18762: Add support for portals in KRun

[Nathaniel Graham]

ngraham added a comment.


  No problem, I'll take care of this for you!

REPOSITORY
  R241 KIO

BRANCH
  flatpak_open_url (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18762

To: GeeXT, jgrulich, apol, dfaure, #frameworks
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D18762: Add support for portals in KRun

[Denis Karpovskii]

GeeXT added a comment.


  @apol I didn't applied for KDE Developer Account yet (I'm new here) so I 
can't, sorry.

REPOSITORY
  R241 KIO

BRANCH
  flatpak_open_url (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18762

To: GeeXT, jgrulich, apol, dfaure, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18853: Fix sharing files with spaces or quotes in names via Telegram

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R495:b45535ee6e91: Fix sharing files with spaces or quotes in 
names via Telegram (authored by mikhailru, committed by apol).

REPOSITORY
  R495 Purpose Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18853?vs=52123=52237

REVISION DETAIL
  https://phabricator.kde.org/D18853

AFFECTED FILES
  src/plugins/telegram/telegramplugin.cpp

To: mikhailru, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18853: Fix sharing files with spaces or quotes in names via Telegram

[Aleix Pol Gonzalez]

apol added a comment.


  Cool! :D welcome to KDE!

REPOSITORY
  R495 Purpose Library

BRANCH
  telegram-sharing-fix (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18853

To: mikhailru, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18762: Add support for portals in KRun

[Aleix Pol Gonzalez]

apol added a comment.


  Thanks!
  Can you land the patch or should we do it for you?

REPOSITORY
  R241 KIO

BRANCH
  flatpak_open_url (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18762

To: GeeXT, jgrulich, apol, dfaure, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18664: Baloo engine: treat every non-success code as a failure

[Stefan Brüns]

bruns added a comment.


  I think this looks good now, but I would prefer an OK from another developer, 
as this has become quite large.
  
  Readability good profit from `if (rc)` -> `if (rc != MDB_SUCCESS)` resp. `if 
(rc == 0)` -> `if (rc == MDB_SUCCESS)`, but I am not sure about this.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D18664

To: valeriymalov, #baloo, bruns, poboiko
Cc: cullmann, ngraham, bruns, kde-frameworks-devel, #baloo, ashaposhnikov, 
michaelh, astippich, spoorun, abrahams

D19156: port to findcanberra from ECM

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R289 KNotifications

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19156

To: sitter, broulik, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19097: Add a test and document PropertyMap/VariantMap conversion

[Stefan Brüns]

bruns added a comment.


  These two conversion functions should just be deprecated, as they are not 
expecially useful.
  
  `toPropertyMap` is only used (an no longer will be after D19088 
) inside baloo as a temporary for the Json 
conversion, and `toVariantMap` is completely unused.

INLINE COMMENTS

> properties.h:367
> + * PropertyMap is a map which stores the results as
> + *  pairs
> + * obtained from the extractors.

This is wrong. **How** it is stored is internal to the map implementation, but
in general keys and values are stored independently.

The typedef itself documents everything there is to know.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D19097

To: astippich, bruns, ngraham
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D19098: Add PropertyMap to QVariantMap conversion function using names

[Stefan Brüns]

bruns added a comment.


  In D19098#415713 , @astippich 
wrote:
  
  > In D19098#414973 , @bruns wrote:
  >
  > > In D19098#414729 , @astippich 
wrote:
  > >
  > > > It already does at two different places, because it fuses different 
information into a single QMap later on (xattr, file size etc...) 
  > > >  
https://phabricator.kde.org/source/baloo-widgets/browse/master/src/extractor.cpp$65
  > > >  
https://phabricator.kde.org/source/baloo-widgets/browse/master/src/filefetchjob.cpp$62
  > >
  > >
  > > This can be done by using a KFM::PropertyMap directly, and adding 
property types for the UserMetaData (tags, comment, rating). Note, the strings 
returned by PropertyInfo::name() are not shared ...
  >
  >
  > It is not only xattr, also everything from kfileitems{group,size,owner...}. 
Adding these as property with no users in KFileMetaData does not seem clean.
  >  Also, you would have to construct the properties from the name. Why not 
use the names directly then? Changing everything to a PropertyMap requires a 
rewrite of large parts, and I certainly will not rewrite baloo-widgets right 
now.
  >  This is just for a small cleanup.
  
  
  It is also not clean to expose an interface in KFileMetaData which is only 
used by baloo-widgets, and **internal** to baloo-widgets. If you want to 
consolidate the implementations, combine the two implementations **inside** 
baloo-widgets.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D19098

To: astippich, bruns, ngraham
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D18664: Baloo engine: treat every non-success code as a failure

[Valeriy Malov]

valeriymalov updated this revision to Diff 52229.
valeriymalov added a comment.


  - fix MTimeDB::get loop

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18664?vs=52216=52229

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18664

AFFECTED FILES
  src/engine/CMakeLists.txt
  src/engine/database.cpp
  src/engine/documentdatadb.cpp
  src/engine/documentdb.cpp
  src/engine/documentiddb.cpp
  src/engine/documenttimedb.cpp
  src/engine/documenturldb.cpp
  src/engine/documenturldb.h
  src/engine/fsutils.cpp
  src/engine/idfilenamedb.cpp
  src/engine/idtreedb.cpp
  src/engine/mtimedb.cpp
  src/engine/phraseanditerator.cpp
  src/engine/positiondb.cpp
  src/engine/postingdb.cpp
  src/engine/transaction.cpp
  src/engine/transaction.h
  src/file/extractorprocess.cpp
  src/file/fileindexscheduler.cpp
  src/file/indexcleaner.cpp
  src/file/main.cpp
  src/file/metadatamover.cpp

To: valeriymalov, #baloo, bruns, poboiko
Cc: cullmann, ngraham, bruns, kde-frameworks-devel, #baloo, ashaposhnikov, 
michaelh, astippich, spoorun, abrahams

D18664: Baloo engine: treat every non-success code as a failure

[Stefan Brüns]

bruns requested changes to this revision.
bruns added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> bruns wrote in mtimedb.cpp:110
> `if  (rc != MDB_NOTFOUND)` for the message

**for the message** - you now only retrieve the first entry, spew an error 
message, and break. In case the key does not exist, you loop infinitely.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D18664

To: valeriymalov, #baloo, bruns, poboiko
Cc: cullmann, ngraham, bruns, kde-frameworks-devel, #baloo, ashaposhnikov, 
michaelh, astippich, spoorun, abrahams

KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.12 - Build # 8 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.12/8/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 21 Feb 2019 16:59:59 +
 Build duration:
3 min 2 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yaml
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report22%
(5/23)26%
(14/53)26%
(14/53)20%
(454/2220)18%
(199/1126)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(2/2)100%
(2/2)97%
(150/155)58%
(61/106)src100%
(8/8)100%
(8/8)67%
(220/327)50%
(104/210)src.externalprocess0%
(0/2)0%
(0/2)0%
(0/137)0%
(0/98)src.fileitemactionplugin0%
(0/1)0%
(0/1)0%
(0/24)0%
(0/16)src.plugins.bluetooth0%
(0/1)0%
(0/1)0%
(0/33)0%
(0/14)src.plugins.email0%
(0/1)0%
(0/1)0%
(0/63)0%
(0/24)src.plugins.imgur0%
(0/2)0%
(0/2)0%
(0/184)0%
(0/69)src.plugins.kdeconnect0%
(0/1)0%
(0/1)0%
(0/31)0%
(0/12)src.plugins.ktp-sendfile0%
(0/1)0%
(0/1)0%
(0/28)0%
(0/12)src.plugins.nextcloud0%
(0/3)0%
(0/3)0%
(0/79)0%
(0/34)src.plugins.pastebin0%
(0/1)0%
(0/1)0%
(0/54)0%
(0/29)src.plugins.phabricator0%
(0/3)0%
(0/3)0%
(0/220)0%
(0/82)src.plugins.phabricator.quick0%
(0/5)0%
(0/5)0%
(0/93)0%
(0/48)src.plugins.phabricator.tests0%
(0/1)0%
(0/1)0%
(0/59)0%
(0/28)src.plugins.reviewboard0%
(0/3)0%
(0/3)0%
(0/229)0%
(0/76)src.plugins.reviewboard.quick0%
(0/7)0%
(0/7)0%
(0/152)0%
(0/92)src.plugins.saveas100%
(1/1)100%
(1/1)57%
(29/51)64%
(28/44)src.plugins.telegram0%
(0/1)0%
   

D19111: Have ShareFileItemAction provide an output or an error if they are provided

[Aleix Pol Gonzalez]

apol closed this revision.
apol added a comment.


  Landed, don't know why this didn't update.

REPOSITORY
  R495 Purpose Library

REVISION DETAIL
  https://phabricator.kde.org/D19111

To: apol, #dolphin, #frameworks, nicolasfella
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D19111: Have ShareFileItemAction provide an output or an error if they are provided

[Aleix Pol Gonzalez]

apol added a comment.


  https://commits.kde.org/purpose/a6d93ff28f090dd0086301884a31e0eea0efd845

REPOSITORY
  R495 Purpose Library

REVISION DETAIL
  https://phabricator.kde.org/D19111

To: apol, #dolphin, #frameworks, nicolasfella
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D19111: Have ShareFileItemAction provide an output or an error if they are provided

[Nicolas Fella]

nicolasfella accepted this revision.
nicolasfella added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> CMakeLists.txt:3
> +find_package(KF5Notifications COMPONENTS)
> +if (NOT KF5KIO_FOUND OR NOT KF5Notifications_FOUND)
> +return()

Maybe move the check to the parent CMakeLists.txt and include 
fileitemactionplugin conditionally?

REPOSITORY
  R495 Purpose Library

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19111

To: apol, #dolphin, #frameworks, nicolasfella
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D18873: add baloo engine debugging category

[Valeriy Malov]

This revision was automatically updated to reflect the committed changes.
Closed by commit R293:f5f1ae889fe9: add baloo engine debugging category 
(authored by valeriymalov).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18873?vs=51279=52220

REVISION DETAIL
  https://phabricator.kde.org/D18873

AFFECTED FILES
  baloo.categories
  src/engine/CMakeLists.txt

To: valeriymalov, #baloo, mlaurent, bruns
Cc: bruns, mlaurent, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, abrahams

D19111: Have ShareFileItemAction provide an output or an error if they are provided

[Aleix Pol Gonzalez]

apol updated this revision to Diff 52218.
apol added a comment.


  Remove unrelated debug info

REPOSITORY
  R495 Purpose Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19111?vs=51940=52218

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19111

AFFECTED FILES
  src/fileitemactionplugin/CMakeLists.txt
  src/fileitemactionplugin/sharefileitemaction.cpp
  src/widgets/menu.h

To: apol, #dolphin, #frameworks, nicolasfella
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D18664: Baloo engine: treat every non-success code as a failure

[Valeriy Malov]

valeriymalov updated this revision to Diff 52216.
valeriymalov marked 4 inline comments as done.
valeriymalov added a comment.


  - review warning fixes

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18664?vs=51284=52216

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18664

AFFECTED FILES
  src/engine/CMakeLists.txt
  src/engine/database.cpp
  src/engine/documentdatadb.cpp
  src/engine/documentdb.cpp
  src/engine/documentiddb.cpp
  src/engine/documenttimedb.cpp
  src/engine/documenturldb.cpp
  src/engine/documenturldb.h
  src/engine/fsutils.cpp
  src/engine/idfilenamedb.cpp
  src/engine/idtreedb.cpp
  src/engine/mtimedb.cpp
  src/engine/phraseanditerator.cpp
  src/engine/positiondb.cpp
  src/engine/postingdb.cpp
  src/engine/transaction.cpp
  src/engine/transaction.h
  src/file/extractorprocess.cpp
  src/file/fileindexscheduler.cpp
  src/file/indexcleaner.cpp
  src/file/main.cpp
  src/file/metadatamover.cpp

To: valeriymalov, #baloo, bruns, poboiko
Cc: cullmann, ngraham, bruns, kde-frameworks-devel, #baloo, ashaposhnikov, 
michaelh, astippich, spoorun, abrahams

KDE CI: Frameworks » baloo » kf5-qt5 SUSEQt5.12 - Build # 20 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20SUSEQt5.12/20/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 21 Feb 2019 16:24:04 +
 Build duration:
3 min 41 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yaml
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 test(s)Name: projectroot.autotests.unit Failed: 2 test(s), Passed: 31 test(s), Skipped: 0 test(s), Total: 33 test(s)Failed: projectroot.autotests.unit.file.filewatchtestFailed: projectroot.autotests.unit.file.kinotifytest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report43%
(10/23)60%
(100/168)60%
(100/168)57%
(5383/9501)41%
(2126/5238)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.benchmarks100%
(2/2)100%
(2/2)100%
(58/58)100%
(22/22)autotests.integration100%
(3/3)100%
(3/3)92%
(373/406)76%
(168/220)autotests.unit.codecs100%
(3/3)100%
(3/3)100%
(70/70)64%
(23/36)autotests.unit.engine100%
(17/17)100%
(17/17)100%
(752/752)55%
(212/382)autotests.unit.file91%
(10/11)91%
(10/11)88%
(794/905)48%
(256/530)autotests.unit.lib67%
(4/6)67%
(4/6)87%
(358/411)43%
(80/184)src.codecs100%
(5/5)100%
(5/5)89%
(130/146)76%
(35/46)src.engine95%
(35/37)95%
(35/37)81%
(1732/2146)60%
(688/1151)src.file39%
(15/38)39%
(15/38)39%
(652/1666)37%
(387/1058)src.file.extractor0%
(0/6)0%
(0/6)0%
(0/182)0%
(0/76)src.kioslaves.kded0%
(0/1)0%
(0/1)0%
(0/38)0%
(0/42)src.kioslaves.search0%
(0/1)0%
(0/1)0%
(0/105)0%
(0/32)src.kioslaves.tags0%
(0/1)0%
(0/1)0%
(0/273)0%
(0/223)src.kioslaves.timeline0%
(0/2)0%
(0/2)0%
(0/211)0%
(0/119)src.lib55%
(6/11)55%
(6/11)49%
(464/945)45%
(255/573)src.qml0%
(0/2)0%
(0/2)0%
(0/69)0%
(0/20)src.qml.experimental0%

KDE CI: Frameworks » baloo » kf5-qt5 SUSEQt5.10 - Build # 27 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20SUSEQt5.10/27/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Thu, 21 Feb 2019 16:24:04 +
 Build duration:
3 min 53 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yaml
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 test(s)Name: projectroot.autotests.unit Failed: 1 test(s), Passed: 32 test(s), Skipped: 0 test(s), Total: 33 test(s)Failed: projectroot.autotests.unit.file.filewatchtest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report43%
(10/23)60%
(100/168)60%
(100/168)57%
(5405/9501)41%
(2141/5238)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.benchmarks100%
(2/2)100%
(2/2)100%
(58/58)100%
(22/22)autotests.integration100%
(3/3)100%
(3/3)92%
(373/406)76%
(168/220)autotests.unit.codecs100%
(3/3)100%
(3/3)100%
(70/70)64%
(23/36)autotests.unit.engine100%
(17/17)100%
(17/17)100%
(752/752)55%
(212/382)autotests.unit.file91%
(10/11)91%
(10/11)90%
(816/905)51%
(270/530)autotests.unit.lib67%
(4/6)67%
(4/6)87%
(358/411)43%
(80/184)src.codecs100%
(5/5)100%
(5/5)89%
(130/146)76%
(35/46)src.engine95%
(35/37)95%
(35/37)81%
(1732/2146)60%
(688/1151)src.file39%
(15/38)39%
(15/38)39%
(652/1666)37%
(388/1058)src.file.extractor0%
(0/6)0%
(0/6)0%
(0/182)0%
(0/76)src.kioslaves.kded0%
(0/1)0%
(0/1)0%
(0/38)0%
(0/42)src.kioslaves.search0%
(0/1)0%
(0/1)0%
(0/105)0%
(0/32)src.kioslaves.tags0%
(0/1)0%
(0/1)0%
(0/273)0%
(0/223)src.kioslaves.timeline0%
(0/2)0%
(0/2)0%
(0/211)0%
(0/119)src.lib55%
(6/11)55%
(6/11)49%
(464/945)45%
(255/573)src.qml0%
(0/2)0%
(0/2)0%
(0/69)0%
(0/20)src.qml.experimental0%
(0/3)0%

D18664: Baloo engine: treat every non-success code as a failure

[Valeriy Malov]

valeriymalov edited the summary of this revision.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D18664

To: valeriymalov, #baloo, bruns, poboiko
Cc: cullmann, ngraham, bruns, kde-frameworks-devel, #baloo, ashaposhnikov, 
michaelh, astippich, spoorun, abrahams

D19200: Return sorted definitions for file names and mime types

[David Schulz]

davschul added a comment.


  Ah sorry completely missed that part. Unfortunately I'm out of office 
already, I'll take a look as soon as I'm back tomorrow.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D19200

To: davschul, cullmann, vkrause
Cc: kwrite-devel, kde-frameworks-devel, bmortimer, michaelh, genethomas, 
ngraham, bruns, demsking, cullmann, vkrause, sars, dhaumann

D19202: Skip base64 encoding of QDataStream, avoid temporary QByteArray

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Frameworks, Baloo, astippich, ngraham.
Herald added a project: Baloo.
bruns requested review of this revision.

REVISION SUMMARY
  There is no need to do any Base64 encoding of the data. Also avoid
  streaming the data to an intermediate QByteArray, but directly stream
  to stdout.

TEST PLAN
  PATH=`pwd`/bin/:$PATH  ctest

REPOSITORY
  R824 Baloo Widgets

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19202

AFFECTED FILES
  autotests/extractortest.cpp
  src/extractor.cpp
  src/indexeddataretriever.cpp

To: bruns, #frameworks, #baloo, astippich, ngraham
Cc: ashaposhnikov, astippich, spoorun, abrahams

D19200: Return sorted definitions for file names and mime types

[Christoph Cullmann]

cullmann added a comment.


  I think the + 1 is the only real issue, the other issue stems from my local 
setting that I have no compiled in QRC.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D19200

To: davschul, cullmann, vkrause
Cc: kwrite-devel, kde-frameworks-devel, bmortimer, michaelh, genethomas, 
ngraham, bruns, demsking, cullmann, vkrause, sars, dhaumann

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 WindowsMSVCQt5.11 - Build # 135 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20WindowsMSVCQt5.11/135/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Thu, 21 Feb 2019 14:27:24 +
 Build duration:
4 min 30 sec and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)

D19200: Return sorted definitions for file names and mime types

[Christoph Cullmann]

cullmann added a comment.


  I think one error is the sort of the empty vector with the begin() + 1
  But even then, make test fails, after fixing this.
  Please take a look and run the tests.
  Thanks

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D19200

To: davschul, cullmann, vkrause
Cc: kwrite-devel, kde-frameworks-devel, bmortimer, michaelh, genethomas, 
ngraham, bruns, demsking, cullmann, vkrause, sars, dhaumann

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 FreeBSDQt5.12 - Build # 40 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20FreeBSDQt5.12/40/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Thu, 21 Feb 2019 14:16:34 +
 Build duration:
4 min 24 sec and counting
   JUnit Tests
  Name: projectroot Failed: 4 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 6 test(s)Failed: projectroot.autotests.folding_testFailed: projectroot.autotests.htmlhighlighter_testFailed: projectroot.autotests.syntaxrepository_testFailed: projectroot.autotests.testhighlighter_test

D19200: Return sorted definitions for file names and mime types

[Christoph Cullmann]

cullmann added a comment.


  Actually, do we need a partial sort? Should we not just stable_sort the 
complete vector by prio? That should keep stuff with same prio untouched, or?

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D19200

To: davschul, cullmann, vkrause
Cc: kwrite-devel, kde-frameworks-devel, bmortimer, michaelh, genethomas, 
ngraham, bruns, demsking, cullmann, vkrause, sars, dhaumann

D18997: Add functions returning all definitions for a mimetype or file name

[Christoph Cullmann]

cullmann closed this revision.
cullmann added a comment.


  Ok ;=)

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D18997

To: davschul, vkrause, cullmann
Cc: dhaumann, cullmann, kwrite-devel, kde-frameworks-devel, bmortimer, 
michaelh, genethomas, ngraham, bruns, demsking, vkrause, sars

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 FreeBSDQt5.12 - Build # 41 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20FreeBSDQt5.12/41/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Thu, 21 Feb 2019 14:27:24 +
 Build duration:
1 min 39 sec and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)

D19200: Return sorted definitions for file names and mime types

[Christoph Cullmann]

cullmann requested changes to this revision.
This revision now requires changes to proceed.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D19200

To: davschul, cullmann, vkrause
Cc: kwrite-devel, kde-frameworks-devel, bmortimer, michaelh, genethomas, 
ngraham, bruns, demsking, cullmann, vkrause, sars, dhaumann

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 WindowsMSVCQt5.11 - Build # 134 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20WindowsMSVCQt5.11/134/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Thu, 21 Feb 2019 14:16:34 +
 Build duration:
5 min 33 sec and counting
   JUnit Tests
  Name: projectroot Failed: 4 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 6 test(s)Failed: projectroot.autotests.folding_testFailed: projectroot.autotests.htmlhighlighter_testFailed: projectroot.autotests.syntaxrepository_testFailed: projectroot.autotests.testhighlighter_test

D19200: Return sorted definitions for file names and mime types

[Christoph Cullmann]

cullmann added a comment.


  The partial sort is bad ;=()

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D19200

To: davschul, cullmann, vkrause
Cc: kwrite-devel, kde-frameworks-devel, bmortimer, michaelh, genethomas, 
ngraham, bruns, demsking, cullmann, vkrause, sars, dhaumann

D19200: Return sorted definitions for file names and mime types

[Christoph Cullmann]

cullmann reopened this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  Beside that this fails ;=)

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D19200

To: davschul, cullmann, vkrause
Cc: kwrite-devel, kde-frameworks-devel, bmortimer, michaelh, genethomas, 
ngraham, bruns, demsking, cullmann, vkrause, sars, dhaumann

D19200: Return sorted definitions for file names and mime types

[Christoph Cullmann]

cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  Yes, this is nice, nice trick with value(0) to avoid adding an element to the 
vector but just letting the API default construct it.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D19200

To: davschul, cullmann, vkrause
Cc: kwrite-devel, kde-frameworks-devel, bmortimer, michaelh, genethomas, 
ngraham, bruns, demsking, cullmann, vkrause, sars, dhaumann

D19200: Return sorted definitions for file names and mime types

[Christoph Cullmann]

This revision was automatically updated to reflect the committed changes.
Closed by commit R216:ba615b22ece6: Return sorted definitions for file names 
and mime types (authored by davschul, committed by cullmann).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19200?vs=52206=52207

REVISION DETAIL
  https://phabricator.kde.org/D19200

AFFECTED FILES
  src/lib/repository.cpp
  src/lib/repository.h

To: davschul, cullmann, vkrause
Cc: kwrite-devel, kde-frameworks-devel, bmortimer, michaelh, genethomas, 
ngraham, bruns, demsking, cullmann, vkrause, sars, dhaumann

D18997: Add functions returning all definitions for a mimetype or file name

[David Schulz]

davschul added a comment.


  Created https://phabricator.kde.org/D19200
  That should implement all the latest suggestions/comments

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D18997

To: davschul, vkrause, cullmann
Cc: dhaumann, cullmann, kwrite-devel, kde-frameworks-devel, bmortimer, 
michaelh, genethomas, ngraham, bruns, demsking, vkrause, sars

D19200: Return sorted definitions for file names and mime types

[David Schulz]

davschul created this revision.
davschul added reviewers: cullmann, vkrause.
davschul added a project: Framework: Syntax Highlighting.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
davschul requested review of this revision.

REVISION SUMMARY
  Sort definitions by priority before returning them.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D19200

AFFECTED FILES
  src/lib/repository.cpp
  src/lib/repository.h

To: davschul, cullmann, vkrause
Cc: kwrite-devel, kde-frameworks-devel, bmortimer, michaelh, genethomas, 
ngraham, bruns, demsking, cullmann, vkrause, sars, dhaumann

D18996: Fix building with namespaced Qt

[Christoph Cullmann]

cullmann added a comment.


  No problem, I just reopened it that I remember to take a look again at it 
myself.
  I just run into this issue wanting to land some patches on a openSUSE Leap 
machine.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D18996

To: davschul, vkrause
Cc: cullmann, kwrite-devel, kde-frameworks-devel, bmortimer, michaelh, 
genethomas, ngraham, bruns, demsking, vkrause, sars, dhaumann

D18996: Fix building with namespaced Qt

[David Schulz]

davschul added a comment.


  Okay I've tested it with 3.12.2 and there were no issues.
  I'm not familiar enough with cmake to tell whether there is a simpler version 
for what I try to achieve here. I just need the -D QT_NAMESPACE compiler 
options. Is there someone in the community who might know how to make it in a 
more elegant way.
  If not I do not need that target_link_libraries part in Qt Creator, because 
we still only support building via qmake or qbs. It was just to be complete 
here. So it could be removed without breaking our use case, but it would break 
namespace builds for any one else.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D18996

To: davschul, vkrause
Cc: cullmann, kwrite-devel, kde-frameworks-devel, bmortimer, michaelh, 
genethomas, ngraham, bruns, demsking, vkrause, sars, dhaumann

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 SUSEQt5.10 - Build # 31 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20SUSEQt5.10/31/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Thu, 21 Feb 2019 12:40:13 +
 Build duration:
5 min 11 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yaml
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report60%
(3/5)81%
(34/42)81%
(34/42)78%
(2672/3409)66%
(1751/2644)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests75%
(6/8)75%
(6/8)91%
(675/740)58%
(386/670)examples0%
(0/2)0%
(0/2)0%
(0/204)0%
(0/88)src.cli0%
(0/1)0%
(0/1)0%
(0/85)0%
(0/28)src.indexer100%
(1/1)100%
(1/1)76%
(222/292)77%
(202/264)src.lib90%
(27/30)90%
(27/30)85%
(1775/2088)73%
(1163/1594)

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 WindowsMSVCQt5.11 - Build # 133 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20WindowsMSVCQt5.11/133/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Thu, 21 Feb 2019 12:40:13 +
 Build duration:
4 min 32 sec and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 SUSEQt5.12 - Build # 25 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20SUSEQt5.12/25/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 21 Feb 2019 12:40:13 +
 Build duration:
2 min 23 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yaml
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report60%
(3/5)81%
(34/42)81%
(34/42)78%
(2672/3409)66%
(1751/2644)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests75%
(6/8)75%
(6/8)91%
(675/740)58%
(386/670)examples0%
(0/2)0%
(0/2)0%
(0/204)0%
(0/88)src.cli0%
(0/1)0%
(0/1)0%
(0/85)0%
(0/28)src.indexer100%
(1/1)100%
(1/1)76%
(222/292)77%
(202/264)src.lib90%
(27/30)90%
(27/30)85%
(1775/2088)73%
(1163/1594)

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 FreeBSDQt5.12 - Build # 39 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20FreeBSDQt5.12/39/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Thu, 21 Feb 2019 12:40:13 +
 Build duration:
2 min 16 sec and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)

D18996: Fix building with namespaced Qt

[Christoph Cullmann]

cullmann reopened this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  Hmm, there is one issue:
  
  With older cmake, aka
  
  cmake version 3.10.2
  
  I get now:
  
  CMake Error at data/CMakeLists.txt:68 (target_link_libraries):
  
Object library target "SyntaxHighlightingData" may not link to anything.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D18996

To: davschul, vkrause
Cc: cullmann, kwrite-devel, kde-frameworks-devel, bmortimer, michaelh, 
genethomas, ngraham, bruns, demsking, vkrause, sars, dhaumann

D19198: BrightScript: Unary and hex numbers, @attribute

[Christoph Cullmann]

This revision was automatically updated to reflect the committed changes.
Closed by commit R216:5c0f50026bfc: BrightScript: Unary and hex numbers, 
@attribute (authored by dlevin, committed by cullmann).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19198?vs=52195=52199

REVISION DETAIL
  https://phabricator.kde.org/D19198

AFFECTED FILES
  autotests/html/brightscript.brs.html
  autotests/input/brightscript.brs
  autotests/reference/brightscript.brs.ref
  data/syntax/brightscript.xml

To: dlevin, cullmann
Cc: kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, demsking, 
cullmann, sars, dhaumann

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 WindowsMSVCQt5.11 - Build # 132 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20WindowsMSVCQt5.11/132/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Thu, 21 Feb 2019 12:30:43 +
 Build duration:
5 min 40 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 6 test(s)Failed: projectroot.autotests.folding_test

kdbusaddons racing nameregistration with kcrash'd instance

[Harald Sitter]

Hey,

I've found a tricky race condition in the startup of kdbusaddons and I
need some thoughts on how to deal with it

Let's assume binary foo is a dbus unique service on org.kde.foo that
uses kcrash with autorestart enabled:

- foo1 gets started
- registers org.kde.foo
- runs normally
- encounters segfault
- kcrash sig handler starts up
- restarts service via kdeinit or qprocess as appropriate
- starts drkonqi

^ it never releases the org.kde.foo service name. Furthermore I am not
sure it ever could, the only point at which it knows to unregister is
in the sig handler and in there it's not save to unregister the name
(surely at the very least it'd have potential to mangle the stack)

- foo2 starts up
- registers org.kde.foo
- fails (org.kde.foo is still claimed by foo1)
- exists assuming the service is already running

dbus-daemon however seems to correctly detect that foo1 is defunct and
after a while will forcefully take away the service names, thus making
it available for registration again.

As examples both plasmashell and powerdevil are unique
auto-restartable services. But, plasmashell (at least on neon) indeed
has just enough delay in the startup that in the autorestart scenario
the well-known unique names are already made available again by
dbus-daemon.
Powerdevil on the other hand is getting to the registration request so
quickly that the (now-crashed) previous instance still holds the name
and service registration fails. We can see as much when
dbus-monitoring the session [1].

This ultimately results in the powerdevil daemon failing to restart
because it fails to acquire its unique service name and as a result
exits with the assumption that the service is already running.

A reliable way for me to reproduce it is to start powerdevil and then
kill SEGV it.

I do see a number of ways we can deal with this but they are all a bit meh.

# Queue registration
kdbusaddons attempts a queued registration with *some* timeout. If a
unique service gets started and fails to register it does it's
activation dance (thinking it is already running) if the activation
dance also fails (because the running service is unresponsive) the
registration is attempted with some timeout so as to possibly reclaim
the name once dbus-daemon freed it. an example is in [2].
Notable disadvantages with this is that we need a blocking eventloop
and it'll still be always racey unless we make the timeout very long.
I am not sure a long timeout is necessarily a problem at this point,
at the very least it may need controlling from the outside since
failed registration doesn't necessarily equal exit().
Could possibly do away with the eventloop by doing a for loop with a sleep().

# Replacement registration on crash
kcrash already sets an environment variable on auto-restarted
instances to indicate that they were restarted. We could check the
variable and if register with ReplaceExistingService. I am not sure
that actually works how I think it does though, but I think this
basically sets a hint on the daemon that the service name may be taken
away by another process. Disadvantage is that restarts caused by
something other than kcrash would not necessarily set the variable and
still suffer from a race (e.g. custom sig handler instead of kcrash).

# Reshuffle kcrash's restart order
Currently kcrash does the autorestart as one of the first things, even
before starting drkonqi. By delaying this a bit we may just be able to
get enough time out everything to not race. Granted I do not know why
it does the autostart so early, there may well be a reason for that.
I didn't quite manage to figure out how dbus-daemon knows that the
process is "lost" but I am somewhat confident that it has to do with
the FD closing. So, closing earlier might help too.

# Reshuffled long queue on crash
Would combine elements of all previous points where Unique service
registration will wait for a bit to successfully register, and wait
for a much longer time if the kcrash env var for autorestart was set
and by reshuffling kcrash's order the overall delay between startup
and name becoming available may be super small. Only likely downside
with this is the blocking qeventloop for queued registration.

# Drkonqi sledgehammer
When drkonqi is available, and run, the autorestart could be delayed
until drkonqi quits. This can be a very long time and drkonqi may not
be available. So, not exactly a reliable solution.

[1] https://phabricator.kde.org/P324
[2] https://phabricator.kde.org/P325

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 SUSEQt5.12 - Build # 24 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20SUSEQt5.12/24/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 21 Feb 2019 12:30:43 +
 Build duration:
3 min 16 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yaml
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 6 test(s)Failed: projectroot.autotests.folding_test
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report60%
(3/5)81%
(34/42)81%
(34/42)78%
(2671/3409)66%
(1750/2644)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests75%
(6/8)75%
(6/8)91%
(674/740)57%
(385/670)examples0%
(0/2)0%
(0/2)0%
(0/204)0%
(0/88)src.cli0%
(0/1)0%
(0/1)0%
(0/85)0%
(0/28)src.indexer100%
(1/1)100%
(1/1)76%
(222/292)77%
(202/264)src.lib90%
(27/30)90%
(27/30)85%
(1775/2088)73%
(1163/1594)

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 SUSEQt5.10 - Build # 30 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20SUSEQt5.10/30/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Thu, 21 Feb 2019 12:30:43 +
 Build duration:
2 min 23 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yaml
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 6 test(s)Failed: projectroot.autotests.folding_test
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report60%
(3/5)81%
(34/42)81%
(34/42)78%
(2671/3409)66%
(1750/2644)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests75%
(6/8)75%
(6/8)91%
(674/740)57%
(385/670)examples0%
(0/2)0%
(0/2)0%
(0/204)0%
(0/88)src.cli0%
(0/1)0%
(0/1)0%
(0/85)0%
(0/28)src.indexer100%
(1/1)100%
(1/1)76%
(222/292)77%
(202/264)src.lib90%
(27/30)90%
(27/30)85%
(1775/2088)73%
(1163/1594)

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 FreeBSDQt5.12 - Build # 38 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20FreeBSDQt5.12/38/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Thu, 21 Feb 2019 12:30:43 +
 Build duration:
2 min 31 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 6 test(s)Failed: projectroot.autotests.folding_test

D19198: BrightScript: Unary and hex numbers, @attribute

[Christoph Cullmann]

cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  Looks reasonable + we have a test => nice, merging.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D19198

To: dlevin, cullmann
Cc: kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, demsking, 
cullmann, sars, dhaumann

D19001: katetextbuffer: refactor TextBuffer::save() to better separate code paths

[Christoph Cullmann]

This revision was automatically updated to reflect the committed changes.
Closed by commit R39:598b6c9ca58b: katetextbuffer: refactor TextBuffer::save() 
to better separate code paths (authored by mgerstner, committed by cullmann).

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19001?vs=51951=52198

REVISION DETAIL
  https://phabricator.kde.org/D19001

AFFECTED FILES
  src/buffer/katetextbuffer.cpp
  src/buffer/katetextbuffer.h

To: mgerstner, dhaumann, cullmann, #ktexteditor, chinmoyr, fvogt
Cc: kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, demsking, 
cullmann, sars, dhaumann

D19001: katetextbuffer: refactor TextBuffer::save() to better separate code paths

[Christoph Cullmann]

cullmann added a comment.


  Thanks, will apply this.
  
  Nice that you help to improve this code.

REVISION DETAIL
  https://phabricator.kde.org/D19001

To: mgerstner, dhaumann, cullmann, #ktexteditor, chinmoyr, fvogt
Cc: kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, demsking, 
cullmann, sars, dhaumann

D19198: BrightScript: Unary and hex numbers, @attribute

[Daniel Levin]

dlevin created this revision.
dlevin added a reviewer: cullmann.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
dlevin requested review of this revision.

REVISION SUMMARY
  Fixed small issues for rvalue highlighting:
  
  - Unary numbers, prefixed with +-
  - Hex numbers, prefixed with 
  - Attribute dereference with var@attr syntax

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D19198

AFFECTED FILES
  autotests/html/brightscript.brs.html
  autotests/input/brightscript.brs
  autotests/reference/brightscript.brs.ref
  data/syntax/brightscript.xml

To: dlevin, cullmann
Cc: kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, demsking, 
cullmann, sars, dhaumann

D18845: authority: add support for passing details to polkit

[Matthias Gerstner]

mgerstner added a comment.


  In D18845#416305 , @bruns wrote:
  
  > Does this solve part of T8075 ?
  
  
  Part of a part it seems. I am currently working towards T10480 
. To actually add polkit details to 
authentication messages further changes in the kauth component are required 
once this change here is accepted.

REVISION DETAIL
  https://phabricator.kde.org/D18845

To: mgerstner, #frameworks, chinmoyr, fvogt, bruns
Cc: kde-frameworks-devel

D19001: katetextbuffer: refactor TextBuffer::save() to better separate code paths

[Matthias Gerstner]

mgerstner added a comment.


  >> @cullmann wrote:
  > 
  > If you pass me your author email, I will push that.
  
  Sure, it's matthias.gerst...@suse.de

REVISION DETAIL
  https://phabricator.kde.org/D19001

To: mgerstner, dhaumann, cullmann, #ktexteditor, chinmoyr, fvogt
Cc: kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, demsking, 
cullmann, sars, dhaumann