fvogt added a comment.
Before I land this, I'd like if someone other than me tries krunner with this
patch applied and judges the result with several runners. The difference is
very noticable with the appstream runner as it does not batch results.
REPOSITORY
R308 KRunner
REVISION DETAIL
broulik created this revision.
broulik added reviewers: Frameworks, dfaure, chinmoyr.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.
REVISION SUMMARY
While reporting the number of files is batched, the processed
pino added inline comments.
INLINE COMMENTS
> engine.h:471
> + */
> +virtual CommentsModel* commentsForEntry(const KNSCore::EntryInternal
> );
> +
BIC change, you cannot add virtual functions in a public class
> provider.h:148
> virtual void loadPayloadLink(const EntryInternal ,
maltek requested changes to this revision.
maltek added a comment.
This revision now requires changes to proceed.
I've gone over the code and found some issues. I haven't fully thought
through the design on a conceptual level, because I assume Matthias already did.
INLINE COMMENTS
>
ngraham added a comment.
Who's left?
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D17595
To: meven, #frameworks, #dolphin, broulik, ngraham
Cc: emmanuelp, ltoscano, bruns, meven, dhaumann, pino, kde-frameworks-devel,
LeGast00n, michaelh, ngraham
brute4s99 marked an inline comment as done.
brute4s99 added inline comments.
INLINE COMMENTS
> nicolasfella wrote in CMakeLists.txt:42
> We don't need DBus on Windows, do we?
we don't, I guess, but dbus-daemon.exe still runs in the background so I can't
say.
The functionality doesn't seem to
On Monday, 17 June 2019 21:34:38 CEST David Edmundson wrote:
> > Which libraries are covered by this mechanism nowadays? The impact is of
> > course bigger the more of the dependencies of the applications are already
> > loaded. When this was developed this was a small amount of relatively
> >
brute4s99 added inline comments.
INLINE COMMENTS
> pino wrote in notifybysnore.cpp:84
> if the notification is not found, this will be an uninitialized pointer; TBH
> if the search for the notification with the specified id fails, then it
> should be better to return earlier, as it means the
brute4s99 updated this revision to Diff 60035.
brute4s99 marked 9 inline comments as done.
REPOSITORY
R289 KNotifications
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D21661?vs=59835=60035
BRANCH
arcpatch-D21661
REVISION DETAIL
https://phabricator.kde.org/D21661
AFFECTED
This revision was automatically updated to reflect the committed changes.
Closed by commit R309:d39cabf2ae86: Add X-Flatpak-RenamedFrom as recognized key
(authored by broulik).
REPOSITORY
R309 KService
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D21780?vs=59727=60015
REVISION
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20FreeBSDQt5.12/31/
Project:
kf5-qt5 FreeBSDQt5.12
Date of build:
Tue, 18 Jun 2019 10:49:21 +
Build duration:
2 min 30 sec and counting
JUnit Tests
Name:
sars added a comment.
I think a partially highlighted line is better than a totally non-highlighted
one. And I think that the user is more likely to instinctively guess correctly
why the end of the line is not highlighted than if the line is not highlighted
at all.
REPOSITORY
R39
bcooksley added a comment.
With regards to Windows, please note that any unit test which depends on
calls that involve D-Bus on the CI system will likely lead to that test hanging
because dbus-daemon is not launched by the CI system.
Where possible D-Bus should be avoided on Windows.
> Are we sure it's fair to assume people have SSD? our of the 4 laptops i own,
> only 2 have SSD.
It's at least safe to assume it's the trend moving forward.
> Do you think it's worth me trying in one of the two that don't have SSD?
More data is normally a good thing. If you or anyone else
meven planned changes to this revision.
meven added a comment.
Still need 4 agreements from copyrights holders to make the necessary license
change.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D17595
To: meven, #frameworks, #dolphin, broulik, ngraham
Cc: emmanuelp,
leinir updated this revision to Diff 60021.
leinir added a comment.
Highlights: NewStuffButton, basic Kiosk support (needs more clever and
user-facing mention of why the thing they just tried to do didn't happen/do
anything), various fixing, cleanup, and sanity work.
- Fix logic for
16 matches
Mail list logo
